[INFO] cloning repository https://github.com/Saetch/g_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Saetch/g_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSaetch%2Fg_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSaetch%2Fg_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 44f7e34756c3f9ff7606aa1ad2b07d69dff70260 [INFO] linting Saetch/g_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSaetch%2Fg_rust" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Saetch/g_rust [INFO] finished tweaking git repo https://github.com/Saetch/g_rust [INFO] tweaked toml for git repo https://github.com/Saetch/g_rust written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Saetch/g_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Saetch/g_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded piston-float v1.0.1 [INFO] [stderr] Downloaded shader_version v0.7.0 [INFO] [stderr] Downloaded piston-viewport v1.0.1 [INFO] [stderr] Downloaded gl v0.13.0 [INFO] [stderr] Downloaded pistoncore-window v0.47.1 [INFO] [stderr] Downloaded read_color v1.0.0 [INFO] [stderr] Downloaded piston-graphics_api_version v1.0.1 [INFO] [stderr] Downloaded spin_sleep v1.0.0 [INFO] [stderr] Downloaded piston v0.53.1 [INFO] [stderr] Downloaded piston-shaders_graphics2d v0.4.0 [INFO] [stderr] Downloaded pistoncore-event_loop v0.53.1 [INFO] [stderr] Downloaded flume v0.10.9 [INFO] [stderr] Downloaded interpolation v0.2.0 [INFO] [stderr] Downloaded pistoncore-glutin_window v0.69.0 [INFO] [stderr] Downloaded piston2d-graphics v0.41.0 [INFO] [stderr] Downloaded piston2d-opengl_graphics v0.79.0 [INFO] [stderr] Downloaded pistoncore-input v1.0.1 [INFO] [stderr] Downloaded piston-texture v0.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afa8f6e9d02da74794d3de85b22d2debe619488258854d1be767640b9cc948f4 [INFO] running `Command { std: "docker" "start" "-a" "afa8f6e9d02da74794d3de85b22d2debe619488258854d1be767640b9cc948f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afa8f6e9d02da74794d3de85b22d2debe619488258854d1be767640b9cc948f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afa8f6e9d02da74794d3de85b22d2debe619488258854d1be767640b9cc948f4", kill_on_drop: false }` [INFO] [stdout] afa8f6e9d02da74794d3de85b22d2debe619488258854d1be767640b9cc948f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 578669f673dbd711741a1e7b8526868dc41e663dc2debe6ac1869ff299b5b357 [INFO] running `Command { std: "docker" "start" "-a" "578669f673dbd711741a1e7b8526868dc41e663dc2debe6ac1869ff299b5b357", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking libloading v0.7.2 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking piston-float v1.0.1 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking piston-viewport v1.0.1 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Checking piston-graphics_api_version v1.0.1 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Checking xml-rs v0.8.4 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking raw-window-handle v0.4.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Checking shader_version v0.7.0 [INFO] [stderr] Checking vecmath v1.0.0 [INFO] [stderr] Checking spin_sleep v1.0.0 [INFO] [stderr] Checking interpolation v0.2.0 [INFO] [stderr] Compiling gl v0.13.0 [INFO] [stderr] Checking bytemuck v1.7.3 [INFO] [stderr] Checking read_color v1.0.0 [INFO] [stderr] Checking piston-texture v0.8.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking spin v0.9.2 [INFO] [stderr] Checking piston-shaders_graphics2d v0.4.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Checking gif v0.11.3 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Checking piston2d-graphics v0.41.0 [INFO] [stderr] Checking nix v0.20.2 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking parking_lot_core v0.8.5 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking xdg v2.4.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking nanorand v0.6.1 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Compiling pin-project-internal v1.0.9 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking pin-project v1.0.9 [INFO] [stderr] Checking flume v0.10.9 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking wayland-egl v0.28.6 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking pistoncore-input v1.0.1 [INFO] [stderr] Checking pistoncore-window v0.47.1 [INFO] [stderr] Checking pistoncore-event_loop v0.53.1 [INFO] [stderr] Checking piston v0.53.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.79.0 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking winit v0.24.0 [INFO] [stderr] Checking glutin v0.26.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.69.0 [INFO] [stderr] Checking g_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/view.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::{ Arc, Mutex, RwLock, RwLockReadGuard}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vec` [INFO] [stdout] --> src/model.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | thread, time::Duration, vec}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/model.rs:3:91 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{ gerade::Gerade, constants::{FIELDWIDTH, FIELDHEIGHT, SPAWN_SIDES_WITH_DELAY, self, CIRCLERADIUS}, vect_2d::Vector2D}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/model.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | 'elementsloop:for element in &*actualvector{ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp` [INFO] [stdout] --> src/gerade.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cmp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/view.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::{ Arc, Mutex, RwLock, RwLockReadGuard}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vec` [INFO] [stdout] --> src/model.rs:2:26 [INFO] [stdout] | [INFO] [stdout] 2 | thread, time::Duration, vec}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/model.rs:3:91 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{ gerade::Gerade, constants::{FIELDWIDTH, FIELDHEIGHT, SPAWN_SIDES_WITH_DELAY, self, CIRCLERADIUS}, vect_2d::Vector2D}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/model.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | 'elementsloop:for element in &*actualvector{ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp` [INFO] [stdout] --> src/gerade.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::cmp; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elapsed` [INFO] [stdout] --> src/main.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | let elapsed = start.elapsed(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_elapsed` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `mirror_on_normal_vec` is never used [INFO] [stdout] --> src/vect_2d.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Vector2D { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 132 | pub fn mirror_on_normal_vec(&mut self, gerade : &Gerade, speed: f64){ //this function works analogous to the mirr... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `closest_point_to_zerozero` is never read [INFO] [stdout] --> src/gerade.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Gerade{ [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub closest_point_to_zerozero: Option<(f64, f64)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `only_normalize` is never used [INFO] [stdout] --> src/gerade.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Gerade{ [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn only_normalize(&mut self){ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/vect_2d.rs:91:30 [INFO] [stdout] | [INFO] [stdout] 91 | let mut left_side = -1.0* non_m_var; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `-non_m_var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vect_2d.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | return (self.x.powi(2) + self.y.powi(2)).sqrt(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return (self.x.powi(2) + self.y.powi(2)).sqrt(); [INFO] [stdout] 129 + (self.x.powi(2) + self.y.powi(2)).sqrt() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/vect_2d.rs:217:30 [INFO] [stdout] | [INFO] [stdout] 217 | let mut left_side = -1.0* non_m_var; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `-non_m_var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `position_read` after checking its variant with `is_err` [INFO] [stdout] --> src/view.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 43 | if position_read.is_err(){ [INFO] [stdout] | ------------------------- help: try: `if let Ok() = position_read` [INFO] [stdout] ... [INFO] [stdout] 47 | position = position_read.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/view.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | let position ; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `position` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 ~ let position = if position_read.is_err(){ [INFO] [stdout] 44 | println!("{}", position_read.err().unwrap()); [INFO] [stdout] 45 | return; [INFO] [stdout] 46 | }else{ [INFO] [stdout] 47 ~ position_read.unwrap() [INFO] [stdout] 48 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:52 [INFO] [stdout] | [INFO] [stdout] 83 | ... let bkgrnd = rectangle_by_corners(mid_x - (FIELDWIDTH as f64 / 2.0) , mid_y - (FIELDHEIGHT as f64 /2.0), mid_x + (FIELDWIDTH a... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `FIELDWIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:88 [INFO] [stdout] | [INFO] [stdout] 83 | ... let bkgrnd = rectangle_by_corners(mid_x - (FIELDWIDTH as f64 / 2.0) , mid_y - (FIELDHEIGHT as f64 /2.0), mid_x + (FIELDWIDTH a... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `FIELDHEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:123 [INFO] [stdout] | [INFO] [stdout] 83 | ...mid_y - (FIELDHEIGHT as f64 /2.0), mid_x + (FIELDWIDTH as f64 / 2.0), mid_y + (FIELDHEIGHT as f64 /2.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `FIELDWIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:158 [INFO] [stdout] | [INFO] [stdout] 83 | ...id_x + (FIELDWIDTH as f64 / 2.0), mid_y + (FIELDHEIGHT as f64 /2.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `FIELDHEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:45 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^ help: try: `x0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:56 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^ help: try: `y0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:67 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `xend` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:80 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `yend` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | for i in 0..(&locations).len(){ [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `locations` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/view.rs:107:52 [INFO] [stdout] | [INFO] [stdout] 107 | let circle = graphics::ellipse::circle(act_x.into(), act_y.into(), CIRCLERADIUS.into()); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `act_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/view.rs:107:66 [INFO] [stdout] | [INFO] [stdout] 107 | let circle = graphics::ellipse::circle(act_x.into(), act_y.into(), CIRCLERADIUS.into()); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `act_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/view.rs:107:80 [INFO] [stdout] | [INFO] [stdout] 107 | let circle = graphics::ellipse::circle(act_x.into(), act_y.into(), CIRCLERADIUS.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CIRCLERADIUS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | return (x0+ x, y0+y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return (x0+ x, y0+y); [INFO] [stdout] 128 + (x0+ x, y0+y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | let x0: f64 = mid_x as f64 - FIELDWIDTH/2.0f64; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `mid_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 126 | let y0: f64 = mid_y as f64 - FIELDHEIGHT/2.0f64; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `mid_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ret.0` after checking its variant with `is_some` [INFO] [stdout] --> src/model.rs:74:71 [INFO] [stdout] | [INFO] [stdout] 64 | ... if ret.0.is_some(){ [INFO] [stdout] | ------------------ help: try: `if let Some() = ret.0` [INFO] [stdout] ... [INFO] [stdout] 74 | ... distance = f64::min(distance, ret.0.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ret.0` after checking its variant with `is_some` [INFO] [stdout] --> src/model.rs:82:67 [INFO] [stdout] | [INFO] [stdout] 64 | ... if ret.0.is_some(){ [INFO] [stdout] | ------------------ help: try: `if let Some() = ret.0` [INFO] [stdout] ... [INFO] [stdout] 82 | ... distance = f64::min(distance, ret.0.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/model.rs:187:16 [INFO] [stdout] | [INFO] [stdout] 187 | if mutval.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mutval.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | return ( None , false); //the second bool is irrelevant here [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return ( None , false); //the second bool is irrelevant here [INFO] [stdout] 238 + ( None , false)//the second bool is irrelevant here [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:267:9 [INFO] [stdout] | [INFO] [stdout] 267 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return ret; [INFO] [stdout] 267 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/controller.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return Controller{ [INFO] [stdout] 18 | | model : modelr.clone(), [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Controller{ [INFO] [stdout] 18 + model : modelr.clone(), [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/controller.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / match args.button{ [INFO] [stdout] 27 | | //add the type of input to read here [INFO] [stdout] 28 | | Button::Keyboard(key) => self.compute_keyboard(key), [INFO] [stdout] 29 | | _ => (), [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Button::Keyboard(key) = args.button { self.compute_keyboard(key) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | self.linien_vektor.0 = self.linien_vektor.0 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.0 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | self.linien_vektor.1 = self.linien_vektor.1 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.1 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | self.linien_vektor.0 = self.linien_vektor.0 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.0 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | self.linien_vektor.1 = self.linien_vektor.1 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.1 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gerade.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return ( ret.0, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return ( ret.0, true); [INFO] [stdout] 114 + ( ret.0, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gerade.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | return (( neuer_schnittpunkt.0.powi(2) + neuer_schnittpunkt.1.powi(2)).sqrt() , neuer_schnittpunkt ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return (( neuer_schnittpunkt.0.powi(2) + neuer_schnittpunkt.1.powi(2)).sqrt() , neuer_schnittpunkt ); [INFO] [stdout] 187 + (( neuer_schnittpunkt.0.powi(2) + neuer_schnittpunkt.1.powi(2)).sqrt() , neuer_schnittpunkt ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/gerade.rs:173:30 [INFO] [stdout] | [INFO] [stdout] 173 | let mut left_side = -1.0* non_m_var; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `-non_m_var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !arg_p.is_err(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `arg_p.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_p` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 59 | if !arg_p.is_err(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 60 | let args = arg_p.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:74:16 [INFO] [stdout] | [INFO] [stdout] 74 | if !arg_p.is_err(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `arg_p.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_p` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 74 | if !arg_p.is_err(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 75 | let args = arg_p.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/model.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | drop(pos); //this is dropped here, so the rendering thread does not delay if it tries to read the ballpos. [INFO] [stdout] | ^^^^^---^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::RwLock` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 59 - drop(pos); //this is dropped here, so the rendering thread does not delay if it tries to read the ballpos. [INFO] [stdout] 59 + let _ = pos; //this is dropped here, so the rendering thread does not delay if it tries to read the ballpos. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/model.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | drop(ball_v); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::RwLock` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 226 - drop(ball_v); [INFO] [stdout] 226 + let _ = ball_v; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elapsed` [INFO] [stdout] --> src/main.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | let elapsed = start.elapsed(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_elapsed` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `mirror_on_normal_vec` is never used [INFO] [stdout] --> src/vect_2d.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Vector2D { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 132 | pub fn mirror_on_normal_vec(&mut self, gerade : &Gerade, speed: f64){ //this function works analogous to the mirr... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `closest_point_to_zerozero` is never read [INFO] [stdout] --> src/gerade.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Gerade{ [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub closest_point_to_zerozero: Option<(f64, f64)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `only_normalize` is never used [INFO] [stdout] --> src/gerade.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Gerade{ [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn only_normalize(&mut self){ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/vect_2d.rs:91:30 [INFO] [stdout] | [INFO] [stdout] 91 | let mut left_side = -1.0* non_m_var; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `-non_m_var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vect_2d.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | return (self.x.powi(2) + self.y.powi(2)).sqrt(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return (self.x.powi(2) + self.y.powi(2)).sqrt(); [INFO] [stdout] 129 + (self.x.powi(2) + self.y.powi(2)).sqrt() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/vect_2d.rs:217:30 [INFO] [stdout] | [INFO] [stdout] 217 | let mut left_side = -1.0* non_m_var; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `-non_m_var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `position_read` after checking its variant with `is_err` [INFO] [stdout] --> src/view.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 43 | if position_read.is_err(){ [INFO] [stdout] | ------------------------- help: try: `if let Ok() = position_read` [INFO] [stdout] ... [INFO] [stdout] 47 | position = position_read.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/view.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | let position ; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `position` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 ~ let position = if position_read.is_err(){ [INFO] [stdout] 44 | println!("{}", position_read.err().unwrap()); [INFO] [stdout] 45 | return; [INFO] [stdout] 46 | }else{ [INFO] [stdout] 47 ~ position_read.unwrap() [INFO] [stdout] 48 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:52 [INFO] [stdout] | [INFO] [stdout] 83 | ... let bkgrnd = rectangle_by_corners(mid_x - (FIELDWIDTH as f64 / 2.0) , mid_y - (FIELDHEIGHT as f64 /2.0), mid_x + (FIELDWIDTH a... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `FIELDWIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:88 [INFO] [stdout] | [INFO] [stdout] 83 | ... let bkgrnd = rectangle_by_corners(mid_x - (FIELDWIDTH as f64 / 2.0) , mid_y - (FIELDHEIGHT as f64 /2.0), mid_x + (FIELDWIDTH a... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `FIELDHEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:123 [INFO] [stdout] | [INFO] [stdout] 83 | ...mid_y - (FIELDHEIGHT as f64 /2.0), mid_x + (FIELDWIDTH as f64 / 2.0), mid_y + (FIELDHEIGHT as f64 /2.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `FIELDWIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:83:158 [INFO] [stdout] | [INFO] [stdout] 83 | ...id_x + (FIELDWIDTH as f64 / 2.0), mid_y + (FIELDHEIGHT as f64 /2.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `FIELDHEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:45 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^ help: try: `x0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:56 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^ help: try: `y0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:67 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `xend` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:95:80 [INFO] [stdout] | [INFO] [stdout] 95 | graphics::line(GREEN, 2.0, [x0 as f64, y0 as f64, xend as f64, yend as f64], c.transform, gl); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `yend` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | for i in 0..(&locations).len(){ [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `locations` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/view.rs:107:52 [INFO] [stdout] | [INFO] [stdout] 107 | let circle = graphics::ellipse::circle(act_x.into(), act_y.into(), CIRCLERADIUS.into()); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `act_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/view.rs:107:66 [INFO] [stdout] | [INFO] [stdout] 107 | let circle = graphics::ellipse::circle(act_x.into(), act_y.into(), CIRCLERADIUS.into()); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `act_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f64` [INFO] [stdout] --> src/view.rs:107:80 [INFO] [stdout] | [INFO] [stdout] 107 | let circle = graphics::ellipse::circle(act_x.into(), act_y.into(), CIRCLERADIUS.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `CIRCLERADIUS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/view.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | return (x0+ x, y0+y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return (x0+ x, y0+y); [INFO] [stdout] 128 + (x0+ x, y0+y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | let x0: f64 = mid_x as f64 - FIELDWIDTH/2.0f64; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `mid_x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/view.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 126 | let y0: f64 = mid_y as f64 - FIELDHEIGHT/2.0f64; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `mid_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ret.0` after checking its variant with `is_some` [INFO] [stdout] --> src/model.rs:74:71 [INFO] [stdout] | [INFO] [stdout] 64 | ... if ret.0.is_some(){ [INFO] [stdout] | ------------------ help: try: `if let Some() = ret.0` [INFO] [stdout] ... [INFO] [stdout] 74 | ... distance = f64::min(distance, ret.0.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ret.0` after checking its variant with `is_some` [INFO] [stdout] --> src/model.rs:82:67 [INFO] [stdout] | [INFO] [stdout] 64 | ... if ret.0.is_some(){ [INFO] [stdout] | ------------------ help: try: `if let Some() = ret.0` [INFO] [stdout] ... [INFO] [stdout] 82 | ... distance = f64::min(distance, ret.0.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/model.rs:187:16 [INFO] [stdout] | [INFO] [stdout] 187 | if mutval.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mutval.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | return ( None , false); //the second bool is irrelevant here [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return ( None , false); //the second bool is irrelevant here [INFO] [stdout] 238 + ( None , false)//the second bool is irrelevant here [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/model.rs:267:9 [INFO] [stdout] | [INFO] [stdout] 267 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 267 - return ret; [INFO] [stdout] 267 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/controller.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / return Controller{ [INFO] [stdout] 18 | | model : modelr.clone(), [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Controller{ [INFO] [stdout] 18 + model : modelr.clone(), [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/controller.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / match args.button{ [INFO] [stdout] 27 | | //add the type of input to read here [INFO] [stdout] 28 | | Button::Keyboard(key) => self.compute_keyboard(key), [INFO] [stdout] 29 | | _ => (), [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ help: try: `if let Button::Keyboard(key) = args.button { self.compute_keyboard(key) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | self.linien_vektor.0 = self.linien_vektor.0 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.0 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | self.linien_vektor.1 = self.linien_vektor.1 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.1 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | self.linien_vektor.0 = self.linien_vektor.0 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.0 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/gerade.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | self.linien_vektor.1 = self.linien_vektor.1 / veklength; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.linien_vektor.1 /= veklength` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gerade.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return ( ret.0, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return ( ret.0, true); [INFO] [stdout] 114 + ( ret.0, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gerade.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | return (( neuer_schnittpunkt.0.powi(2) + neuer_schnittpunkt.1.powi(2)).sqrt() , neuer_schnittpunkt ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return (( neuer_schnittpunkt.0.powi(2) + neuer_schnittpunkt.1.powi(2)).sqrt() , neuer_schnittpunkt ); [INFO] [stdout] 187 + (( neuer_schnittpunkt.0.powi(2) + neuer_schnittpunkt.1.powi(2)).sqrt() , neuer_schnittpunkt ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/gerade.rs:173:30 [INFO] [stdout] | [INFO] [stdout] 173 | let mut left_side = -1.0* non_m_var; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `-non_m_var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:59:16 [INFO] [stdout] | [INFO] [stdout] 59 | if !arg_p.is_err(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `arg_p.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_p` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 59 | if !arg_p.is_err(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 60 | let args = arg_p.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:74:16 [INFO] [stdout] | [INFO] [stdout] 74 | if !arg_p.is_err(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `arg_p.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_p` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:75:28 [INFO] [stdout] | [INFO] [stdout] 74 | if !arg_p.is_err(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 75 | let args = arg_p.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/model.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | drop(pos); //this is dropped here, so the rendering thread does not delay if it tries to read the ballpos. [INFO] [stdout] | ^^^^^---^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::RwLock` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 59 - drop(pos); //this is dropped here, so the rendering thread does not delay if it tries to read the ballpos. [INFO] [stdout] 59 + let _ = pos; //this is dropped here, so the rendering thread does not delay if it tries to read the ballpos. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/model.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | drop(ball_v); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::sync::RwLock` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 226 - drop(ball_v); [INFO] [stdout] 226 + let _ = ball_v; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.41s [INFO] running `Command { std: "docker" "inspect" "578669f673dbd711741a1e7b8526868dc41e663dc2debe6ac1869ff299b5b357", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "578669f673dbd711741a1e7b8526868dc41e663dc2debe6ac1869ff299b5b357", kill_on_drop: false }` [INFO] [stdout] 578669f673dbd711741a1e7b8526868dc41e663dc2debe6ac1869ff299b5b357