[INFO] cloning repository https://github.com/SHoltzen/rs-perm
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SHoltzen/rs-perm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSHoltzen%2Frs-perm", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSHoltzen%2Frs-perm'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 70a9c857f2bc023e2bdae27c9cfafcd2d239c21f
[INFO] linting SHoltzen/rs-perm against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSHoltzen%2Frs-perm" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/SHoltzen/rs-perm
[INFO] finished tweaking git repo https://github.com/SHoltzen/rs-perm
[INFO] tweaked toml for git repo https://github.com/SHoltzen/rs-perm written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/SHoltzen/rs-perm on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/SHoltzen/rs-perm already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] c9f9e27b938f75b2d388815670ac80c86427c93e3d90d0b57d86fa111bbebef6
[INFO] running `Command { std: "docker" "start" "-a" "c9f9e27b938f75b2d388815670ac80c86427c93e3d90d0b57d86fa111bbebef6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "c9f9e27b938f75b2d388815670ac80c86427c93e3d90d0b57d86fa111bbebef6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c9f9e27b938f75b2d388815670ac80c86427c93e3d90d0b57d86fa111bbebef6", kill_on_drop: false }`
[INFO] [stdout] c9f9e27b938f75b2d388815670ac80c86427c93e3d90d0b57d86fa111bbebef6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6de76b65e64a48f38d12e399c1bda082e5b7df56d663964ec3ce11465e572072
[INFO] running `Command { std: "docker" "start" "-a" "6de76b65e64a48f38d12e399c1bda082e5b7df56d663964ec3ce11465e572072", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.97
[INFO] [stderr]     Checking getrandom v0.2.3
[INFO] [stderr]     Checking rand_core v0.6.3
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.4
[INFO] [stderr]     Checking rs-perm v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/group.rs:253:13
[INFO] [stdout]     |
[INFO] [stdout] 253 |             gens: gens,
[INFO] [stdout]     |             ^^^^^^^^^^ help: replace it with: `gens`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `perm::*`
[INFO] [stdout]  --> src/main.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use perm::*;
[INFO] [stdout]   |     ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/group.rs:253:13
[INFO] [stdout]     |
[INFO] [stdout] 253 |             gens: gens,
[INFO] [stdout]     |             ^^^^^^^^^^ help: replace it with: `gens`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `perm::*`
[INFO] [stdout]  --> src/main.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use perm::*;
[INFO] [stdout]   |     ^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `id` is never read
[INFO] [stdout]  --> src/group.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub struct GroupRNG {
[INFO] [stdout]   |            -------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 9 |     id: Perm,
[INFO] [stdout]   |     ^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `g` and `base` are never read
[INFO] [stdout]   --> src/group.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 70 | struct StabView<'a> {
[INFO] [stdout]    |        -------- fields in this struct
[INFO] [stdout] 71 |     g: Vec<&'a Perm>,
[INFO] [stdout]    |     ^
[INFO] [stdout] 72 |     /// the set of stabilized points
[INFO] [stdout] 73 |     base: Vec<usize>,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `StabView` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `add_gen` is never used
[INFO] [stdout]    --> src/group.rs:107:12
[INFO] [stdout]     |
[INFO] [stdout]  80 | impl<'a> StabView<'a> {
[INFO] [stdout]     | --------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 107 |     pub fn add_gen(&mut self, g: &'a Perm) -> () {
[INFO] [stdout]     |            ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]  --> src/perm.rs:8:9
[INFO] [stdout]   |
[INFO] [stdout] 8 |         return self.p[point]
[INFO] [stdout]   |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]   = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]   |
[INFO] [stdout] 8 -         return self.p[point]
[INFO] [stdout] 8 +         self.p[point]
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 13 |         return Perm { p: v }
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 -         return Perm { p: v }
[INFO] [stdout] 13 +         Perm { p: v }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 |         return Perm::new((0..(sz)).collect())
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 -         return Perm::new((0..(sz)).collect())
[INFO] [stdout] 29 +         Perm::new((0..(sz)).collect())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `Perm` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/perm.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     pub fn len(&self) -> usize {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:33:9
[INFO] [stdout]    |
[INFO] [stdout] 33 |         return self.p.len()
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -         return self.p.len()
[INFO] [stdout] 33 +         self.p.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 41 |         return Perm::new(r)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -         return Perm::new(r)
[INFO] [stdout] 41 +         Perm::new(r)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return Perm::new(r);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -         return Perm::new(r);
[INFO] [stdout] 51 +         Perm::new(r)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `r`
[INFO] [stdout]   --> src/perm.rs:48:18
[INFO] [stdout]    |
[INFO] [stdout] 48 |         for i in 0..(self.p.len()) {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 48 -         for i in 0..(self.p.len()) {
[INFO] [stdout] 48 +         for (i, <item>) in r.iter_mut().enumerate().take((self.p.len())) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/group.rs:44:43
[INFO] [stdout]    |
[INFO] [stdout] 44 |                 self.gens[i] = pi.compose(&pj);
[INFO] [stdout]    |                                           ^^^ help: change this to: `pj`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/group.rs:50:43
[INFO] [stdout]    |
[INFO] [stdout] 50 |                 self.gens[i] = pj.compose(&pi);
[INFO] [stdout]    |                                           ^^^ help: change this to: `pi`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/group.rs:52:49
[INFO] [stdout]    |
[INFO] [stdout] 52 |                 self.gens[i] = pj.inv().compose(&pi);
[INFO] [stdout]    |                                                 ^^^ help: change this to: `pi`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/group.rs:98:20
[INFO] [stdout]    |
[INFO] [stdout] 98 |                 if !s[newp].is_none() { continue }
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^ help: try: `s[newp].is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop
[INFO] [stdout]   --> src/group.rs:95:13
[INFO] [stdout]    |
[INFO] [stdout] 95 |             let top = frontier.pop().unwrap();
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some
[INFO] [stdout]    = note: `#[warn(clippy::manual_while_let_some)]` on by default
[INFO] [stdout] help: consider using a `while..let` loop
[INFO] [stdout]    |
[INFO] [stdout] 94 ~         while let Some(top) = frontier.pop() {
[INFO] [stdout] 95 ~             
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/group.rs:125:20
[INFO] [stdout]     |
[INFO] [stdout] 125 |                 if !self.schreier[newp].is_none() { continue }
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.schreier[newp].is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/group.rs:107:43
[INFO] [stdout]     |
[INFO] [stdout] 107 |     pub fn add_gen(&mut self, g: &'a Perm) -> () {
[INFO] [stdout]     |                                           ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]     = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop
[INFO] [stdout]    --> src/group.rs:122:13
[INFO] [stdout]     |
[INFO] [stdout] 122 |             let top = frontier.pop().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some
[INFO] [stdout] help: consider using a `while..let` loop
[INFO] [stdout]     |
[INFO] [stdout] 121 ~         while let Some(top) = frontier.pop() {
[INFO] [stdout] 122 ~             
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:148:9
[INFO] [stdout]     |
[INFO] [stdout] 148 |         return r;
[INFO] [stdout]     |         ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 148 -         return r;
[INFO] [stdout] 148 +         r
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:154:9
[INFO] [stdout]     |
[INFO] [stdout] 154 |         return self.schreier.iter().map(|x| if x.is_none() { 0 } else { 1 }).sum()
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 154 -         return self.schreier.iter().map(|x| if x.is_none() { 0 } else { 1 }).sum()
[INFO] [stdout] 154 +         self.schreier.iter().map(|x| if x.is_none() { 0 } else { 1 }).sum()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:178:9
[INFO] [stdout]     |
[INFO] [stdout] 178 |         return self.n;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 178 -         return self.n;
[INFO] [stdout] 178 +         self.n
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:197:9
[INFO] [stdout]     |
[INFO] [stdout] 197 |         return curg;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 197 -         return curg;
[INFO] [stdout] 197 +         curg
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:207:9
[INFO] [stdout]     |
[INFO] [stdout] 207 |         return stab_chain;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 207 -         return stab_chain;
[INFO] [stdout] 207 +         stab_chain
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/group.rs:200:36
[INFO] [stdout]     |
[INFO] [stdout] 200 |     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView> {
[INFO] [stdout]     |                                    ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 200 -     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView> {
[INFO] [stdout] 200 +     fn gen_stab_chain(&self, base: &[usize]) -> Vec<StabView> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/group.rs:211:43
[INFO] [stdout]     |
[INFO] [stdout] 211 |     pub fn random_schreier_sims(&mut self) -> () {
[INFO] [stdout]     |                                           ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:243:9
[INFO] [stdout]     |
[INFO] [stdout] 243 |         return chain.iter().map(|x| x.base_orbit_size()).product()
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 243 -         return chain.iter().map(|x| x.base_orbit_size()).product()
[INFO] [stdout] 243 +         chain.iter().map(|x| x.base_orbit_size()).product()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:252:9
[INFO] [stdout]     |
[INFO] [stdout] 252 | /         return Group {
[INFO] [stdout] 253 | |             gens: gens,
[INFO] [stdout] 254 | |             n: l,
[INFO] [stdout] 255 | |             id: Perm::id(l),
[INFO] [stdout] 256 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 252 ~         Group {
[INFO] [stdout] 253 +             gens: gens,
[INFO] [stdout] 254 +             n: l,
[INFO] [stdout] 255 +             id: Perm::id(l),
[INFO] [stdout] 256 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/group.rs:247:17
[INFO] [stdout]     |
[INFO] [stdout] 247 |         assert!(gens.len() > 0);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!gens.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `gens`
[INFO] [stdout]    --> src/group.rs:249:18
[INFO] [stdout]     |
[INFO] [stdout] 249 |         for i in 0..gens.len() {
[INFO] [stdout]     |                  ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 249 -         for i in 0..gens.len() {
[INFO] [stdout] 249 +         for <item> in &gens {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:276:9
[INFO] [stdout]     |
[INFO] [stdout] 276 |         return orbit;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 276 -         return orbit;
[INFO] [stdout] 276 +         orbit
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop
[INFO] [stdout]    --> src/group.rs:266:13
[INFO] [stdout]     |
[INFO] [stdout] 266 |             let top = frontier.pop().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some
[INFO] [stdout] help: consider using a `while..let` loop
[INFO] [stdout]     |
[INFO] [stdout] 265 ~         while let Some(top) = frontier.pop() {
[INFO] [stdout] 266 ~             
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:282:9
[INFO] [stdout]     |
[INFO] [stdout] 282 | /         return Group {
[INFO] [stdout] 283 | |             n,
[INFO] [stdout] 284 | |             id: Perm::id(n),
[INFO] [stdout] 285 | |             gens: vec![Perm::new(gen)]
[INFO] [stdout] 286 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 282 ~         Group {
[INFO] [stdout] 283 +             n,
[INFO] [stdout] 284 +             id: Perm::id(n),
[INFO] [stdout] 285 +             gens: vec![Perm::new(gen)]
[INFO] [stdout] 286 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:296:9
[INFO] [stdout]     |
[INFO] [stdout] 296 | /         return Group {
[INFO] [stdout] 297 | |             n,
[INFO] [stdout] 298 | |             id: Perm::id(n),
[INFO] [stdout] 299 | |             gens
[INFO] [stdout] 300 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 296 ~         Group {
[INFO] [stdout] 297 +             n,
[INFO] [stdout] 298 +             id: Perm::id(n),
[INFO] [stdout] 299 +             gens
[INFO] [stdout] 300 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:312:9
[INFO] [stdout]     |
[INFO] [stdout] 312 |         return Group {n: 49, id: Perm::id(49), gens}
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 312 -         return Group {n: 49, id: Perm::id(49), gens}
[INFO] [stdout] 312 +         Group {n: 49, id: Perm::id(49), gens}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `chooseR` should have a snake case name
[INFO] [stdout]   --> src/group.rs:40:13
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let chooseR : bool = self.rng.gen_bool(0.5);
[INFO] [stdout]    |             ^^^^^^^ help: convert the identifier to snake case: `choose_r`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/group.rs:200:23
[INFO] [stdout]     |
[INFO] [stdout] 200 |     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView> {
[INFO] [stdout]     |                       ^^^^^                            ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                       |
[INFO] [stdout]     |                       the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 200 |     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView<'_>> {
[INFO] [stdout]     |                                                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `id` is never read
[INFO] [stdout]  --> src/group.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | pub struct GroupRNG {
[INFO] [stdout]   |            -------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 9 |     id: Perm,
[INFO] [stdout]   |     ^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `g` and `base` are never read
[INFO] [stdout]   --> src/group.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 70 | struct StabView<'a> {
[INFO] [stdout]    |        -------- fields in this struct
[INFO] [stdout] 71 |     g: Vec<&'a Perm>,
[INFO] [stdout]    |     ^
[INFO] [stdout] 72 |     /// the set of stabilized points
[INFO] [stdout] 73 |     base: Vec<usize>,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `StabView` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `add_gen` is never used
[INFO] [stdout]    --> src/group.rs:107:12
[INFO] [stdout]     |
[INFO] [stdout]  80 | impl<'a> StabView<'a> {
[INFO] [stdout]     | --------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 107 |     pub fn add_gen(&mut self, g: &'a Perm) -> () {
[INFO] [stdout]     |            ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]  --> src/perm.rs:8:9
[INFO] [stdout]   |
[INFO] [stdout] 8 |         return self.p[point]
[INFO] [stdout]   |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]   = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]   |
[INFO] [stdout] 8 -         return self.p[point]
[INFO] [stdout] 8 +         self.p[point]
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 13 |         return Perm { p: v }
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 13 -         return Perm { p: v }
[INFO] [stdout] 13 +         Perm { p: v }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 |         return Perm::new((0..(sz)).collect())
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 -         return Perm::new((0..(sz)).collect())
[INFO] [stdout] 29 +         Perm::new((0..(sz)).collect())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `Perm` has a public `len` method, but no `is_empty` method
[INFO] [stdout]   --> src/perm.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     pub fn len(&self) -> usize {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stdout]    = note: `#[warn(clippy::len_without_is_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:33:9
[INFO] [stdout]    |
[INFO] [stdout] 33 |         return self.p.len()
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -         return self.p.len()
[INFO] [stdout] 33 +         self.p.len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 41 |         return Perm::new(r)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -         return Perm::new(r)
[INFO] [stdout] 41 +         Perm::new(r)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/perm.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         return Perm::new(r);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -         return Perm::new(r);
[INFO] [stdout] 51 +         Perm::new(r)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `r`
[INFO] [stdout]   --> src/perm.rs:48:18
[INFO] [stdout]    |
[INFO] [stdout] 48 |         for i in 0..(self.p.len()) {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 48 -         for i in 0..(self.p.len()) {
[INFO] [stdout] 48 +         for (i, <item>) in r.iter_mut().enumerate().take((self.p.len())) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/group.rs:44:43
[INFO] [stdout]    |
[INFO] [stdout] 44 |                 self.gens[i] = pi.compose(&pj);
[INFO] [stdout]    |                                           ^^^ help: change this to: `pj`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/group.rs:50:43
[INFO] [stdout]    |
[INFO] [stdout] 50 |                 self.gens[i] = pj.compose(&pi);
[INFO] [stdout]    |                                           ^^^ help: change this to: `pi`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/group.rs:52:49
[INFO] [stdout]    |
[INFO] [stdout] 52 |                 self.gens[i] = pj.inv().compose(&pi);
[INFO] [stdout]    |                                                 ^^^ help: change this to: `pi`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/group.rs:98:20
[INFO] [stdout]    |
[INFO] [stdout] 98 |                 if !s[newp].is_none() { continue }
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^ help: try: `s[newp].is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop
[INFO] [stdout]   --> src/group.rs:95:13
[INFO] [stdout]    |
[INFO] [stdout] 95 |             let top = frontier.pop().unwrap();
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some
[INFO] [stdout]    = note: `#[warn(clippy::manual_while_let_some)]` on by default
[INFO] [stdout] help: consider using a `while..let` loop
[INFO] [stdout]    |
[INFO] [stdout] 94 ~         while let Some(top) = frontier.pop() {
[INFO] [stdout] 95 ~             
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/group.rs:125:20
[INFO] [stdout]     |
[INFO] [stdout] 125 |                 if !self.schreier[newp].is_none() { continue }
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.schreier[newp].is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/group.rs:107:43
[INFO] [stdout]     |
[INFO] [stdout] 107 |     pub fn add_gen(&mut self, g: &'a Perm) -> () {
[INFO] [stdout]     |                                           ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]     = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop
[INFO] [stdout]    --> src/group.rs:122:13
[INFO] [stdout]     |
[INFO] [stdout] 122 |             let top = frontier.pop().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some
[INFO] [stdout] help: consider using a `while..let` loop
[INFO] [stdout]     |
[INFO] [stdout] 121 ~         while let Some(top) = frontier.pop() {
[INFO] [stdout] 122 ~             
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:148:9
[INFO] [stdout]     |
[INFO] [stdout] 148 |         return r;
[INFO] [stdout]     |         ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 148 -         return r;
[INFO] [stdout] 148 +         r
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:154:9
[INFO] [stdout]     |
[INFO] [stdout] 154 |         return self.schreier.iter().map(|x| if x.is_none() { 0 } else { 1 }).sum()
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 154 -         return self.schreier.iter().map(|x| if x.is_none() { 0 } else { 1 }).sum()
[INFO] [stdout] 154 +         self.schreier.iter().map(|x| if x.is_none() { 0 } else { 1 }).sum()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:178:9
[INFO] [stdout]     |
[INFO] [stdout] 178 |         return self.n;
[INFO] [stdout]     |         ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 178 -         return self.n;
[INFO] [stdout] 178 +         self.n
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:197:9
[INFO] [stdout]     |
[INFO] [stdout] 197 |         return curg;
[INFO] [stdout]     |         ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 197 -         return curg;
[INFO] [stdout] 197 +         curg
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:207:9
[INFO] [stdout]     |
[INFO] [stdout] 207 |         return stab_chain;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 207 -         return stab_chain;
[INFO] [stdout] 207 +         stab_chain
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/group.rs:200:36
[INFO] [stdout]     |
[INFO] [stdout] 200 |     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView> {
[INFO] [stdout]     |                                    ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 200 -     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView> {
[INFO] [stdout] 200 +     fn gen_stab_chain(&self, base: &[usize]) -> Vec<StabView> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/group.rs:211:43
[INFO] [stdout]     |
[INFO] [stdout] 211 |     pub fn random_schreier_sims(&mut self) -> () {
[INFO] [stdout]     |                                           ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:243:9
[INFO] [stdout]     |
[INFO] [stdout] 243 |         return chain.iter().map(|x| x.base_orbit_size()).product()
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 243 -         return chain.iter().map(|x| x.base_orbit_size()).product()
[INFO] [stdout] 243 +         chain.iter().map(|x| x.base_orbit_size()).product()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:252:9
[INFO] [stdout]     |
[INFO] [stdout] 252 | /         return Group {
[INFO] [stdout] 253 | |             gens: gens,
[INFO] [stdout] 254 | |             n: l,
[INFO] [stdout] 255 | |             id: Perm::id(l),
[INFO] [stdout] 256 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 252 ~         Group {
[INFO] [stdout] 253 +             gens: gens,
[INFO] [stdout] 254 +             n: l,
[INFO] [stdout] 255 +             id: Perm::id(l),
[INFO] [stdout] 256 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/group.rs:247:17
[INFO] [stdout]     |
[INFO] [stdout] 247 |         assert!(gens.len() > 0);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!gens.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is only used to index `gens`
[INFO] [stdout]    --> src/group.rs:249:18
[INFO] [stdout]     |
[INFO] [stdout] 249 |         for i in 0..gens.len() {
[INFO] [stdout]     |                  ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 249 -         for i in 0..gens.len() {
[INFO] [stdout] 249 +         for <item> in &gens {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:276:9
[INFO] [stdout]     |
[INFO] [stdout] 276 |         return orbit;
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 276 -         return orbit;
[INFO] [stdout] 276 +         orbit
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop
[INFO] [stdout]    --> src/group.rs:266:13
[INFO] [stdout]     |
[INFO] [stdout] 266 |             let top = frontier.pop().unwrap();
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some
[INFO] [stdout] help: consider using a `while..let` loop
[INFO] [stdout]     |
[INFO] [stdout] 265 ~         while let Some(top) = frontier.pop() {
[INFO] [stdout] 266 ~             
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:282:9
[INFO] [stdout]     |
[INFO] [stdout] 282 | /         return Group {
[INFO] [stdout] 283 | |             n,
[INFO] [stdout] 284 | |             id: Perm::id(n),
[INFO] [stdout] 285 | |             gens: vec![Perm::new(gen)]
[INFO] [stdout] 286 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 282 ~         Group {
[INFO] [stdout] 283 +             n,
[INFO] [stdout] 284 +             id: Perm::id(n),
[INFO] [stdout] 285 +             gens: vec![Perm::new(gen)]
[INFO] [stdout] 286 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:296:9
[INFO] [stdout]     |
[INFO] [stdout] 296 | /         return Group {
[INFO] [stdout] 297 | |             n,
[INFO] [stdout] 298 | |             id: Perm::id(n),
[INFO] [stdout] 299 | |             gens
[INFO] [stdout] 300 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 296 ~         Group {
[INFO] [stdout] 297 +             n,
[INFO] [stdout] 298 +             id: Perm::id(n),
[INFO] [stdout] 299 +             gens
[INFO] [stdout] 300 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/group.rs:312:9
[INFO] [stdout]     |
[INFO] [stdout] 312 |         return Group {n: 49, id: Perm::id(49), gens}
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 312 -         return Group {n: 49, id: Perm::id(49), gens}
[INFO] [stdout] 312 +         Group {n: 49, id: Perm::id(49), gens}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `chooseR` should have a snake case name
[INFO] [stdout]   --> src/group.rs:40:13
[INFO] [stdout]    |
[INFO] [stdout] 40 |         let chooseR : bool = self.rng.gen_bool(0.5);
[INFO] [stdout]    |             ^^^^^^^ help: convert the identifier to snake case: `choose_r`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing
[INFO] [stdout]    --> src/group.rs:200:23
[INFO] [stdout]     |
[INFO] [stdout] 200 |     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView> {
[INFO] [stdout]     |                       ^^^^^                            ^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                       |
[INFO] [stdout]     |                       the lifetime is elided here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: use `'_` for type paths
[INFO] [stdout]     |
[INFO] [stdout] 200 |     fn gen_stab_chain(&self, base: &Vec<usize>) -> Vec<StabView<'_>> {
[INFO] [stdout]     |                                                                ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.49s
[INFO] running `Command { std: "docker" "inspect" "6de76b65e64a48f38d12e399c1bda082e5b7df56d663964ec3ce11465e572072", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6de76b65e64a48f38d12e399c1bda082e5b7df56d663964ec3ce11465e572072", kill_on_drop: false }`
[INFO] [stdout] 6de76b65e64a48f38d12e399c1bda082e5b7df56d663964ec3ce11465e572072