[INFO] cloning repository https://github.com/SHIMA0111/password_generator_wasm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SHIMA0111/password_generator_wasm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSHIMA0111%2Fpassword_generator_wasm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSHIMA0111%2Fpassword_generator_wasm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6299bd4a5a2cf8ec29bddf387ff702baa3588b35 [INFO] linting SHIMA0111/password_generator_wasm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSHIMA0111%2Fpassword_generator_wasm" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SHIMA0111/password_generator_wasm [INFO] finished tweaking git repo https://github.com/SHIMA0111/password_generator_wasm [INFO] tweaked toml for git repo https://github.com/SHIMA0111/password_generator_wasm written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SHIMA0111/password_generator_wasm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SHIMA0111/password_generator_wasm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hermit-abi v0.3.6 [INFO] [stderr] Downloaded bumpalo v3.15.1 [INFO] [stderr] Downloaded implicit-clone v0.4.8 [INFO] [stderr] Downloaded serde-wasm-bindgen v0.6.3 [INFO] [stderr] Downloaded cc v1.0.86 [INFO] [stderr] Downloaded syn v2.0.50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30919ba0f42e240dcce2963306aa135f38fe6eac5e3b456e962e7a551c0b50ae [INFO] running `Command { std: "docker" "start" "-a" "30919ba0f42e240dcce2963306aa135f38fe6eac5e3b456e962e7a551c0b50ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30919ba0f42e240dcce2963306aa135f38fe6eac5e3b456e962e7a551c0b50ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30919ba0f42e240dcce2963306aa135f38fe6eac5e3b456e962e7a551c0b50ae", kill_on_drop: false }` [INFO] [stdout] 30919ba0f42e240dcce2963306aa135f38fe6eac5e3b456e962e7a551c0b50ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e83b3a76c9c08a609c2df53ddb8944d2f0793785fd2d531bda7057c5adc795ea [INFO] running `Command { std: "docker" "start" "-a" "e83b3a76c9c08a609c2df53ddb8944d2f0793785fd2d531bda7057c5adc795ea", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.91 [INFO] [stderr] Compiling bumpalo v3.15.1 [INFO] [stderr] Compiling wasm-bindgen v0.2.91 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling indexmap v2.2.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling prettyplease v0.2.16 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.91 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.4 [INFO] [stderr] Compiling gloo-worker-macros v0.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling implicit-clone-derive v0.1.1 [INFO] [stderr] Checking implicit-clone v0.4.8 [INFO] [stderr] Compiling yew-macro v0.21.0 [INFO] [stderr] Checking pin-project v1.1.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.91 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.91 [INFO] [stderr] Checking js-sys v0.3.68 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking pinned v0.1.0 [INFO] [stderr] Checking prokio v0.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking web-sys v0.3.68 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.41 [INFO] [stderr] Checking serde-wasm-bindgen v0.6.3 [INFO] [stderr] Checking gloo-timers v0.3.0 [INFO] [stderr] Checking gloo-utils v0.2.0 [INFO] [stderr] Checking gloo-events v0.2.0 [INFO] [stderr] Checking gloo-dialogs v0.2.0 [INFO] [stderr] Checking gloo-render v0.2.0 [INFO] [stderr] Checking gloo-file v0.3.0 [INFO] [stderr] Checking gloo-console v0.3.0 [INFO] [stderr] Checking gloo-storage v0.3.0 [INFO] [stderr] Checking gloo-history v0.2.2 [INFO] [stderr] Checking gloo-net v0.4.0 [INFO] [stderr] Checking gloo-worker v0.4.0 [INFO] [stderr] Checking gloo v0.10.0 [INFO] [stderr] Checking yew v0.21.0 [INFO] [stderr] Checking wasm_password_generator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use console_error_panic_hook; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use console_error_panic_hook; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/components/password_generator.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | let symbol_indices; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `symbol_indices` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 45 ~ [INFO] [stdout] 46 ~ let symbol_indices = if enabled_symbols.is_empty() { [INFO] [stdout] 47 ~ Uniform::new(0, 1) [INFO] [stdout] 48 | } else { [INFO] [stdout] 49 ~ Uniform::new(0, enabled_symbols.len()) [INFO] [stdout] 50 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/components/model.rs:29:112 [INFO] [stdout] | [INFO] [stdout] 29 | let passwords = generate_password(&args).map_err(|e| format!("Failed to generate password due to {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/model.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | if !(elements.length() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(elements.length() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | { for (*passwords).passwords.iter().map(|password| { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `passwords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:135:57 [INFO] [stdout] | [INFO] [stdout] 135 | ... select_text(&element); [INFO] [stdout] | ^^^^^^^^ help: change this to: `element` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/components/password_generator.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | let symbol_indices; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `symbol_indices` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 45 ~ [INFO] [stdout] 46 ~ let symbol_indices = if enabled_symbols.is_empty() { [INFO] [stdout] 47 ~ Uniform::new(0, 1) [INFO] [stdout] 48 | } else { [INFO] [stdout] 49 ~ Uniform::new(0, enabled_symbols.len()) [INFO] [stdout] 50 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/components/model.rs:29:112 [INFO] [stdout] | [INFO] [stdout] 29 | let passwords = generate_password(&args).map_err(|e| format!("Failed to generate password due to {}", e.to_string()))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/model.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | if !(elements.length() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(elements.length() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/lib.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 129 | { for (*passwords).passwords.iter().map(|password| { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `passwords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:135:57 [INFO] [stdout] | [INFO] [stdout] 135 | ... select_text(&element); [INFO] [stdout] | ^^^^^^^^ help: change this to: `element` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 42.16s [INFO] running `Command { std: "docker" "inspect" "e83b3a76c9c08a609c2df53ddb8944d2f0793785fd2d531bda7057c5adc795ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e83b3a76c9c08a609c2df53ddb8944d2f0793785fd2d531bda7057c5adc795ea", kill_on_drop: false }` [INFO] [stdout] e83b3a76c9c08a609c2df53ddb8944d2f0793785fd2d531bda7057c5adc795ea