[INFO] cloning repository https://github.com/SAXTEN2011/LogicDiagramGenerator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SAXTEN2011/LogicDiagramGenerator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSAXTEN2011%2FLogicDiagramGenerator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSAXTEN2011%2FLogicDiagramGenerator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 89ef07d876ee97048f447e22e0e0a72192ab223a [INFO] linting SAXTEN2011/LogicDiagramGenerator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSAXTEN2011%2FLogicDiagramGenerator" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SAXTEN2011/LogicDiagramGenerator [INFO] finished tweaking git repo https://github.com/SAXTEN2011/LogicDiagramGenerator [INFO] tweaked toml for git repo https://github.com/SAXTEN2011/LogicDiagramGenerator written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SAXTEN2011/LogicDiagramGenerator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SAXTEN2011/LogicDiagramGenerator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded adler v1.0.1 [INFO] [stderr] Downloaded byteorder v1.4.2 [INFO] [stderr] Downloaded memoffset v0.6.1 [INFO] [stderr] Downloaded gif v0.11.1 [INFO] [stderr] Downloaded weezl v0.1.4 [INFO] [stderr] Downloaded crossbeam-channel v0.5.0 [INFO] [stderr] Downloaded image v0.23.13 [INFO] [stderr] Downloaded libc v0.2.86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 610b42eb9516c50bd1e8db5272353cddbf93ac231c423f0da2136d23fc3464e6 [INFO] running `Command { std: "docker" "start" "-a" "610b42eb9516c50bd1e8db5272353cddbf93ac231c423f0da2136d23fc3464e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "610b42eb9516c50bd1e8db5272353cddbf93ac231c423f0da2136d23fc3464e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "610b42eb9516c50bd1e8db5272353cddbf93ac231c423f0da2136d23fc3464e6", kill_on_drop: false }` [INFO] [stdout] 610b42eb9516c50bd1e8db5272353cddbf93ac231c423f0da2136d23fc3464e6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8456db0357145cd6ebc094506349b573c76b679d1950808edbfbb85c3be34aed [INFO] running `Command { std: "docker" "start" "-a" "8456db0357145cd6ebc094506349b573c76b679d1950808edbfbb85c3be34aed", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Checking weezl v0.1.4 [INFO] [stderr] Checking adler v1.0.1 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Checking bytemuck v1.5.1 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking miniz_oxide v0.4.4 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking gif v0.11.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.3 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rayon-core v1.9.0 [INFO] [stderr] Checking rayon v1.5.0 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.13 [INFO] [stderr] Checking logic_diagram_generator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `convert::TryInto` [INFO] [stdout] --> src/expression_parser.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | convert::TryInto, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/expression_parser.rs:332:15 [INFO] [stdout] | [INFO] [stdout] 332 | if(names_of_inputs.len() == 1){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - if(names_of_inputs.len() == 1){ [INFO] [stdout] 332 + if names_of_inputs.len() == 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/expression_parser.rs:337:17 [INFO] [stdout] | [INFO] [stdout] 337 | gate_type: gate_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `convert::TryInto` [INFO] [stdout] --> src/renderer.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::VecDeque, convert::TryInto}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GateType` [INFO] [stdout] --> src/renderer.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::expression_parser::{Gate, GateType}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SpriteInfo` [INFO] [stdout] --> src/renderer.rs:7:49 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::spritesheet::{Sprite, SpriteCreator, SpriteInfo}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/renderer.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | (origin + x + g.position().x as u32), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 - (origin + x + g.position().x as u32), [INFO] [stdout] 207 + origin + x + g.position().x as u32 , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/spritesheet.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ImageBuffer`, `Pixel`, `RgbImage`, `Rgb`, `RgbaImage`, `Rgba`, `SubImage`, `imageops`, `math`, and `open` [INFO] [stdout] --> src/spritesheet.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | imageops, math, open, DynamicImage, GenericImageView, ImageBuffer, Pixel, Rgb, RgbImage, Rgba, [INFO] [stdout] | ^^^^^^^^ ^^^^ ^^^^ ^^^^^^^^^^^ ^^^^^ ^^^ ^^^^^^^^ ^^^^ [INFO] [stdout] 4 | RgbaImage, SubImage, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `convert::TryInto` [INFO] [stdout] --> src/expression_parser.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | convert::TryInto, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/expression_parser.rs:332:15 [INFO] [stdout] | [INFO] [stdout] 332 | if(names_of_inputs.len() == 1){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 332 - if(names_of_inputs.len() == 1){ [INFO] [stdout] 332 + if names_of_inputs.len() == 1 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/expression_parser.rs:337:17 [INFO] [stdout] | [INFO] [stdout] 337 | gate_type: gate_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `convert::TryInto` [INFO] [stdout] --> src/renderer.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::VecDeque, convert::TryInto}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GateType` [INFO] [stdout] --> src/renderer.rs:6:38 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::expression_parser::{Gate, GateType}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SpriteInfo` [INFO] [stdout] --> src/renderer.rs:7:49 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::spritesheet::{Sprite, SpriteCreator, SpriteInfo}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around method argument [INFO] [stdout] --> src/renderer.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | (origin + x + g.position().x as u32), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 - (origin + x + g.position().x as u32), [INFO] [stdout] 207 + origin + x + g.position().x as u32 , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/spritesheet.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ImageBuffer`, `Pixel`, `RgbImage`, `Rgb`, `RgbaImage`, `Rgba`, `SubImage`, `imageops`, `math`, and `open` [INFO] [stdout] --> src/spritesheet.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | imageops, math, open, DynamicImage, GenericImageView, ImageBuffer, Pixel, Rgb, RgbImage, Rgba, [INFO] [stdout] | ^^^^^^^^ ^^^^ ^^^^ ^^^^^^^^^^^ ^^^^^ ^^^ ^^^^^^^^ ^^^^ [INFO] [stdout] 4 | RgbaImage, SubImage, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GenericImageView` [INFO] [stdout] --> src/spritesheet.rs:3:41 [INFO] [stdout] | [INFO] [stdout] 3 | imageops, math, open, DynamicImage, GenericImageView, ImageBuffer, Pixel, Rgb, RgbImage, Rgba, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GenericImageView` [INFO] [stdout] --> src/spritesheet.rs:3:41 [INFO] [stdout] | [INFO] [stdout] 3 | imageops, math, open, DynamicImage, GenericImageView, ImageBuffer, Pixel, Rgb, RgbImage, Rgba, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pixel_size` [INFO] [stdout] --> src/renderer.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | let pixel_size = size.ceil() as usize; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pixel_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v_metrics` [INFO] [stdout] --> src/renderer.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | let v_metrics = self.font.v_metrics(scale); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_v_metrics` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_tree_breadth_first` is never used [INFO] [stdout] --> src/renderer.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 15 | impl Renderer { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 95 | fn draw_tree_breadth_first(&mut self, tree: &Gate, y_origin: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/spritesheet.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl SpriteInfo { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 28 | pub fn new(width: u32, height: u32, inputs: Vec, outputs: Vec) -> SpriteInfo { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `spritesheet` is never read [INFO] [stdout] --> src/spritesheet.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct SpriteCreator { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 39 | spritesheet: DynamicImage, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pixel_size` [INFO] [stdout] --> src/renderer.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | let pixel_size = size.ceil() as usize; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pixel_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v_metrics` [INFO] [stdout] --> src/renderer.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | let v_metrics = self.font.v_metrics(scale); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_v_metrics` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/expression_parser.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | u32, vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:38:40 [INFO] [stdout] | [INFO] [stdout] 38 | while popped != '(' && stack.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 43 | if stack.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_tree_breadth_first` is never used [INFO] [stdout] --> src/renderer.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 15 | impl Renderer { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 95 | fn draw_tree_breadth_first(&mut self, tree: &Gate, y_origin: u32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/spritesheet.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl SpriteInfo { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 28 | pub fn new(width: u32, height: u32, inputs: Vec, outputs: Vec) -> SpriteInfo { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `spritesheet` is never read [INFO] [stdout] --> src/spritesheet.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct SpriteCreator { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 39 | spritesheet: DynamicImage, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/expression_parser.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | u32, vec, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/expression_parser.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOT` contains a capitalized acronym [INFO] [stdout] --> src/expression_parser.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | NOT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Not` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INPUT` contains a capitalized acronym [INFO] [stdout] --> src/expression_parser.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | INPUT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:38:40 [INFO] [stdout] | [INFO] [stdout] 38 | while popped != '(' && stack.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 43 | if stack.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return 1; [INFO] [stdout] 111 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | return max_depth + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return max_depth + 1; [INFO] [stdout] 117 + max_depth + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 110 | if self.inputs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inputs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return self.gate_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return self.gate_type.clone(); [INFO] [stdout] 122 + self.gate_type.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/expression_parser.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOT` contains a capitalized acronym [INFO] [stdout] --> src/expression_parser.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | NOT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Not` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INPUT` contains a capitalized acronym [INFO] [stdout] --> src/expression_parser.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | INPUT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:111:13 [INFO] [stdout] | [INFO] [stdout] 111 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return 1; [INFO] [stdout] 111 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | return max_depth + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return max_depth + 1; [INFO] [stdout] 117 + max_depth + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 110 | if self.inputs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inputs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return self.gate_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return self.gate_type.clone(); [INFO] [stdout] 122 + self.gate_type.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GateType` which implements the `Copy` trait [INFO] [stdout] --> src/expression_parser.rs:122:16 [INFO] [stdout] | [INFO] [stdout] 122 | return self.gate_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | return &self.inputs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return &self.inputs; [INFO] [stdout] 125 + &self.inputs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | return self.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return self.name.clone(); [INFO] [stdout] 128 + self.name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | return this_y; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return this_y; [INFO] [stdout] 182 + this_y [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | return this_y.min(*child_inputs.iter().min().unwrap_or(&0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return this_y.min(*child_inputs.iter().min().unwrap_or(&0)); [INFO] [stdout] 193 + this_y.min(*child_inputs.iter().min().unwrap_or(&0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GateType` which implements the `Copy` trait [INFO] [stdout] --> src/expression_parser.rs:122:16 [INFO] [stdout] | [INFO] [stdout] 122 | return self.gate_type.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if self.inputs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inputs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | return &self.inputs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return &self.inputs; [INFO] [stdout] 125 + &self.inputs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | return self.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return self.name.clone(); [INFO] [stdout] 128 + self.name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | return this_y; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return this_y; [INFO] [stdout] 209 + this_y [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | return this_y.max(*child_inputs.iter().max().unwrap_or(&0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return this_y.max(*child_inputs.iter().max().unwrap_or(&0)); [INFO] [stdout] 224 + this_y.max(*child_inputs.iter().max().unwrap_or(&0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 208 | if self.inputs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inputs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | return this_y; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return this_y; [INFO] [stdout] 182 + this_y [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | return this_y.min(*child_inputs.iter().min().unwrap_or(&0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return this_y.min(*child_inputs.iter().min().unwrap_or(&0)); [INFO] [stdout] 193 + this_y.min(*child_inputs.iter().min().unwrap_or(&0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if self.inputs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inputs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/expression_parser.rs:230:47 [INFO] [stdout] | [INFO] [stdout] 230 | let mut max = self.find_max_y_element((2 as u32).pow(self.depth()) * 50, 0, 1); [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/expression_parser.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | max = max + 40; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `max += 40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | return this_y; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return this_y; [INFO] [stdout] 209 + this_y [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_parser.rs:224:13 [INFO] [stdout] | [INFO] [stdout] 224 | return this_y.max(*child_inputs.iter().max().unwrap_or(&0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return this_y.max(*child_inputs.iter().max().unwrap_or(&0)); [INFO] [stdout] 224 + this_y.max(*child_inputs.iter().max().unwrap_or(&0)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/expression_parser.rs:232:43 [INFO] [stdout] | [INFO] [stdout] 232 | let min = self.find_min_y_element((2 as u32).pow(self.depth()) * 50, 0, 1); [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_parser.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 208 | if self.inputs.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inputs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/expression_parser.rs:230:47 [INFO] [stdout] | [INFO] [stdout] 230 | let mut max = self.find_max_y_element((2 as u32).pow(self.depth()) * 50, 0, 1); [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/expression_parser.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | max = max + 40; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `max += 40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/expression_parser.rs:232:43 [INFO] [stdout] | [INFO] [stdout] 232 | let min = self.find_min_y_element((2 as u32).pow(self.depth()) * 50, 0, 1); [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GateType` which implements the `Copy` trait [INFO] [stdout] --> src/expression_parser.rs:331:87 [INFO] [stdout] | [INFO] [stdout] 331 | let mut created_name = names_of_inputs.join(&gate_type_to_operator_symbol(gate_type.clone())[..]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GateType` which implements the `Copy` trait [INFO] [stdout] --> src/expression_parser.rs:333:69 [INFO] [stdout] | [INFO] [stdout] 333 | created_name.push_str(&gate_type_to_operator_symbol(gate_type.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_parser.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 361 | if (p1 == 0 && p2 == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 362 | | || (p1 == 0 && *c2 == '(') [INFO] [stdout] 363 | | || (*c1 == ')' && p2 == 0) [INFO] [stdout] 364 | | || (*c1 == '\'' && p2 == 0) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 363 - || (*c1 == ')' && p2 == 0) [INFO] [stdout] 364 - || (*c1 == '\'' && p2 == 0) [INFO] [stdout] 361 + if !(p1 != 0 && p2 != 0 || p2 != 0 && *c2 != '(' || p1 != 0 && *c1 != ')' && *c1 != '\'') [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 363 - || (*c1 == ')' && p2 == 0) [INFO] [stdout] 364 - || (*c1 == '\'' && p2 == 0) [INFO] [stdout] 361 + if (*c1 == '\'' || *c1 == ')' || p1 == 0) && (*c2 == '(' || p2 == 0) && (p2 == 0 || p1 == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GateType` which implements the `Copy` trait [INFO] [stdout] --> src/expression_parser.rs:331:87 [INFO] [stdout] | [INFO] [stdout] 331 | let mut created_name = names_of_inputs.join(&gate_type_to_operator_symbol(gate_type.clone())[..]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_parser.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 361 | if (p1 == 0 && p2 == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 362 | | || (p1 == 0 && *c2 == '(') [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 361 + if !(p1 != 0 || p2 != 0 && *c2 != '(') [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 361 + if (*c2 == '(' || p2 == 0) && p1 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GateType` which implements the `Copy` trait [INFO] [stdout] --> src/expression_parser.rs:333:69 [INFO] [stdout] | [INFO] [stdout] 333 | created_name.push_str(&gate_type_to_operator_symbol(gate_type.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `gate_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_parser.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 361 | if (p1 == 0 && p2 == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 362 | | || (p1 == 0 && *c2 == '(') [INFO] [stdout] 363 | | || (*c1 == ')' && p2 == 0) [INFO] [stdout] 364 | | || (*c1 == '\'' && p2 == 0) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 363 - || (*c1 == ')' && p2 == 0) [INFO] [stdout] 364 - || (*c1 == '\'' && p2 == 0) [INFO] [stdout] 361 + if !(p1 != 0 && p2 != 0 || p2 != 0 && *c2 != '(' || p1 != 0 && *c1 != ')' && *c1 != '\'') [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 363 - || (*c1 == ')' && p2 == 0) [INFO] [stdout] 364 - || (*c1 == '\'' && p2 == 0) [INFO] [stdout] 361 + if (*c1 == '\'' || *c1 == ')' || p1 == 0) && (*c2 == '(' || p2 == 0) && (p2 == 0 || p1 == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_parser.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 361 | if (p1 == 0 && p2 == 0) [INFO] [stdout] | ____________^ [INFO] [stdout] 362 | | || (p1 == 0 && *c2 == '(') [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 361 + if !(p1 != 0 || p2 != 0 && *c2 != '(') [INFO] [stdout] | [INFO] [stdout] 361 - if (p1 == 0 && p2 == 0) [INFO] [stdout] 362 - || (p1 == 0 && *c2 == '(') [INFO] [stdout] 361 + if (*c2 == '(' || p2 == 0) && p1 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | &tree, [INFO] [stdout] | ^^^^^ help: change this to: `tree` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/renderer.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / match connect_to_point { [INFO] [stdout] 58 | | Some(point) => { [INFO] [stdout] 59 | | self.wire( [INFO] [stdout] 60 | | x_offset + 90, [INFO] [stdout] ... | [INFO] [stdout] 70 | | None => {} [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some(point) = connect_to_point { [INFO] [stdout] 58 + self.wire( [INFO] [stdout] 59 + x_offset + 90, [INFO] [stdout] 60 + y_origin [INFO] [stdout] 61 + + self [INFO] [stdout] 62 + .sprite_creator [INFO] [stdout] 63 + .get_sprite_info(sprite_type.clone()) [INFO] [stdout] 64 + .outputs[0], [INFO] [stdout] 65 + point[0], [INFO] [stdout] 66 + point[1], [INFO] [stdout] 67 + ); [INFO] [stdout] 68 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/renderer.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | &tree, [INFO] [stdout] | ^^^^^ help: change this to: `tree` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/renderer.rs:64:46 [INFO] [stdout] | [INFO] [stdout] 64 | ... .get_sprite_info(sprite_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/renderer.rs:88:46 [INFO] [stdout] | [INFO] [stdout] 88 | ... .get_sprite_info(sprite_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/renderer.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / match connect_to_point { [INFO] [stdout] 58 | | Some(point) => { [INFO] [stdout] 59 | | self.wire( [INFO] [stdout] 60 | | x_offset + 90, [INFO] [stdout] ... | [INFO] [stdout] 70 | | None => {} [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some(point) = connect_to_point { [INFO] [stdout] 58 + self.wire( [INFO] [stdout] 59 + x_offset + 90, [INFO] [stdout] 60 + y_origin [INFO] [stdout] 61 + + self [INFO] [stdout] 62 + .sprite_creator [INFO] [stdout] 63 + .get_sprite_info(sprite_type.clone()) [INFO] [stdout] 64 + .outputs[0], [INFO] [stdout] 65 + point[0], [INFO] [stdout] 66 + point[1], [INFO] [stdout] 67 + ); [INFO] [stdout] 68 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/renderer.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | max_depth: u32, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_depth` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/renderer.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | max_depth, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/renderer.rs:64:46 [INFO] [stdout] | [INFO] [stdout] 64 | ... .get_sprite_info(sprite_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/renderer.rs:88:46 [INFO] [stdout] | [INFO] [stdout] 88 | ... .get_sprite_info(sprite_type.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/renderer.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | max_depth: u32, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_depth` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/renderer.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | max_depth, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/renderer.rs:168:59 [INFO] [stdout] | [INFO] [stdout] 168 | let sprite_image = self.sprite_creator.get_sprite(sprite.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/renderer.rs:168:59 [INFO] [stdout] | [INFO] [stdout] 168 | let sprite_image = self.sprite_creator.get_sprite(sprite.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/renderer.rs:208:51 [INFO] [stdout] | [INFO] [stdout] 208 | ... 12) as i32 + (g.pixel_bounding_box().unwrap().max.y) as i32 + (g.pixel_bounding_box().unwrap().min.y) as i32) as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g.pixel_bounding_box().unwrap().max.y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/renderer.rs:208:100 [INFO] [stdout] | [INFO] [stdout] 208 | ...x.y) as i32 + (g.pixel_bounding_box().unwrap().min.y) as i32) as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g.pixel_bounding_box().unwrap().min.y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/renderer.rs:208:51 [INFO] [stdout] | [INFO] [stdout] 208 | ... 12) as i32 + (g.pixel_bounding_box().unwrap().max.y) as i32 + (g.pixel_bounding_box().unwrap().min.y) as i32) as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g.pixel_bounding_box().unwrap().max.y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/renderer.rs:208:100 [INFO] [stdout] | [INFO] [stdout] 208 | ...x.y) as i32 + (g.pixel_bounding_box().unwrap().min.y) as i32) as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(g.pixel_bounding_box().unwrap().min.y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless parenthesis on range literals can be removed [INFO] [stdout] --> src/renderer.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | for y in (0)..((dy).abs() + output_offset) { [INFO] [stdout] | ^^^ help: try: `0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_parens_on_range_literals [INFO] [stdout] = note: `#[warn(clippy::needless_parens_on_range_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/renderer.rs:235:27 [INFO] [stdout] | [INFO] [stdout] 235 | let pixel_x = (x_origin + x) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(x_origin + x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless parenthesis on range literals can be removed [INFO] [stdout] --> src/renderer.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | for y in (0)..((dy).abs() + output_offset) { [INFO] [stdout] | ^^^ help: try: `0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_parens_on_range_literals [INFO] [stdout] = note: `#[warn(clippy::needless_parens_on_range_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NAND` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | NAND, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nand` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOR` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | NOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/renderer.rs:235:27 [INFO] [stdout] | [INFO] [stdout] 235 | let pixel_x = (x_origin + x) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(x_origin + x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XNOR` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | XNOR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Xnor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOT` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | NOT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Not` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INPUT` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | INPUT [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NAND` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | NAND, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nand` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOR` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | NOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XNOR` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | XNOR, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Xnor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOT` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | NOT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Not` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INPUT` contains a capitalized acronym [INFO] [stdout] --> src/spritesheet.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | INPUT [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/spritesheet.rs:69:31 [INFO] [stdout] | [INFO] [stdout] 69 | sprite_map.insert(sprite.clone(), img); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/spritesheet.rs:69:31 [INFO] [stdout] | [INFO] [stdout] 69 | sprite_map.insert(sprite.clone(), img); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `sprite` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spritesheet.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return self.already_generated.get(&sprite_name).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return self.already_generated.get(&sprite_name).unwrap(); [INFO] [stdout] 132 + self.already_generated.get(&sprite_name).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spritesheet.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return self.already_generated.get(&sprite_name).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return self.already_generated.get(&sprite_name).unwrap(); [INFO] [stdout] 132 + self.already_generated.get(&sprite_name).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/spritesheet.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 47 | for sprite in vec![ [INFO] [stdout] | _______________________^ [INFO] [stdout] 48 | | Sprite::AND, [INFO] [stdout] 49 | | Sprite::NAND, [INFO] [stdout] 50 | | Sprite::OR, [INFO] [stdout] ... | [INFO] [stdout] 55 | | Sprite::INPUT, [INFO] [stdout] 56 | | ] { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 47 ~ for sprite in [Sprite::AND, [INFO] [stdout] 48 + Sprite::NAND, [INFO] [stdout] 49 + Sprite::OR, [INFO] [stdout] 50 + Sprite::NOR, [INFO] [stdout] 51 + Sprite::XOR, [INFO] [stdout] 52 + Sprite::XNOR, [INFO] [stdout] 53 + Sprite::NOT, [INFO] [stdout] 54 ~ Sprite::INPUT] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `gate_padding` should have an upper case name [INFO] [stdout] --> src/renderer.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 103 | const gate_padding: u32 = 40; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 103 - const gate_padding: u32 = 40; [INFO] [stdout] 103 + const GATE_PADDING: u32 = 40; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/spritesheet.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 47 | for sprite in vec![ [INFO] [stdout] | _______________________^ [INFO] [stdout] 48 | | Sprite::AND, [INFO] [stdout] 49 | | Sprite::NAND, [INFO] [stdout] 50 | | Sprite::OR, [INFO] [stdout] ... | [INFO] [stdout] 55 | | Sprite::INPUT, [INFO] [stdout] 56 | | ] { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 47 ~ for sprite in [Sprite::AND, [INFO] [stdout] 48 + Sprite::NAND, [INFO] [stdout] 49 + Sprite::OR, [INFO] [stdout] 50 + Sprite::NOR, [INFO] [stdout] 51 + Sprite::XOR, [INFO] [stdout] 52 + Sprite::XNOR, [INFO] [stdout] 53 + Sprite::NOT, [INFO] [stdout] 54 ~ Sprite::INPUT] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `gate_padding` should have an upper case name [INFO] [stdout] --> src/renderer.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 103 | const gate_padding: u32 = 40; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 103 - const gate_padding: u32 = 40; [INFO] [stdout] 103 + const GATE_PADDING: u32 = 40; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.18s [INFO] running `Command { std: "docker" "inspect" "8456db0357145cd6ebc094506349b573c76b679d1950808edbfbb85c3be34aed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8456db0357145cd6ebc094506349b573c76b679d1950808edbfbb85c3be34aed", kill_on_drop: false }` [INFO] [stdout] 8456db0357145cd6ebc094506349b573c76b679d1950808edbfbb85c3be34aed