[INFO] cloning repository https://github.com/S-Nakamur-a/reversi-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/S-Nakamur-a/reversi-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS-Nakamur-a%2Freversi-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS-Nakamur-a%2Freversi-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0890c13208911d894d508740635b4819d598853d [INFO] linting S-Nakamur-a/reversi-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS-Nakamur-a%2Freversi-rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/S-Nakamur-a/reversi-rs [INFO] finished tweaking git repo https://github.com/S-Nakamur-a/reversi-rs [INFO] tweaked toml for git repo https://github.com/S-Nakamur-a/reversi-rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/S-Nakamur-a/reversi-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/S-Nakamur-a/reversi-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a44c1cb257c9183388754d0074ec244798e608227a7287e2e370a6fd82ab4346 [INFO] running `Command { std: "docker" "start" "-a" "a44c1cb257c9183388754d0074ec244798e608227a7287e2e370a6fd82ab4346", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a44c1cb257c9183388754d0074ec244798e608227a7287e2e370a6fd82ab4346", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a44c1cb257c9183388754d0074ec244798e608227a7287e2e370a6fd82ab4346", kill_on_drop: false }` [INFO] [stdout] a44c1cb257c9183388754d0074ec244798e608227a7287e2e370a6fd82ab4346 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d9e683cbe36b17ec298188e2f30e4df13b2fc451f1ebdebb745ef056e86f53d [INFO] running `Command { std: "docker" "start" "-a" "1d9e683cbe36b17ec298188e2f30e4df13b2fc451f1ebdebb745ef056e86f53d", kill_on_drop: false }` [INFO] [stderr] Checking reversi v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | Some(Piece::Black) => format!("⚫️"), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"⚫️".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | Some(Piece::White) => format!("⚪️"), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"⚪️".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/main.rs:64:32 [INFO] [stdout] | [INFO] [stdout] 64 | row >= 0 && row < 8 && col >= 0 && col < 8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/main.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | row >= 0 && row < 8 && col >= 0 && col < 8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 176 | | || (row == 0 && col == 7) [INFO] [stdout] 177 | | || (row == 7 && col == 0) [INFO] [stdout] 178 | | || (row == 7 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 177 - || (row == 7 && col == 0) [INFO] [stdout] 178 - || (row == 7 && col == 7) [INFO] [stdout] 175 + if !(col != 0 && col != 7 || row != 0 && row != 7) [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 177 - || (row == 7 && col == 0) [INFO] [stdout] 178 - || (row == 7 && col == 7) [INFO] [stdout] 175 + if (row == 7 || row == 0) && (col == 7 || col == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 176 | | || (row == 0 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 175 + if !(row != 0 || col != 0 && col != 7) [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 175 + if (col == 7 || col == 0) && row == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 186 | | || (row == 0 && col == 7) [INFO] [stdout] 187 | | || (row == 7 && col == 0) [INFO] [stdout] 188 | | || (row == 7 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 187 - || (row == 7 && col == 0) [INFO] [stdout] 188 - || (row == 7 && col == 7) [INFO] [stdout] 185 + if !(col != 0 && col != 7 || row != 0 && row != 7) [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 187 - || (row == 7 && col == 0) [INFO] [stdout] 188 - || (row == 7 && col == 7) [INFO] [stdout] 185 + if (row == 7 || row == 0) && (col == 7 || col == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 186 | | || (row == 0 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 185 + if !(row != 0 || col != 0 && col != 7) [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 185 + if (col == 7 || col == 0) && row == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:235:1 [INFO] [stdout] | [INFO] [stdout] 235 | / fn minimax( [INFO] [stdout] 236 | | board: &Board, [INFO] [stdout] 237 | | depth: u32, [INFO] [stdout] 238 | | mut alpha: i32, [INFO] [stdout] ... | [INFO] [stdout] 243 | | time_limit: Duration, [INFO] [stdout] 244 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | Some(Piece::Black) => format!("⚫️"), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"⚫️".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | Some(Piece::White) => format!("⚪️"), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"⚪️".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/main.rs:64:32 [INFO] [stdout] | [INFO] [stdout] 64 | row >= 0 && row < 8 && col >= 0 && col < 8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/main.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | row >= 0 && row < 8 && col >= 0 && col < 8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..8).contains(&row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 176 | | || (row == 0 && col == 7) [INFO] [stdout] 177 | | || (row == 7 && col == 0) [INFO] [stdout] 178 | | || (row == 7 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 177 - || (row == 7 && col == 0) [INFO] [stdout] 178 - || (row == 7 && col == 7) [INFO] [stdout] 175 + if !(col != 0 && col != 7 || row != 0 && row != 7) [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 177 - || (row == 7 && col == 0) [INFO] [stdout] 178 - || (row == 7 && col == 7) [INFO] [stdout] 175 + if (row == 7 || row == 0) && (col == 7 || col == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 176 | | || (row == 0 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 175 + if !(row != 0 || col != 0 && col != 7) [INFO] [stdout] | [INFO] [stdout] 175 - if (row == 0 && col == 0) [INFO] [stdout] 176 - || (row == 0 && col == 7) [INFO] [stdout] 175 + if (col == 7 || col == 0) && row == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 186 | | || (row == 0 && col == 7) [INFO] [stdout] 187 | | || (row == 7 && col == 0) [INFO] [stdout] 188 | | || (row == 7 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 187 - || (row == 7 && col == 0) [INFO] [stdout] 188 - || (row == 7 && col == 7) [INFO] [stdout] 185 + if !(col != 0 && col != 7 || row != 0 && row != 7) [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 187 - || (row == 7 && col == 0) [INFO] [stdout] 188 - || (row == 7 && col == 7) [INFO] [stdout] 185 + if (row == 7 || row == 0) && (col == 7 || col == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:185:28 [INFO] [stdout] | [INFO] [stdout] 185 | if (row == 0 && col == 0) [INFO] [stdout] | ____________________________^ [INFO] [stdout] 186 | | || (row == 0 && col == 7) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 185 + if !(row != 0 || col != 0 && col != 7) [INFO] [stdout] | [INFO] [stdout] 185 - if (row == 0 && col == 0) [INFO] [stdout] 186 - || (row == 0 && col == 7) [INFO] [stdout] 185 + if (col == 7 || col == 0) && row == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:235:1 [INFO] [stdout] | [INFO] [stdout] 235 | / fn minimax( [INFO] [stdout] 236 | | board: &Board, [INFO] [stdout] 237 | | depth: u32, [INFO] [stdout] 238 | | mut alpha: i32, [INFO] [stdout] ... | [INFO] [stdout] 243 | | time_limit: Duration, [INFO] [stdout] 244 | | ) -> i32 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s [INFO] running `Command { std: "docker" "inspect" "1d9e683cbe36b17ec298188e2f30e4df13b2fc451f1ebdebb745ef056e86f53d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d9e683cbe36b17ec298188e2f30e4df13b2fc451f1ebdebb745ef056e86f53d", kill_on_drop: false }` [INFO] [stdout] 1d9e683cbe36b17ec298188e2f30e4df13b2fc451f1ebdebb745ef056e86f53d