[INFO] cloning repository https://github.com/Ryan-M3/simrs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ryan-M3/simrs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRyan-M3%2Fsimrs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRyan-M3%2Fsimrs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a376bc453bdeffe10e95de449f10460ce525f242 [INFO] linting Ryan-M3/simrs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRyan-M3%2Fsimrs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Ryan-M3/simrs [INFO] finished tweaking git repo https://github.com/Ryan-M3/simrs [INFO] tweaked toml for git repo https://github.com/Ryan-M3/simrs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Ryan-M3/simrs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Ryan-M3/simrs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memmap2 v0.9.7 [INFO] [stderr] Downloaded gilrs-core v0.6.4 [INFO] [stderr] Downloaded twox-hash v2.1.1 [INFO] [stderr] Downloaded naga_oil v0.17.1 [INFO] [stderr] Downloaded prettyplease v0.2.36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c91ca84e0807bdfb639160d8e75d18cfbbfcc08e7bc5ba1fbdc1dd6919a3c35 [INFO] running `Command { std: "docker" "start" "-a" "5c91ca84e0807bdfb639160d8e75d18cfbbfcc08e7bc5ba1fbdc1dd6919a3c35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c91ca84e0807bdfb639160d8e75d18cfbbfcc08e7bc5ba1fbdc1dd6919a3c35", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c91ca84e0807bdfb639160d8e75d18cfbbfcc08e7bc5ba1fbdc1dd6919a3c35", kill_on_drop: false }` [INFO] [stdout] 5c91ca84e0807bdfb639160d8e75d18cfbbfcc08e7bc5ba1fbdc1dd6919a3c35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86527f23dc05b8ac60cd430b0c3f1186f62454ae57054c791ad3b5812cf7bed1 [INFO] running `Command { std: "docker" "start" "-a" "86527f23dc05b8ac60cd430b0c3f1186f62454ae57054c791ad3b5812cf7bed1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling winnow v0.7.12 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Compiling typeid v1.0.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking downcast-rs v2.0.1 [INFO] [stderr] Checking bevy_ptr v0.16.1 [INFO] [stderr] Checking disqualified v1.0.0 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Checking nonmax v0.5.5 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Compiling indexmap v2.10.0 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Compiling parking_lot v0.12.4 [INFO] [stderr] Compiling uuid v1.17.0 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tempfile v3.22.0 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking ctrlc v3.4.7 [INFO] [stderr] Checking erased-serde v0.4.6 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stderr] Checking proptest v1.7.0 [INFO] [stderr] Checking bevy_platform v0.16.1 [INFO] [stderr] Checking bevy_utils v0.16.1 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling variadics_please v1.1.0 [INFO] [stderr] Compiling assert_type_match v0.1.1 [INFO] [stderr] Compiling bevy_macro_utils v0.16.1 [INFO] [stderr] Compiling bevy_reflect_derive v0.16.1 [INFO] [stderr] Compiling bevy_ecs_macros v0.16.1 [INFO] [stderr] Compiling bevy_derive v0.16.1 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking bevy_tasks v0.16.1 [INFO] [stderr] Checking bevy_reflect v0.16.1 [INFO] [stderr] Checking bevy_ecs v0.16.1 [INFO] [stderr] Checking bevy_app v0.16.1 [INFO] [stderr] Checking bevy_time v0.16.1 [INFO] [stderr] Checking bevy_log v0.16.1 [INFO] [stderr] Checking simrs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/records/rolling_mean.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | window: window, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/records/rolling_mean.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | window: window, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | / if let Ok(job) = jobs.get(ad.job) { [INFO] [stdout] 97 | | if let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | | // skip if already a member [INFO] [stdout] 99 | | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ if let Ok(job) = jobs.get(ad.job) [INFO] [stdout] 97 ~ && let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | // skip if already a member [INFO] [stdout] ... [INFO] [stdout] 109 | } [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / if let Ok(mut job) = jobs.get_mut(r.job) { [INFO] [stdout] 134 | | if let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] 136 | | let current = members.len() as u32; [INFO] [stdout] ... | [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 133 ~ if let Ok(mut job) = jobs.get_mut(r.job) [INFO] [stdout] 134 ~ && let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] ... [INFO] [stdout] 163 | } [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:154:25 [INFO] [stdout] | [INFO] [stdout] 154 | if !members.iter().any(|&e| e == r.applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&r.applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if !(age < n) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `(age >= n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | if !(age >= n) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(age < n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 13 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | | inv.items.push(item); [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 12 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 13 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | inv.items.push(item); [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 22 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | | inv.items.swap_remove(i); [INFO] [stdout] 24 | | return true; [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 22 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | inv.items.swap_remove(i); [INFO] [stdout] 24 | return true; [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Some(src) = from { [INFO] [stdout] 34 | | if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Some(src) = from [INFO] [stdout] 34 ~ && let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 | } [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ if let Ok(mut inv) = q_inv.get_mut(src) [INFO] [stdout] 35 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / if let Ok(mut inv) = q_inv.get_mut(to) { [INFO] [stdout] 42 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | | inv.items.push(item); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if let Ok(mut inv) = q_inv.get_mut(to) [INFO] [stdout] 42 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | inv.items.push(item); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|inv| inv.items.iter().any(|&e| e == item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mortality/system.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 22 | ) -> impl FnMut(ResMut, ResMut, Query<(Entity, &Person)>, EventWriter) [INFO] [stdout] | ______^ [INFO] [stdout] 23 | | + Send [INFO] [stdout] 24 | | + Sync [INFO] [stdout] 25 | | + 'static { [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Person` [INFO] [stdout] --> src/person.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { age: 0.0 } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Person { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/records/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod records; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | / if let Ok(job) = jobs.get(ad.job) { [INFO] [stdout] 97 | | if let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | | // skip if already a member [INFO] [stdout] 99 | | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ if let Ok(job) = jobs.get(ad.job) [INFO] [stdout] 97 ~ && let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | // skip if already a member [INFO] [stdout] ... [INFO] [stdout] 109 | } [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / if let Ok(mut job) = jobs.get_mut(r.job) { [INFO] [stdout] 134 | | if let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] 136 | | let current = members.len() as u32; [INFO] [stdout] ... | [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 133 ~ if let Ok(mut job) = jobs.get_mut(r.job) [INFO] [stdout] 134 ~ && let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] ... [INFO] [stdout] 163 | } [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:154:25 [INFO] [stdout] | [INFO] [stdout] 154 | if !members.iter().any(|&e| e == r.applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&r.applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if !(age < n) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `(age >= n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | if !(age >= n) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(age < n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 13 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | | inv.items.push(item); [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 12 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 13 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | inv.items.push(item); [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 22 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | | inv.items.swap_remove(i); [INFO] [stdout] 24 | | return true; [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 22 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | inv.items.swap_remove(i); [INFO] [stdout] 24 | return true; [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Some(src) = from { [INFO] [stdout] 34 | | if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Some(src) = from [INFO] [stdout] 34 ~ && let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 | } [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ if let Ok(mut inv) = q_inv.get_mut(src) [INFO] [stdout] 35 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / if let Ok(mut inv) = q_inv.get_mut(to) { [INFO] [stdout] 42 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | | inv.items.push(item); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if let Ok(mut inv) = q_inv.get_mut(to) [INFO] [stdout] 42 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | inv.items.push(item); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|inv| inv.items.iter().any(|&e| e == item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mortality/system.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 22 | ) -> impl FnMut(ResMut, ResMut, Query<(Entity, &Person)>, EventWriter) [INFO] [stdout] | ______^ [INFO] [stdout] 23 | | + Send [INFO] [stdout] 24 | | + Sync [INFO] [stdout] 25 | | + 'static { [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Person` [INFO] [stdout] --> src/person.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Self { [INFO] [stdout] 12 | | Self { age: 0.0 } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Person { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/records/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod records; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/records/rolling_mean.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | window: window, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/records/rolling_mean.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | window: window, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> tests/mortality_model_props.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 44 | prop_assert!(0.0 <= h && h <= 1.0, "hazard out of bounds: h({a})={h}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&h)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `alive` are never read [INFO] [stdout] --> tests/mortality_ecs_props.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 45 | struct AgentInit { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 46 | id: u64, [INFO] [stdout] | ^^ [INFO] [stdout] 47 | age: u16, [INFO] [stdout] 48 | alive: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AgentInit` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `draw_u01` is never used [INFO] [stdout] --> tests/mortality_rng.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn draw_u01(global_seed: u64, agent_id: u64, tick: u64) -> f32 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | / if let Ok(job) = jobs.get(ad.job) { [INFO] [stdout] 97 | | if let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | | // skip if already a member [INFO] [stdout] 99 | | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ if let Ok(job) = jobs.get(ad.job) [INFO] [stdout] 97 ~ && let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | // skip if already a member [INFO] [stdout] ... [INFO] [stdout] 109 | } [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / if let Ok(mut job) = jobs.get_mut(r.job) { [INFO] [stdout] 134 | | if let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] 136 | | let current = members.len() as u32; [INFO] [stdout] ... | [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 133 ~ if let Ok(mut job) = jobs.get_mut(r.job) [INFO] [stdout] 134 ~ && let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] ... [INFO] [stdout] 163 | } [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:154:25 [INFO] [stdout] | [INFO] [stdout] 154 | if !members.iter().any(|&e| e == r.applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&r.applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if !(age < n) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `(age >= n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | if !(age >= n) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(age < n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 13 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | | inv.items.push(item); [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 12 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 13 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | inv.items.push(item); [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 22 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | | inv.items.swap_remove(i); [INFO] [stdout] 24 | | return true; [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 22 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | inv.items.swap_remove(i); [INFO] [stdout] 24 | return true; [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Some(src) = from { [INFO] [stdout] 34 | | if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Some(src) = from [INFO] [stdout] 34 ~ && let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 | } [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ if let Ok(mut inv) = q_inv.get_mut(src) [INFO] [stdout] 35 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / if let Ok(mut inv) = q_inv.get_mut(to) { [INFO] [stdout] 42 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | | inv.items.push(item); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if let Ok(mut inv) = q_inv.get_mut(to) [INFO] [stdout] 42 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | inv.items.push(item); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|inv| inv.items.iter().any(|&e| e == item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mortality/system.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 22 | ) -> impl FnMut(ResMut, ResMut, Query<(Entity, &Person)>, EventWriter) [INFO] [stdout] | ______^ [INFO] [stdout] 23 | | + Send [INFO] [stdout] 24 | | + Sync [INFO] [stdout] 25 | | + 'static { [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/records/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod records; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/main.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | app.add_plugins(bevy_time::TimePlugin::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 75 - app.add_plugins(bevy_time::TimePlugin::default()); [INFO] [stdout] 75 + app.add_plugins(bevy_time::TimePlugin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | / if let Ok(job) = jobs.get(ad.job) { [INFO] [stdout] 97 | | if let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | | // skip if already a member [INFO] [stdout] 99 | | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ if let Ok(job) = jobs.get(ad.job) [INFO] [stdout] 97 ~ && let Some((spec, members)) = job.roles.get(ad.role_index) { [INFO] [stdout] 98 | // skip if already a member [INFO] [stdout] ... [INFO] [stdout] 109 | } [INFO] [stdout] 110 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | if members.iter().any(|&e| e == applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/hiring_manager/plugin.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / if let Ok(mut job) = jobs.get_mut(r.job) { [INFO] [stdout] 134 | | if let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] 136 | | let current = members.len() as u32; [INFO] [stdout] ... | [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 133 ~ if let Ok(mut job) = jobs.get_mut(r.job) [INFO] [stdout] 134 ~ && let Some((spec, members)) = job.roles.get_mut(r.role_index) { [INFO] [stdout] 135 | // capacity left = min(max - current, batch, min - current) [INFO] [stdout] ... [INFO] [stdout] 163 | } [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/hiring_manager/plugin.rs:154:25 [INFO] [stdout] | [INFO] [stdout] 154 | if !members.iter().any(|&e| e == r.applicant) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `members.contains(&r.applicant)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:176:24 [INFO] [stdout] | [INFO] [stdout] 176 | if !(age < n) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `(age >= n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hiring_manager/plugin.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | if !(age >= n) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(age < n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 13 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | | inv.items.push(item); [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 12 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 13 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 14 | inv.items.push(item); [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / if let Ok(mut inv) = q_inv.get_mut(container) { [INFO] [stdout] 22 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | | inv.items.swap_remove(i); [INFO] [stdout] 24 | | return true; [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Ok(mut inv) = q_inv.get_mut(container) [INFO] [stdout] 22 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 23 | inv.items.swap_remove(i); [INFO] [stdout] 24 | return true; [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / if let Some(src) = from { [INFO] [stdout] 34 | | if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if let Some(src) = from [INFO] [stdout] 34 ~ && let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 | } [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / if let Ok(mut inv) = q_inv.get_mut(src) { [INFO] [stdout] 35 | | if let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | | inv.items.swap_remove(i); [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 34 ~ if let Ok(mut inv) = q_inv.get_mut(src) [INFO] [stdout] 35 ~ && let Some(i) = inv.items.iter().position(|&e| e == item) { [INFO] [stdout] 36 | inv.items.swap_remove(i); [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/inventory/component.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / if let Ok(mut inv) = q_inv.get_mut(to) { [INFO] [stdout] 42 | | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | | inv.items.push(item); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if let Ok(mut inv) = q_inv.get_mut(to) [INFO] [stdout] 42 ~ && !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] 43 | inv.items.push(item); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | if !inv.items.iter().any(|&e| e == item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/inventory/component.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|inv| inv.items.iter().any(|&e| e == item)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inv.items.contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mortality/system.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 22 | ) -> impl FnMut(ResMut, ResMut, Query<(Entity, &Person)>, EventWriter) [INFO] [stdout] | ______^ [INFO] [stdout] 23 | | + Send [INFO] [stdout] 24 | | + Sync [INFO] [stdout] 25 | | + 'static { [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/records/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod records; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/main.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | app.add_plugins(bevy_time::TimePlugin::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 75 - app.add_plugins(bevy_time::TimePlugin::default()); [INFO] [stdout] 75 + app.add_plugins(bevy_time::TimePlugin); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.31s [INFO] running `Command { std: "docker" "inspect" "86527f23dc05b8ac60cd430b0c3f1186f62454ae57054c791ad3b5812cf7bed1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86527f23dc05b8ac60cd430b0c3f1186f62454ae57054c791ad3b5812cf7bed1", kill_on_drop: false }` [INFO] [stdout] 86527f23dc05b8ac60cd430b0c3f1186f62454ae57054c791ad3b5812cf7bed1