[INFO] cloning repository https://github.com/RubenSomsen/advent-of-code
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RubenSomsen/advent-of-code" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRubenSomsen%2Fadvent-of-code", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRubenSomsen%2Fadvent-of-code'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 497d06cb1537e112db8a2ae0f8610d3ee1fb2e66
[INFO] linting RubenSomsen/advent-of-code against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRubenSomsen%2Fadvent-of-code" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/RubenSomsen/advent-of-code
[INFO] finished tweaking git repo https://github.com/RubenSomsen/advent-of-code
[INFO] tweaked toml for git repo https://github.com/RubenSomsen/advent-of-code written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/RubenSomsen/advent-of-code on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/RubenSomsen/advent-of-code already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 0b392e11c88ee7b4fc52c4df8537441dfdbd74c14a74520f0fb0f3d10e187327
[INFO] running `Command { std: "docker" "start" "-a" "0b392e11c88ee7b4fc52c4df8537441dfdbd74c14a74520f0fb0f3d10e187327", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "0b392e11c88ee7b4fc52c4df8537441dfdbd74c14a74520f0fb0f3d10e187327", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0b392e11c88ee7b4fc52c4df8537441dfdbd74c14a74520f0fb0f3d10e187327", kill_on_drop: false }`
[INFO] [stdout] 0b392e11c88ee7b4fc52c4df8537441dfdbd74c14a74520f0fb0f3d10e187327
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 96130fb49434f6bd96df7938e2db949766d52a2033ca936bb03b4720a3194690
[INFO] running `Command { std: "docker" "start" "-a" "96130fb49434f6bd96df7938e2db949766d52a2033ca936bb03b4720a3194690", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.112
[INFO] [stderr]     Checking getrandom v0.2.4
[INFO] [stderr]     Checking rand_core v0.6.3
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.4
[INFO] [stderr]     Checking practice v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: method `print` is never used
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:185:8
[INFO] [stdout]     |
[INFO] [stdout] 157 | impl Pair {
[INFO] [stdout]     | --------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 185 |     fn print(&self, is_first: bool) { // debug tool
[INFO] [stdout]     |        ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.49s
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:25:5
[INFO] [stdout]    |
[INFO] [stdout] 25 |     return pair.score()
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 25 -     return pair.score()
[INFO] [stdout] 25 +     pair.score()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:21:11
[INFO] [stdout]    |
[INFO] [stdout] 21 |     while pair_vector.len() != 0 {
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pair_vector.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 |     return largest
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -     return largest
[INFO] [stdout] 41 +     largest
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:28:26
[INFO] [stdout]    |
[INFO] [stdout] 28 | fn answer_b(pair_vector: &Vec<Pair>) -> usize {
[INFO] [stdout]    |                          ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 28 - fn answer_b(pair_vector: &Vec<Pair>) -> usize {
[INFO] [stdout] 28 + fn answer_b(pair_vector: &[Pair]) -> usize {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `e` after checking its variant with `is_none`
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:48:61
[INFO] [stdout]    |
[INFO] [stdout] 48 |             if e.is_none() { break } else { propagate(pair, e.unwrap(), &mut 0); }
[INFO] [stdout]    |             --------------                                  ^^^^^^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: try: `if let Some(<item>) = e`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:73:16
[INFO] [stdout]    |
[INFO] [stdout] 73 |             if !e.is_none() { return e }
[INFO] [stdout]    |                ^^^^^^^^^^^^ help: try: `e.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:76:5
[INFO] [stdout]    |
[INFO] [stdout] 76 |     return None
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 76 -     return None
[INFO] [stdout] 76 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:93:5
[INFO] [stdout]    |
[INFO] [stdout] 93 |     return false
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 93 -     return false
[INFO] [stdout] 93 +     false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:111:5
[INFO] [stdout]     |
[INFO] [stdout] 111 |     return false
[INFO] [stdout]     |     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 111 -     return false
[INFO] [stdout] 111 +     false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: creating a new box
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:102:17
[INFO] [stdout]     |
[INFO] [stdout] 102 |                 *p_ab = Box::new(Some(Pair::split(*v_ab)));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `**p_ab = Some(Pair::split(*v_ab))`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this creates a needless allocation
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_box
[INFO] [stdout]     = note: `#[warn(clippy::replace_box)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     return pair_vector
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -     return pair_vector
[INFO] [stdout] 123 +     pair_vector
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: creating a new box
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:134:13
[INFO] [stdout]     |
[INFO] [stdout] 134 |             *pair_ab = Box::new(Some(parse_string(string, index)));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `**pair_ab = Some(parse_string(string, index))`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this creates a needless allocation
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_box
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:159:9
[INFO] [stdout]     |
[INFO] [stdout] 159 |         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 159 -         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout] 159 +         Pair { val_a: 0, val_b: 0, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:163:9
[INFO] [stdout]     |
[INFO] [stdout] 163 |         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(Some(pair_a)), pair_b: Box::new(Some(pair_b)) }
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 163 -         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(Some(pair_a)), pair_b: Box::new(Some(pair_b)) }
[INFO] [stdout] 163 +         Pair { val_a: 0, val_b: 0, pair_a: Box::new(Some(pair_a)), pair_b: Box::new(Some(pair_b)) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:167:9
[INFO] [stdout]     |
[INFO] [stdout] 167 |         return Pair { val_a: val/2, val_b: val/2 + val%2, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 167 -         return Pair { val_a: val/2, val_b: val/2 + val%2, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout] 167 +         Pair { val_a: val/2, val_b: val/2 + val%2, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:182:9
[INFO] [stdout]     |
[INFO] [stdout] 182 |         return score
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 182 -         return score
[INFO] [stdout] 182 +         score
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `print` is never used
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:185:8
[INFO] [stdout]     |
[INFO] [stdout] 157 | impl Pair {
[INFO] [stdout]     | --------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 185 |     fn print(&self, is_first: bool) { // debug tool
[INFO] [stdout]     |        ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:25:5
[INFO] [stdout]    |
[INFO] [stdout] 25 |     return pair.score()
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 25 -     return pair.score()
[INFO] [stdout] 25 +     pair.score()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:21:11
[INFO] [stdout]    |
[INFO] [stdout] 21 |     while pair_vector.len() != 0 {
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pair_vector.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 |     return largest
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -     return largest
[INFO] [stdout] 41 +     largest
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:28:26
[INFO] [stdout]    |
[INFO] [stdout] 28 | fn answer_b(pair_vector: &Vec<Pair>) -> usize {
[INFO] [stdout]    |                          ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 28 - fn answer_b(pair_vector: &Vec<Pair>) -> usize {
[INFO] [stdout] 28 + fn answer_b(pair_vector: &[Pair]) -> usize {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `e` after checking its variant with `is_none`
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:48:61
[INFO] [stdout]    |
[INFO] [stdout] 48 |             if e.is_none() { break } else { propagate(pair, e.unwrap(), &mut 0); }
[INFO] [stdout]    |             --------------                                  ^^^^^^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: try: `if let Some(<item>) = e`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:73:16
[INFO] [stdout]    |
[INFO] [stdout] 73 |             if !e.is_none() { return e }
[INFO] [stdout]    |                ^^^^^^^^^^^^ help: try: `e.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:76:5
[INFO] [stdout]    |
[INFO] [stdout] 76 |     return None
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 76 -     return None
[INFO] [stdout] 76 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/./puzzles/a21_18.rs:93:5
[INFO] [stdout]    |
[INFO] [stdout] 93 |     return false
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 93 -     return false
[INFO] [stdout] 93 +     false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:111:5
[INFO] [stdout]     |
[INFO] [stdout] 111 |     return false
[INFO] [stdout]     |     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 111 -     return false
[INFO] [stdout] 111 +     false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: creating a new box
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:102:17
[INFO] [stdout]     |
[INFO] [stdout] 102 |                 *p_ab = Box::new(Some(Pair::split(*v_ab)));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `**p_ab = Some(Pair::split(*v_ab))`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this creates a needless allocation
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_box
[INFO] [stdout]     = note: `#[warn(clippy::replace_box)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     return pair_vector
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -     return pair_vector
[INFO] [stdout] 123 +     pair_vector
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: creating a new box
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:134:13
[INFO] [stdout]     |
[INFO] [stdout] 134 |             *pair_ab = Box::new(Some(parse_string(string, index)));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `**pair_ab = Some(parse_string(string, index))`
[INFO] [stdout]     |
[INFO] [stdout]     = note: this creates a needless allocation
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_box
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:159:9
[INFO] [stdout]     |
[INFO] [stdout] 159 |         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 159 -         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout] 159 +         Pair { val_a: 0, val_b: 0, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:163:9
[INFO] [stdout]     |
[INFO] [stdout] 163 |         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(Some(pair_a)), pair_b: Box::new(Some(pair_b)) }
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 163 -         return Pair { val_a: 0, val_b: 0, pair_a: Box::new(Some(pair_a)), pair_b: Box::new(Some(pair_b)) }
[INFO] [stdout] 163 +         Pair { val_a: 0, val_b: 0, pair_a: Box::new(Some(pair_a)), pair_b: Box::new(Some(pair_b)) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:167:9
[INFO] [stdout]     |
[INFO] [stdout] 167 |         return Pair { val_a: val/2, val_b: val/2 + val%2, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 167 -         return Pair { val_a: val/2, val_b: val/2 + val%2, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout] 167 +         Pair { val_a: val/2, val_b: val/2 + val%2, pair_a: Box::new(None), pair_b: Box::new(None) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/./puzzles/a21_18.rs:182:9
[INFO] [stdout]     |
[INFO] [stdout] 182 |         return score
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 182 -         return score
[INFO] [stdout] 182 +         score
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "96130fb49434f6bd96df7938e2db949766d52a2033ca936bb03b4720a3194690", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "96130fb49434f6bd96df7938e2db949766d52a2033ca936bb03b4720a3194690", kill_on_drop: false }`
[INFO] [stdout] 96130fb49434f6bd96df7938e2db949766d52a2033ca936bb03b4720a3194690