[INFO] cloning repository https://github.com/RoootTheFox/shuc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RoootTheFox/shuc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRoootTheFox%2Fshuc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRoootTheFox%2Fshuc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9ac73b26b0541401dec2d7637b2d97905bd4c8b8 [INFO] linting RoootTheFox/shuc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRoootTheFox%2Fshuc" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RoootTheFox/shuc [INFO] finished tweaking git repo https://github.com/RoootTheFox/shuc [INFO] tweaked toml for git repo https://github.com/RoootTheFox/shuc written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RoootTheFox/shuc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RoootTheFox/shuc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b635374ea697303935060d222ec86d67e90cd287537b8e0f223abc01fd81e915 [INFO] running `Command { std: "docker" "start" "-a" "b635374ea697303935060d222ec86d67e90cd287537b8e0f223abc01fd81e915", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b635374ea697303935060d222ec86d67e90cd287537b8e0f223abc01fd81e915", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b635374ea697303935060d222ec86d67e90cd287537b8e0f223abc01fd81e915", kill_on_drop: false }` [INFO] [stdout] b635374ea697303935060d222ec86d67e90cd287537b8e0f223abc01fd81e915 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 931f8fd2956edcc32c96adb52c919ec25f38303289fa9101a21db5566ebd8fc5 [INFO] running `Command { std: "docker" "start" "-a" "931f8fd2956edcc32c96adb52c919ec25f38303289fa9101a21db5566ebd8fc5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.167 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking shuc v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `who.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `who` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:36:61 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `who.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `who` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:36:61 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 36 - let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] 36 + println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 36 - let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] 36 + println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | Err(_) => std::io::stdin() [INFO] [stdout] | ___________________^ [INFO] [stdout] 100 | | .bytes() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | Err(_) => std::io::stdin() [INFO] [stdout] | ___________________^ [INFO] [stdout] 100 | | .bytes() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.65s [INFO] running `Command { std: "docker" "inspect" "931f8fd2956edcc32c96adb52c919ec25f38303289fa9101a21db5566ebd8fc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "931f8fd2956edcc32c96adb52c919ec25f38303289fa9101a21db5566ebd8fc5", kill_on_drop: false }` [INFO] [stdout] 931f8fd2956edcc32c96adb52c919ec25f38303289fa9101a21db5566ebd8fc5