[INFO] cloning repository https://github.com/Rocketman21/spravochnik [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Rocketman21/spravochnik" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRocketman21%2Fspravochnik", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRocketman21%2Fspravochnik'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2cb7a16405136a237238f8c254be1657a8ef1a86 [INFO] linting Rocketman21/spravochnik against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRocketman21%2Fspravochnik" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Rocketman21/spravochnik [INFO] finished tweaking git repo https://github.com/Rocketman21/spravochnik [INFO] tweaked toml for git repo https://github.com/Rocketman21/spravochnik written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Rocketman21/spravochnik on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Rocketman21/spravochnik already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strum_macros v0.25.1 [INFO] [stderr] Downloaded syn v1.0.78 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4876d3b06545c609e06948964c7a8a030b1a7c50eaaa3e29235c063140eeb395 [INFO] running `Command { std: "docker" "start" "-a" "4876d3b06545c609e06948964c7a8a030b1a7c50eaaa3e29235c063140eeb395", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4876d3b06545c609e06948964c7a8a030b1a7c50eaaa3e29235c063140eeb395", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4876d3b06545c609e06948964c7a8a030b1a7c50eaaa3e29235c063140eeb395", kill_on_drop: false }` [INFO] [stdout] 4876d3b06545c609e06948964c7a8a030b1a7c50eaaa3e29235c063140eeb395 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4827f8ed390a09d5c22f04d86ce7a55970b3d4c79819a7406eb192b3e8ee47b5 [INFO] running `Command { std: "docker" "start" "-a" "4827f8ed390a09d5c22f04d86ce7a55970b3d4c79819a7406eb192b3e8ee47b5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling syn v1.0.78 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Compiling strum_macros v0.25.1 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Compiling structopt-derive v0.4.16 [INFO] [stderr] Checking structopt v0.3.23 [INFO] [stderr] Checking spravochnik v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/rename.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 35 | .expect(&format!("Не могу изменить имя файла, {:?}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Не могу изменить имя файла, {:?}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/rename.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | let new_filename = path [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 32 | | .file_name() [INFO] [stdout] 33 | | .and_then(|name| name.to_str()) [INFO] [stdout] 34 | | .and_then(|name| Some(name.replace(&from, &to))) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ let new_filename = path [INFO] [stdout] 32 + .file_name() [INFO] [stdout] 33 + .and_then(|name| name.to_str()).map(|name| name.replace(&from, &to)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/rename.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 35 | .expect(&format!("Не могу изменить имя файла, {:?}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("Не могу изменить имя файла, {:?}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | if self.contains(&naming.case(case)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `naming.case(case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/rename.rs:31:40 [INFO] [stdout] | [INFO] [stdout] 31 | let new_filename = path [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 32 | | .file_name() [INFO] [stdout] 33 | | .and_then(|name| name.to_str()) [INFO] [stdout] 34 | | .and_then(|name| Some(name.replace(&from, &to))) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ let new_filename = path [INFO] [stdout] 32 + .file_name() [INFO] [stdout] 33 + .and_then(|name| name.to_str()).map(|name| name.replace(&from, &to)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | for capture in Regex::new(r"[\w\-]+").unwrap().find_iter(self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | for case in NamingCase::iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:108:54 [INFO] [stdout] | [INFO] [stdout] 108 | if capture.as_str().contains(&naming.case(case)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `naming.case(case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/main.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 112 | ... return capture [INFO] [stdout] | ______________________________^ [INFO] [stdout] 113 | | ... .as_str() [INFO] [stdout] 114 | | ... .chars() [INFO] [stdout] 115 | | ... .next() [INFO] [stdout] ... | [INFO] [stdout] 121 | | ... Some(NamingCase::SingularUpperCamel) [INFO] [stdout] 122 | | ... }) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 116 ~ .map(|char| { [INFO] [stdout] 117 | if char.is_lowercase() { [INFO] [stdout] 118 ~ return NamingCase::SingularLowerCamel; [INFO] [stdout] 119 | } [INFO] [stdout] 120 | [INFO] [stdout] 121 ~ NamingCase::SingularUpperCamel [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:138:22 [INFO] [stdout] | [INFO] [stdout] 138 | self.replace(&from.case(original_case), &to.case(original_case)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `from.case(original_case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | self.replace(&from.case(original_case), &to.case(original_case)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `to.case(original_case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | if self.contains(&naming.case(case)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `naming.case(case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | for capture in Regex::new(r"[\w\-]+").unwrap().find_iter(self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | for case in NamingCase::iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:108:54 [INFO] [stdout] | [INFO] [stdout] 108 | if capture.as_str().contains(&naming.case(case)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `naming.case(case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/main.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 112 | ... return capture [INFO] [stdout] | ______________________________^ [INFO] [stdout] 113 | | ... .as_str() [INFO] [stdout] 114 | | ... .chars() [INFO] [stdout] 115 | | ... .next() [INFO] [stdout] ... | [INFO] [stdout] 121 | | ... Some(NamingCase::SingularUpperCamel) [INFO] [stdout] 122 | | ... }) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 116 ~ .map(|char| { [INFO] [stdout] 117 | if char.is_lowercase() { [INFO] [stdout] 118 ~ return NamingCase::SingularLowerCamel; [INFO] [stdout] 119 | } [INFO] [stdout] 120 | [INFO] [stdout] 121 ~ NamingCase::SingularUpperCamel [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:138:22 [INFO] [stdout] | [INFO] [stdout] 138 | self.replace(&from.case(original_case), &to.case(original_case)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `from.case(original_case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | self.replace(&from.case(original_case), &to.case(original_case)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `to.case(original_case)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:197:16 [INFO] [stdout] | [INFO] [stdout] 197 | if !to_lower || (to_lower && index != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 197 - if !to_lower || (to_lower && index != 0) { [INFO] [stdout] 197 + if !(to_lower && index == 0) { [INFO] [stdout] | [INFO] [stdout] 197 - if !to_lower || (to_lower && index != 0) { [INFO] [stdout] 197 + if !to_lower || index != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:197:16 [INFO] [stdout] | [INFO] [stdout] 197 | if !to_lower || (to_lower && index != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 197 - if !to_lower || (to_lower && index != 0) { [INFO] [stdout] 197 + if !(to_lower && index == 0) { [INFO] [stdout] | [INFO] [stdout] 197 - if !to_lower || (to_lower && index != 0) { [INFO] [stdout] 197 + if !to_lower || index != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.64s [INFO] running `Command { std: "docker" "inspect" "4827f8ed390a09d5c22f04d86ce7a55970b3d4c79819a7406eb192b3e8ee47b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4827f8ed390a09d5c22f04d86ce7a55970b3d4c79819a7406eb192b3e8ee47b5", kill_on_drop: false }` [INFO] [stdout] 4827f8ed390a09d5c22f04d86ce7a55970b3d4c79819a7406eb192b3e8ee47b5