[INFO] cloning repository https://github.com/RocketRace/F-UTF-8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RocketRace/F-UTF-8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRocketRace%2FF-UTF-8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRocketRace%2FF-UTF-8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3c394240703bcb86a3440c3edc4d4dfc2e503de8 [INFO] linting RocketRace/F-UTF-8 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRocketRace%2FF-UTF-8" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RocketRace/F-UTF-8 [INFO] finished tweaking git repo https://github.com/RocketRace/F-UTF-8 [INFO] tweaked toml for git repo https://github.com/RocketRace/F-UTF-8 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RocketRace/F-UTF-8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RocketRace/F-UTF-8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2eb754c3f81c2af58aa6bd7aae030db83009979b38e75e53371cdd603de6aed [INFO] running `Command { std: "docker" "start" "-a" "b2eb754c3f81c2af58aa6bd7aae030db83009979b38e75e53371cdd603de6aed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2eb754c3f81c2af58aa6bd7aae030db83009979b38e75e53371cdd603de6aed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2eb754c3f81c2af58aa6bd7aae030db83009979b38e75e53371cdd603de6aed", kill_on_drop: false }` [INFO] [stdout] b2eb754c3f81c2af58aa6bd7aae030db83009979b38e75e53371cdd603de6aed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 055b0d550ee669953a67e54cc7ea8fc2b6cb58a5b909f3aee542d9a8513edf41 [INFO] running `Command { std: "docker" "start" "-a" "055b0d550ee669953a67e54cc7ea8fc2b6cb58a5b909f3aee542d9a8513edf41", kill_on_drop: false }` [INFO] [stderr] Checking f-utf-8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if chunk[0] != 0b11111111 [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | || chunk[1] != 0b10000000 [INFO] [stdout] 29 | | || chunk[2] != 0b10000000 [INFO] [stdout] 30 | | || chunk[3] != 0b10000000 [INFO] [stdout] ... | [INFO] [stdout] 33 | | || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 34 | | || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 34 - || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if !(chunk[0] == 0b11111111 && chunk[1] == 0b10000000 && chunk[2] == 0b10000000 && chunk[3] == 0b10000000 && chunk[4] & 0b11110000 == 0b10000000 && chunk[5] & 0b11000000 == 0b10000000 && chunk[6] & 0b11000000 == 0b10000000) [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 34 - || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if chunk[0] != 0b11111111 || chunk[1] != 0b10000000 || chunk[2] != 0b10000000 || chunk[3] != 0b10000000 || chunk[4] & 0b11110000 != 0b10000000 || chunk[5] & 0b11000000 != 0b10000000 || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if chunk[0] != 0b11111111 [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | || chunk[1] != 0b10000000 [INFO] [stdout] 29 | | || chunk[2] != 0b10000000 [INFO] [stdout] 30 | | || chunk[3] != 0b10000000 [INFO] [stdout] 31 | | || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 | | || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 | | || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if !(chunk[0] == 0b11111111 && chunk[1] == 0b10000000 && chunk[2] == 0b10000000 && chunk[3] == 0b10000000 && chunk[4] & 0b11110000 == 0b10000000 && chunk[5] & 0b11000000 == 0b10000000) [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if chunk[0] != 0b11111111 || chunk[1] != 0b10000000 || chunk[2] != 0b10000000 || chunk[3] != 0b10000000 || chunk[4] & 0b11110000 != 0b10000000 || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | while let Some(chunk) = it.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for chunk in it.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | if 0xd800 <= bits && bits <= 0xdfff { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xd800..=0xdfff).contains(&bits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | if it.remainder().len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!it.remainder().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if chunk[0] != 0b11111111 [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | || chunk[1] != 0b10000000 [INFO] [stdout] 29 | | || chunk[2] != 0b10000000 [INFO] [stdout] 30 | | || chunk[3] != 0b10000000 [INFO] [stdout] ... | [INFO] [stdout] 33 | | || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 34 | | || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 34 - || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if !(chunk[0] == 0b11111111 && chunk[1] == 0b10000000 && chunk[2] == 0b10000000 && chunk[3] == 0b10000000 && chunk[4] & 0b11110000 == 0b10000000 && chunk[5] & 0b11000000 == 0b10000000 && chunk[6] & 0b11000000 == 0b10000000) [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 34 - || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if chunk[0] != 0b11111111 || chunk[1] != 0b10000000 || chunk[2] != 0b10000000 || chunk[3] != 0b10000000 || chunk[4] & 0b11110000 != 0b10000000 || chunk[5] & 0b11000000 != 0b10000000 || chunk[6] & 0b11000000 != 0b10000000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 27 | if chunk[0] != 0b11111111 [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | || chunk[1] != 0b10000000 [INFO] [stdout] 29 | | || chunk[2] != 0b10000000 [INFO] [stdout] 30 | | || chunk[3] != 0b10000000 [INFO] [stdout] 31 | | || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 | | || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 | | || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if !(chunk[0] == 0b11111111 && chunk[1] == 0b10000000 && chunk[2] == 0b10000000 && chunk[3] == 0b10000000 && chunk[4] & 0b11110000 == 0b10000000 && chunk[5] & 0b11000000 == 0b10000000) [INFO] [stdout] | [INFO] [stdout] 27 - if chunk[0] != 0b11111111 [INFO] [stdout] 28 - || chunk[1] != 0b10000000 [INFO] [stdout] 29 - || chunk[2] != 0b10000000 [INFO] [stdout] 30 - || chunk[3] != 0b10000000 [INFO] [stdout] 31 - || chunk[4] & 0b11110000 != 0b10000000 [INFO] [stdout] 32 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 33 - || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] 27 + if chunk[0] != 0b11111111 || chunk[1] != 0b10000000 || chunk[2] != 0b10000000 || chunk[3] != 0b10000000 || chunk[4] & 0b11110000 != 0b10000000 || chunk[5] & 0b11000000 != 0b10000000 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | while let Some(chunk) = it.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for chunk in it.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | if 0xd800 <= bits && bits <= 0xdfff { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0xd800..=0xdfff).contains(&bits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | if it.remainder().len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!it.remainder().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] running `Command { std: "docker" "inspect" "055b0d550ee669953a67e54cc7ea8fc2b6cb58a5b909f3aee542d9a8513edf41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "055b0d550ee669953a67e54cc7ea8fc2b6cb58a5b909f3aee542d9a8513edf41", kill_on_drop: false }` [INFO] [stdout] 055b0d550ee669953a67e54cc7ea8fc2b6cb58a5b909f3aee542d9a8513edf41