[INFO] cloning repository https://github.com/RishRishTheFish/full_test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RishRishTheFish/full_test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRishRishTheFish%2Ffull_test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRishRishTheFish%2Ffull_test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 14c65b08fb5b5f65992c13670a6b23baa8cdceef [INFO] linting RishRishTheFish/full_test against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRishRishTheFish%2Ffull_test" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RishRishTheFish/full_test [INFO] finished tweaking git repo https://github.com/RishRishTheFish/full_test [INFO] tweaked toml for git repo https://github.com/RishRishTheFish/full_test written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RishRishTheFish/full_test on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RishRishTheFish/full_test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d9bf3adb0673daf4a66172c6cec979392e86c10e19552a1f5385244adc077a1 [INFO] running `Command { std: "docker" "start" "-a" "1d9bf3adb0673daf4a66172c6cec979392e86c10e19552a1f5385244adc077a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d9bf3adb0673daf4a66172c6cec979392e86c10e19552a1f5385244adc077a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d9bf3adb0673daf4a66172c6cec979392e86c10e19552a1f5385244adc077a1", kill_on_drop: false }` [INFO] [stdout] 1d9bf3adb0673daf4a66172c6cec979392e86c10e19552a1f5385244adc077a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe65d83d044574e4bbe5c9d042bb98c9022fd16a49c8311ce3c90c0ba49e33d2 [INFO] running `Command { std: "docker" "start" "-a" "fe65d83d044574e4bbe5c9d042bb98c9022fd16a49c8311ce3c90c0ba49e33d2", kill_on_drop: false }` [INFO] [stderr] Checking full_test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `core::borrow` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::borrow; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `os::unix::fs::FileExt` [INFO] [stdout] --> src/main.rs:2:54 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{cell::RefCell, io::{stdin, stdout, Write}, os::unix::fs::FileExt, rc::{Rc, Weak}}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `args` is never read [INFO] [stdout] --> src/main.rs:524:33 [INFO] [stdout] | [INFO] [stdout] 524 | let mut args: Vec = first_command.split(" ").map(|s| s.to_string()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `new_location` is never read [INFO] [stdout] --> src/main.rs:527:36 [INFO] [stdout] | [INFO] [stdout] 527 | let mut new_location: String = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `parent` is never read [INFO] [stdout] --> src/main.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 42 | struct Folder [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | parent: Option>>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Folder` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 201 | if current.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = current` [INFO] [stdout] 202 | Some(Rc::new(RefCell::new(current.unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:237:17 [INFO] [stdout] | [INFO] [stdout] 237 | borrored_buffer.size = borrored_buffer.size + object_type.get_size(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `borrored_buffer.size += object_type.get_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/main.rs:313:25 [INFO] [stdout] | [INFO] [stdout] 313 | / ... borrowed_children.iter().filter( [INFO] [stdout] 314 | | ... |object| !(object.borrow().get_name() == object_type.get_name() && object.borrow().get_type() == object_type.get_type()) [INFO] [stdout] 315 | | ... ).map(|child| child.clone()).collect() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 313 ~ borrowed_children.iter().filter( [INFO] [stdout] 314 + |object| !(object.borrow().get_name() == object_type.get_name() && object.borrow().get_type() == object_type.get_type()) [INFO] [stdout] 315 ~ ).cloned().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:319:46 [INFO] [stdout] | [INFO] [stdout] 319 | let borrowed_children_size = borrowed_children.len().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `borrowed_children.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:394:16 [INFO] [stdout] | [INFO] [stdout] 394 | if !(location_operation == "/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(location_operation != "/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:375:16 [INFO] [stdout] | [INFO] [stdout] 375 | if processed_location_opertation.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `processed_location_opertation.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:427:16 [INFO] [stdout] | [INFO] [stdout] 427 | if processed_location_opertation.split("/").last().unwrap().len() > 0 && processed_location_opertation.split("/").last(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!processed_location_opertation.split("/").last().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:436:16 [INFO] [stdout] | [INFO] [stdout] 436 | if processed_location_opertation.split("/").last().unwrap().len() > 0 && processed_location_opertation.split("/").last(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!processed_location_opertation.split("/").last().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:472:34 [INFO] [stdout] | [INFO] [stdout] 472 | let mut total_size = folder.borrow().size.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `folder.borrow().size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:480:54 [INFO] [stdout] | [INFO] [stdout] 480 | child_folder.borrow_mut().size = new_size.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:481:21 [INFO] [stdout] | [INFO] [stdout] 481 | total_size = total_size + new_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_size += new_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `size` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:563:34 [INFO] [stdout] | [INFO] [stdout] 561 | if size.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = size` [INFO] [stdout] 562 | if size.clone().unwrap() < 4194304 { [INFO] [stdout] 563 | final_size = size.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:512:5 [INFO] [stdout] | [INFO] [stdout] 512 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:575:15 [INFO] [stdout] | [INFO] [stdout] 575 | match args.get(0).unwrap().as_ref() { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `fileSize` should have a snake case name [INFO] [stdout] --> src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | fileSize: usize, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `fileSize` should have a snake case name [INFO] [stdout] --> src/main.rs:29:26 [INFO] [stdout] | [INFO] [stdout] 29 | fn new(name: String, fileSize: usize) -> File { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::borrow; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `os::unix::fs::FileExt` [INFO] [stdout] --> src/main.rs:2:54 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{cell::RefCell, io::{stdin, stdout, Write}, os::unix::fs::FileExt, rc::{Rc, Weak}}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `args` is never read [INFO] [stdout] --> src/main.rs:524:33 [INFO] [stdout] | [INFO] [stdout] 524 | let mut args: Vec = first_command.split(" ").map(|s| s.to_string()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `new_location` is never read [INFO] [stdout] --> src/main.rs:527:36 [INFO] [stdout] | [INFO] [stdout] 527 | let mut new_location: String = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `parent` is never read [INFO] [stdout] --> src/main.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 42 | struct Folder [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 45 | parent: Option>>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Folder` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 201 | if current.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = current` [INFO] [stdout] 202 | Some(Rc::new(RefCell::new(current.unwrap()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:237:17 [INFO] [stdout] | [INFO] [stdout] 237 | borrored_buffer.size = borrored_buffer.size + object_type.get_size(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `borrored_buffer.size += object_type.get_size()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/main.rs:313:25 [INFO] [stdout] | [INFO] [stdout] 313 | / ... borrowed_children.iter().filter( [INFO] [stdout] 314 | | ... |object| !(object.borrow().get_name() == object_type.get_name() && object.borrow().get_type() == object_type.get_type()) [INFO] [stdout] 315 | | ... ).map(|child| child.clone()).collect() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 313 ~ borrowed_children.iter().filter( [INFO] [stdout] 314 + |object| !(object.borrow().get_name() == object_type.get_name() && object.borrow().get_type() == object_type.get_type()) [INFO] [stdout] 315 ~ ).cloned().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:319:46 [INFO] [stdout] | [INFO] [stdout] 319 | let borrowed_children_size = borrowed_children.len().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `borrowed_children.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:394:16 [INFO] [stdout] | [INFO] [stdout] 394 | if !(location_operation == "/") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(location_operation != "/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:375:16 [INFO] [stdout] | [INFO] [stdout] 375 | if processed_location_opertation.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `processed_location_opertation.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:427:16 [INFO] [stdout] | [INFO] [stdout] 427 | if processed_location_opertation.split("/").last().unwrap().len() > 0 && processed_location_opertation.split("/").last(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!processed_location_opertation.split("/").last().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:436:16 [INFO] [stdout] | [INFO] [stdout] 436 | if processed_location_opertation.split("/").last().unwrap().len() > 0 && processed_location_opertation.split("/").last(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!processed_location_opertation.split("/").last().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:472:34 [INFO] [stdout] | [INFO] [stdout] 472 | let mut total_size = folder.borrow().size.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `folder.borrow().size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:480:54 [INFO] [stdout] | [INFO] [stdout] 480 | child_folder.borrow_mut().size = new_size.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:481:21 [INFO] [stdout] | [INFO] [stdout] 481 | total_size = total_size + new_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_size += new_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `size` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:563:34 [INFO] [stdout] | [INFO] [stdout] 561 | if size.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = size` [INFO] [stdout] 562 | if size.clone().unwrap() < 4194304 { [INFO] [stdout] 563 | final_size = size.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:512:5 [INFO] [stdout] | [INFO] [stdout] 512 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/main.rs:575:15 [INFO] [stdout] | [INFO] [stdout] 575 | match args.get(0).unwrap().as_ref() { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `fileSize` should have a snake case name [INFO] [stdout] --> src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | fileSize: usize, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_size` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `fileSize` should have a snake case name [INFO] [stdout] --> src/main.rs:29:26 [INFO] [stdout] | [INFO] [stdout] 29 | fn new(name: String, fileSize: usize) -> File { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `file_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `Command { std: "docker" "inspect" "fe65d83d044574e4bbe5c9d042bb98c9022fd16a49c8311ce3c90c0ba49e33d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe65d83d044574e4bbe5c9d042bb98c9022fd16a49c8311ce3c90c0ba49e33d2", kill_on_drop: false }` [INFO] [stdout] fe65d83d044574e4bbe5c9d042bb98c9022fd16a49c8311ce3c90c0ba49e33d2