[INFO] cloning repository https://github.com/RincewindWizzard/dht-exmple [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RincewindWizzard/dht-exmple" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRincewindWizzard%2Fdht-exmple", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRincewindWizzard%2Fdht-exmple'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2592d45ba0232c79f9f917ccf7022ed1b1a3525f [INFO] linting RincewindWizzard/dht-exmple against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRincewindWizzard%2Fdht-exmple" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RincewindWizzard/dht-exmple [INFO] finished tweaking git repo https://github.com/RincewindWizzard/dht-exmple [INFO] tweaked toml for git repo https://github.com/RincewindWizzard/dht-exmple written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RincewindWizzard/dht-exmple on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RincewindWizzard/dht-exmple already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cc v1.0.81 [INFO] [stderr] Downloaded stderrlog v0.5.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aac119719e5b5ad42d30e7b2e5bce607aa16383385acc6958bfea43f60f3cb9b [INFO] running `Command { std: "docker" "start" "-a" "aac119719e5b5ad42d30e7b2e5bce607aa16383385acc6958bfea43f60f3cb9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aac119719e5b5ad42d30e7b2e5bce607aa16383385acc6958bfea43f60f3cb9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aac119719e5b5ad42d30e7b2e5bce607aa16383385acc6958bfea43f60f3cb9b", kill_on_drop: false }` [INFO] [stdout] aac119719e5b5ad42d30e7b2e5bce607aa16383385acc6958bfea43f60f3cb9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8acf5d56689a1ded20b7e92c84b8032a686c2751b0fafcc762bf78bdfb8aa183 [INFO] running `Command { std: "docker" "start" "-a" "8acf5d56689a1ded20b7e92c84b8032a686c2751b0fafcc762bf78bdfb8aa183", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking stderrlog v0.5.4 [INFO] [stderr] Checking multithreading_sample v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::iter::Map` [INFO] [stdout] --> src/tokenring.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::iter::Map; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::mpsc::channel` [INFO] [stdout] --> src/tokenring.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::mpsc::channel; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::mpsc` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::sync::mpsc; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `Sender` [INFO] [stdout] --> src/main.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::mpsc::{Receiver, Sender}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::debug` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use log::debug; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `threadpool::ThreadPool` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use threadpool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `RouteType` and `Token` [INFO] [stdout] --> src/main.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::tokenring::{Node, RouteType, Token}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::tokenring::Token::TEXT` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::tokenring::Token::TEXT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::Map` [INFO] [stdout] --> src/tokenring.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::iter::Map; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::mpsc::channel` [INFO] [stdout] --> src/tokenring.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::mpsc::channel; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::mpsc` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::sync::mpsc; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Receiver` and `Sender` [INFO] [stdout] --> src/main.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::mpsc::{Receiver, Sender}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::debug` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use log::debug; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `threadpool::ThreadPool` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use threadpool::ThreadPool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `RouteType` and `Token` [INFO] [stdout] --> src/main.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::tokenring::{Node, RouteType, Token}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::tokenring::Token::TEXT` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::tokenring::Token::TEXT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/tokenring.rs:208:29 [INFO] [stdout] | [INFO] [stdout] 208 | Token::PONG(src, dst) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `token` [INFO] [stdout] --> src/tokenring.rs:267:38 [INFO] [stdout] | [INFO] [stdout] 267 | if let Err(SendError(token)) = result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_token` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `route_type` [INFO] [stdout] --> src/tokenring.rs:293:14 [INFO] [stdout] | [INFO] [stdout] 293 | for (route_type, rx) in &self.rx { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_route_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx` [INFO] [stdout] --> src/main.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | let (tx, rx) = node.channel(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `TEXT` and `PING` are never constructed [INFO] [stdout] --> src/tokenring.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum Token { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 19 | TEXT(String), [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | PING(NodeId, NodeId), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_internal` is never used [INFO] [stdout] --> src/tokenring.rs:33:4 [INFO] [stdout] | [INFO] [stdout] 33 | fn is_internal(token: &Token) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `NodeLogik` is never used [INFO] [stdout] --> src/tokenring.rs:55:11 [INFO] [stdout] | [INFO] [stdout] 55 | pub trait NodeLogik { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `ping` is never used [INFO] [stdout] --> src/tokenring.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 72 | impl NodeHandle { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn ping(&self, dst: NodeId) -> Result<(), SendError> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send` is never used [INFO] [stdout] --> src/tokenring.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 116 | impl Node { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 281 | pub fn send(&mut self, token: Token) -> Result<(), anyhow::Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXT` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | TEXT(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INIT` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | INIT(NodeId), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Init` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PING` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | PING(NodeId, NodeId), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PONG` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | PONG(NodeId, NodeId), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pong` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STORE` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | STORE(Key, Value), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Store` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RETRIEVE` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | RETRIEVE(Key), [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Retrieve` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RETRIEVED` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | RETRIEVED(Key, Value), [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Retrieved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHUTDOWN` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | SHUTDOWN, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Shutdown` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXTERNAL` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | EXTERNAL, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `External` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INTERNAL` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | INTERNAL, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Internal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BROADCAST` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | BROADCAST, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Broadcast` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/tokenring.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | / pub fn new() -> NodeHandle { [INFO] [stdout] 118 | | let (external_out_tx, external_out_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] 119 | | let (external_in_tx, external_in_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] 120 | | let mut node = Node { [INFO] [stdout] ... | [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/tokenring.rs:208:29 [INFO] [stdout] | [INFO] [stdout] 208 | Token::PONG(src, dst) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `token` [INFO] [stdout] --> src/tokenring.rs:267:38 [INFO] [stdout] | [INFO] [stdout] 267 | if let Err(SendError(token)) = result { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_token` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tokenring.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | format!("unknown node") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"unknown node".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokenring.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 245 | if !self.id.is_some_and(|id| get_node_in_charge(&key, ring_size) == id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.id.is_none_or(|id| get_node_in_charge(&key, ring_size) != id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/tokenring.rs:153:28 [INFO] [stdout] | [INFO] [stdout] 153 | if let None = self.id { [INFO] [stdout] | -------^^^^---------- help: try: `if self.id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `route_type` [INFO] [stdout] --> src/tokenring.rs:293:14 [INFO] [stdout] | [INFO] [stdout] 293 | for (route_type, rx) in &self.rx { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_route_type` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tx` [INFO] [stdout] --> src/main.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | let (tx, rx) = node.channel(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_tx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `TEXT` and `PING` are never constructed [INFO] [stdout] --> src/tokenring.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum Token { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 19 | TEXT(String), [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | PING(NodeId, NodeId), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_internal` is never used [INFO] [stdout] --> src/tokenring.rs:33:4 [INFO] [stdout] | [INFO] [stdout] 33 | fn is_internal(token: &Token) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `NodeLogik` is never used [INFO] [stdout] --> src/tokenring.rs:55:11 [INFO] [stdout] | [INFO] [stdout] 55 | pub trait NodeLogik { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `ping` is never used [INFO] [stdout] --> src/tokenring.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 72 | impl NodeHandle { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 85 | pub fn ping(&self, dst: NodeId) -> Result<(), SendError> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send` is never used [INFO] [stdout] --> src/tokenring.rs:281:12 [INFO] [stdout] | [INFO] [stdout] 116 | impl Node { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 281 | pub fn send(&mut self, token: Token) -> Result<(), anyhow::Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXT` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | TEXT(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INIT` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | INIT(NodeId), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Init` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PING` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | PING(NodeId, NodeId), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PONG` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | PONG(NodeId, NodeId), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pong` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STORE` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | STORE(Key, Value), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Store` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RETRIEVE` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | RETRIEVE(Key), [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Retrieve` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RETRIEVED` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | RETRIEVED(Key, Value), [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Retrieved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHUTDOWN` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | SHUTDOWN, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Shutdown` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXTERNAL` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | EXTERNAL, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `External` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INTERNAL` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | INTERNAL, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Internal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BROADCAST` contains a capitalized acronym [INFO] [stdout] --> src/tokenring.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | BROADCAST, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Broadcast` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/tokenring.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | / pub fn new() -> NodeHandle { [INFO] [stdout] 118 | | let (external_out_tx, external_out_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] 119 | | let (external_in_tx, external_in_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] 120 | | let mut node = Node { [INFO] [stdout] ... | [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tokenring.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | sel.recv(&rx); [INFO] [stdout] | ^^^ help: change this to: `rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/tokenring.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | format!("unknown node") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"unknown node".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokenring.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 245 | if !self.id.is_some_and(|id| get_node_in_charge(&key, ring_size) == id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.id.is_none_or(|id| get_node_in_charge(&key, ring_size) != id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/tokenring.rs:153:28 [INFO] [stdout] | [INFO] [stdout] 153 | if let None = self.id { [INFO] [stdout] | -------^^^^---------- help: try: `if self.id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tokenring.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | sel.recv(&rx); [INFO] [stdout] | ^^^ help: change this to: `rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.82s [INFO] running `Command { std: "docker" "inspect" "8acf5d56689a1ded20b7e92c84b8032a686c2751b0fafcc762bf78bdfb8aa183", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8acf5d56689a1ded20b7e92c84b8032a686c2751b0fafcc762bf78bdfb8aa183", kill_on_drop: false }` [INFO] [stdout] 8acf5d56689a1ded20b7e92c84b8032a686c2751b0fafcc762bf78bdfb8aa183