[INFO] cloning repository https://github.com/RiderSargent/CLI-invaders [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RiderSargent/CLI-invaders" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRiderSargent%2FCLI-invaders", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRiderSargent%2FCLI-invaders'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cd982bf49c37d75d4e7bedefd9ac70bd980422ca [INFO] linting RiderSargent/CLI-invaders/cd982bf49c37d75d4e7bedefd9ac70bd980422ca against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRiderSargent%2FCLI-invaders" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RiderSargent/CLI-invaders [INFO] finished tweaking git repo https://github.com/RiderSargent/CLI-invaders [INFO] tweaked toml for git repo https://github.com/RiderSargent/CLI-invaders written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RiderSargent/CLI-invaders on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RiderSargent/CLI-invaders already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rusty_audio v1.4.1 [INFO] [stderr] Downloaded rusty_time v0.11.3 [INFO] [stderr] Downloaded signal-hook v0.1.17 [INFO] [stderr] Downloaded crossterm_winapi v0.6.2 [INFO] [stderr] Downloaded crossterm v0.17.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61ab0539cc6af7db4fde7fcc49a6161ca176f19b5d90da1214537674cab142d0 [INFO] running `Command { std: "docker" "start" "-a" "61ab0539cc6af7db4fde7fcc49a6161ca176f19b5d90da1214537674cab142d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61ab0539cc6af7db4fde7fcc49a6161ca176f19b5d90da1214537674cab142d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61ab0539cc6af7db4fde7fcc49a6161ca176f19b5d90da1214537674cab142d0", kill_on_drop: false }` [INFO] [stdout] 61ab0539cc6af7db4fde7fcc49a6161ca176f19b5d90da1214537674cab142d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c7f5c8348362cac19018186cfb466c12343e2bfbb228adf94bec4b76d0e9ba3 [INFO] running `Command { std: "docker" "start" "-a" "8c7f5c8348362cac19018186cfb466c12343e2bfbb228adf94bec4b76d0e9ba3", kill_on_drop: false }` [INFO] [stderr] Checking libc v0.2.147 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking hound v3.5.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking rusty_time v0.11.3 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking symphonia-core v0.5.3 [INFO] [stderr] Checking symphonia-metadata v0.5.3 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.3 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking alsa v0.7.0 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking symphonia v0.5.3 [INFO] [stderr] Checking crossterm v0.17.7 [INFO] [stderr] Checking rodio v0.17.1 [INFO] [stderr] Checking rusty_audio v1.4.1 [INFO] [stderr] Checking invaders v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/frame.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | col.push(" "); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![" ";SIZE]` [INFO] [stdout] = help: or `col.extend(std::iter::repeat_n(" ", SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Player` [INFO] [stdout] --> src/player.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | x: NUM_COLS / 2, [INFO] [stdout] 17 | | y: NUM_ROWS - 1, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for Player { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/frame.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | col.push(" "); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![" ";SIZE]` [INFO] [stdout] = help: or `col.extend(std::iter::repeat_n(" ", SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Player` [INFO] [stdout] --> src/player.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | x: NUM_COLS / 2, [INFO] [stdout] 17 | | y: NUM_ROWS - 1, [INFO] [stdout] 18 | | } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for Player { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / loop { [INFO] [stdout] 37 | | let curr_frame = match render_rx.recv() { [INFO] [stdout] 38 | | Ok(x) => x, [INFO] [stdout] 39 | | Err(_) => break, [INFO] [stdout] ... | [INFO] [stdout] 42 | | last_frame = curr_frame; [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ while let Ok(x) = render_rx.recv() { [INFO] [stdout] 37 + let curr_frame = x; [INFO] [stdout] 38 + .. [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | / loop { [INFO] [stdout] 37 | | let curr_frame = match render_rx.recv() { [INFO] [stdout] 38 | | Ok(x) => x, [INFO] [stdout] 39 | | Err(_) => break, [INFO] [stdout] ... | [INFO] [stdout] 42 | | last_frame = curr_frame; [INFO] [stdout] 43 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ while let Ok(x) = render_rx.recv() { [INFO] [stdout] 37 + let curr_frame = x; [INFO] [stdout] 38 + .. [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.95s [INFO] running `Command { std: "docker" "inspect" "8c7f5c8348362cac19018186cfb466c12343e2bfbb228adf94bec4b76d0e9ba3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c7f5c8348362cac19018186cfb466c12343e2bfbb228adf94bec4b76d0e9ba3", kill_on_drop: false }` [INFO] [stdout] 8c7f5c8348362cac19018186cfb466c12343e2bfbb228adf94bec4b76d0e9ba3