[INFO] cloning repository https://github.com/Rickard-Martensson/rust_raytracer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Rickard-Martensson/rust_raytracer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRickard-Martensson%2Frust_raytracer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRickard-Martensson%2Frust_raytracer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f5c28eb240fb91c226c77845aa1596bb1bfafb05 [INFO] linting Rickard-Martensson/rust_raytracer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRickard-Martensson%2Frust_raytracer" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Rickard-Martensson/rust_raytracer [INFO] finished tweaking git repo https://github.com/Rickard-Martensson/rust_raytracer [INFO] tweaked toml for git repo https://github.com/Rickard-Martensson/rust_raytracer written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Rickard-Martensson/rust_raytracer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Rickard-Martensson/rust_raytracer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded autocfg v0.1.6 [INFO] [stderr] Downloaded num-rational v0.2.2 [INFO] [stderr] Downloaded num-iter v0.1.39 [INFO] [stderr] Downloaded png v0.15.0 [INFO] [stderr] Downloaded bitflags v1.2.0 [INFO] [stderr] Downloaded arrayvec v0.4.11 [INFO] [stderr] Downloaded jpeg-decoder v0.1.16 [INFO] [stderr] Downloaded rayon-core v1.6.0 [INFO] [stderr] Downloaded image v0.22.3 [INFO] [stderr] Downloaded rayon v1.2.0 [INFO] [stderr] Downloaded libc v0.2.62 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95b03d95984cd5946999c330605cfa5c02d5fd05180fbcadaed2f4bc7d585fd2 [INFO] running `Command { std: "docker" "start" "-a" "95b03d95984cd5946999c330605cfa5c02d5fd05180fbcadaed2f4bc7d585fd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95b03d95984cd5946999c330605cfa5c02d5fd05180fbcadaed2f4bc7d585fd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95b03d95984cd5946999c330605cfa5c02d5fd05180fbcadaed2f4bc7d585fd2", kill_on_drop: false }` [INFO] [stdout] 95b03d95984cd5946999c330605cfa5c02d5fd05180fbcadaed2f4bc7d585fd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1886574ebecae6acd405c982916aa4906644a3798c140cbf69bff8b29f54ad2 [INFO] running `Command { std: "docker" "start" "-a" "c1886574ebecae6acd405c982916aa4906644a3798c140cbf69bff8b29f54ad2", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking png v0.15.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking jpeg-decoder v0.1.16 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking image v0.22.3 [INFO] [stderr] Checking RayTracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/intersnect.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | avstand: avstand, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `avstand` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/intersnect.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | object: object, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/intersnect.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | avstand: avstand, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `avstand` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/intersnect.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | object: object, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `ny` is never used [INFO] [stdout] --> src/geometri.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | impl Sphere { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 70 | pub fn ny(center: Point, radius: f64, material: Material) -> Self { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `ny` is never used [INFO] [stdout] --> src/geometri.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 81 | impl Plane { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 82 | pub fn ny(position: Point, normal: Vector3, material: Material) -> Self { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `intensitet` is never read [INFO] [stdout] --> src/geometri.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 87 | pub struct Ljus { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 90 | pub intensitet: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `ny` is never used [INFO] [stdout] --> src/geometri.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 69 | impl Sphere { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 70 | pub fn ny(center: Point, radius: f64, material: Material) -> Self { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `zero` and `normal_vektor` are never used [INFO] [stdout] --> src/vector3.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Vector3 { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 11 | pub fn zero() -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn normal_vektor(&self) -> Vector3 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `ny` is never used [INFO] [stdout] --> src/geometri.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 81 | impl Plane { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 82 | pub fn ny(position: Point, normal: Vector3, material: Material) -> Self { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `intensitet` is never read [INFO] [stdout] --> src/geometri.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 87 | pub struct Ljus { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 90 | pub intensitet: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `zero` and `normal_vektor` are never used [INFO] [stdout] --> src/vector3.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Vector3 { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] 11 | pub fn zero() -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn normal_vektor(&self) -> Vector3 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `luddighet` is never read [INFO] [stdout] --> src/intersnect.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Korsning<'a> { //implementera lifetime senare, för o optimera [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub luddighet: f64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Korsning` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `luddighet` is never read [INFO] [stdout] --> src/intersnect.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Korsning<'a> { //implementera lifetime senare, för o optimera [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 9 | pub luddighet: f64, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Korsning` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/geometri.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return Self { center, radius, material}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Self { center, radius, material}; [INFO] [stdout] 71 + Self { center, radius, material} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/geometri.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return Self {position, normal, material}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Self {position, normal, material}; [INFO] [stdout] 83 + Self {position, normal, material} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | / return Vector3{ [INFO] [stdout] 13 | | x: 0.0, [INFO] [stdout] 14 | | y: 0.0, [INFO] [stdout] 15 | | z: 0.0, [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Vector3{ [INFO] [stdout] 13 + x: 0.0, [INFO] [stdout] 14 + y: 0.0, [INFO] [stdout] 15 + z: 0.0, [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return Vector3 { [INFO] [stdout] 22 | | x: 0.0, [INFO] [stdout] 23 | | y: 1.0, [INFO] [stdout] 24 | | z: 0.0 [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Vector3 { [INFO] [stdout] 22 + x: 0.0, [INFO] [stdout] 23 + y: 1.0, [INFO] [stdout] 24 + z: 0.0 [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/geometri.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return Self { center, radius, material}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Self { center, radius, material}; [INFO] [stdout] 71 + Self { center, radius, material} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/geometri.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return Self {position, normal, material}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Self {position, normal, material}; [INFO] [stdout] 83 + Self {position, normal, material} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | / return Vector3{ [INFO] [stdout] 13 | | x: 0.0, [INFO] [stdout] 14 | | y: 0.0, [INFO] [stdout] 15 | | z: 0.0, [INFO] [stdout] 16 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ Vector3{ [INFO] [stdout] 13 + x: 0.0, [INFO] [stdout] 14 + y: 0.0, [INFO] [stdout] 15 + z: 0.0, [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return Vector3 { [INFO] [stdout] 22 | | x: 0.0, [INFO] [stdout] 23 | | y: 1.0, [INFO] [stdout] 24 | | z: 0.0 [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Vector3 { [INFO] [stdout] 22 + x: 0.0, [INFO] [stdout] 23 + y: 1.0, [INFO] [stdout] 24 + z: 0.0 [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return ( [INFO] [stdout] 30 | | self.x * self.x [INFO] [stdout] 31 | | + self.y * self.y [INFO] [stdout] 32 | | + self.z * self.z [INFO] [stdout] 33 | | ).sqrt(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ ( [INFO] [stdout] 30 + self.x * self.x [INFO] [stdout] 31 + + self.y * self.y [INFO] [stdout] 32 + + self.z * self.z [INFO] [stdout] 33 ~ ).sqrt() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return ( [INFO] [stdout] 30 | | self.x * self.x [INFO] [stdout] 31 | | + self.y * self.y [INFO] [stdout] 32 | | + self.z * self.z [INFO] [stdout] 33 | | ).sqrt(); [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ ( [INFO] [stdout] 30 + self.x * self.x [INFO] [stdout] 31 + + self.y * self.y [INFO] [stdout] 32 + + self.z * self.z [INFO] [stdout] 33 ~ ).sqrt() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / return Vector3{ [INFO] [stdout] 39 | | x: self.x / self.magnitud(), [INFO] [stdout] 40 | | y: self.y / self.magnitud(), [INFO] [stdout] 41 | | z: self.z / self.magnitud(), [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ Vector3{ [INFO] [stdout] 39 + x: self.x / self.magnitud(), [INFO] [stdout] 40 + y: self.y / self.magnitud(), [INFO] [stdout] 41 + z: self.z / self.magnitud(), [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / return Vector3{ [INFO] [stdout] 39 | | x: self.x / self.magnitud(), [INFO] [stdout] 40 | | y: self.y / self.magnitud(), [INFO] [stdout] 41 | | z: self.z / self.magnitud(), [INFO] [stdout] 42 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ Vector3{ [INFO] [stdout] 39 + x: self.x / self.magnitud(), [INFO] [stdout] 40 + y: self.y / self.magnitud(), [INFO] [stdout] 41 + z: self.z / self.magnitud(), [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / return self.x * ny_vektor.x [INFO] [stdout] 51 | | + self.y * ny_vektor.y [INFO] [stdout] 52 | | + self.z * ny_vektor.z [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ self.x * ny_vektor.x [INFO] [stdout] 51 + + self.y * ny_vektor.y [INFO] [stdout] 52 + + self.z * ny_vektor.z [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / return self.x * ny_vektor.x [INFO] [stdout] 51 | | + self.y * ny_vektor.y [INFO] [stdout] 52 | | + self.z * ny_vektor.z [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ self.x * ny_vektor.x [INFO] [stdout] 51 + + self.y * ny_vektor.y [INFO] [stdout] 52 + + self.z * ny_vektor.z [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return Vector3 { [INFO] [stdout] 62 | | x: self.x - point2.x, [INFO] [stdout] 63 | | y: self.y - point2.y, [INFO] [stdout] 64 | | z: self.z - point2.z, [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Vector3 { [INFO] [stdout] 62 + x: self.x - point2.x, [INFO] [stdout] 63 + y: self.y - point2.y, [INFO] [stdout] 64 + z: self.z - point2.z, [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return Vector3 { [INFO] [stdout] 75 | | x: -self.x, [INFO] [stdout] 76 | | y: -self.y, [INFO] [stdout] 77 | | z: -self.z, [INFO] [stdout] 78 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ Vector3 { [INFO] [stdout] 75 + x: -self.x, [INFO] [stdout] 76 + y: -self.y, [INFO] [stdout] 77 + z: -self.z, [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / return Vector3 { [INFO] [stdout] 87 | | x: self.x * skalar, [INFO] [stdout] 88 | | y: self.y * skalar, [INFO] [stdout] 89 | | z: self.z * skalar, [INFO] [stdout] 90 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 ~ Vector3 { [INFO] [stdout] 87 + x: self.x * skalar, [INFO] [stdout] 88 + y: self.y * skalar, [INFO] [stdout] 89 + z: self.z * skalar, [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return Vector3 { [INFO] [stdout] 62 | | x: self.x - point2.x, [INFO] [stdout] 63 | | y: self.y - point2.y, [INFO] [stdout] 64 | | z: self.z - point2.z, [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Vector3 { [INFO] [stdout] 62 + x: self.x - point2.x, [INFO] [stdout] 63 + y: self.y - point2.y, [INFO] [stdout] 64 + z: self.z - point2.z, [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return Vector3 { [INFO] [stdout] 75 | | x: -self.x, [INFO] [stdout] 76 | | y: -self.y, [INFO] [stdout] 77 | | z: -self.z, [INFO] [stdout] 78 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ Vector3 { [INFO] [stdout] 75 + x: -self.x, [INFO] [stdout] 76 + y: -self.y, [INFO] [stdout] 77 + z: -self.z, [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / return Vector3 { [INFO] [stdout] 87 | | x: self.x * skalar, [INFO] [stdout] 88 | | y: self.y * skalar, [INFO] [stdout] 89 | | z: self.z * skalar, [INFO] [stdout] 90 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 ~ Vector3 { [INFO] [stdout] 87 + x: self.x * skalar, [INFO] [stdout] 88 + y: self.y * skalar, [INFO] [stdout] 89 + z: self.z * skalar, [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / return Point { [INFO] [stdout] 99 | | x: self.x + vektor.x, [INFO] [stdout] 100 | | y: self.y + vektor.y, [INFO] [stdout] 101 | | z: self.z + vektor.z, [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ Point { [INFO] [stdout] 99 + x: self.x + vektor.x, [INFO] [stdout] 100 + y: self.y + vektor.y, [INFO] [stdout] 101 + z: self.z + vektor.z, [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Korsning { [INFO] [stdout] 16 | | avstand: avstand, [INFO] [stdout] 17 | | object: object, [INFO] [stdout] 18 | | luddighet: 0.0, [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Korsning { [INFO] [stdout] 16 + avstand: avstand, [INFO] [stdout] 17 + object: object, [INFO] [stdout] 18 + luddighet: 0.0, [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector3.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / return Point { [INFO] [stdout] 99 | | x: self.x + vektor.x, [INFO] [stdout] 100 | | y: self.y + vektor.y, [INFO] [stdout] 101 | | z: self.z + vektor.z, [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ Point { [INFO] [stdout] 99 + x: self.x + vektor.x, [INFO] [stdout] 100 + y: self.y + vektor.y, [INFO] [stdout] 101 + z: self.z + vektor.z, [INFO] [stdout] 102 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return Some(avstand); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Some(avstand); [INFO] [stdout] 64 + Some(avstand) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | / return Korsning { [INFO] [stdout] 16 | | avstand: avstand, [INFO] [stdout] 17 | | object: object, [INFO] [stdout] 18 | | luddighet: 0.0, [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 ~ Korsning { [INFO] [stdout] 16 + avstand: avstand, [INFO] [stdout] 17 + object: object, [INFO] [stdout] 18 + luddighet: 0.0, [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return *traffpunkt - self.center; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return *traffpunkt - self.center; [INFO] [stdout] 69 + *traffpunkt - self.center [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return None; [INFO] [stdout] 84 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return Some(avstand); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Some(avstand); [INFO] [stdout] 64 + Some(avstand) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return *traffpunkt - self.center; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return *traffpunkt - self.center; [INFO] [stdout] 69 + *traffpunkt - self.center [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/intersnect.rs:79:51 [INFO] [stdout] | [INFO] [stdout] 79 | let avstand = ny_vektor.skalarprodukt(&normal) / denom; [INFO] [stdout] | ^^^^^^^ help: change this to: `normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return -self.normal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return -self.normal; [INFO] [stdout] 87 + -self.normal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return self.elements [INFO] [stdout] 20 | | .iter() [INFO] [stdout] 21 | | .filter_map(|elem| elem.option_korsning(ray) [INFO] [stdout] 22 | | .map(|avstand| Korsning::new(avstand, elem)) [INFO] [stdout] 23 | | .filter(|elem| elem.avstand > 1e-6)) [INFO] [stdout] 24 | | .min_by(|i1, i2| i1.avstand.partial_cmp(&i2.avstand) [INFO] [stdout] 25 | | .unwrap()); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ self.elements [INFO] [stdout] 20 + .iter() [INFO] [stdout] 21 + .filter_map(|elem| elem.option_korsning(ray) [INFO] [stdout] 22 + .map(|avstand| Korsning::new(avstand, elem)) [INFO] [stdout] 23 + .filter(|elem| elem.avstand > 1e-6)) [INFO] [stdout] 24 + .min_by(|i1, i2| i1.avstand.partial_cmp(&i2.avstand) [INFO] [stdout] 25 ~ .unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / return Rgba::from_channels( [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | ((color.red as f64 * ljusfarg.red as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 42 | | ((color.green as f64 * ljusfarg.green as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 43 | | ((color.blue as f64 * ljusfarg.blue as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 44 | | ((color.alpha as f64 * ljusfarg.alpha as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 45 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ Rgba::from_channels( [INFO] [stdout] 40 + [INFO] [stdout] 41 + ((color.red as f64 * ljusfarg.red as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 42 + ((color.green as f64 * ljusfarg.green as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 43 + ((color.blue as f64 * ljusfarg.blue as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 44 + ((color.alpha as f64 * ljusfarg.alpha as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 45 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scene.rs:67:46 [INFO] [stdout] | [INFO] [stdout] 67 | let traffpunkt_skuggad = !scene.trace(&skugg_ray).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `scene.trace(&skugg_ray).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return image; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return image; [INFO] [stdout] 102 + image [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return None; [INFO] [stdout] 84 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/intersnect.rs:79:51 [INFO] [stdout] | [INFO] [stdout] 79 | let avstand = ny_vektor.skalarprodukt(&normal) / denom; [INFO] [stdout] | ^^^^^^^ help: change this to: `normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/intersnect.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return -self.normal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return -self.normal; [INFO] [stdout] 87 + -self.normal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | / return self.elements [INFO] [stdout] 20 | | .iter() [INFO] [stdout] 21 | | .filter_map(|elem| elem.option_korsning(ray) [INFO] [stdout] 22 | | .map(|avstand| Korsning::new(avstand, elem)) [INFO] [stdout] 23 | | .filter(|elem| elem.avstand > 1e-6)) [INFO] [stdout] 24 | | .min_by(|i1, i2| i1.avstand.partial_cmp(&i2.avstand) [INFO] [stdout] 25 | | .unwrap()); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ self.elements [INFO] [stdout] 20 + .iter() [INFO] [stdout] 21 + .filter_map(|elem| elem.option_korsning(ray) [INFO] [stdout] 22 + .map(|avstand| Korsning::new(avstand, elem)) [INFO] [stdout] 23 + .filter(|elem| elem.avstand > 1e-6)) [INFO] [stdout] 24 + .min_by(|i1, i2| i1.avstand.partial_cmp(&i2.avstand) [INFO] [stdout] 25 ~ .unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / return Rgba::from_channels( [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | ((color.red as f64 * ljusfarg.red as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 42 | | ((color.green as f64 * ljusfarg.green as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 43 | | ((color.blue as f64 * ljusfarg.blue as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 44 | | ((color.alpha as f64 * ljusfarg.alpha as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 45 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ Rgba::from_channels( [INFO] [stdout] 40 + [INFO] [stdout] 41 + ((color.red as f64 * ljusfarg.red as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 42 + ((color.green as f64 * ljusfarg.green as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 43 + ((color.blue as f64 * ljusfarg.blue as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 44 + ((color.alpha as f64 * ljusfarg.alpha as f64).sqrt() * styrka * reflekt) as u8, [INFO] [stdout] 45 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/scene.rs:67:46 [INFO] [stdout] | [INFO] [stdout] 67 | let traffpunkt_skuggad = !scene.trace(&skugg_ray).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `scene.trace(&skugg_ray).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scene.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return image; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return image; [INFO] [stdout] 102 + image [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/scene.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn trace(&self, ray: &Ray) -> Option { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | pub fn trace(&self, ray: &Ray) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/scene.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn trace(&self, ray: &Ray) -> Option { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | pub fn trace(&self, ray: &Ray) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.02s [INFO] running `Command { std: "docker" "inspect" "c1886574ebecae6acd405c982916aa4906644a3798c140cbf69bff8b29f54ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1886574ebecae6acd405c982916aa4906644a3798c140cbf69bff8b29f54ad2", kill_on_drop: false }` [INFO] [stdout] c1886574ebecae6acd405c982916aa4906644a3798c140cbf69bff8b29f54ad2