[INFO] cloning repository https://github.com/Revertron/Yggdrasil-ng
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Revertron/Yggdrasil-ng" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRevertron%2FYggdrasil-ng", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRevertron%2FYggdrasil-ng'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 8dc2c3abc45024a9fbab8ff3ae2739c16660a812
[INFO] linting Revertron/Yggdrasil-ng against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRevertron%2FYggdrasil-ng" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Revertron/Yggdrasil-ng
[INFO] finished tweaking git repo https://github.com/Revertron/Yggdrasil-ng
[INFO] tweaked toml for git repo https://github.com/Revertron/Yggdrasil-ng written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Revertron/Yggdrasil-ng on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Revertron/Yggdrasil-ng already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded alloca v0.4.0
[INFO] [stderr]   Downloaded murmur3 v0.5.2
[INFO] [stderr]   Downloaded netlink-packet-utils v0.5.2
[INFO] [stderr]   Downloaded page_size v0.6.0
[INFO] [stderr]   Downloaded crypto_box v0.9.1
[INFO] [stderr]   Downloaded blake2 v0.10.6
[INFO] [stderr]   Downloaded base64ct v1.8.3
[INFO] [stderr]   Downloaded comfy-table v7.2.2
[INFO] [stderr]   Downloaded asn1-rs v0.7.1
[INFO] [stderr]   Downloaded ed25519-dalek v2.2.0
[INFO] [stderr]   Downloaded criterion v0.8.2
[INFO] [stderr]   Downloaded crossterm v0.29.0
[INFO] [stderr]   Downloaded plotters v0.3.7
[INFO] [stderr]   Downloaded tokio-util v0.7.18
[INFO] [stderr]   Downloaded netlink-packet-route v0.24.0
[INFO] [stderr]   Downloaded route_manager v0.2.11
[INFO] [stderr]   Downloaded tun-rs v2.8.2
[INFO] [stderr]   Downloaded netlink-packet-route v0.28.0
[INFO] [stderr]   Downloaded x509-parser v0.18.1
[INFO] [stderr]   Downloaded half v2.7.1
[INFO] [stderr]   Downloaded der-parser v10.0.0
[INFO] [stderr]   Downloaded rcgen v0.14.7
[INFO] [stderr]   Downloaded nix v0.31.2
[INFO] [stderr]   Downloaded libloading v0.9.0
[INFO] [stderr]   Downloaded getifaddrs v0.6.0
[INFO] [stderr]   Downloaded getopts v0.2.24
[INFO] [stderr]   Downloaded criterion-plot v0.8.2
[INFO] [stderr]   Downloaded oorandom v11.1.5
[INFO] [stderr]   Downloaded oid-registry v0.8.1
[INFO] [stderr]   Downloaded ipnet v2.12.0
[INFO] [stderr]   Downloaded netlink-packet-core v0.7.0
[INFO] [stderr]   Downloaded winreg v0.55.0
[INFO] [stderr]   Downloaded ed25519 v2.2.3
[INFO] [stderr]   Downloaded netconfig-rs v0.1.5
[INFO] [stderr]   Downloaded plotters-backend v0.3.7
[INFO] [stderr]   Downloaded plotters-svg v0.3.7
[INFO] [stderr]   Downloaded crypto_secretbox v0.1.1
[INFO] [stderr]   Downloaded asn1-rs-derive v0.6.0
[INFO] [stderr]   Downloaded c2rust-bitfields-derive v0.22.1
[INFO] [stderr]   Downloaded c2rust-bitfields v0.22.1
[INFO] [stderr]   Downloaded flume v0.12.0
[INFO] [stderr]   Downloaded netlink-packet-core v0.8.1
[INFO] [stderr]   Downloaded netlink-sys v0.8.8
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] fac81fd70caeedb6e68821efd712b3c2af6ad3e6824ffdf05f36d37506bd0705
[INFO] running `Command { std: "docker" "start" "-a" "fac81fd70caeedb6e68821efd712b3c2af6ad3e6824ffdf05f36d37506bd0705", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "fac81fd70caeedb6e68821efd712b3c2af6ad3e6824ffdf05f36d37506bd0705", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "fac81fd70caeedb6e68821efd712b3c2af6ad3e6824ffdf05f36d37506bd0705", kill_on_drop: false }`
[INFO] [stdout] fac81fd70caeedb6e68821efd712b3c2af6ad3e6824ffdf05f36d37506bd0705
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 36077b520b28173680df0fb9e8449ad7fca3dfdd6e1349582c20a2c7ddfc0e16
[INFO] running `Command { std: "docker" "start" "-a" "36077b520b28173680df0fb9e8449ad7fca3dfdd6e1349582c20a2c7ddfc0e16", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.103
[INFO] [stderr]    Compiling unicode-ident v1.0.22
[INFO] [stderr]    Compiling libc v0.2.183
[INFO] [stderr]    Compiling typenum v1.19.0
[INFO] [stderr]    Compiling crossbeam-utils v0.8.21
[INFO] [stderr]    Compiling generic-array v0.14.7
[INFO] [stderr]     Checking pin-project-lite v0.2.17
[INFO] [stderr]    Compiling cc v1.2.57
[INFO] [stderr]    Compiling serde_core v1.0.228
[INFO] [stderr]    Compiling parking_lot_core v0.9.12
[INFO] [stderr]    Compiling zerocopy v0.8.42
[INFO] [stderr]    Compiling serde v1.0.228
[INFO] [stderr]     Checking lock_api v0.4.14
[INFO] [stderr]    Compiling semver v1.0.27
[INFO] [stderr]     Checking once_cell v1.21.4
[INFO] [stderr]     Checking log v0.4.29
[INFO] [stderr]    Compiling quote v1.0.40
[INFO] [stderr]    Compiling cfg_aliases v0.2.1
[INFO] [stderr]    Compiling thiserror v2.0.18
[INFO] [stderr]     Checking regex-syntax v0.8.10
[INFO] [stderr]    Compiling syn v2.0.106
[INFO] [stderr]    Compiling rustc_version v0.4.1
[INFO] [stderr]    Compiling time-macros v0.2.27
[INFO] [stderr]     Checking tracing-core v0.1.36
[INFO] [stderr]    Compiling curve25519-dalek v4.1.3
[INFO] [stderr]     Checking num_threads v0.1.7
[INFO] [stderr]     Checking opaque-debug v0.3.1
[INFO] [stderr]    Compiling memoffset v0.9.1
[INFO] [stderr]     Checking memchr v2.8.0
[INFO] [stderr]    Compiling ring v0.17.14
[INFO] [stderr]     Checking signature v2.2.0
[INFO] [stderr]     Checking ed25519 v2.2.3
[INFO] [stderr]     Checking concurrent-queue v2.5.0
[INFO] [stderr]     Checking futures-sink v0.3.32
[INFO] [stderr]     Checking parking v2.2.1
[INFO] [stderr]     Checking sharded-slab v0.1.7
[INFO] [stderr]     Checking regex-automata v0.4.14
[INFO] [stderr]     Checking event-listener v5.4.1
[INFO] [stderr]     Checking serde_json v1.0.149
[INFO] [stderr]     Checking tracing-log v0.2.0
[INFO] [stderr]     Checking getrandom v0.2.17
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking errno v0.3.14
[INFO] [stderr]     Checking signal-hook-registry v1.4.8
[INFO] [stderr]     Checking parking_lot v0.12.5
[INFO] [stderr]     Checking socket2 v0.6.3
[INFO] [stderr]     Checking mio v1.1.1
[INFO] [stderr]     Checking time v0.3.47
[INFO] [stderr]    Compiling nix v0.30.1
[INFO] [stderr]     Checking thread_local v1.1.9
[INFO] [stderr]     Checking nu-ansi-term v0.50.3
[INFO] [stderr]     Checking murmur3 v0.5.2
[INFO] [stderr]    Compiling rustix v1.1.4
[INFO] [stderr]     Checking hex v0.4.3
[INFO] [stderr]     Checking event-listener-strategy v0.5.4
[INFO] [stderr]    Compiling nix v0.31.2
[INFO] [stderr]     Checking fastrand v2.3.0
[INFO] [stderr]    Compiling litrs v1.0.0
[INFO] [stderr]     Checking futures-io v0.3.32
[INFO] [stderr]     Checking piper v0.2.5
[INFO] [stderr]     Checking async-channel v2.5.0
[INFO] [stderr]     Checking netlink-sys v0.8.8
[INFO] [stderr]     Checking futures-lite v2.6.1
[INFO] [stderr]    Compiling document-features v0.2.12
[INFO] [stderr]     Checking async-task v4.7.1
[INFO] [stderr]    Compiling tun-rs v2.8.2
[INFO] [stderr]     Checking percent-encoding v2.3.2
[INFO] [stderr]     Checking base64 v0.22.1
[INFO] [stderr]     Checking unicode-width v0.2.2
[INFO] [stderr]     Checking winnow v0.7.15
[INFO] [stderr]     Checking ipnet v2.12.0
[INFO] [stderr]     Checking pem v3.0.6
[INFO] [stderr]     Checking crossterm v0.29.0
[INFO] [stderr]     Checking form_urlencoded v1.2.2
[INFO] [stderr]     Checking blocking v1.6.2
[INFO] [stderr]     Checking yasna v0.5.2
[INFO] [stderr]     Checking matchers v0.2.0
[INFO] [stderr]    Compiling rustls v0.23.37
[INFO] [stderr]     Checking getifaddrs v0.6.0
[INFO] [stderr]     Checking crossbeam-epoch v0.9.18
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]     Checking unicode-segmentation v1.12.0
[INFO] [stderr]    Compiling rayon-core v1.13.0
[INFO] [stderr]     Checking crossbeam-deque v0.8.6
[INFO] [stderr]     Checking getopts v0.2.24
[INFO] [stderr]    Compiling alloca v0.4.0
[INFO] [stderr]     Checking ciborium-io v0.2.2
[INFO] [stderr]     Checking clap_lex v1.1.0
[INFO] [stderr]     Checking comfy-table v7.2.2
[INFO] [stderr]     Checking anstyle v1.0.14
[INFO] [stderr]     Checking plotters-backend v0.3.7
[INFO] [stderr]    Compiling synstructure v0.13.2
[INFO] [stderr]     Checking clap_builder v4.6.0
[INFO] [stderr]     Checking plotters-svg v0.3.7
[INFO] [stderr]     Checking itertools v0.13.0
[INFO] [stderr]     Checking cast v0.3.0
[INFO] [stderr]     Checking rayon v1.11.0
[INFO] [stderr]     Checking plotters v0.3.7
[INFO] [stderr]     Checking regex v1.12.3
[INFO] [stderr]     Checking page_size v0.6.0
[INFO] [stderr]     Checking oorandom v11.1.5
[INFO] [stderr]     Checking anes v0.1.6
[INFO] [stderr]    Compiling zeroize_derive v1.4.3
[INFO] [stderr]    Compiling zerofrom-derive v0.1.6
[INFO] [stderr]    Compiling yoke-derive v0.8.1
[INFO] [stderr]    Compiling zerocopy-derive v0.8.42
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]     Checking zeroize v1.8.2
[INFO] [stderr]    Compiling zerovec-derive v0.11.2
[INFO] [stderr]    Compiling displaydoc v0.2.5
[INFO] [stderr]    Compiling curve25519-dalek-derive v0.1.1
[INFO] [stderr]    Compiling tokio-macros v2.6.1
[INFO] [stderr]     Checking crypto-common v0.1.7
[INFO] [stderr]     Checking block-buffer v0.10.4
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking zerofrom v0.1.6
[INFO] [stderr]     Checking yoke v0.8.1
[INFO] [stderr]     Checking inout v0.1.4
[INFO] [stderr]     Checking tokio v1.50.0
[INFO] [stderr]     Checking universal-hash v0.5.1
[INFO] [stderr]     Checking cipher v0.4.4
[INFO] [stderr]    Compiling thiserror-impl v2.0.18
[INFO] [stderr]     Checking poly1305 v0.8.0
[INFO] [stderr]     Checking zerovec v0.11.5
[INFO] [stderr]     Checking salsa20 v0.10.2
[INFO] [stderr]     Checking zerotrie v0.2.3
[INFO] [stderr]     Checking aead v0.5.2
[INFO] [stderr]     Checking tinystr v0.8.2
[INFO] [stderr]     Checking icu_locale_core v2.1.1
[INFO] [stderr]     Checking potential_utf v0.1.4
[INFO] [stderr]    Compiling thiserror-impl v1.0.69
[INFO] [stderr]    Compiling tracing-attributes v0.1.31
[INFO] [stderr]    Compiling futures-macro v0.3.32
[INFO] [stderr]     Checking icu_collections v2.1.1
[INFO] [stderr]     Checking icu_provider v2.1.1
[INFO] [stderr]     Checking crypto_secretbox v0.1.1
[INFO] [stderr]     Checking sha2 v0.10.9
[INFO] [stderr]     Checking crypto_box v0.9.1
[INFO] [stderr]     Checking x25519-dalek v2.0.1
[INFO] [stderr]     Checking rustls-pki-types v1.14.0
[INFO] [stderr]     Checking ed25519-dalek v2.2.0
[INFO] [stderr]     Checking thiserror v1.0.69
[INFO] [stderr]     Checking netlink-packet-utils v0.5.2
[INFO] [stderr]     Checking tracing v0.1.44
[INFO] [stderr]    Compiling async-trait v0.1.89
[INFO] [stderr]     Checking futures-util v0.3.32
[INFO] [stderr]     Checking icu_properties v2.1.2
[INFO] [stderr]     Checking netlink-packet-core v0.7.0
[INFO] [stderr]     Checking tracing-subscriber v0.3.23
[INFO] [stderr]     Checking icu_normalizer v2.1.1
[INFO] [stderr]     Checking netlink-packet-route v0.24.0
[INFO] [stderr]     Checking rustls-webpki v0.103.9
[INFO] [stderr]     Checking serde_spanned v0.6.9
[INFO] [stderr]     Checking toml_datetime v0.6.11
[INFO] [stderr]     Checking toml_edit v0.22.27
[INFO] [stderr]     Checking idna_adapter v1.2.1
[INFO] [stderr]     Checking idna v1.1.0
[INFO] [stderr]     Checking rcgen v0.14.7
[INFO] [stderr]     Checking url v2.5.8
[INFO] [stderr]     Checking blake2 v0.10.6
[INFO] [stderr]     Checking tinytemplate v1.2.1
[INFO] [stderr]     Checking clap v4.6.0
[INFO] [stderr]     Checking criterion-plot v0.8.2
[INFO] [stderr]     Checking tokio-util v0.7.18
[INFO] [stderr]     Checking ppv-lite86 v0.2.21
[INFO] [stderr]     Checking half v2.7.1
[INFO] [stderr]     Checking ciborium-ll v0.2.2
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking ciborium v0.2.2
[INFO] [stderr]     Checking toml v0.8.23
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking criterion v0.8.2
[INFO] [stderr]     Checking ironwood v0.1.2 (/opt/rustwide/workdir/crates/ironwood)
[INFO] [stderr]     Checking tokio-rustls v0.26.4
[INFO] [stderr]     Checking netconfig-rs v0.1.5
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> crates/ironwood/src/core.rs:287:9
[INFO] [stdout]     |
[INFO] [stdout] 268 | /         let result = peer_reader(
[INFO] [stdout] 269 | |             peer_id,
[INFO] [stdout] 270 | |             peer_key,
[INFO] [stdout] 271 | |             self.pub_key,
[INFO] [stdout] ...   |
[INFO] [stdout] 285 | |         .await;
[INFO] [stdout]     | |_______________- unnecessary `let` binding
[INFO] [stdout] 286 |
[INFO] [stdout] 287 |           result
[INFO] [stdout]     |           ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 268 ~         
[INFO] [stdout] 269 |
[INFO] [stdout] 270 ~         peer_reader(
[INFO] [stdout] 271 +             peer_id,
[INFO] [stdout] 272 +             peer_key,
[INFO] [stdout] 273 +             self.pub_key,
[INFO] [stdout] 274 +             read_half,
[INFO] [stdout] 275 +             self.router.clone(),
[INFO] [stdout] 276 +             self.peers.clone(),
[INFO] [stdout] 277 +             self.delivery_queue.clone(),
[INFO] [stdout] 278 +             self.traffic_tx.clone(),
[INFO] [stdout] 279 +             writer_tx.clone(),
[INFO] [stdout] 280 +             peer_cancel.clone(),
[INFO] [stdout] 281 +             self.config.peer_max_message_size,
[INFO] [stdout] 282 +             self.config.peer_timeout,
[INFO] [stdout] 283 +             self.config.peer_keepalive_delay,
[INFO] [stdout] 284 +             self.path_notify_cb.clone(),
[INFO] [stdout] 285 +             read_deadline,
[INFO] [stdout] 286 +         )
[INFO] [stdout] 287 +         .await
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/core.rs:464:33
[INFO] [stdout]     |
[INFO] [stdout] 464 |             for (_id, entry) in entries {
[INFO] [stdout]     |                                 ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout]     = note: `#[warn(clippy::for_kv_map)]` on by default
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 464 -             for (_id, entry) in entries {
[INFO] [stdout] 464 +             for entry in entries.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> crates/ironwood/src/core.rs:494:9
[INFO] [stdout]     |
[INFO] [stdout] 494 |         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 494 -         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout] 494 +         result.sort_by_key(|a| a.key);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> crates/ironwood/src/core.rs:525:9
[INFO] [stdout]     |
[INFO] [stdout] 525 |         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 525 -         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout] 525 +         result.sort_by_key(|a| a.key);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/traffic.rs:303:9
[INFO] [stdout]     |
[INFO] [stdout] 303 | /         if let Some(age) = queue.oldest_age() {
[INFO] [stdout] 304 | |             if age > MAX_PACKET_AGE {
[INFO] [stdout] 305 | |                 queue.drop_largest();
[INFO] [stdout] 306 | |                 tracing::debug!("Dropped oldest packet from queue (age > 25ms)");
[INFO] [stdout] 307 | |             }
[INFO] [stdout] 308 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 303 ~         if let Some(age) = queue.oldest_age()
[INFO] [stdout] 304 ~             && age > MAX_PACKET_AGE {
[INFO] [stdout] 305 |                 queue.drop_largest();
[INFO] [stdout] 306 |                 tracing::debug!("Dropped oldest packet from queue (age > 25ms)");
[INFO] [stdout] 307 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/bloom.rs:149:9
[INFO] [stdout]     |
[INFO] [stdout] 149 | /         self.blooms
[INFO] [stdout] 150 | |             .get(key)
[INFO] [stdout] 151 | |             .map_or(false, |info| info.on_tree)
[INFO] [stdout]     | |_______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 151 -             .map_or(false, |info| info.on_tree)
[INFO] [stdout] 151 +             .is_some_and(|info| info.on_tree)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/bloom.rs:203:18
[INFO] [stdout]     |
[INFO] [stdout] 203 |               else if let Some(parent) = infos.get(pk) {
[INFO] [stdout]     |  __________________^
[INFO] [stdout] 204 | |                 if parent == self_key {
[INFO] [stdout] 205 | |                     pbi.on_tree = true;
[INFO] [stdout] 206 | |                 }
[INFO] [stdout] 207 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 203 ~             else if let Some(parent) = infos.get(pk)
[INFO] [stdout] 204 ~                 && parent == self_key {
[INFO] [stdout] 205 |                     pbi.on_tree = true;
[INFO] [stdout] 206 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:140:13
[INFO] [stdout]     |
[INFO] [stdout] 140 |             rumor.send_time.map_or(false, |t| t.elapsed() < throttle)
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 140 -             rumor.send_time.map_or(false, |t| t.elapsed() < throttle)
[INFO] [stdout] 140 +             rumor.send_time.is_some_and(|t| t.elapsed() < throttle)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:150:9
[INFO] [stdout]     |
[INFO] [stdout] 150 | /         if self.rumors.contains_key(&xformed_dest) {
[INFO] [stdout] 151 | |             false
[INFO] [stdout] 152 | |         } else {
[INFO] [stdout] 153 | |             self.rumors.insert(
[INFO] [stdout] ...   |
[INFO] [stdout] 161 | |             true
[INFO] [stdout] 162 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout]     = note: `#[warn(clippy::map_entry)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 150 ~         if let std::collections::hash_map::Entry::Vacant(e) = self.rumors.entry(xformed_dest) {
[INFO] [stdout] 151 +             e.insert(PathRumor {
[INFO] [stdout] 152 +                     traffic: None,
[INFO] [stdout] 153 +                     send_time: None,
[INFO] [stdout] 154 +                     created: Instant::now(),
[INFO] [stdout] 155 +                 });
[INFO] [stdout] 156 +             true
[INFO] [stdout] 157 +         } else {
[INFO] [stdout] 158 +             false
[INFO] [stdout] 159 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:242:20
[INFO] [stdout]     |
[INFO] [stdout] 242 |                   if rumor
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 243 | |                     .traffic
[INFO] [stdout] 244 | |                     .as_ref()
[INFO] [stdout] 245 | |                     .map_or(false, |t| t.dest == source)
[INFO] [stdout]     | |________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 245 -                     .map_or(false, |t| t.dest == source)
[INFO] [stdout] 245 +                     .is_some_and(|t| t.dest == source)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:277:9
[INFO] [stdout]     |
[INFO] [stdout] 277 | /         if let Some(info) = self.paths.get_mut(key) {
[INFO] [stdout] 278 | |             if !info.broken {
[INFO] [stdout] 279 | |                 info.last_refresh = Instant::now();
[INFO] [stdout] 280 | |             }
[INFO] [stdout] 281 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 277 ~         if let Some(info) = self.paths.get_mut(key)
[INFO] [stdout] 278 ~             && !info.broken {
[INFO] [stdout] 279 |                 info.last_refresh = Instant::now();
[INFO] [stdout] 280 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: large size difference between variants
[INFO] [stdout]    --> crates/ironwood/src/router.rs:151:1
[INFO] [stdout]     |
[INFO] [stdout] 151 | /   pub(crate) enum RouterAction {
[INFO] [stdout] 152 | |       /// Send a signature request to a specific peer.
[INFO] [stdout] 153 | |       SendSigReq {
[INFO] [stdout] 154 | |           peer_id: PeerId,
[INFO] [stdout] ...   |
[INFO] [stdout] 163 | | /     SendAnnounce {
[INFO] [stdout] 164 | | |         peer_id: PeerId,
[INFO] [stdout] 165 | | |         ann: wire::Announce,
[INFO] [stdout] 166 | | |     },
[INFO] [stdout]     | | |_____- the second-largest variant contains at least 224 bytes
[INFO] [stdout] 167 | |       /// Send a bloom filter to a specific peer.
[INFO] [stdout] 168 | | /     SendBloom {
[INFO] [stdout] 169 | | |         peer_id: PeerId,
[INFO] [stdout] 170 | | |         bloom: crate::bloom::BloomFilter,
[INFO] [stdout] 171 | | |     },
[INFO] [stdout]     | | |_____- the largest variant contains at least 1032 bytes
[INFO] [stdout] ...   |
[INFO] [stdout] 199 | |       },
[INFO] [stdout] 200 | |   }
[INFO] [stdout]     | |___^ the entire enum is at least 1040 bytes
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stdout]     = note: `#[warn(clippy::large_enum_variant)]` on by default
[INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
[INFO] [stdout]     |
[INFO] [stdout] 170 -         bloom: crate::bloom::BloomFilter,
[INFO] [stdout] 170 +         bloom: Box<crate::bloom::BloomFilter>,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/router.rs:351:24
[INFO] [stdout]     |
[INFO] [stdout] 351 |             let diff = old.map_or(true, |o| o != &anc);
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use a standard comparison instead
[INFO] [stdout]     |
[INFO] [stdout] 351 -             let diff = old.map_or(true, |o| o != &anc);
[INFO] [stdout] 351 +             let diff = old != Some(&anc);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:383:35
[INFO] [stdout]     |
[INFO] [stdout] 383 |                 for (_, entry) in peers {
[INFO] [stdout]     |                                   ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 383 -                 for (_, entry) in peers {
[INFO] [stdout] 383 +                 for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]    --> crates/ironwood/src/router.rs:404:9
[INFO] [stdout]     |
[INFO] [stdout] 404 | /         if !self.peers.contains_key(&key) {
[INFO] [stdout] 405 | |             self.peers.insert(key, HashMap::new());
[INFO] [stdout] 406 | |             self.sent.insert(key, HashSet::new());
[INFO] [stdout] 407 | |             self.ports.insert(entry.port, key);
[INFO] [stdout] ...   |
[INFO] [stdout] 422 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 404 ~         if let std::collections::hash_map::Entry::Vacant(e) = self.peers.entry(key) {
[INFO] [stdout] 405 +             e.insert(HashMap::new());
[INFO] [stdout] 406 +             self.sent.insert(key, HashSet::new());
[INFO] [stdout] 407 +             self.ports.insert(entry.port, key);
[INFO] [stdout] 408 +             self.blooms.add_info(key);
[INFO] [stdout] 409 +         } else {
[INFO] [stdout] 410 +             // Send already-sent announcements to new connection
[INFO] [stdout] 411 +             if let Some(sent_keys) = self.sent.get(&key) {
[INFO] [stdout] 412 +                 let sent_keys: Vec<PublicKey> = sent_keys.iter().copied().collect();
[INFO] [stdout] 413 +                 for k in sent_keys {
[INFO] [stdout] 414 +                     if let Some(info) = self.infos.get(&k) {
[INFO] [stdout] 415 +                         actions.push(RouterAction::SendAnnounce {
[INFO] [stdout] 416 +                             peer_id,
[INFO] [stdout] 417 +                             ann: info.get_announce(k).to_wire(),
[INFO] [stdout] 418 +                         });
[INFO] [stdout] 419 +                     }
[INFO] [stdout] 420 +                 }
[INFO] [stdout] 421 +             }
[INFO] [stdout] 422 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/router.rs:533:25
[INFO] [stdout]     |
[INFO] [stdout] 533 |           let req_match = self
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 534 | |             .requests
[INFO] [stdout] 535 | |             .get(key)
[INFO] [stdout] 536 | |             .map_or(false, |r| r.seq == res.seq && r.nonce == res.nonce);
[INFO] [stdout]     | |________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 536 -             .map_or(false, |r| r.seq == res.seq && r.nonce == res.nonce);
[INFO] [stdout] 536 +             .is_some_and(|r| r.seq == res.seq && r.nonce == res.nonce);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:725:39
[INFO] [stdout]     |
[INFO] [stdout] 725 |                     for (_, entry) in peers {
[INFO] [stdout]     |                                       ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 725 -                     for (_, entry) in peers {
[INFO] [stdout] 725 +                     for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:751:35
[INFO] [stdout]     |
[INFO] [stdout] 751 |                 for (_, entry) in peers {
[INFO] [stdout]     |                                   ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 751 -                 for (_, entry) in peers {
[INFO] [stdout] 751 +                 for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:889:35
[INFO] [stdout]     |
[INFO] [stdout] 889 |                 for (_, entry) in peers {
[INFO] [stdout]     |                                   ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 889 -                 for (_, entry) in peers {
[INFO] [stdout] 889 +                 for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]     --> crates/ironwood/src/router.rs:1015:13
[INFO] [stdout]      |
[INFO] [stdout] 1015 | /             if dist < best_dist {
[INFO] [stdout] 1016 | |                 if let Some(peers) = self.peers.get(k) {
[INFO] [stdout] 1017 | |                     for (_, entry) in peers {
[INFO] [stdout] 1018 | |                         candidates.push(entry.clone());
[INFO] [stdout] ...    |
[INFO] [stdout] 1021 | |             }
[INFO] [stdout]      | |_____________^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]      |
[INFO] [stdout] 1015 ~             if dist < best_dist
[INFO] [stdout] 1016 ~                 && let Some(peers) = self.peers.get(k) {
[INFO] [stdout] 1017 |                     for (_, entry) in peers {
[INFO] [stdout] 1018 |                         candidates.push(entry.clone());
[INFO] [stdout] 1019 |                     }
[INFO] [stdout] 1020 ~                 }
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]     --> crates/ironwood/src/router.rs:1017:39
[INFO] [stdout]      |
[INFO] [stdout] 1017 |                     for (_, entry) in peers {
[INFO] [stdout]      |                                       ^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]      |
[INFO] [stdout] 1017 -                     for (_, entry) in peers {
[INFO] [stdout] 1017 +                     for entry in peers.values() {
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:121:14
[INFO] [stdout]     |
[INFO] [stdout] 121 |             .or_insert_with(HashMap::new)
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]     = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:243:13
[INFO] [stdout]     |
[INFO] [stdout] 243 | /             if let Some(age) = queue.oldest_age() {
[INFO] [stdout] 244 | |                 if age > MAX_PACKET_AGE_SEND {
[INFO] [stdout] 245 | |                     if queue.drop_largest() {
[INFO] [stdout] 246 | |                         tracing::warn!(
[INFO] [stdout] ...   |
[INFO] [stdout] 253 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 243 ~             if let Some(age) = queue.oldest_age()
[INFO] [stdout] 244 ~                 && age > MAX_PACKET_AGE_SEND {
[INFO] [stdout] 245 |                     if queue.drop_largest() {
[INFO] [stdout] ...
[INFO] [stdout] 251 |                     }
[INFO] [stdout] 252 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:244:17
[INFO] [stdout]     |
[INFO] [stdout] 244 | /                 if age > MAX_PACKET_AGE_SEND {
[INFO] [stdout] 245 | |                     if queue.drop_largest() {
[INFO] [stdout] 246 | |                         tracing::warn!(
[INFO] [stdout] 247 | |                             "send_traffic_to_peer[{}]: dropped oldest packet (age={:?} > 25ms) - backpressure applied",
[INFO] [stdout] ...   |
[INFO] [stdout] 252 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 244 ~                 if age > MAX_PACKET_AGE_SEND
[INFO] [stdout] 245 ~                     && queue.drop_largest() {
[INFO] [stdout] 246 |                         tracing::warn!(
[INFO] [stdout] ...
[INFO] [stdout] 250 |                         );
[INFO] [stdout] 251 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (15/7)
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:369:1
[INFO] [stdout]     |
[INFO] [stdout] 369 | / pub(crate) async fn peer_reader(
[INFO] [stdout] 370 | |     peer_id: PeerId,
[INFO] [stdout] 371 | |     peer_key: PublicKey,
[INFO] [stdout] 372 | |     our_key: PublicKey,
[INFO] [stdout] ...   |
[INFO] [stdout] 384 | |     read_deadline: ReadDeadline,
[INFO] [stdout] 385 | | ) -> Result<(), Error> {
[INFO] [stdout]     | |______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:404:17
[INFO] [stdout]     |
[INFO] [stdout] 404 | /                 if let Some(d) = deadline {
[INFO] [stdout] 405 | |                     if std::time::Instant::now() >= d {
[INFO] [stdout] 406 | |                         tracing::debug!("peer_reader[{}]: peer timeout ({}ms, no reply from {:02x?}), disconnecting",
[INFO] [stdout] 407 | |                             peer_id, peer_timeout.as_millis(), &peer_key[..8]);
[INFO] [stdout] ...   |
[INFO] [stdout] 411 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 404 ~                 if let Some(d) = deadline
[INFO] [stdout] 405 ~                     && std::time::Instant::now() >= d {
[INFO] [stdout] 406 |                         tracing::debug!("peer_reader[{}]: peer timeout ({}ms, no reply from {:02x?}), disconnecting",
[INFO] [stdout] ...
[INFO] [stdout] 409 |                         break;
[INFO] [stdout] 410 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `types::Error`
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:422:42
[INFO] [stdout]     |
[INFO] [stdout] 422 |                 disconnect_reason = Some(e.into());
[INFO] [stdout]     |                                          ^^^^^^^^ help: consider removing `.into()`: `e`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:479:17
[INFO] [stdout]     |
[INFO] [stdout] 479 | /                 if let Some(peers_map) = router.peers.get(&peer_key) {
[INFO] [stdout] 480 | |                     if let Some(entry) = peers_map.get(&peer_id) {
[INFO] [stdout] 481 | |                         let action = router.handle_request_with_data(entry, &req);
[INFO] [stdout] 482 | |                         drop(router);
[INFO] [stdout] ...   |
[INFO] [stdout] 485 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 479 ~                 if let Some(peers_map) = router.peers.get(&peer_key)
[INFO] [stdout] 480 ~                     && let Some(entry) = peers_map.get(&peer_id) {
[INFO] [stdout] 481 |                         let action = router.handle_request_with_data(entry, &req);
[INFO] [stdout] 482 |                         drop(router);
[INFO] [stdout] 483 |                         dispatch_action(action, &peers).await;
[INFO] [stdout] 484 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (15/7)
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:725:1
[INFO] [stdout]     |
[INFO] [stdout] 725 | / pub(crate) async fn peer_writer(
[INFO] [stdout] 726 | |     peer_id: PeerId,
[INFO] [stdout] 727 | |     peer_key: PublicKey,
[INFO] [stdout] 728 | |     port: PeerPort,
[INFO] [stdout] ...   |
[INFO] [stdout] 740 | |     cancel: CancellationToken,
[INFO] [stdout] 741 | | ) {
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:822:25
[INFO] [stdout]     |
[INFO] [stdout] 822 | /                         if let Some(ptype) = peek_frame_type(&data) {
[INFO] [stdout] 823 | |                             if !matches!(ptype, wire::PacketType::KeepAlive | wire::PacketType::Dummy) {
[INFO] [stdout] 824 | |                                 *read_deadline.lock().unwrap() = Some(std::time::Instant::now() + peer_timeout);
[INFO] [stdout] 825 | |                             }
[INFO] [stdout] 826 | |                         }
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 822 ~                         if let Some(ptype) = peek_frame_type(&data)
[INFO] [stdout] 823 ~                             && !matches!(ptype, wire::PacketType::KeepAlive | wire::PacketType::Dummy) {
[INFO] [stdout] 824 |                                 *read_deadline.lock().unwrap() = Some(std::time::Instant::now() + peer_timeout);
[INFO] [stdout] 825 ~                             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:366:16
[INFO] [stdout]     |
[INFO] [stdout] 366 |             if !(self.recv_nonce < nonce) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.recv_nonce >= nonce)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:371:16
[INFO] [stdout]     |
[INFO] [stdout] 371 |             if !(self.next_send_nonce < nonce) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.next_send_nonce >= nonce)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:376:16
[INFO] [stdout]     |
[INFO] [stdout] 376 |             if !(self.next_recv_nonce < nonce) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.next_recv_nonce >= nonce)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:425:29
[INFO] [stdout]     |
[INFO] [stdout] 425 |           let should_rotate = self
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 426 | |             .rotated
[INFO] [stdout] 427 | |             .map_or(true, |t| t.elapsed() > Duration::from_secs(60));
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_none_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 427 -             .map_or(true, |t| t.elapsed() > Duration::from_secs(60));
[INFO] [stdout] 427 +             .is_none_or(|t| t.elapsed() > Duration::from_secs(60));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:564:13
[INFO] [stdout]     |
[INFO] [stdout] 564 | /             if let Some(buf_data) = buffered_data {
[INFO] [stdout] 565 | |                 if let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 566 | |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] 567 | |                         dest: *from,
[INFO] [stdout] ...   |
[INFO] [stdout] 571 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 564 ~             if let Some(buf_data) = buffered_data
[INFO] [stdout] 565 ~                 && let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 566 |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] ...
[INFO] [stdout] 569 |                     });
[INFO] [stdout] 570 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:603:13
[INFO] [stdout]     |
[INFO] [stdout] 603 | /             if let Some(buf_data) = buffered_data {
[INFO] [stdout] 604 | |                 if let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 605 | |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] 606 | |                         dest: *from,
[INFO] [stdout] ...   |
[INFO] [stdout] 610 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 603 ~             if let Some(buf_data) = buffered_data
[INFO] [stdout] 604 ~                 && let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 605 |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] ...
[INFO] [stdout] 608 |                     });
[INFO] [stdout] 609 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant redefinition of a binding `curve_priv`
[INFO] [stdout]   --> crates/ironwood/src/encrypted/mod.rs:82:13
[INFO] [stdout]    |
[INFO] [stdout] 82 |             let curve_priv = curve_priv;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: `curve_priv` is initially defined here
[INFO] [stdout]   --> crates/ironwood/src/encrypted/mod.rs:69:13
[INFO] [stdout]    |
[INFO] [stdout] 69 |         let curve_priv = ed25519_private_to_curve25519(&secret);
[INFO] [stdout]    |             ^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
[INFO] [stdout]    = note: `#[warn(clippy::redundant_locals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> crates/ironwood/src/encrypted/mod.rs:152:9
[INFO] [stdout]     |
[INFO] [stdout] 152 |         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 152 -         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout] 152 +         result.sort_by_key(|a| a.key);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Checking yggdrasil v0.1.2 (/opt/rustwide/workdir/crates/yggdrasil)
[INFO] [stdout] warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
[INFO] [stdout]  --> crates/ironwood/benches/logging_overhead.rs:1:17
[INFO] [stdout]   |
[INFO] [stdout] 1 | use criterion::{black_box, criterion_group, criterion_main, Criterion, BenchmarkId};
[INFO] [stdout]   |                 ^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
[INFO] [stdout]   --> crates/ironwood/benches/logging_overhead.rs:13:9
[INFO] [stdout]    |
[INFO] [stdout] 13 |         black_box(packet_id.wrapping_add(1));
[INFO] [stdout]    |         ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `criterion::black_box`: use `std::hint::black_box()` instead
[INFO] [stdout]   --> crates/ironwood/benches/logging_overhead.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 |         black_box(packet_id.wrapping_add(1));
[INFO] [stdout]    |         ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]   --> crates/ironwood/benches/logging_overhead.rs:29:22
[INFO] [stdout]    |
[INFO] [stdout] 29 |         .with_writer(|| std::io::sink()) // Discard all output
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `std::io::sink`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]    = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> crates/ironwood/src/core.rs:287:9
[INFO] [stdout]     |
[INFO] [stdout] 268 | /         let result = peer_reader(
[INFO] [stdout] 269 | |             peer_id,
[INFO] [stdout] 270 | |             peer_key,
[INFO] [stdout] 271 | |             self.pub_key,
[INFO] [stdout] ...   |
[INFO] [stdout] 285 | |         .await;
[INFO] [stdout]     | |_______________- unnecessary `let` binding
[INFO] [stdout] 286 |
[INFO] [stdout] 287 |           result
[INFO] [stdout]     |           ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 268 ~         
[INFO] [stdout] 269 |
[INFO] [stdout] 270 ~         peer_reader(
[INFO] [stdout] 271 +             peer_id,
[INFO] [stdout] 272 +             peer_key,
[INFO] [stdout] 273 +             self.pub_key,
[INFO] [stdout] 274 +             read_half,
[INFO] [stdout] 275 +             self.router.clone(),
[INFO] [stdout] 276 +             self.peers.clone(),
[INFO] [stdout] 277 +             self.delivery_queue.clone(),
[INFO] [stdout] 278 +             self.traffic_tx.clone(),
[INFO] [stdout] 279 +             writer_tx.clone(),
[INFO] [stdout] 280 +             peer_cancel.clone(),
[INFO] [stdout] 281 +             self.config.peer_max_message_size,
[INFO] [stdout] 282 +             self.config.peer_timeout,
[INFO] [stdout] 283 +             self.config.peer_keepalive_delay,
[INFO] [stdout] 284 +             self.path_notify_cb.clone(),
[INFO] [stdout] 285 +             read_deadline,
[INFO] [stdout] 286 +         )
[INFO] [stdout] 287 +         .await
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/core.rs:464:33
[INFO] [stdout]     |
[INFO] [stdout] 464 |             for (_id, entry) in entries {
[INFO] [stdout]     |                                 ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout]     = note: `#[warn(clippy::for_kv_map)]` on by default
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 464 -             for (_id, entry) in entries {
[INFO] [stdout] 464 +             for entry in entries.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> crates/ironwood/src/core.rs:494:9
[INFO] [stdout]     |
[INFO] [stdout] 494 |         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 494 -         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout] 494 +         result.sort_by_key(|a| a.key);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> crates/ironwood/src/core.rs:525:9
[INFO] [stdout]     |
[INFO] [stdout] 525 |         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 525 -         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout] 525 +         result.sort_by_key(|a| a.key);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/traffic.rs:303:9
[INFO] [stdout]     |
[INFO] [stdout] 303 | /         if let Some(age) = queue.oldest_age() {
[INFO] [stdout] 304 | |             if age > MAX_PACKET_AGE {
[INFO] [stdout] 305 | |                 queue.drop_largest();
[INFO] [stdout] 306 | |                 tracing::debug!("Dropped oldest packet from queue (age > 25ms)");
[INFO] [stdout] 307 | |             }
[INFO] [stdout] 308 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 303 ~         if let Some(age) = queue.oldest_age()
[INFO] [stdout] 304 ~             && age > MAX_PACKET_AGE {
[INFO] [stdout] 305 |                 queue.drop_largest();
[INFO] [stdout] 306 |                 tracing::debug!("Dropped oldest packet from queue (age > 25ms)");
[INFO] [stdout] 307 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/bloom.rs:149:9
[INFO] [stdout]     |
[INFO] [stdout] 149 | /         self.blooms
[INFO] [stdout] 150 | |             .get(key)
[INFO] [stdout] 151 | |             .map_or(false, |info| info.on_tree)
[INFO] [stdout]     | |_______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 151 -             .map_or(false, |info| info.on_tree)
[INFO] [stdout] 151 +             .is_some_and(|info| info.on_tree)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/bloom.rs:203:18
[INFO] [stdout]     |
[INFO] [stdout] 203 |               else if let Some(parent) = infos.get(pk) {
[INFO] [stdout]     |  __________________^
[INFO] [stdout] 204 | |                 if parent == self_key {
[INFO] [stdout] 205 | |                     pbi.on_tree = true;
[INFO] [stdout] 206 | |                 }
[INFO] [stdout] 207 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 203 ~             else if let Some(parent) = infos.get(pk)
[INFO] [stdout] 204 ~                 && parent == self_key {
[INFO] [stdout] 205 |                     pbi.on_tree = true;
[INFO] [stdout] 206 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> crates/ironwood/src/bloom.rs:608:41
[INFO] [stdout]     |
[INFO] [stdout] 608 |         println!("Key: {}", hex::encode(&key));
[INFO] [stdout]     |                                         ^^^^ help: change this to: `key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:140:13
[INFO] [stdout]     |
[INFO] [stdout] 140 |             rumor.send_time.map_or(false, |t| t.elapsed() < throttle)
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 140 -             rumor.send_time.map_or(false, |t| t.elapsed() < throttle)
[INFO] [stdout] 140 +             rumor.send_time.is_some_and(|t| t.elapsed() < throttle)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:150:9
[INFO] [stdout]     |
[INFO] [stdout] 150 | /         if self.rumors.contains_key(&xformed_dest) {
[INFO] [stdout] 151 | |             false
[INFO] [stdout] 152 | |         } else {
[INFO] [stdout] 153 | |             self.rumors.insert(
[INFO] [stdout] ...   |
[INFO] [stdout] 161 | |             true
[INFO] [stdout] 162 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout]     = note: `#[warn(clippy::map_entry)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 150 ~         if let std::collections::hash_map::Entry::Vacant(e) = self.rumors.entry(xformed_dest) {
[INFO] [stdout] 151 +             e.insert(PathRumor {
[INFO] [stdout] 152 +                     traffic: None,
[INFO] [stdout] 153 +                     send_time: None,
[INFO] [stdout] 154 +                     created: Instant::now(),
[INFO] [stdout] 155 +                 });
[INFO] [stdout] 156 +             true
[INFO] [stdout] 157 +         } else {
[INFO] [stdout] 158 +             false
[INFO] [stdout] 159 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:242:20
[INFO] [stdout]     |
[INFO] [stdout] 242 |                   if rumor
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 243 | |                     .traffic
[INFO] [stdout] 244 | |                     .as_ref()
[INFO] [stdout] 245 | |                     .map_or(false, |t| t.dest == source)
[INFO] [stdout]     | |________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 245 -                     .map_or(false, |t| t.dest == source)
[INFO] [stdout] 245 +                     .is_some_and(|t| t.dest == source)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/pathfinder.rs:277:9
[INFO] [stdout]     |
[INFO] [stdout] 277 | /         if let Some(info) = self.paths.get_mut(key) {
[INFO] [stdout] 278 | |             if !info.broken {
[INFO] [stdout] 279 | |                 info.last_refresh = Instant::now();
[INFO] [stdout] 280 | |             }
[INFO] [stdout] 281 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 277 ~         if let Some(info) = self.paths.get_mut(key)
[INFO] [stdout] 278 ~             && !info.broken {
[INFO] [stdout] 279 |                 info.last_refresh = Instant::now();
[INFO] [stdout] 280 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: large size difference between variants
[INFO] [stdout]    --> crates/ironwood/src/router.rs:151:1
[INFO] [stdout]     |
[INFO] [stdout] 151 | /   pub(crate) enum RouterAction {
[INFO] [stdout] 152 | |       /// Send a signature request to a specific peer.
[INFO] [stdout] 153 | |       SendSigReq {
[INFO] [stdout] 154 | |           peer_id: PeerId,
[INFO] [stdout] ...   |
[INFO] [stdout] 163 | | /     SendAnnounce {
[INFO] [stdout] 164 | | |         peer_id: PeerId,
[INFO] [stdout] 165 | | |         ann: wire::Announce,
[INFO] [stdout] 166 | | |     },
[INFO] [stdout]     | | |_____- the second-largest variant contains at least 224 bytes
[INFO] [stdout] 167 | |       /// Send a bloom filter to a specific peer.
[INFO] [stdout] 168 | | /     SendBloom {
[INFO] [stdout] 169 | | |         peer_id: PeerId,
[INFO] [stdout] 170 | | |         bloom: crate::bloom::BloomFilter,
[INFO] [stdout] 171 | | |     },
[INFO] [stdout]     | | |_____- the largest variant contains at least 1032 bytes
[INFO] [stdout] ...   |
[INFO] [stdout] 199 | |       },
[INFO] [stdout] 200 | |   }
[INFO] [stdout]     | |___^ the entire enum is at least 1040 bytes
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
[INFO] [stdout]     = note: `#[warn(clippy::large_enum_variant)]` on by default
[INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
[INFO] [stdout]     |
[INFO] [stdout] 170 -         bloom: crate::bloom::BloomFilter,
[INFO] [stdout] 170 +         bloom: Box<crate::bloom::BloomFilter>,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/router.rs:351:24
[INFO] [stdout]     |
[INFO] [stdout] 351 |             let diff = old.map_or(true, |o| o != &anc);
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use a standard comparison instead
[INFO] [stdout]     |
[INFO] [stdout] 351 -             let diff = old.map_or(true, |o| o != &anc);
[INFO] [stdout] 351 +             let diff = old != Some(&anc);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:383:35
[INFO] [stdout]     |
[INFO] [stdout] 383 |                 for (_, entry) in peers {
[INFO] [stdout]     |                                   ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 383 -                 for (_, entry) in peers {
[INFO] [stdout] 383 +                 for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stdout]    --> crates/ironwood/src/router.rs:404:9
[INFO] [stdout]     |
[INFO] [stdout] 404 | /         if !self.peers.contains_key(&key) {
[INFO] [stdout] 405 | |             self.peers.insert(key, HashMap::new());
[INFO] [stdout] 406 | |             self.sent.insert(key, HashSet::new());
[INFO] [stdout] 407 | |             self.ports.insert(entry.port, key);
[INFO] [stdout] ...   |
[INFO] [stdout] 422 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 404 ~         if let std::collections::hash_map::Entry::Vacant(e) = self.peers.entry(key) {
[INFO] [stdout] 405 +             e.insert(HashMap::new());
[INFO] [stdout] 406 +             self.sent.insert(key, HashSet::new());
[INFO] [stdout] 407 +             self.ports.insert(entry.port, key);
[INFO] [stdout] 408 +             self.blooms.add_info(key);
[INFO] [stdout] 409 +         } else {
[INFO] [stdout] 410 +             // Send already-sent announcements to new connection
[INFO] [stdout] 411 +             if let Some(sent_keys) = self.sent.get(&key) {
[INFO] [stdout] 412 +                 let sent_keys: Vec<PublicKey> = sent_keys.iter().copied().collect();
[INFO] [stdout] 413 +                 for k in sent_keys {
[INFO] [stdout] 414 +                     if let Some(info) = self.infos.get(&k) {
[INFO] [stdout] 415 +                         actions.push(RouterAction::SendAnnounce {
[INFO] [stdout] 416 +                             peer_id,
[INFO] [stdout] 417 +                             ann: info.get_announce(k).to_wire(),
[INFO] [stdout] 418 +                         });
[INFO] [stdout] 419 +                     }
[INFO] [stdout] 420 +                 }
[INFO] [stdout] 421 +             }
[INFO] [stdout] 422 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/router.rs:533:25
[INFO] [stdout]     |
[INFO] [stdout] 533 |           let req_match = self
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 534 | |             .requests
[INFO] [stdout] 535 | |             .get(key)
[INFO] [stdout] 536 | |             .map_or(false, |r| r.seq == res.seq && r.nonce == res.nonce);
[INFO] [stdout]     | |________________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]     |
[INFO] [stdout] 536 -             .map_or(false, |r| r.seq == res.seq && r.nonce == res.nonce);
[INFO] [stdout] 536 +             .is_some_and(|r| r.seq == res.seq && r.nonce == res.nonce);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:725:39
[INFO] [stdout]     |
[INFO] [stdout] 725 |                     for (_, entry) in peers {
[INFO] [stdout]     |                                       ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 725 -                     for (_, entry) in peers {
[INFO] [stdout] 725 +                     for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:751:35
[INFO] [stdout]     |
[INFO] [stdout] 751 |                 for (_, entry) in peers {
[INFO] [stdout]     |                                   ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 751 -                 for (_, entry) in peers {
[INFO] [stdout] 751 +                 for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]    --> crates/ironwood/src/router.rs:889:35
[INFO] [stdout]     |
[INFO] [stdout] 889 |                 for (_, entry) in peers {
[INFO] [stdout]     |                                   ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 889 -                 for (_, entry) in peers {
[INFO] [stdout] 889 +                 for entry in peers.values() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]     --> crates/ironwood/src/router.rs:1015:13
[INFO] [stdout]      |
[INFO] [stdout] 1015 | /             if dist < best_dist {
[INFO] [stdout] 1016 | |                 if let Some(peers) = self.peers.get(k) {
[INFO] [stdout] 1017 | |                     for (_, entry) in peers {
[INFO] [stdout] 1018 | |                         candidates.push(entry.clone());
[INFO] [stdout] ...    |
[INFO] [stdout] 1021 | |             }
[INFO] [stdout]      | |_____________^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]      |
[INFO] [stdout] 1015 ~             if dist < best_dist
[INFO] [stdout] 1016 ~                 && let Some(peers) = self.peers.get(k) {
[INFO] [stdout] 1017 |                     for (_, entry) in peers {
[INFO] [stdout] 1018 |                         candidates.push(entry.clone());
[INFO] [stdout] 1019 |                     }
[INFO] [stdout] 1020 ~                 }
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]     --> crates/ironwood/src/router.rs:1017:39
[INFO] [stdout]      |
[INFO] [stdout] 1017 |                     for (_, entry) in peers {
[INFO] [stdout]      |                                       ^^^^^
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]      |
[INFO] [stdout] 1017 -                     for (_, entry) in peers {
[INFO] [stdout] 1017 +                     for entry in peers.values() {
[INFO] [stdout]      |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:121:14
[INFO] [stdout]     |
[INFO] [stdout] 121 |             .or_insert_with(HashMap::new)
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]     = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:243:13
[INFO] [stdout]     |
[INFO] [stdout] 243 | /             if let Some(age) = queue.oldest_age() {
[INFO] [stdout] 244 | |                 if age > MAX_PACKET_AGE_SEND {
[INFO] [stdout] 245 | |                     if queue.drop_largest() {
[INFO] [stdout] 246 | |                         tracing::warn!(
[INFO] [stdout] ...   |
[INFO] [stdout] 253 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 243 ~             if let Some(age) = queue.oldest_age()
[INFO] [stdout] 244 ~                 && age > MAX_PACKET_AGE_SEND {
[INFO] [stdout] 245 |                     if queue.drop_largest() {
[INFO] [stdout] ...
[INFO] [stdout] 251 |                     }
[INFO] [stdout] 252 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:244:17
[INFO] [stdout]     |
[INFO] [stdout] 244 | /                 if age > MAX_PACKET_AGE_SEND {
[INFO] [stdout] 245 | |                     if queue.drop_largest() {
[INFO] [stdout] 246 | |                         tracing::warn!(
[INFO] [stdout] 247 | |                             "send_traffic_to_peer[{}]: dropped oldest packet (age={:?} > 25ms) - backpressure applied",
[INFO] [stdout] ...   |
[INFO] [stdout] 252 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 244 ~                 if age > MAX_PACKET_AGE_SEND
[INFO] [stdout] 245 ~                     && queue.drop_largest() {
[INFO] [stdout] 246 |                         tracing::warn!(
[INFO] [stdout] ...
[INFO] [stdout] 250 |                         );
[INFO] [stdout] 251 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (15/7)
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:369:1
[INFO] [stdout]     |
[INFO] [stdout] 369 | / pub(crate) async fn peer_reader(
[INFO] [stdout] 370 | |     peer_id: PeerId,
[INFO] [stdout] 371 | |     peer_key: PublicKey,
[INFO] [stdout] 372 | |     our_key: PublicKey,
[INFO] [stdout] ...   |
[INFO] [stdout] 384 | |     read_deadline: ReadDeadline,
[INFO] [stdout] 385 | | ) -> Result<(), Error> {
[INFO] [stdout]     | |______________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]     = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:404:17
[INFO] [stdout]     |
[INFO] [stdout] 404 | /                 if let Some(d) = deadline {
[INFO] [stdout] 405 | |                     if std::time::Instant::now() >= d {
[INFO] [stdout] 406 | |                         tracing::debug!("peer_reader[{}]: peer timeout ({}ms, no reply from {:02x?}), disconnecting",
[INFO] [stdout] 407 | |                             peer_id, peer_timeout.as_millis(), &peer_key[..8]);
[INFO] [stdout] ...   |
[INFO] [stdout] 411 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 404 ~                 if let Some(d) = deadline
[INFO] [stdout] 405 ~                     && std::time::Instant::now() >= d {
[INFO] [stdout] 406 |                         tracing::debug!("peer_reader[{}]: peer timeout ({}ms, no reply from {:02x?}), disconnecting",
[INFO] [stdout] ...
[INFO] [stdout] 409 |                         break;
[INFO] [stdout] 410 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `types::Error`
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:422:42
[INFO] [stdout]     |
[INFO] [stdout] 422 |                 disconnect_reason = Some(e.into());
[INFO] [stdout]     |                                          ^^^^^^^^ help: consider removing `.into()`: `e`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:479:17
[INFO] [stdout]     |
[INFO] [stdout] 479 | /                 if let Some(peers_map) = router.peers.get(&peer_key) {
[INFO] [stdout] 480 | |                     if let Some(entry) = peers_map.get(&peer_id) {
[INFO] [stdout] 481 | |                         let action = router.handle_request_with_data(entry, &req);
[INFO] [stdout] 482 | |                         drop(router);
[INFO] [stdout] ...   |
[INFO] [stdout] 485 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 479 ~                 if let Some(peers_map) = router.peers.get(&peer_key)
[INFO] [stdout] 480 ~                     && let Some(entry) = peers_map.get(&peer_id) {
[INFO] [stdout] 481 |                         let action = router.handle_request_with_data(entry, &req);
[INFO] [stdout] 482 |                         drop(router);
[INFO] [stdout] 483 |                         dispatch_action(action, &peers).await;
[INFO] [stdout] 484 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (15/7)
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:725:1
[INFO] [stdout]     |
[INFO] [stdout] 725 | / pub(crate) async fn peer_writer(
[INFO] [stdout] 726 | |     peer_id: PeerId,
[INFO] [stdout] 727 | |     peer_key: PublicKey,
[INFO] [stdout] 728 | |     port: PeerPort,
[INFO] [stdout] ...   |
[INFO] [stdout] 740 | |     cancel: CancellationToken,
[INFO] [stdout] 741 | | ) {
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/peers.rs:822:25
[INFO] [stdout]     |
[INFO] [stdout] 822 | /                         if let Some(ptype) = peek_frame_type(&data) {
[INFO] [stdout] 823 | |                             if !matches!(ptype, wire::PacketType::KeepAlive | wire::PacketType::Dummy) {
[INFO] [stdout] 824 | |                                 *read_deadline.lock().unwrap() = Some(std::time::Instant::now() + peer_timeout);
[INFO] [stdout] 825 | |                             }
[INFO] [stdout] 826 | |                         }
[INFO] [stdout]     | |_________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 822 ~                         if let Some(ptype) = peek_frame_type(&data)
[INFO] [stdout] 823 ~                             && !matches!(ptype, wire::PacketType::KeepAlive | wire::PacketType::Dummy) {
[INFO] [stdout] 824 |                                 *read_deadline.lock().unwrap() = Some(std::time::Instant::now() + peer_timeout);
[INFO] [stdout] 825 ~                             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:366:16
[INFO] [stdout]     |
[INFO] [stdout] 366 |             if !(self.recv_nonce < nonce) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.recv_nonce >= nonce)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:371:16
[INFO] [stdout]     |
[INFO] [stdout] 371 |             if !(self.next_send_nonce < nonce) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.next_send_nonce >= nonce)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:376:16
[INFO] [stdout]     |
[INFO] [stdout] 376 |             if !(self.next_recv_nonce < nonce) {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.next_recv_nonce >= nonce)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:425:29
[INFO] [stdout]     |
[INFO] [stdout] 425 |           let should_rotate = self
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 426 | |             .rotated
[INFO] [stdout] 427 | |             .map_or(true, |t| t.elapsed() > Duration::from_secs(60));
[INFO] [stdout]     | |____________________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout] help: use `is_none_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 427 -             .map_or(true, |t| t.elapsed() > Duration::from_secs(60));
[INFO] [stdout] 427 +             .is_none_or(|t| t.elapsed() > Duration::from_secs(60));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:564:13
[INFO] [stdout]     |
[INFO] [stdout] 564 | /             if let Some(buf_data) = buffered_data {
[INFO] [stdout] 565 | |                 if let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 566 | |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] 567 | |                         dest: *from,
[INFO] [stdout] ...   |
[INFO] [stdout] 571 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 564 ~             if let Some(buf_data) = buffered_data
[INFO] [stdout] 565 ~                 && let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 566 |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] ...
[INFO] [stdout] 569 |                     });
[INFO] [stdout] 570 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/ironwood/src/encrypted/session.rs:603:13
[INFO] [stdout]     |
[INFO] [stdout] 603 | /             if let Some(buf_data) = buffered_data {
[INFO] [stdout] 604 | |                 if let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 605 | |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] 606 | |                         dest: *from,
[INFO] [stdout] ...   |
[INFO] [stdout] 610 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 603 ~             if let Some(buf_data) = buffered_data
[INFO] [stdout] 604 ~                 && let Ok(traffic_data) = info.do_send(&buf_data) {
[INFO] [stdout] 605 |                     actions.push(OutAction::SendToInner {
[INFO] [stdout] ...
[INFO] [stdout] 608 |                     });
[INFO] [stdout] 609 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant redefinition of a binding `curve_priv`
[INFO] [stdout]   --> crates/ironwood/src/encrypted/mod.rs:82:13
[INFO] [stdout]    |
[INFO] [stdout] 82 |             let curve_priv = curve_priv;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: `curve_priv` is initially defined here
[INFO] [stdout]   --> crates/ironwood/src/encrypted/mod.rs:69:13
[INFO] [stdout]    |
[INFO] [stdout] 69 |         let curve_priv = ed25519_private_to_curve25519(&secret);
[INFO] [stdout]    |             ^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
[INFO] [stdout]    = note: `#[warn(clippy::redundant_locals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> crates/ironwood/src/encrypted/mod.rs:152:9
[INFO] [stdout]     |
[INFO] [stdout] 152 |         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 152 -         result.sort_by(|a, b| a.key.cmp(&b.key));
[INFO] [stdout] 152 +         result.sort_by_key(|a| a.key);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> crates/yggdrasil/src/admin.rs:486:22
[INFO] [stdout]     |
[INFO] [stdout] 486 |                 .map(|k| hex::encode(k))
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex::encode`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> crates/yggdrasil/src/admin.rs:515:22
[INFO] [stdout]     |
[INFO] [stdout] 515 |                 .map(|k| hex::encode(k))
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex::encode`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:257:9
[INFO] [stdout]     |
[INFO] [stdout] 257 | /         if let Some(buffered) = addr_buf {
[INFO] [stdout] 258 | |             if buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 259 | |                 let addr = Addr(key);
[INFO] [stdout] 260 | |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 261 | |             }
[INFO] [stdout] 262 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 257 ~         if let Some(buffered) = addr_buf
[INFO] [stdout] 258 ~             && buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 259 |                 let addr = Addr(key);
[INFO] [stdout] 260 |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 261 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:264:9
[INFO] [stdout]     |
[INFO] [stdout] 264 | /         if let Some(buffered) = subnet_buf {
[INFO] [stdout] 265 | |             if buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 266 | |                 let addr = Addr(key);
[INFO] [stdout] 267 | |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 268 | |             }
[INFO] [stdout] 269 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 264 ~         if let Some(buffered) = subnet_buf
[INFO] [stdout] 265 ~             && buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 266 |                 let addr = Addr(key);
[INFO] [stdout] 267 |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 268 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`)
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:364:12
[INFO] [stdout]     |
[INFO] [stdout] 364 |     sum += (len >> 16) as u32;
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^ help: try: `(len >> 16)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`)
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:365:12
[INFO] [stdout]     |
[INFO] [stdout] 365 |     sum += (len & 0xFFFF) as u32;
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `(len & 0xFFFF)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `BanList`
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:134:5
[INFO] [stdout]     |
[INFO] [stdout] 134 | /     pub fn new() -> Self {
[INFO] [stdout] 135 | |         Self(Arc::new(Mutex::new(HashMap::new())))
[INFO] [stdout] 136 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 133 + impl Default for BanList {
[INFO] [stdout] 134 +     fn default() -> Self {
[INFO] [stdout] 135 +         Self::new()
[INFO] [stdout] 136 +     }
[INFO] [stdout] 137 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:141:9
[INFO] [stdout]     |
[INFO] [stdout] 141 | /         if let Some(entry) = map.get_mut(&ip) {
[INFO] [stdout] 142 | |             if let Some(banned_until) = entry.banned_until {
[INFO] [stdout] 143 | |                 if Instant::now() < banned_until {
[INFO] [stdout] 144 | |                     return true;
[INFO] [stdout] ...   |
[INFO] [stdout] 152 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 141 ~         if let Some(entry) = map.get_mut(&ip)
[INFO] [stdout] 142 ~             && let Some(banned_until) = entry.banned_until {
[INFO] [stdout] 143 |                 if Instant::now() < banned_until {
[INFO] [stdout] ...
[INFO] [stdout] 150 |                 }
[INFO] [stdout] 151 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `ActiveLinks`
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:347:5
[INFO] [stdout]     |
[INFO] [stdout] 347 | /     pub fn new() -> Self {
[INFO] [stdout] 348 | |         let (peer_tx, _) = broadcast::channel(16);
[INFO] [stdout] 349 | |         Self {
[INFO] [stdout] 350 | |             inner: Arc::new(Mutex::new(ActiveLinksInner {
[INFO] [stdout] ...   |
[INFO] [stdout] 357 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 346 + impl Default for ActiveLinks {
[INFO] [stdout] 347 +     fn default() -> Self {
[INFO] [stdout] 348 +         Self::new()
[INFO] [stdout] 349 +     }
[INFO] [stdout] 350 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:871:5
[INFO] [stdout]     |
[INFO] [stdout] 871 | /     if let Some(ip) = peer_ip {
[INFO] [stdout] 872 | |         if active.ban_list.is_banned(ip).await {
[INFO] [stdout] 873 | |             return Err(format!("IP {} is temporarily banned", ip));
[INFO] [stdout] 874 | |         }
[INFO] [stdout] 875 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 871 ~     if let Some(ip) = peer_ip
[INFO] [stdout] 872 ~         && active.ban_list.is_banned(ip).await {
[INFO] [stdout] 873 |             return Err(format!("IP {} is temporarily banned", ip));
[INFO] [stdout] 874 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:46:21
[INFO] [stdout]    |
[INFO] [stdout] 46 |     self_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]    = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:48:22
[INFO] [stdout]    |
[INFO] [stdout] 48 |     peers_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:50:21
[INFO] [stdout]    |
[INFO] [stdout] 50 |     tree_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:52:25
[INFO] [stdout]    |
[INFO] [stdout] 52 |     nodeinfo_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:81:5
[INFO] [stdout]    |
[INFO] [stdout] 81 | /     pub async fn handle_proto_message(
[INFO] [stdout] 82 | |         &self,
[INFO] [stdout] 83 | |         from_key: [u8; 32],
[INFO] [stdout] 84 | |         payload: &[u8],
[INFO] [stdout] ...  |
[INFO] [stdout] 89 | |         nodeinfo_json: &str,
[INFO] [stdout] 90 | |     ) -> Option<(Addr, Vec<u8>)> {
[INFO] [stdout]    | |________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> crates/yggdrasil/src/proto.rs:119:5
[INFO] [stdout]     |
[INFO] [stdout] 119 | /     async fn handle_debug_message(
[INFO] [stdout] 120 | |         &self,
[INFO] [stdout] 121 | |         from_key: [u8; 32],
[INFO] [stdout] 122 | |         debug_type: u8,
[INFO] [stdout] ...   |
[INFO] [stdout] 127 | |         get_tree_keys: impl Fn() -> Vec<[u8; 32]>,
[INFO] [stdout] 128 | |     ) -> Option<(Addr, Vec<u8>)> {
[INFO] [stdout]     | |________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> crates/yggdrasil/src/admin.rs:486:22
[INFO] [stdout]     |
[INFO] [stdout] 486 |                 .map(|k| hex::encode(k))
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex::encode`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> crates/yggdrasil/src/admin.rs:515:22
[INFO] [stdout]     |
[INFO] [stdout] 515 |                 .map(|k| hex::encode(k))
[INFO] [stdout]     |                      ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex::encode`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:257:9
[INFO] [stdout]     |
[INFO] [stdout] 257 | /         if let Some(buffered) = addr_buf {
[INFO] [stdout] 258 | |             if buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 259 | |                 let addr = Addr(key);
[INFO] [stdout] 260 | |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 261 | |             }
[INFO] [stdout] 262 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 257 ~         if let Some(buffered) = addr_buf
[INFO] [stdout] 258 ~             && buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 259 |                 let addr = Addr(key);
[INFO] [stdout] 260 |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 261 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:264:9
[INFO] [stdout]     |
[INFO] [stdout] 264 | /         if let Some(buffered) = subnet_buf {
[INFO] [stdout] 265 | |             if buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 266 | |                 let addr = Addr(key);
[INFO] [stdout] 267 | |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 268 | |             }
[INFO] [stdout] 269 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 264 ~         if let Some(buffered) = subnet_buf
[INFO] [stdout] 265 ~             && buffered.time.elapsed() < KEY_STORE_TIMEOUT {
[INFO] [stdout] 266 |                 let addr = Addr(key);
[INFO] [stdout] 267 |                 let _ = self.core.write_to(&buffered.data, &addr).await;
[INFO] [stdout] 268 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`)
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:364:12
[INFO] [stdout]     |
[INFO] [stdout] 364 |     sum += (len >> 16) as u32;
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^ help: try: `(len >> 16)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`)
[INFO] [stdout]    --> crates/yggdrasil/src/ipv6rwc.rs:365:12
[INFO] [stdout]     |
[INFO] [stdout] 365 |     sum += (len & 0xFFFF) as u32;
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^ help: try: `(len & 0xFFFF)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `BanList`
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:134:5
[INFO] [stdout]     |
[INFO] [stdout] 134 | /     pub fn new() -> Self {
[INFO] [stdout] 135 | |         Self(Arc::new(Mutex::new(HashMap::new())))
[INFO] [stdout] 136 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 133 + impl Default for BanList {
[INFO] [stdout] 134 +     fn default() -> Self {
[INFO] [stdout] 135 +         Self::new()
[INFO] [stdout] 136 +     }
[INFO] [stdout] 137 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:141:9
[INFO] [stdout]     |
[INFO] [stdout] 141 | /         if let Some(entry) = map.get_mut(&ip) {
[INFO] [stdout] 142 | |             if let Some(banned_until) = entry.banned_until {
[INFO] [stdout] 143 | |                 if Instant::now() < banned_until {
[INFO] [stdout] 144 | |                     return true;
[INFO] [stdout] ...   |
[INFO] [stdout] 152 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 141 ~         if let Some(entry) = map.get_mut(&ip)
[INFO] [stdout] 142 ~             && let Some(banned_until) = entry.banned_until {
[INFO] [stdout] 143 |                 if Instant::now() < banned_until {
[INFO] [stdout] ...
[INFO] [stdout] 150 |                 }
[INFO] [stdout] 151 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `ActiveLinks`
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:347:5
[INFO] [stdout]     |
[INFO] [stdout] 347 | /     pub fn new() -> Self {
[INFO] [stdout] 348 | |         let (peer_tx, _) = broadcast::channel(16);
[INFO] [stdout] 349 | |         Self {
[INFO] [stdout] 350 | |             inner: Arc::new(Mutex::new(ActiveLinksInner {
[INFO] [stdout] ...   |
[INFO] [stdout] 357 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 346 + impl Default for ActiveLinks {
[INFO] [stdout] 347 +     fn default() -> Self {
[INFO] [stdout] 348 +         Self::new()
[INFO] [stdout] 349 +     }
[INFO] [stdout] 350 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/links.rs:871:5
[INFO] [stdout]     |
[INFO] [stdout] 871 | /     if let Some(ip) = peer_ip {
[INFO] [stdout] 872 | |         if active.ban_list.is_banned(ip).await {
[INFO] [stdout] 873 | |             return Err(format!("IP {} is temporarily banned", ip));
[INFO] [stdout] 874 | |         }
[INFO] [stdout] 875 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 871 ~     if let Some(ip) = peer_ip
[INFO] [stdout] 872 ~         && active.ban_list.is_banned(ip).await {
[INFO] [stdout] 873 |             return Err(format!("IP {} is temporarily banned", ip));
[INFO] [stdout] 874 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:46:21
[INFO] [stdout]    |
[INFO] [stdout] 46 |     self_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]    = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:48:22
[INFO] [stdout]    |
[INFO] [stdout] 48 |     peers_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:50:21
[INFO] [stdout]    |
[INFO] [stdout] 50 |     tree_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:52:25
[INFO] [stdout]    |
[INFO] [stdout] 52 |     nodeinfo_callbacks: Arc<Mutex<HashMap<[u8; 32], (Callback, Instant)>>>,
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]   --> crates/yggdrasil/src/proto.rs:81:5
[INFO] [stdout]    |
[INFO] [stdout] 81 | /     pub async fn handle_proto_message(
[INFO] [stdout] 82 | |         &self,
[INFO] [stdout] 83 | |         from_key: [u8; 32],
[INFO] [stdout] 84 | |         payload: &[u8],
[INFO] [stdout] ...  |
[INFO] [stdout] 89 | |         nodeinfo_json: &str,
[INFO] [stdout] 90 | |     ) -> Option<(Addr, Vec<u8>)> {
[INFO] [stdout]    | |________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout]    = note: `#[warn(clippy::too_many_arguments)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this function has too many arguments (8/7)
[INFO] [stdout]    --> crates/yggdrasil/src/proto.rs:119:5
[INFO] [stdout]     |
[INFO] [stdout] 119 | /     async fn handle_debug_message(
[INFO] [stdout] 120 | |         &self,
[INFO] [stdout] 121 | |         from_key: [u8; 32],
[INFO] [stdout] 122 | |         debug_type: u8,
[INFO] [stdout] ...   |
[INFO] [stdout] 127 | |         get_tree_keys: impl Fn() -> Vec<[u8; 32]>,
[INFO] [stdout] 128 | |     ) -> Option<(Addr, Vec<u8>)> {
[INFO] [stdout]     | |________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/yggdrasilctl.rs:357:13
[INFO] [stdout]     |
[INFO] [stdout] 357 | /             if let Some(down) = response.get("peers_down").and_then(|v| v.as_array()) {
[INFO] [stdout] 358 | |                 if !down.is_empty() {
[INFO] [stdout] 359 | |                     println!("\n  Down peers:");
[INFO] [stdout] 360 | |                     for p in down {
[INFO] [stdout] ...   |
[INFO] [stdout] 366 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 357 ~             if let Some(down) = response.get("peers_down").and_then(|v| v.as_array())
[INFO] [stdout] 358 ~                 && !down.is_empty() {
[INFO] [stdout] 359 |                     println!("\n  Down peers:");
[INFO] [stdout] ...
[INFO] [stdout] 364 |                     }
[INFO] [stdout] 365 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/yggdrasilctl.rs:369:13
[INFO] [stdout]     |
[INFO] [stdout] 369 | /             if let Some(lats) = response.get("peer_latencies").and_then(|v| v.as_array()) {
[INFO] [stdout] 370 | |                 if !lats.is_empty() {
[INFO] [stdout] 371 | |                     println!("\n  Peer latencies:");
[INFO] [stdout] 372 | |                     let mut table = Table::new();
[INFO] [stdout] ...   |
[INFO] [stdout] 384 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 369 ~             if let Some(lats) = response.get("peer_latencies").and_then(|v| v.as_array())
[INFO] [stdout] 370 ~                 && !lats.is_empty() {
[INFO] [stdout] 371 |                     println!("\n  Peer latencies:");
[INFO] [stdout] ...
[INFO] [stdout] 382 |                     println!("{}", table);
[INFO] [stdout] 383 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/yggdrasilctl.rs:357:13
[INFO] [stdout]     |
[INFO] [stdout] 357 | /             if let Some(down) = response.get("peers_down").and_then(|v| v.as_array()) {
[INFO] [stdout] 358 | |                 if !down.is_empty() {
[INFO] [stdout] 359 | |                     println!("\n  Down peers:");
[INFO] [stdout] 360 | |                     for p in down {
[INFO] [stdout] ...   |
[INFO] [stdout] 366 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 357 ~             if let Some(down) = response.get("peers_down").and_then(|v| v.as_array())
[INFO] [stdout] 358 ~                 && !down.is_empty() {
[INFO] [stdout] 359 |                     println!("\n  Down peers:");
[INFO] [stdout] ...
[INFO] [stdout] 364 |                     }
[INFO] [stdout] 365 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> crates/yggdrasil/src/yggdrasilctl.rs:369:13
[INFO] [stdout]     |
[INFO] [stdout] 369 | /             if let Some(lats) = response.get("peer_latencies").and_then(|v| v.as_array()) {
[INFO] [stdout] 370 | |                 if !lats.is_empty() {
[INFO] [stdout] 371 | |                     println!("\n  Peer latencies:");
[INFO] [stdout] 372 | |                     let mut table = Table::new();
[INFO] [stdout] ...   |
[INFO] [stdout] 384 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 369 ~             if let Some(lats) = response.get("peer_latencies").and_then(|v| v.as_array())
[INFO] [stdout] 370 ~                 && !lats.is_empty() {
[INFO] [stdout] 371 |                     println!("\n  Peer latencies:");
[INFO] [stdout] ...
[INFO] [stdout] 382 |                     println!("{}", table);
[INFO] [stdout] 383 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 49s
[INFO] running `Command { std: "docker" "inspect" "36077b520b28173680df0fb9e8449ad7fca3dfdd6e1349582c20a2c7ddfc0e16", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "36077b520b28173680df0fb9e8449ad7fca3dfdd6e1349582c20a2c7ddfc0e16", kill_on_drop: false }`
[INFO] [stdout] 36077b520b28173680df0fb9e8449ad7fca3dfdd6e1349582c20a2c7ddfc0e16