[INFO] cloning repository https://github.com/Renmusxd/IsingMonteCarlo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Renmusxd/IsingMonteCarlo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRenmusxd%2FIsingMonteCarlo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRenmusxd%2FIsingMonteCarlo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 970ae53cda04b5f9bbf993cce807979e0c2fbb6b [INFO] linting Renmusxd/IsingMonteCarlo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRenmusxd%2FIsingMonteCarlo" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Renmusxd/IsingMonteCarlo [INFO] finished tweaking git repo https://github.com/Renmusxd/IsingMonteCarlo [INFO] tweaked toml for git repo https://github.com/Renmusxd/IsingMonteCarlo written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Renmusxd/IsingMonteCarlo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (available: v0.14.0) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding rand_chacha v0.3.1 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9971cd6c5caab7db24db1aec08101d1cc70ed13844ed02fe29b2ba714e072c0d [INFO] running `Command { std: "docker" "start" "-a" "9971cd6c5caab7db24db1aec08101d1cc70ed13844ed02fe29b2ba714e072c0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9971cd6c5caab7db24db1aec08101d1cc70ed13844ed02fe29b2ba714e072c0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9971cd6c5caab7db24db1aec08101d1cc70ed13844ed02fe29b2ba714e072c0d", kill_on_drop: false }` [INFO] [stdout] 9971cd6c5caab7db24db1aec08101d1cc70ed13844ed02fe29b2ba714e072c0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 79b1695bf4193095569052734925bf73ac32d284b6d1b173f54198bb757e8f44 [INFO] running `Command { std: "docker" "start" "-a" "79b1695bf4193095569052734925bf73ac32d284b6d1b173f54198bb757e8f44", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking qmc v2.20.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/classical/graph.rs:289:14 [INFO] [stdout] | [INFO] [stdout] 289 | .map(|wm| -> SmallVec<[usize; 2]> { [INFO] [stdout] | ______________^ [INFO] [stdout] 290 | | match wm { [INFO] [stdout] 291 | | WormMove::Single(v) => smallvec![v], [INFO] [stdout] 292 | | WormMove::Double(va, vb) => smallvec![va, vb], [INFO] [stdout] 293 | | } [INFO] [stdout] 294 | | }) [INFO] [stdout] 295 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 289 ~ .flat_map(|wm| -> SmallVec<[usize; 2]> { [INFO] [stdout] 290 + match wm { [INFO] [stdout] 291 + WormMove::Single(v) => smallvec![v], [INFO] [stdout] 292 + WormMove::Double(va, vb) => smallvec![va, vb], [INFO] [stdout] 293 + } [INFO] [stdout] 294 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/classical/graph.rs:445:13 [INFO] [stdout] | [INFO] [stdout] 445 | std::f64::NAN [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 445 - std::f64::NAN [INFO] [stdout] 445 + f64::NAN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/fast_ops.rs:260:47 [INFO] [stdout] | [INFO] [stdout] 260 | vars_to_subvars.resize(nvars, std::usize::MAX); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 260 - vars_to_subvars.resize(nvars, std::usize::MAX); [INFO] [stdout] 260 + vars_to_subvars.resize(nvars, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/fast_ops.rs:292:25 [INFO] [stdout] | [INFO] [stdout] 292 | if i == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 292 - if i == std::usize::MAX { [INFO] [stdout] 292 + if i == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sse/qmc_runner.rs:176:57 [INFO] [stdout] | [INFO] [stdout] 176 | let bond_weights = M::make_bond_weights(&h, num_bonds, |b| bonds_fn(b).0); [INFO] [stdout] | ^^ help: change this to: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sse/qmc_runner.rs:215:43 [INFO] [stdout] | [INFO] [stdout] 215 | m.make_loop_update_with_rng(None, &h, &mut state, &mut rng); [INFO] [stdout] | ^^ help: change this to: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:433:47 [INFO] [stdout] | [INFO] [stdout] 433 | .all(|(a, b)| (a - b).abs() < std::f64::EPSILON) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 433 - .all(|(a, b)| (a - b).abs() < std::f64::EPSILON) [INFO] [stdout] 433 + .all(|(a, b)| (a - b).abs() < f64::EPSILON) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:467:49 [INFO] [stdout] | [INFO] [stdout] 467 | if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 467 - if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] 467 + if (old - item).abs() < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:526:57 [INFO] [stdout] | [INFO] [stdout] 526 | ... if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 526 - if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] 526 + if (old - item).abs() < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:541:57 [INFO] [stdout] | [INFO] [stdout] 541 | ... if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 541 - if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] 541 + if (old - item).abs() < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:649:30 [INFO] [stdout] | [INFO] [stdout] 649 | let mask = !(std::usize::MAX << (self.n << 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 649 - let mask = !(std::usize::MAX << (self.n << 1)); [INFO] [stdout] 649 + let mask = !(usize::MAX << (self.n << 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:652:73 [INFO] [stdout] | [INFO] [stdout] 652 | (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 652 - (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] 652 + (self.mat[indx] - self.mat[(!indx) & mask]).abs() < f64::EPSILON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:657:30 [INFO] [stdout] | [INFO] [stdout] 657 | let mask = !(std::usize::MAX << self.n); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 657 - let mask = !(std::usize::MAX << self.n); [INFO] [stdout] 657 + let mask = !(usize::MAX << self.n); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:660:73 [INFO] [stdout] | [INFO] [stdout] 660 | (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 660 - (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] 660 + (self.mat[indx] - self.mat[(!indx) & mask]).abs() < f64::EPSILON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:230:39 [INFO] [stdout] | [INFO] [stdout] 230 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 230 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 230 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:283:55 [INFO] [stdout] | [INFO] [stdout] 283 | let n_clusters = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 283 - let n_clusters = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 283 + let n_clusters = if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:349:39 [INFO] [stdout] | [INFO] [stdout] 349 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 349 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 349 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/sse/qmc_ising.rs:375:55 [INFO] [stdout] | [INFO] [stdout] 375 | let steps_to_run = updates_in_sweep.unwrap_or((state.len() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `state.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:376:54 [INFO] [stdout] | [INFO] [stdout] 376 | let successes = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 376 - let successes = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 376 + let successes = if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:463:43 [INFO] [stdout] | [INFO] [stdout] 463 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 463 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 463 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:666:39 [INFO] [stdout] | [INFO] [stdout] 666 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 666 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 666 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/sse/qmc_ising.rs:711:32 [INFO] [stdout] | [INFO] [stdout] 711 | let steps_to_run = (state.len() + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `state.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:713:54 [INFO] [stdout] | [INFO] [stdout] 713 | let succs = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 713 - let succs = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 713 + let succs = if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:754:38 [INFO] [stdout] | [INFO] [stdout] 754 | if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 754 - if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 754 + if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:841:34 [INFO] [stdout] | [INFO] [stdout] 841 | if w.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 841 - if w.abs() > std::f64::EPSILON { [INFO] [stdout] 841 + if w.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:966:33 [INFO] [stdout] | [INFO] [stdout] 966 | if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 966 - if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 966 + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `err` [INFO] [stdout] --> src/sse/qmc_traits/op_container.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 285 | / match res { [INFO] [stdout] 286 | | Ok(_) => None, [INFO] [stdout] 287 | | Err(v) => Some(v), [INFO] [stdout] 288 | | } [INFO] [stdout] | |_________^ help: replace with: `res.err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:454:53 [INFO] [stdout] | [INFO] [stdout] 454 | ... *bout = *bout != !cluster_state[subvar]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*bout == cluster_state[subvar]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:693:13 [INFO] [stdout] | [INFO] [stdout] 693 | &ws_for_flip, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `ws_for_flip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:876:45 [INFO] [stdout] | [INFO] [stdout] 876 | ... .zip(Some(bout)) [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 877 | | ... .map(|(subvar, bout)| (subvar, bout)) [INFO] [stdout] | |___________________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:887:27 [INFO] [stdout] | [INFO] [stdout] 887 | if mult < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 887 - if mult < std::f64::EPSILON { [INFO] [stdout] 887 + if mult < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:897:27 [INFO] [stdout] | [INFO] [stdout] 897 | if mult < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 897 - if mult < std::f64::EPSILON { [INFO] [stdout] 897 + if mult < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:1054:1 [INFO] [stdout] | [INFO] [stdout] 1054 | / fn build_cluster( [INFO] [stdout] 1055 | | mut cluster_size: usize, [INFO] [stdout] 1056 | | (init_var, init_flip): (usize, Option), [INFO] [stdout] 1057 | | cutoff: usize, [INFO] [stdout] ... | [INFO] [stdout] 1066 | | CBM: ClusterBoundaryManager, [INFO] [stdout] 1067 | | R: Rng, [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:1200:11 [INFO] [stdout] | [INFO] [stdout] 1200 | < std::f64::EPSILON; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1200 - < std::f64::EPSILON; [INFO] [stdout] 1200 + < f64::EPSILON; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:166:14 [INFO] [stdout] | [INFO] [stdout] 166 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:196:14 [INFO] [stdout] | [INFO] [stdout] 196 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:211:14 [INFO] [stdout] | [INFO] [stdout] 211 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:225:14 [INFO] [stdout] | [INFO] [stdout] 225 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:240:14 [INFO] [stdout] | [INFO] [stdout] 240 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:254:14 [INFO] [stdout] | [INFO] [stdout] 254 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:268:14 [INFO] [stdout] | [INFO] [stdout] 268 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:285:14 [INFO] [stdout] | [INFO] [stdout] 285 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/util/bondcontainer.rs:81:49 [INFO] [stdout] | [INFO] [stdout] 81 | let valid = weight_sum.abs() <= std::f64::EPSILON * self.keys.len() as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 81 - let valid = weight_sum.abs() <= std::f64::EPSILON * self.keys.len() as f64; [INFO] [stdout] 81 + let valid = weight_sum.abs() <= f64::EPSILON * self.keys.len() as f64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sse/qmc_ising.rs:169:25 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn make_haminfo(&self) -> HamInfo { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 169 | pub fn make_haminfo(&self) -> HamInfo<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/check_loop_crash.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / vec![( [INFO] [stdout] 11 | | 0, [INFO] [stdout] 12 | | FastOp::diagonal(smallvec![0, 1], 0, smallvec![false, false], false), [INFO] [stdout] 13 | | )] [INFO] [stdout] 14 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 13 - )] [INFO] [stdout] 14 - .into_iter(), [INFO] [stdout] 13 + )], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/check_loop_crash.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / vec![ [INFO] [stdout] 43 | | ( [INFO] [stdout] 44 | | 0, [INFO] [stdout] 45 | | FastOp::diagonal(smallvec![0, 1], 0, smallvec![false, false], false), [INFO] [stdout] ... | [INFO] [stdout] 52 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 51 - ] [INFO] [stdout] 52 - .into_iter(), [INFO] [stdout] 51 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/cluster_test.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | / vec![( [INFO] [stdout] 11 | | 0, [INFO] [stdout] 12 | | FastOp::offdiagonal(smallvec![0], 0, smallvec![false], smallvec![false], true), [INFO] [stdout] 13 | | )] [INFO] [stdout] 14 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 13 - )] [INFO] [stdout] 14 - .into_iter(), [INFO] [stdout] 13 + )], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/cluster_test.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / vec![ [INFO] [stdout] 28 | | ( [INFO] [stdout] 29 | | 0, [INFO] [stdout] 30 | | FastOp::offdiagonal(smallvec![0], 0, smallvec![false], smallvec![false], true), [INFO] [stdout] ... | [INFO] [stdout] 37 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 36 - ] [INFO] [stdout] 37 - .into_iter(), [INFO] [stdout] 36 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/cluster_test.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / vec![ [INFO] [stdout] 51 | | ( [INFO] [stdout] 52 | | 0, [INFO] [stdout] 53 | | FastOp::offdiagonal(smallvec![0], 0, smallvec![false], smallvec![false], true), [INFO] [stdout] ... | [INFO] [stdout] 68 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 67 - ] [INFO] [stdout] 68 - .into_iter(), [INFO] [stdout] 67 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> tests/longitudinal_crash.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | .map(|i| (0usize..l).map(|j| (i, j)).collect::>()) [INFO] [stdout] | __________^ [INFO] [stdout] 8 | | .flatten() [INFO] [stdout] | |__________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|i| (0usize..l).map(|j| (i, j)).collect::>())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> tests/check_rvb_crash.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | .map(|i| (0usize..l).map(|j| (i, j)).collect::>()) [INFO] [stdout] | __________^ [INFO] [stdout] 10 | | .flatten() [INFO] [stdout] | |__________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|i| (0usize..l).map(|j| (i, j)).collect::>())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/check_rvb_crash.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / vec![ [INFO] [stdout] 73 | | ( [INFO] [stdout] 74 | | 0, [INFO] [stdout] 75 | | FastOp::offdiagonal(smallvec![0], 0, smallvec![false], smallvec![false], true), [INFO] [stdout] ... | [INFO] [stdout] 82 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 81 - ] [INFO] [stdout] 82 - .into_iter(), [INFO] [stdout] 81 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/check_rvb_crash.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | / vec![ [INFO] [stdout] 116 | | ( [INFO] [stdout] 117 | | 0, [INFO] [stdout] 118 | | FastOp::offdiagonal(smallvec![0], 0, smallvec![false], smallvec![false], true), [INFO] [stdout] ... | [INFO] [stdout] 133 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 132 - ] [INFO] [stdout] 133 - .into_iter(), [INFO] [stdout] 132 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> examples/crash_check.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | .map(|i| { [INFO] [stdout] | __________^ [INFO] [stdout] 14 | | (0usize..side_len) [INFO] [stdout] 15 | | .map(|j| (i, j)) [INFO] [stdout] 16 | | .collect::>() [INFO] [stdout] 17 | | }) [INFO] [stdout] 18 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 13 ~ .flat_map(|i| { [INFO] [stdout] 14 + (0usize..side_len) [INFO] [stdout] 15 + .map(|j| (i, j)) [INFO] [stdout] 16 + .collect::>() [INFO] [stdout] 17 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/check_rvb_crash.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | / vec![ [INFO] [stdout] 174 | | ( [INFO] [stdout] 175 | | 0, [INFO] [stdout] 176 | | FastOp::offdiagonal(smallvec![0], 2, smallvec![false], smallvec![false], true), [INFO] [stdout] ... | [INFO] [stdout] 195 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 194 - ] [INFO] [stdout] 195 - .into_iter(), [INFO] [stdout] 194 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/check_rvb_crash.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / vec![ [INFO] [stdout] 229 | | ( [INFO] [stdout] 230 | | 0, [INFO] [stdout] 231 | | FastOp::offdiagonal(smallvec![0], 2, smallvec![false], smallvec![false], true), [INFO] [stdout] ... | [INFO] [stdout] 266 | | .into_iter(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 265 - ] [INFO] [stdout] 266 - .into_iter(), [INFO] [stdout] 265 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/classical/graph.rs:289:14 [INFO] [stdout] | [INFO] [stdout] 289 | .map(|wm| -> SmallVec<[usize; 2]> { [INFO] [stdout] | ______________^ [INFO] [stdout] 290 | | match wm { [INFO] [stdout] 291 | | WormMove::Single(v) => smallvec![v], [INFO] [stdout] 292 | | WormMove::Double(va, vb) => smallvec![va, vb], [INFO] [stdout] 293 | | } [INFO] [stdout] 294 | | }) [INFO] [stdout] 295 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 289 ~ .flat_map(|wm| -> SmallVec<[usize; 2]> { [INFO] [stdout] 290 + match wm { [INFO] [stdout] 291 + WormMove::Single(v) => smallvec![v], [INFO] [stdout] 292 + WormMove::Double(va, vb) => smallvec![va, vb], [INFO] [stdout] 293 + } [INFO] [stdout] 294 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/classical/graph.rs:445:13 [INFO] [stdout] | [INFO] [stdout] 445 | std::f64::NAN [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 445 - std::f64::NAN [INFO] [stdout] 445 + f64::NAN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/classical/graph.rs:463:14 [INFO] [stdout] | [INFO] [stdout] 463 | .map(|i| (0usize..l).map(|j| (i, j)).collect::>()) [INFO] [stdout] | ______________^ [INFO] [stdout] 464 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|i| (0usize..l).map(|j| (i, j)).collect::>())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> benches/end_to_end.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|i| (0usize..l).map(|j| (i, j)).collect::>()) [INFO] [stdout] | __________^ [INFO] [stdout] 15 | | .flatten() [INFO] [stdout] | |__________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|i| (0usize..l).map(|j| (i, j)).collect::>())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/fast_ops.rs:260:47 [INFO] [stdout] | [INFO] [stdout] 260 | vars_to_subvars.resize(nvars, std::usize::MAX); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 260 - vars_to_subvars.resize(nvars, std::usize::MAX); [INFO] [stdout] 260 + vars_to_subvars.resize(nvars, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/fast_ops.rs:292:25 [INFO] [stdout] | [INFO] [stdout] 292 | if i == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 292 - if i == std::usize::MAX { [INFO] [stdout] 292 + if i == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sse/qmc_runner.rs:176:57 [INFO] [stdout] | [INFO] [stdout] 176 | let bond_weights = M::make_bond_weights(&h, num_bonds, |b| bonds_fn(b).0); [INFO] [stdout] | ^^ help: change this to: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sse/qmc_runner.rs:215:43 [INFO] [stdout] | [INFO] [stdout] 215 | m.make_loop_update_with_rng(None, &h, &mut state, &mut rng); [INFO] [stdout] | ^^ help: change this to: `h` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:433:47 [INFO] [stdout] | [INFO] [stdout] 433 | .all(|(a, b)| (a - b).abs() < std::f64::EPSILON) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 433 - .all(|(a, b)| (a - b).abs() < std::f64::EPSILON) [INFO] [stdout] 433 + .all(|(a, b)| (a - b).abs() < f64::EPSILON) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:467:49 [INFO] [stdout] | [INFO] [stdout] 467 | if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 467 - if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] 467 + if (old - item).abs() < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:526:57 [INFO] [stdout] | [INFO] [stdout] 526 | ... if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 526 - if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] 526 + if (old - item).abs() < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:541:57 [INFO] [stdout] | [INFO] [stdout] 541 | ... if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 541 - if (old - item).abs() < std::f64::EPSILON { [INFO] [stdout] 541 + if (old - item).abs() < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:649:30 [INFO] [stdout] | [INFO] [stdout] 649 | let mask = !(std::usize::MAX << (self.n << 1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 649 - let mask = !(std::usize::MAX << (self.n << 1)); [INFO] [stdout] 649 + let mask = !(usize::MAX << (self.n << 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:652:73 [INFO] [stdout] | [INFO] [stdout] 652 | (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 652 - (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] 652 + (self.mat[indx] - self.mat[(!indx) & mask]).abs() < f64::EPSILON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:657:30 [INFO] [stdout] | [INFO] [stdout] 657 | let mask = !(std::usize::MAX << self.n); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 657 - let mask = !(std::usize::MAX << self.n); [INFO] [stdout] 657 + let mask = !(usize::MAX << self.n); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_runner.rs:660:73 [INFO] [stdout] | [INFO] [stdout] 660 | (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 660 - (self.mat[indx] - self.mat[(!indx) & mask]).abs() < std::f64::EPSILON [INFO] [stdout] 660 + (self.mat[indx] - self.mat[(!indx) & mask]).abs() < f64::EPSILON [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:230:39 [INFO] [stdout] | [INFO] [stdout] 230 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 230 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 230 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:283:55 [INFO] [stdout] | [INFO] [stdout] 283 | let n_clusters = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 283 - let n_clusters = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 283 + let n_clusters = if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:349:39 [INFO] [stdout] | [INFO] [stdout] 349 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 349 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 349 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/sse/qmc_ising.rs:375:55 [INFO] [stdout] | [INFO] [stdout] 375 | let steps_to_run = updates_in_sweep.unwrap_or((state.len() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `state.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:376:54 [INFO] [stdout] | [INFO] [stdout] 376 | let successes = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 376 - let successes = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 376 + let successes = if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:463:43 [INFO] [stdout] | [INFO] [stdout] 463 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 463 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 463 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:666:39 [INFO] [stdout] | [INFO] [stdout] 666 | + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 666 - + if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 666 + + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/sse/qmc_ising.rs:711:32 [INFO] [stdout] | [INFO] [stdout] 711 | let steps_to_run = (state.len() + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `state.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:713:54 [INFO] [stdout] | [INFO] [stdout] 713 | let succs = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 713 - let succs = if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 713 + let succs = if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:754:38 [INFO] [stdout] | [INFO] [stdout] 754 | if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 754 - if self.longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 754 + if self.longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:841:34 [INFO] [stdout] | [INFO] [stdout] 841 | if w.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 841 - if w.abs() > std::f64::EPSILON { [INFO] [stdout] 841 + if w.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_ising.rs:966:33 [INFO] [stdout] | [INFO] [stdout] 966 | if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 966 - if longitudinal.abs() > std::f64::EPSILON { [INFO] [stdout] 966 + if longitudinal.abs() > f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `err` [INFO] [stdout] --> src/sse/qmc_traits/op_container.rs:285:9 [INFO] [stdout] | [INFO] [stdout] 285 | / match res { [INFO] [stdout] 286 | | Ok(_) => None, [INFO] [stdout] 287 | | Err(v) => Some(v), [INFO] [stdout] 288 | | } [INFO] [stdout] | |_________^ help: replace with: `res.err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:454:53 [INFO] [stdout] | [INFO] [stdout] 454 | ... *bout = *bout != !cluster_state[subvar]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*bout == cluster_state[subvar]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:693:13 [INFO] [stdout] | [INFO] [stdout] 693 | &ws_for_flip, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `ws_for_flip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:876:45 [INFO] [stdout] | [INFO] [stdout] 876 | ... .zip(Some(bout)) [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 877 | | ... .map(|(subvar, bout)| (subvar, bout)) [INFO] [stdout] | |___________________________________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:887:27 [INFO] [stdout] | [INFO] [stdout] 887 | if mult < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 887 - if mult < std::f64::EPSILON { [INFO] [stdout] 887 + if mult < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:897:27 [INFO] [stdout] | [INFO] [stdout] 897 | if mult < std::f64::EPSILON { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 897 - if mult < std::f64::EPSILON { [INFO] [stdout] 897 + if mult < f64::EPSILON { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:1054:1 [INFO] [stdout] | [INFO] [stdout] 1054 | / fn build_cluster( [INFO] [stdout] 1055 | | mut cluster_size: usize, [INFO] [stdout] 1056 | | (init_var, init_flip): (usize, Option), [INFO] [stdout] 1057 | | cutoff: usize, [INFO] [stdout] ... | [INFO] [stdout] 1066 | | CBM: ClusterBoundaryManager, [INFO] [stdout] 1067 | | R: Rng, [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:1200:11 [INFO] [stdout] | [INFO] [stdout] 1200 | < std::f64::EPSILON; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 1200 - < std::f64::EPSILON; [INFO] [stdout] 1200 + < f64::EPSILON; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/sse/qmc_traits/rvb.rs:1293:17 [INFO] [stdout] | [INFO] [stdout] 1293 | / vec![ [INFO] [stdout] 1294 | | ( [INFO] [stdout] 1295 | | 0, [INFO] [stdout] 1296 | | FastOp::offdiagonal( [INFO] [stdout] ... | [INFO] [stdout] 1379 | | .into_iter(), [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/sse/fast_ops.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 82 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1378 - ] [INFO] [stdout] 1379 - .into_iter(), [INFO] [stdout] 1378 + ], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:166:14 [INFO] [stdout] | [INFO] [stdout] 166 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:196:14 [INFO] [stdout] | [INFO] [stdout] 196 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:211:14 [INFO] [stdout] | [INFO] [stdout] 211 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:225:14 [INFO] [stdout] | [INFO] [stdout] 225 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:240:14 [INFO] [stdout] | [INFO] [stdout] 240 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:254:14 [INFO] [stdout] | [INFO] [stdout] 254 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:268:14 [INFO] [stdout] | [INFO] [stdout] 268 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/sse/fast_op_alloc.rs:285:14 [INFO] [stdout] | [INFO] [stdout] 285 | .unwrap_or_else(Default::default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/util/bondcontainer.rs:81:49 [INFO] [stdout] | [INFO] [stdout] 81 | let valid = weight_sum.abs() <= std::f64::EPSILON * self.keys.len() as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 81 - let valid = weight_sum.abs() <= std::f64::EPSILON * self.keys.len() as f64; [INFO] [stdout] 81 + let valid = weight_sum.abs() <= f64::EPSILON * self.keys.len() as f64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/sse/qmc_ising.rs:169:25 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn make_haminfo(&self) -> HamInfo { [INFO] [stdout] | ^^^^^ ^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 169 | pub fn make_haminfo(&self) -> HamInfo<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.07s [INFO] running `Command { std: "docker" "inspect" "79b1695bf4193095569052734925bf73ac32d284b6d1b173f54198bb757e8f44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79b1695bf4193095569052734925bf73ac32d284b6d1b173f54198bb757e8f44", kill_on_drop: false }` [INFO] [stdout] 79b1695bf4193095569052734925bf73ac32d284b6d1b173f54198bb757e8f44