[INFO] cloning repository https://github.com/Ray-D-Song/thumb-book [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ray-D-Song/thumb-book" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRay-D-Song%2Fthumb-book", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRay-D-Song%2Fthumb-book'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c1f896167d14b5b8abf5a0243f7bdaa777a5db47 [INFO] linting Ray-D-Song/thumb-book against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRay-D-Song%2Fthumb-book" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Ray-D-Song/thumb-book [INFO] finished tweaking git repo https://github.com/Ray-D-Song/thumb-book [INFO] tweaked toml for git repo https://github.com/Ray-D-Song/thumb-book written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Ray-D-Song/thumb-book on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Ray-D-Song/thumb-book already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26c10191cf201189b325459f21829af7a301a61a3f6dd2a30d8648a21b631d6b [INFO] running `Command { std: "docker" "start" "-a" "26c10191cf201189b325459f21829af7a301a61a3f6dd2a30d8648a21b631d6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26c10191cf201189b325459f21829af7a301a61a3f6dd2a30d8648a21b631d6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26c10191cf201189b325459f21829af7a301a61a3f6dd2a30d8648a21b631d6b", kill_on_drop: false }` [INFO] [stdout] 26c10191cf201189b325459f21829af7a301a61a3f6dd2a30d8648a21b631d6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b94536fb95082c38dca2a704df798f6344075f9d13bee555b3a9929dabad2db8 [INFO] running `Command { std: "docker" "start" "-a" "b94536fb95082c38dca2a704df798f6344075f9d13bee555b3a9929dabad2db8", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Checking unicase v2.8.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking thumb-book v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/libs/process.rs:54:73 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn process_index(index_path: &str, output_index_path: &str, routes: &Vec) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - pub fn process_index(index_path: &str, output_index_path: &str, routes: &Vec) -> Result<(), Box> { [INFO] [stdout] 54 + pub fn process_index(index_path: &str, output_index_path: &str, routes: &[String]) -> Result<(), Box> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/process.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | .replace("{{title}}", &config.get("title").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `config.get("title").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/check.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | if !std::fs::metadata(&config_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&config_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/check.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !std::fs::metadata(&posts_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&posts_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/check.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !std::fs::metadata(&posts_output_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&posts_output_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/libs/generate.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn generate_routes(posts_vec: &Vec) -> Result, Box> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 ~ pub fn generate_routes(posts_vec: &[Post]) -> Result, Box> { [INFO] [stdout] 5 | let mut a_tags = Vec::new(); [INFO] [stdout] 6 ~ let mut sorted_posts = posts_vec.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/libs/generate.rs:26:41 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_search_index(posts_vec: &Vec) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn generate_search_index(posts_vec: &Vec) -> Result<(), Box> { [INFO] [stdout] 26 + pub fn generate_search_index(posts_vec: &[Post]) -> Result<(), Box> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 34 | let posts_vec = process_posts(&posts_dir.to_str().unwrap(), &posts_output_dir.to_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `posts_dir.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:34:65 [INFO] [stdout] | [INFO] [stdout] 34 | let posts_vec = process_posts(&posts_dir.to_str().unwrap(), &posts_output_dir.to_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `posts_output_dir.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | let _ = process_index(¤t_dir.join("index.md").to_str().unwrap(), &output_index_path.to_str().unwrap(), &routes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `current_dir.join("index.md").to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:40:76 [INFO] [stdout] | [INFO] [stdout] 40 | let _ = process_index(¤t_dir.join("index.md").to_str().unwrap(), &output_index_path.to_str().unwrap(), &routes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `output_index_path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/libs/process.rs:54:73 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn process_index(index_path: &str, output_index_path: &str, routes: &Vec) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - pub fn process_index(index_path: &str, output_index_path: &str, routes: &Vec) -> Result<(), Box> { [INFO] [stdout] 54 + pub fn process_index(index_path: &str, output_index_path: &str, routes: &[String]) -> Result<(), Box> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libs/process.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | .replace("{{title}}", &config.get("title").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `config.get("title").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/check.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | if !std::fs::metadata(&config_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&config_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/check.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !std::fs::metadata(&posts_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&posts_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/check.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | if !std::fs::metadata(&posts_output_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&posts_output_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/libs/generate.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn generate_routes(posts_vec: &Vec) -> Result, Box> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 ~ pub fn generate_routes(posts_vec: &[Post]) -> Result, Box> { [INFO] [stdout] 5 | let mut a_tags = Vec::new(); [INFO] [stdout] 6 ~ let mut sorted_posts = posts_vec.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/libs/generate.rs:26:41 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn generate_search_index(posts_vec: &Vec) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn generate_search_index(posts_vec: &Vec) -> Result<(), Box> { [INFO] [stdout] 26 + pub fn generate_search_index(posts_vec: &[Post]) -> Result<(), Box> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 34 | let posts_vec = process_posts(&posts_dir.to_str().unwrap(), &posts_output_dir.to_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `posts_dir.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:34:65 [INFO] [stdout] | [INFO] [stdout] 34 | let posts_vec = process_posts(&posts_dir.to_str().unwrap(), &posts_output_dir.to_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `posts_output_dir.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | let _ = process_index(¤t_dir.join("index.md").to_str().unwrap(), &output_index_path.to_str().unwrap(), &routes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `current_dir.join("index.md").to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:40:76 [INFO] [stdout] | [INFO] [stdout] 40 | let _ = process_index(¤t_dir.join("index.md").to_str().unwrap(), &output_index_path.to_str().unwrap(), &routes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `output_index_path.to_str().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.25s [INFO] running `Command { std: "docker" "inspect" "b94536fb95082c38dca2a704df798f6344075f9d13bee555b3a9929dabad2db8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b94536fb95082c38dca2a704df798f6344075f9d13bee555b3a9929dabad2db8", kill_on_drop: false }` [INFO] [stdout] b94536fb95082c38dca2a704df798f6344075f9d13bee555b3a9929dabad2db8