[INFO] cloning repository https://github.com/Raxmo/PackardV3
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Raxmo/PackardV3" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaxmo%2FPackardV3", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaxmo%2FPackardV3'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 33087d0150f15bd11f2c528d12b06c5d545812e3
[INFO] linting Raxmo/PackardV3 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaxmo%2FPackardV3" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Raxmo/PackardV3
[INFO] finished tweaking git repo https://github.com/Raxmo/PackardV3
[INFO] tweaked toml for git repo https://github.com/Raxmo/PackardV3 written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Raxmo/PackardV3 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Raxmo/PackardV3 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] b3574667262230230e416dd8cf8cba6fce5841da202d52b3e0ad5b7c6dab8d13
[INFO] running `Command { std: "docker" "start" "-a" "b3574667262230230e416dd8cf8cba6fce5841da202d52b3e0ad5b7c6dab8d13", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "b3574667262230230e416dd8cf8cba6fce5841da202d52b3e0ad5b7c6dab8d13", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b3574667262230230e416dd8cf8cba6fce5841da202d52b3e0ad5b7c6dab8d13", kill_on_drop: false }`
[INFO] [stdout] b3574667262230230e416dd8cf8cba6fce5841da202d52b3e0ad5b7c6dab8d13
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] d0276d727223af171fec7736fa15c82d903cf9eed5975b39aa7a9d58c1fa2af5
[INFO] running `Command { std: "docker" "start" "-a" "d0276d727223af171fec7736fa15c82d903cf9eed5975b39aa7a9d58c1fa2af5", kill_on_drop: false }`
[INFO] [stderr]    Compiling serde v1.0.228
[INFO] [stderr]     Checking indexmap v2.12.1
[INFO] [stderr]     Checking iana-time-zone v0.1.64
[INFO] [stderr]     Checking chrono v0.4.42
[INFO] [stderr]     Checking serde_yaml v0.9.34+deprecated
[INFO] [stderr]     Checking packard-core v0.1.0 (/opt/rustwide/workdir/packard-core)
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]   --> packard-core/src/effects.rs:85:18
[INFO] [stdout]    |
[INFO] [stdout] 85 |         let re = Regex::new(r"^([a-z_][a-z0-9_.]*)\s*(\+=|-=|=)\s*(.+)$")
[INFO] [stdout]    |                  ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]   --> packard-core/src/effects.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     for effect_expr in effects_str.split(';') {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]    = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> packard-core/src/runtime.rs:13:12
[INFO] [stdout]    |
[INFO] [stdout] 13 |         if !vault.get_scene(start_scene).is_some() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vault.get_scene(start_scene).is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> packard-core/src/runtime.rs:62:12
[INFO] [stdout]    |
[INFO] [stdout] 62 |         if !self.vault.get_scene(&next_id).is_some() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vault.get_scene(&next_id).is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Checking packard-cli v0.1.0 (/opt/rustwide/workdir/packard-cli)
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]   --> packard-core/src/effects.rs:85:18
[INFO] [stdout]    |
[INFO] [stdout] 85 |         let re = Regex::new(r"^([a-z_][a-z0-9_.]*)\s*(\+=|-=|=)\s*(.+)$")
[INFO] [stdout]    |                  ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]   --> packard-core/src/effects.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     for effect_expr in effects_str.split(';') {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]    = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> packard-core/src/conditions.rs:158:9
[INFO] [stdout]     |
[INFO] [stdout] 158 |         assert_eq!(cond.evaluate(&state).unwrap(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 158 -         assert_eq!(cond.evaluate(&state).unwrap(), true);
[INFO] [stdout] 158 +         assert!(cond.evaluate(&state).unwrap());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> packard-core/src/conditions.rs:167:9
[INFO] [stdout]     |
[INFO] [stdout] 167 |         assert_eq!(cond.evaluate(&state).unwrap(), false);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 167 -         assert_eq!(cond.evaluate(&state).unwrap(), false);
[INFO] [stdout] 167 +         assert!(!cond.evaluate(&state).unwrap());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> packard-core/src/conditions.rs:190:9
[INFO] [stdout]     |
[INFO] [stdout] 190 |         assert_eq!(cond.evaluate(&state).unwrap(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 190 -         assert_eq!(cond.evaluate(&state).unwrap(), true);
[INFO] [stdout] 190 +         assert!(cond.evaluate(&state).unwrap());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> packard-core/src/conditions.rs:200:9
[INFO] [stdout]     |
[INFO] [stdout] 200 |         assert_eq!(cond.evaluate(&state).unwrap(), false);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 200 -         assert_eq!(cond.evaluate(&state).unwrap(), false);
[INFO] [stdout] 200 +         assert!(!cond.evaluate(&state).unwrap());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> packard-core/src/conditions.rs:210:9
[INFO] [stdout]     |
[INFO] [stdout] 210 |         assert_eq!(cond.evaluate(&state).unwrap(), true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 210 -         assert_eq!(cond.evaluate(&state).unwrap(), true);
[INFO] [stdout] 210 +         assert!(cond.evaluate(&state).unwrap());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> packard-core/src/conditions.rs:220:9
[INFO] [stdout]     |
[INFO] [stdout] 220 |         assert_eq!(cond.evaluate(&state).unwrap(), false);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 220 -         assert_eq!(cond.evaluate(&state).unwrap(), false);
[INFO] [stdout] 220 +         assert!(!cond.evaluate(&state).unwrap());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> packard-core/src/runtime.rs:13:12
[INFO] [stdout]    |
[INFO] [stdout] 13 |         if !vault.get_scene(start_scene).is_some() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vault.get_scene(start_scene).is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> packard-core/src/runtime.rs:62:12
[INFO] [stdout]    |
[INFO] [stdout] 62 |         if !self.vault.get_scene(&next_id).is_some() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vault.get_scene(&next_id).is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.08s
[INFO] running `Command { std: "docker" "inspect" "d0276d727223af171fec7736fa15c82d903cf9eed5975b39aa7a9d58c1fa2af5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d0276d727223af171fec7736fa15c82d903cf9eed5975b39aa7a9d58c1fa2af5", kill_on_drop: false }`
[INFO] [stdout] d0276d727223af171fec7736fa15c82d903cf9eed5975b39aa7a9d58c1fa2af5