[INFO] cloning repository https://github.com/Raven-Book/raven-oss-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Raven-Book/raven-oss-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaven-Book%2Fraven-oss-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaven-Book%2Fraven-oss-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2da3c47e01ef7bb00a5bf0803f701ead0460b89d [INFO] linting Raven-Book/raven-oss-tools against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaven-Book%2Fraven-oss-tools" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Raven-Book/raven-oss-tools [INFO] finished tweaking git repo https://github.com/Raven-Book/raven-oss-tools [INFO] tweaked toml for git repo https://github.com/Raven-Book/raven-oss-tools written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Raven-Book/raven-oss-tools on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Raven-Book/raven-oss-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded windows-targets v0.52.4 [INFO] [stderr] Downloaded clap_lex v0.7.1 [INFO] [stderr] Downloaded aws-smithy-xml v0.60.8 [INFO] [stderr] Downloaded rfc6979 v0.3.1 [INFO] [stderr] Downloaded aws-smithy-query v0.60.7 [INFO] [stderr] Downloaded base64-simd v0.8.0 [INFO] [stderr] Downloaded base16ct v0.1.1 [INFO] [stderr] Downloaded ff v0.12.1 [INFO] [stderr] Downloaded crc32c v0.6.8 [INFO] [stderr] Downloaded group v0.12.1 [INFO] [stderr] Downloaded ecdsa v0.14.8 [INFO] [stderr] Downloaded signature v1.6.4 [INFO] [stderr] Downloaded aws-sigv4 v1.2.3 [INFO] [stderr] Downloaded security-framework-sys v2.9.1 [INFO] [stderr] Downloaded async-trait v0.1.81 [INFO] [stderr] Downloaded aws-sdk-sso v1.36.0 [INFO] [stderr] Downloaded crypto-bigint v0.5.5 [INFO] [stderr] Downloaded aws-sdk-ssooidc v1.37.0 [INFO] [stderr] Downloaded aws-sdk-sts v1.36.0 [INFO] [stderr] Downloaded aws-config v1.5.4 [INFO] [stderr] Downloaded h2 v0.3.25 [INFO] [stderr] Downloaded hyper v0.14.28 [INFO] [stderr] Downloaded clap_builder v4.5.11 [INFO] [stderr] Downloaded serde_json v1.0.120 [INFO] [stderr] Downloaded aws-smithy-runtime v1.6.2 [INFO] [stderr] Downloaded syn v2.0.55 [INFO] [stderr] Downloaded tokio-util v0.7.10 [INFO] [stderr] Downloaded der v0.6.1 [INFO] [stderr] Downloaded rustls v0.21.10 [INFO] [stderr] Downloaded security-framework v2.9.2 [INFO] [stderr] Downloaded aws-smithy-runtime-api v1.7.1 [INFO] [stderr] Downloaded cc v1.0.90 [INFO] [stderr] Downloaded mio v1.0.1 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.52.4 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.52.4 [INFO] [stderr] Downloaded p256 v0.11.1 [INFO] [stderr] Downloaded num-traits v0.2.18 [INFO] [stderr] Downloaded aws-smithy-types v1.2.0 [INFO] [stderr] Downloaded regex-lite v0.1.5 [INFO] [stderr] Downloaded clap v4.5.11 [INFO] [stderr] Downloaded proc-macro2 v1.0.79 [INFO] [stderr] Downloaded aws-runtime v1.3.1 [INFO] [stderr] Downloaded crypto-bigint v0.4.9 [INFO] [stderr] Downloaded sec1 v0.3.0 [INFO] [stderr] Downloaded elliptic-curve v0.12.3 [INFO] [stderr] Downloaded aws-smithy-json v0.60.7 [INFO] [stderr] Downloaded crc32fast v1.4.0 [INFO] [stderr] Downloaded vsimd v0.8.0 [INFO] [stderr] Downloaded semver v1.0.22 [INFO] [stderr] Downloaded clap_derive v4.5.11 [INFO] [stderr] Downloaded xmlparser v0.13.6 [INFO] [stderr] Downloaded tokio v1.39.1 [INFO] [stderr] Downloaded aws-smithy-async v1.2.1 [INFO] [stderr] Downloaded aws-types v1.3.3 [INFO] [stderr] Downloaded aws-smithy-eventstream v0.60.4 [INFO] [stderr] Downloaded aws-smithy-http v0.60.9 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.52.4 [INFO] [stderr] Downloaded windows_i686_gnu v0.52.4 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.52.4 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.52.4 [INFO] [stderr] Downloaded rustls-native-certs v0.6.3 [INFO] [stderr] Downloaded windows_i686_msvc v0.52.4 [INFO] [stderr] Downloaded either v1.10.0 [INFO] [stderr] Downloaded spki v0.6.0 [INFO] [stderr] Downloaded pkcs8 v0.9.0 [INFO] [stderr] Downloaded aws-smithy-checksums v0.60.11 [INFO] [stderr] Downloaded bytes-utils v0.1.4 [INFO] [stderr] Downloaded fastrand v2.0.2 [INFO] [stderr] Downloaded anstyle-query v1.1.0 [INFO] [stderr] Downloaded aws-credential-types v1.2.0 [INFO] [stderr] Downloaded outref v0.5.1 [INFO] [stderr] Downloaded aws-sdk-s3 v1.42.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89eeef2bd8250c6338f0402ee1b79e1a49c0fb3b97ecd82b911449f6c3a4b2cc [INFO] running `Command { std: "docker" "start" "-a" "89eeef2bd8250c6338f0402ee1b79e1a49c0fb3b97ecd82b911449f6c3a4b2cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89eeef2bd8250c6338f0402ee1b79e1a49c0fb3b97ecd82b911449f6c3a4b2cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89eeef2bd8250c6338f0402ee1b79e1a49c0fb3b97ecd82b911449f6c3a4b2cc", kill_on_drop: false }` [INFO] [stdout] 89eeef2bd8250c6338f0402ee1b79e1a49c0fb3b97ecd82b911449f6c3a4b2cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a678b6e394b44c42d5cee598b11db9662949b58efc50910d06c3d41978c7fe5 [INFO] running `Command { std: "docker" "start" "-a" "3a678b6e394b44c42d5cee598b11db9662949b58efc50910d06c3d41978c7fe5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking httparse v1.8.0 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.39.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking aws-smithy-types v1.2.0 [INFO] [stderr] Checking h2 v0.3.25 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.1 [INFO] [stderr] Checking aws-smithy-eventstream v0.60.4 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-smithy-http v0.60.9 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking aws-smithy-checksums v0.60.11 [INFO] [stderr] Checking aws-runtime v1.3.1 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.6.2 [INFO] [stderr] Checking aws-sdk-sts v1.36.0 [INFO] [stderr] Checking aws-sdk-sso v1.36.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.37.0 [INFO] [stderr] Checking aws-sdk-s3 v1.42.0 [INFO] [stderr] Checking aws-config v1.5.4 [INFO] [stderr] Checking raven-oss-tools v0.1.1-dev (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `DeleteFolder` is never used [INFO] [stdout] --> src/utils.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | pub(crate) trait DeleteFolder { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 332 | let client = Client::from_conf(s3_config_builder.build()); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 333 | client [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 332 ~ [INFO] [stdout] 333 ~ Client::from_conf(s3_config_builder.build()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/utils.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | while let Some(chr) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for chr in chars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:41:58 [INFO] [stdout] | [INFO] [stdout] 41 | if !(path.ends_with('/') || path.ends_with('\\')) && path.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:192:23 [INFO] [stdout] | [INFO] [stdout] 192 | .args(&["+H", &path_text]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["+H", &path_text]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/utils.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | / if let Err(err) = tokio::fs::rename(path_buf, new_path_buf).await { [INFO] [stdout] 211 | | return Err(err); [INFO] [stdout] 212 | | } [INFO] [stdout] | |_________________^ help: replace it with: `tokio::fs::rename(path_buf, new_path_buf).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | io::Error::new(ErrorKind::Other, text) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 222 - io::Error::new(ErrorKind::Other, text) [INFO] [stdout] 222 + io::Error::other(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/utils.rs:234:13 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Err(err) = remove_dir_all(value).await { [INFO] [stdout] 235 | | return Err(err); [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____________^ help: replace it with: `remove_dir_all(value).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/utils.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | / if let Err(err) = remove_dir_all(self).await { [INFO] [stdout] 246 | | return Err(err); [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________^ help: replace it with: `remove_dir_all(self).await?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/crypt.rs:43:43 [INFO] [stdout] | [INFO] [stdout] 43 | let result = decrypt(&*buffer, less_safe_key).unwrap_or_exit("解密时失败"); [INFO] [stdout] | ^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/crypt.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | encrypt(&*buffer, less_safe_key).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | ^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/crypt.rs:162:14 [INFO] [stdout] | [INFO] [stdout] 162 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `HidePath` is never used [INFO] [stdout] --> src/utils.rs:181:18 [INFO] [stdout] | [INFO] [stdout] 181 | pub(crate) trait HidePath { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `string_to_error` is never used [INFO] [stdout] --> src/utils.rs:220:4 [INFO] [stdout] | [INFO] [stdout] 220 | fn string_to_error(s: impl Into) -> io::Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DeleteFolder` is never used [INFO] [stdout] --> src/utils.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | pub(crate) trait DeleteFolder { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 332 | let client = Client::from_conf(s3_config_builder.build()); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 333 | client [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 332 ~ [INFO] [stdout] 333 ~ Client::from_conf(s3_config_builder.build()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/utils.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | while let Some(chr) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for chr in chars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:41:58 [INFO] [stdout] | [INFO] [stdout] 41 | if !(path.ends_with('/') || path.ends_with('\\')) && path.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:192:23 [INFO] [stdout] | [INFO] [stdout] 192 | .args(&["+H", &path_text]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["+H", &path_text]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/utils.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | / if let Err(err) = tokio::fs::rename(path_buf, new_path_buf).await { [INFO] [stdout] 211 | | return Err(err); [INFO] [stdout] 212 | | } [INFO] [stdout] | |_________________^ help: replace it with: `tokio::fs::rename(path_buf, new_path_buf).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | io::Error::new(ErrorKind::Other, text) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 222 - io::Error::new(ErrorKind::Other, text) [INFO] [stdout] 222 + io::Error::other(text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/utils.rs:234:13 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Err(err) = remove_dir_all(value).await { [INFO] [stdout] 235 | | return Err(err); [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____________^ help: replace it with: `remove_dir_all(value).await?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/utils.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | / if let Err(err) = remove_dir_all(self).await { [INFO] [stdout] 246 | | return Err(err); [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________^ help: replace it with: `remove_dir_all(self).await?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/crypt.rs:43:43 [INFO] [stdout] | [INFO] [stdout] 43 | let result = decrypt(&*buffer, less_safe_key).unwrap_or_exit("解密时失败"); [INFO] [stdout] | ^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/crypt.rs:57:30 [INFO] [stdout] | [INFO] [stdout] 57 | encrypt(&*buffer, less_safe_key).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | ^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filename` [INFO] [stdout] --> src/bin/rcrypt.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | let filename = _process_crypt_file(rot_crypt, true).await; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filename` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filename` [INFO] [stdout] --> src/bin/rcrypt.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let filename = _process_crypt_file(rot_crypt, false).await; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filename` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `decrypt_file`, `encrypt_file`, and `get_crypt_file_name` [INFO] [stdout] --> src/bin/rot.rs:7:39 [INFO] [stdout] | [INFO] [stdout] 7 | use raven_oss_tools::crypt::{decrypt, decrypt_file, encrypt, encrypt_file, get_crypt_file_name, setup_key}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `decrypt_file`, `encrypt_file`, and `get_crypt_file_name` [INFO] [stdout] --> src/bin/rot.rs:7:39 [INFO] [stdout] | [INFO] [stdout] 7 | use raven_oss_tools::crypt::{decrypt, decrypt_file, encrypt, encrypt_file, get_crypt_file_name, setup_key}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filename` [INFO] [stdout] --> src/bin/rcrypt.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | let filename = _process_crypt_file(rot_crypt, true).await; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filename` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filename` [INFO] [stdout] --> src/bin/rcrypt.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let filename = _process_crypt_file(rot_crypt, false).await; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filename` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / client.lock() [INFO] [stdout] 87 | | .unwrap_or_exit("获取 client 失败") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:94:37 [INFO] [stdout] | [INFO] [stdout] 94 | ... }))).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | / client.lock() [INFO] [stdout] 97 | | .unwrap_or_exit("获取 client 失败") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | .download_file(&rot_download.remote_path, &download_path, None).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/rot.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 82 | let has_password = !rot_download.password.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rot_download.password.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/rot.rs:84:48 [INFO] [stdout] | [INFO] [stdout] 84 | let less_safe_key = Arc::new(setup_key(&rot_download.password.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `rot_download.password.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/bin/rot.rs:92:57 [INFO] [stdout] | [INFO] [stdout] 92 | ... let result = decrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 92 - let result = decrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] 92 + let result = decrypt(buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 92 | let result = decrypt(&**buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | client.lock().unwrap().upload_file( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:132:14 [INFO] [stdout] | [INFO] [stdout] 132 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | client.lock().unwrap().upload_file( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:140:14 [INFO] [stdout] | [INFO] [stdout] 140 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/rot.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 120 | let has_password = !rot_upload.password.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rot_upload.password.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/rot.rs:122:48 [INFO] [stdout] | [INFO] [stdout] 122 | let less_safe_key = Arc::new(setup_key(&rot_upload.password.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `rot_upload.password.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/bin/rot.rs:129:29 [INFO] [stdout] | [INFO] [stdout] 129 | encrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 129 - encrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] 129 + encrypt(buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 129 | encrypt(&**buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | let resp = client.lock().unwrap().list_obj(rot_list.max_length, prefix_path, None).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:159:88 [INFO] [stdout] | [INFO] [stdout] 159 | let resp = client.lock().unwrap().list_obj(rot_list.max_length, prefix_path, None).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / client.lock() [INFO] [stdout] 87 | | .unwrap_or_exit("获取 client 失败") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:94:37 [INFO] [stdout] | [INFO] [stdout] 94 | ... }))).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | / client.lock() [INFO] [stdout] 97 | | .unwrap_or_exit("获取 client 失败") [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:98:77 [INFO] [stdout] | [INFO] [stdout] 98 | .download_file(&rot_download.remote_path, &download_path, None).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/rot.rs:82:24 [INFO] [stdout] | [INFO] [stdout] 82 | let has_password = !rot_download.password.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rot_download.password.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/rot.rs:84:48 [INFO] [stdout] | [INFO] [stdout] 84 | let less_safe_key = Arc::new(setup_key(&rot_download.password.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `rot_download.password.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/bin/rot.rs:92:57 [INFO] [stdout] | [INFO] [stdout] 92 | ... let result = decrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 92 - let result = decrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] 92 + let result = decrypt(buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 92 | let result = decrypt(&**buffer, &less_safe_key_clone).unwrap_or_exit("解密时失败"); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | client.lock().unwrap().upload_file( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:132:14 [INFO] [stdout] | [INFO] [stdout] 132 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | client.lock().unwrap().upload_file( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:140:14 [INFO] [stdout] | [INFO] [stdout] 140 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/rot.rs:120:24 [INFO] [stdout] | [INFO] [stdout] 120 | let has_password = !rot_upload.password.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rot_upload.password.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/rot.rs:122:48 [INFO] [stdout] | [INFO] [stdout] 122 | let less_safe_key = Arc::new(setup_key(&rot_upload.password.unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `rot_upload.password.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/bin/rot.rs:129:29 [INFO] [stdout] | [INFO] [stdout] 129 | encrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 129 - encrypt(&*buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] 129 + encrypt(buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 129 | encrypt(&**buffer, &less_safe_key_clone).unwrap_or_exit("文件加密时失败") [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/bin/rot.rs:159:16 [INFO] [stdout] | [INFO] [stdout] 159 | let resp = client.lock().unwrap().list_obj(rot_list.max_length, prefix_path, None).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/bin/rot.rs:159:88 [INFO] [stdout] | [INFO] [stdout] 159 | let resp = client.lock().unwrap().list_obj(rot_list.max_length, prefix_path, None).await; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 24s [INFO] running `Command { std: "docker" "inspect" "3a678b6e394b44c42d5cee598b11db9662949b58efc50910d06c3d41978c7fe5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a678b6e394b44c42d5cee598b11db9662949b58efc50910d06c3d41978c7fe5", kill_on_drop: false }` [INFO] [stdout] 3a678b6e394b44c42d5cee598b11db9662949b58efc50910d06c3d41978c7fe5