[INFO] cloning repository https://github.com/RaveenaBhasin/Snap-a-version-control-system
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RaveenaBhasin/Snap-a-version-control-system" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaveenaBhasin%2FSnap-a-version-control-system", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaveenaBhasin%2FSnap-a-version-control-system'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b5d9eb6bd0e46f3ebc8c543e31387342280dbd84
[INFO] linting RaveenaBhasin/Snap-a-version-control-system against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaveenaBhasin%2FSnap-a-version-control-system" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/RaveenaBhasin/Snap-a-version-control-system
[INFO] finished tweaking git repo https://github.com/RaveenaBhasin/Snap-a-version-control-system
[INFO] tweaked toml for git repo https://github.com/RaveenaBhasin/Snap-a-version-control-system written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/RaveenaBhasin/Snap-a-version-control-system on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/RaveenaBhasin/Snap-a-version-control-system already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded sha256 v1.6.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 66aba3a0525ccdfea483c383527941d57040fb783405933658623721ada97d37
[INFO] running `Command { std: "docker" "start" "-a" "66aba3a0525ccdfea483c383527941d57040fb783405933658623721ada97d37", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "66aba3a0525ccdfea483c383527941d57040fb783405933658623721ada97d37", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "66aba3a0525ccdfea483c383527941d57040fb783405933658623721ada97d37", kill_on_drop: false }`
[INFO] [stdout] 66aba3a0525ccdfea483c383527941d57040fb783405933658623721ada97d37
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a7ad34155da402916e405bd8c9c013bd67e9c83c83990da9102bac751e460ee0
[INFO] running `Command { std: "docker" "start" "-a" "a7ad34155da402916e405bd8c9c013bd67e9c83c83990da9102bac751e460ee0", kill_on_drop: false }`
[INFO] [stderr]     Checking tokio v1.48.0
[INFO] [stderr]     Checking ryu v1.0.21
[INFO] [stderr]     Checking itoa v1.0.16
[INFO] [stderr]    Compiling syn v2.0.111
[INFO] [stderr]     Checking crypto-common v0.1.7
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking serde_json v1.0.145
[INFO] [stderr]     Checking sha2 v0.10.9
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]    Compiling async-trait v0.1.89
[INFO] [stderr]     Checking sha256 v1.6.0
[INFO] [stderr]     Checking serde v1.0.228
[INFO] [stderr]     Checking git-poc v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `fmt::format`
[INFO] [stdout]  --> src/main.rs:1:33
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::{collections::HashMap, fmt::format, fs, time::{SystemTime, UNIX_EPOCH}};
[INFO] [stdout]   |                                 ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:346:9
[INFO] [stdout]     |
[INFO] [stdout] 346 |         tree_hash: tree_hash,
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tree_hash`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `fmt::format`
[INFO] [stdout]  --> src/main.rs:1:33
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::{collections::HashMap, fmt::format, fs, time::{SystemTime, UNIX_EPOCH}};
[INFO] [stdout]   |                                 ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/main.rs:346:9
[INFO] [stdout]     |
[INFO] [stdout] 346 |         tree_hash: tree_hash,
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tree_hash`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `build_tree` is never used
[INFO] [stdout]   --> src/main.rs:56:4
[INFO] [stdout]    |
[INFO] [stdout] 56 | fn build_tree(dir: &str) -> String {
[INFO] [stdout]    |    ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `read_directory` is never used
[INFO] [stdout]    --> src/main.rs:118:4
[INFO] [stdout]     |
[INFO] [stdout] 118 | fn read_directory(dir: &str, files: &mut HashMap<String, String>) {
[INFO] [stdout]     |    ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `build_tree` is never used
[INFO] [stdout]   --> src/main.rs:56:4
[INFO] [stdout]    |
[INFO] [stdout] 56 | fn build_tree(dir: &str) -> String {
[INFO] [stdout]    |    ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `read_directory` is never used
[INFO] [stdout]    --> src/main.rs:118:4
[INFO] [stdout]     |
[INFO] [stdout] 118 | fn read_directory(dir: &str, files: &mut HashMap<String, String>) {
[INFO] [stdout]     |    ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 |     return hash;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -     return hash;
[INFO] [stdout] 26 +     hash
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     return tree_hash;   
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -     return tree_hash;   
[INFO] [stdout] 33 +     tree_hash
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:91:5
[INFO] [stdout]    |
[INFO] [stdout] 91 |     return head.to_string();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 91 -     return head.to_string();
[INFO] [stdout] 91 +     head.to_string()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:129:28
[INFO] [stdout]     |
[INFO] [stdout] 129 |             read_directory(&path.to_str().unwrap(), files);
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path.to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 |     return hash;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -     return hash;
[INFO] [stdout] 26 +     hash
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     return tree_hash;   
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -     return tree_hash;   
[INFO] [stdout] 33 +     tree_hash
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:91:5
[INFO] [stdout]    |
[INFO] [stdout] 91 |     return head.to_string();
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 91 -     return head.to_string();
[INFO] [stdout] 91 +     head.to_string()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:290:8
[INFO] [stdout]     |
[INFO] [stdout] 290 |     if !fs::metadata(".snap/HEAD").is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(".snap/HEAD").is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:129:28
[INFO] [stdout]     |
[INFO] [stdout] 129 |             read_directory(&path.to_str().unwrap(), files);
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path.to_str().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's keys
[INFO] [stdout]    --> src/main.rs:432:38
[INFO] [stdout]     |
[INFO] [stdout] 432 |     for (file_path, _staged_hash) in &staged_files {
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout]     = note: `#[warn(clippy::for_kv_map)]` on by default
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 432 -     for (file_path, _staged_hash) in &staged_files {
[INFO] [stdout] 432 +     for file_path in staged_files.keys() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:446:9
[INFO] [stdout]     |
[INFO] [stdout] 446 | /         if let Some(staged_hash) = staged_files.get(file_path) {
[INFO] [stdout] 447 | |             if working_hash != staged_hash {
[INFO] [stdout] 448 | |                 if !has_modified {
[INFO] [stdout] 449 | |                     println!("Changes not staged for commit:");
[INFO] [stdout] ...   |
[INFO] [stdout] 454 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 446 ~         if let Some(staged_hash) = staged_files.get(file_path)
[INFO] [stdout] 447 ~             && working_hash != staged_hash {
[INFO] [stdout] 448 |                 if !has_modified {
[INFO] [stdout] ...
[INFO] [stdout] 452 |                 println!("  \x1b[31mmodified:   {}\x1b[0m", file_path);
[INFO] [stdout] 453 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's keys
[INFO] [stdout]    --> src/main.rs:462:27
[INFO] [stdout]     |
[INFO] [stdout] 462 |     for (file_path, _) in &working_files {
[INFO] [stdout]     |                           ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 462 -     for (file_path, _) in &working_files {
[INFO] [stdout] 462 +     for file_path in working_files.keys() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:290:8
[INFO] [stdout]     |
[INFO] [stdout] 290 |     if !fs::metadata(".snap/HEAD").is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(".snap/HEAD").is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:520:9
[INFO] [stdout]     |
[INFO] [stdout] 520 | /         for entry in entries {
[INFO] [stdout] 521 | |             if let Ok(entry) = entry {
[INFO] [stdout] 522 | |                 let hash = entry.file_name().to_string_lossy().to_string();
[INFO] [stdout] 523 | |                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] ...   |
[INFO] [stdout] 529 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:521:13
[INFO] [stdout]     |
[INFO] [stdout] 521 | /             if let Ok(entry) = entry {
[INFO] [stdout] 522 | |                 let hash = entry.file_name().to_string_lossy().to_string();
[INFO] [stdout] 523 | |                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] 524 | |                     if let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] ...   |
[INFO] [stdout] 528 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]     = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 520 ~         for entry in entries.flatten() {
[INFO] [stdout] 521 +             let hash = entry.file_name().to_string_lossy().to_string();
[INFO] [stdout] 522 +             if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] 523 +                 if let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] 524 +                     commits.push((hash, commit));
[INFO] [stdout] 525 +                 }
[INFO] [stdout] 526 +             }
[INFO] [stdout] 527 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:523:17
[INFO] [stdout]     |
[INFO] [stdout] 523 | /                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] 524 | |                     if let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] 525 | |                         commits.push((hash, commit));
[INFO] [stdout] 526 | |                     }
[INFO] [stdout] 527 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 523 ~                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash))
[INFO] [stdout] 524 ~                     && let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] 525 |                         commits.push((hash, commit));
[INFO] [stdout] 526 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/main.rs:533:5
[INFO] [stdout]     |
[INFO] [stdout] 533 |     commits.sort_by(|a, b| b.1.timestamp.cmp(&a.1.timestamp));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 533 -     commits.sort_by(|a, b| b.1.timestamp.cmp(&a.1.timestamp));
[INFO] [stdout] 533 +     commits.sort_by_key(|b| std::cmp::Reverse(b.1.timestamp));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's keys
[INFO] [stdout]    --> src/main.rs:432:38
[INFO] [stdout]     |
[INFO] [stdout] 432 |     for (file_path, _staged_hash) in &staged_files {
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout]     = note: `#[warn(clippy::for_kv_map)]` on by default
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 432 -     for (file_path, _staged_hash) in &staged_files {
[INFO] [stdout] 432 +     for file_path in staged_files.keys() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:446:9
[INFO] [stdout]     |
[INFO] [stdout] 446 | /         if let Some(staged_hash) = staged_files.get(file_path) {
[INFO] [stdout] 447 | |             if working_hash != staged_hash {
[INFO] [stdout] 448 | |                 if !has_modified {
[INFO] [stdout] 449 | |                     println!("Changes not staged for commit:");
[INFO] [stdout] ...   |
[INFO] [stdout] 454 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 446 ~         if let Some(staged_hash) = staged_files.get(file_path)
[INFO] [stdout] 447 ~             && working_hash != staged_hash {
[INFO] [stdout] 448 |                 if !has_modified {
[INFO] [stdout] ...
[INFO] [stdout] 452 |                 println!("  \x1b[31mmodified:   {}\x1b[0m", file_path);
[INFO] [stdout] 453 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's keys
[INFO] [stdout]    --> src/main.rs:462:27
[INFO] [stdout]     |
[INFO] [stdout] 462 |     for (file_path, _) in &working_files {
[INFO] [stdout]     |                           ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]     |
[INFO] [stdout] 462 -     for (file_path, _) in &working_files {
[INFO] [stdout] 462 +     for file_path in working_files.keys() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:520:9
[INFO] [stdout]     |
[INFO] [stdout] 520 | /         for entry in entries {
[INFO] [stdout] 521 | |             if let Ok(entry) = entry {
[INFO] [stdout] 522 | |                 let hash = entry.file_name().to_string_lossy().to_string();
[INFO] [stdout] 523 | |                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] ...   |
[INFO] [stdout] 529 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:521:13
[INFO] [stdout]     |
[INFO] [stdout] 521 | /             if let Ok(entry) = entry {
[INFO] [stdout] 522 | |                 let hash = entry.file_name().to_string_lossy().to_string();
[INFO] [stdout] 523 | |                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] 524 | |                     if let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] ...   |
[INFO] [stdout] 528 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]     = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 520 ~         for entry in entries.flatten() {
[INFO] [stdout] 521 +             let hash = entry.file_name().to_string_lossy().to_string();
[INFO] [stdout] 522 +             if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] 523 +                 if let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] 524 +                     commits.push((hash, commit));
[INFO] [stdout] 525 +                 }
[INFO] [stdout] 526 +             }
[INFO] [stdout] 527 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:523:17
[INFO] [stdout]     |
[INFO] [stdout] 523 | /                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash)) {
[INFO] [stdout] 524 | |                     if let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] 525 | |                         commits.push((hash, commit));
[INFO] [stdout] 526 | |                     }
[INFO] [stdout] 527 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 523 ~                 if let Ok(data) = fs::read_to_string(format!(".snap/objects/{}", hash))
[INFO] [stdout] 524 ~                     && let Ok(commit) = serde_json::from_str::<Commit>(&data) {
[INFO] [stdout] 525 |                         commits.push((hash, commit));
[INFO] [stdout] 526 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/main.rs:533:5
[INFO] [stdout]     |
[INFO] [stdout] 533 |     commits.sort_by(|a, b| b.1.timestamp.cmp(&a.1.timestamp));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 533 -     commits.sort_by(|a, b| b.1.timestamp.cmp(&a.1.timestamp));
[INFO] [stdout] 533 +     commits.sort_by_key(|b| std::cmp::Reverse(b.1.timestamp));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:737:9
[INFO] [stdout]     |
[INFO] [stdout] 737 | /         for entry in heads_dir {
[INFO] [stdout] 738 | |             if let Ok(entry) = entry {
[INFO] [stdout] 739 | |                 let branch_name = entry.file_name().to_str().unwrap().to_string();
[INFO] [stdout] 740 | |                 let marker = if branch_name == current_branch { " *" } else { "  " };
[INFO] [stdout] ...   |
[INFO] [stdout] 744 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:738:13
[INFO] [stdout]     |
[INFO] [stdout] 738 | /             if let Ok(entry) = entry {
[INFO] [stdout] 739 | |                 let branch_name = entry.file_name().to_str().unwrap().to_string();
[INFO] [stdout] 740 | |                 let marker = if branch_name == current_branch { " *" } else { "  " };
[INFO] [stdout] 741 | |                 println!("{} {}", marker, branch_name);
[INFO] [stdout] 742 | |                 found_branches = true;
[INFO] [stdout] 743 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 737 ~         for entry in heads_dir.flatten() {
[INFO] [stdout] 738 +             let branch_name = entry.file_name().to_str().unwrap().to_string();
[INFO] [stdout] 739 +             let marker = if branch_name == current_branch { " *" } else { "  " };
[INFO] [stdout] 740 +             println!("{} {}", marker, branch_name);
[INFO] [stdout] 741 +             found_branches = true;
[INFO] [stdout] 742 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]    --> src/main.rs:737:9
[INFO] [stdout]     |
[INFO] [stdout] 737 | /         for entry in heads_dir {
[INFO] [stdout] 738 | |             if let Ok(entry) = entry {
[INFO] [stdout] 739 | |                 let branch_name = entry.file_name().to_str().unwrap().to_string();
[INFO] [stdout] 740 | |                 let marker = if branch_name == current_branch { " *" } else { "  " };
[INFO] [stdout] ...   |
[INFO] [stdout] 744 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]    --> src/main.rs:738:13
[INFO] [stdout]     |
[INFO] [stdout] 738 | /             if let Ok(entry) = entry {
[INFO] [stdout] 739 | |                 let branch_name = entry.file_name().to_str().unwrap().to_string();
[INFO] [stdout] 740 | |                 let marker = if branch_name == current_branch { " *" } else { "  " };
[INFO] [stdout] 741 | |                 println!("{} {}", marker, branch_name);
[INFO] [stdout] 742 | |                 found_branches = true;
[INFO] [stdout] 743 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 737 ~         for entry in heads_dir.flatten() {
[INFO] [stdout] 738 +             let branch_name = entry.file_name().to_str().unwrap().to_string();
[INFO] [stdout] 739 +             let marker = if branch_name == current_branch { " *" } else { "  " };
[INFO] [stdout] 740 +             println!("{} {}", marker, branch_name);
[INFO] [stdout] 741 +             found_branches = true;
[INFO] [stdout] 742 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.16s
[INFO] running `Command { std: "docker" "inspect" "a7ad34155da402916e405bd8c9c013bd67e9c83c83990da9102bac751e460ee0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a7ad34155da402916e405bd8c9c013bd67e9c83c83990da9102bac751e460ee0", kill_on_drop: false }`
[INFO] [stdout] a7ad34155da402916e405bd8c9c013bd67e9c83c83990da9102bac751e460ee0