[INFO] cloning repository https://github.com/Rasmus20B/stoa
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Rasmus20B/stoa" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRasmus20B%2Fstoa", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRasmus20B%2Fstoa'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f3a18c24f5f23553ed345adafff1ebdb1e768132
[INFO] linting Rasmus20B/stoa against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRasmus20B%2Fstoa" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Rasmus20B/stoa
[INFO] finished tweaking git repo https://github.com/Rasmus20B/stoa
[INFO] tweaked toml for git repo https://github.com/Rasmus20B/stoa written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Rasmus20B/stoa on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Rasmus20B/stoa already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] bfe27149f681917b2773ef7a47d786aff51521105f10e14a6877b42272d63a5c
[INFO] running `Command { std: "docker" "start" "-a" "bfe27149f681917b2773ef7a47d786aff51521105f10e14a6877b42272d63a5c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "bfe27149f681917b2773ef7a47d786aff51521105f10e14a6877b42272d63a5c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bfe27149f681917b2773ef7a47d786aff51521105f10e14a6877b42272d63a5c", kill_on_drop: false }`
[INFO] [stdout] bfe27149f681917b2773ef7a47d786aff51521105f10e14a6877b42272d63a5c
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 40bd4d15ac190fb960dab8fcc4992766189988fa6f552452e7901d06d07e4c08
[INFO] running `Command { std: "docker" "start" "-a" "40bd4d15ac190fb960dab8fcc4992766189988fa6f552452e7901d06d07e4c08", kill_on_drop: false }`
[INFO] [stderr]     Checking stoa-core v0.1.0 (/opt/rustwide/workdir/stoa-core)
[INFO] [stderr]    Compiling syn v2.0.101
[INFO] [stderr]     Checking clap_builder v4.5.38
[INFO] [stdout] warning: unused import: `KEYWORD_MAP`
[INFO] [stdout]  --> stoa-core/src/lexer.rs:6:58
[INFO] [stdout]   |
[INFO] [stdout] 6 |     token::{match_keyword, SourceLoc, Token, TokenValue, KEYWORD_MAP},
[INFO] [stdout]   |                                                          ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::path::PathBuf`
[INFO] [stdout]  --> stoa-core/src/token.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::path::PathBuf;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `KEYWORD_MAP`
[INFO] [stdout]  --> stoa-core/src/lexer.rs:6:58
[INFO] [stdout]   |
[INFO] [stdout] 6 |     token::{match_keyword, SourceLoc, Token, TokenValue, KEYWORD_MAP},
[INFO] [stdout]   |                                                          ^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `diagnostic::Diagnostic`
[INFO] [stdout]    --> stoa-core/src/parser.rs:319:17
[INFO] [stdout]     |
[INFO] [stdout] 319 |     use crate::{diagnostic::Diagnostic, token::{SourceLoc, Token, TokenValue}};
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::path::PathBuf`
[INFO] [stdout]  --> stoa-core/src/token.rs:1:5
[INFO] [stdout]   |
[INFO] [stdout] 1 | use std::path::PathBuf;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `diagnostics`
[INFO] [stdout]   --> stoa-core/src/lexer.rs:60:24
[INFO] [stdout]    |
[INFO] [stdout] 60 | pub fn lex(text: &str, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<Token>> {
[INFO] [stdout]    |                        ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `intermediate_store`
[INFO] [stdout]  --> stoa-core/src/macro.rs:5:22
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn expand_macros(intermediate_store: &mut KeyValueBlock) -> Result<()> {
[INFO] [stdout]   |                      ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intermediate_store`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `diagnostics`
[INFO] [stdout]    --> stoa-core/src/parser.rs:155:47
[INFO] [stdout]     |
[INFO] [stdout] 155 | fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                               ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `diagnostics`
[INFO] [stdout]    --> stoa-core/src/parser.rs:200:48
[INFO] [stdout]     |
[INFO] [stdout] 200 | fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                                ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `p`
[INFO] [stdout]    --> stoa-core/src/parser.rs:306:35
[INFO] [stdout]     |
[INFO] [stdout] 306 |             TokenValue::MacroCall(p) => {
[INFO] [stdout]     |                                   ^ help: if this is intentional, prefix it with an underscore: `_p`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `category`, `location`, and `snippet` are never read
[INFO] [stdout]   --> stoa-core/src/diagnostic.rs:8:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | pub struct Diagnostic {
[INFO] [stdout]    |            ---------- fields in this struct
[INFO] [stdout]  8 |     category: DiagnosticCategory,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout]  9 |     location: SourceLoc,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 10 |     snippet: String,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `short_debug` is never used
[INFO] [stdout]    --> stoa-core/src/keyvalue.rs:118:8
[INFO] [stdout]     |
[INFO] [stdout]  95 | impl BlockValue {
[INFO] [stdout]     | --------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 118 |     fn short_debug(&self) -> String {
[INFO] [stdout]     |        ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `input` is never read
[INFO] [stdout]   --> stoa-core/src/lexer.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout]  9 | struct LexIter<'a> {
[INFO] [stdout]    |        ------- field in this struct
[INFO] [stdout] 10 |     input: &'a str,
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `expand_macros` is never used
[INFO] [stdout]  --> stoa-core/src/macro.rs:5:8
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn expand_macros(intermediate_store: &mut KeyValueBlock) -> Result<()> {
[INFO] [stdout]   |        ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `expect_object_id` is never used
[INFO] [stdout]   --> stoa-core/src/parser.rs:40:12
[INFO] [stdout]    |
[INFO] [stdout] 11 | impl<'a> Parser<'a> {
[INFO] [stdout]    | ------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 40 |     pub fn expect_object_id(&mut self) -> Result<i64> {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `parse_identifier_value` is never used
[INFO] [stdout]    --> stoa-core/src/parser.rs:114:4
[INFO] [stdout]     |
[INFO] [stdout] 114 | fn parse_identifier_value(identifier: String, start_loc: SourceLoc, parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Resu...
[INFO] [stdout]     |    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `diagnostics`
[INFO] [stdout]   --> stoa-core/src/lexer.rs:60:24
[INFO] [stdout]    |
[INFO] [stdout] 60 | pub fn lex(text: &str, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<Token>> {
[INFO] [stdout]    |                        ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `intermediate_store`
[INFO] [stdout]  --> stoa-core/src/macro.rs:5:22
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn expand_macros(intermediate_store: &mut KeyValueBlock) -> Result<()> {
[INFO] [stdout]   |                      ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_intermediate_store`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> stoa-core/src/lexer.rs:142:20
[INFO] [stdout]     |
[INFO] [stdout] 142 |                 if !(c == '=') {
[INFO] [stdout]     |                    ^^^^^^^^^^^ help: try: `(c != '=')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> stoa-core/src/lexer.rs:60:37
[INFO] [stdout]    |
[INFO] [stdout] 60 | pub fn lex(text: &str, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<Token>> {
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 60 - pub fn lex(text: &str, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<Token>> {
[INFO] [stdout] 60 + pub fn lex(text: &str, diagnostics: &mut [Diagnostic]) -> Result<Vec<Token>> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `diagnostics`
[INFO] [stdout]    --> stoa-core/src/parser.rs:155:47
[INFO] [stdout]     |
[INFO] [stdout] 155 | fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                               ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `diagnostics`
[INFO] [stdout]    --> stoa-core/src/parser.rs:200:48
[INFO] [stdout]     |
[INFO] [stdout] 200 | fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                                ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:34:13
[INFO] [stdout]    |
[INFO] [stdout] 34 |             return Ok(current)
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 34 -             return Ok(current)
[INFO] [stdout] 34 +             Ok(current)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:36:13
[INFO] [stdout]    |
[INFO] [stdout] 36 |             return Err(Error::UnexpectedToken((*current).clone()))
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -             return Err(Error::UnexpectedToken((*current).clone()))
[INFO] [stdout] 36 +             Err(Error::UnexpectedToken((*current).clone()))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:69:14
[INFO] [stdout]    |
[INFO] [stdout] 69 |         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 69 -         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout] 69 +         _ => Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:99:5
[INFO] [stdout]    |
[INFO] [stdout] 99 |     return Err(Error::UnexpectedEOF)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -     return Err(Error::UnexpectedEOF)
[INFO] [stdout] 99 +     Err(Error::UnexpectedEOF)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:110:14
[INFO] [stdout]     |
[INFO] [stdout] 110 |         _ => return Err(Error::UnexpectedToken((*token).clone()))
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -         _ => return Err(Error::UnexpectedToken((*token).clone()))
[INFO] [stdout] 110 +         _ => Err(Error::UnexpectedToken((*token).clone()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:119:30
[INFO] [stdout]     |
[INFO] [stdout] 119 |           TokenValue::Comma => return Ok(
[INFO] [stdout]     |  ______________________________^
[INFO] [stdout] 120 | |             BlockValue::Literal(identifier)
[INFO] [stdout] 121 | |         ),
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 ~         TokenValue::Comma => Ok(
[INFO] [stdout] 120 +             BlockValue::Literal(identifier)
[INFO] [stdout] 121 ~         ),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:122:14
[INFO] [stdout]     |
[INFO] [stdout] 122 |         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 122 -         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout] 122 +         _ => Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> stoa-core/src/parser.rs:118:81
[INFO] [stdout]     |
[INFO] [stdout] 118 |         TokenValue::Identifier(s) => parse_identifier_value(identifier + " " +  &s, start_loc, parser, diagnostics),
[INFO] [stdout]     |                                                                                 ^^ help: change this to: `s`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: parameter is only used in recursion
[INFO] [stdout]    --> stoa-core/src/parser.rs:114:47
[INFO] [stdout]     |
[INFO] [stdout] 114 | fn parse_identifier_value(identifier: String, start_loc: SourceLoc, parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Resu...
[INFO] [stdout]     |                                               ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_start_loc`
[INFO] [stdout]     |
[INFO] [stdout] note: parameter used here
[INFO] [stdout]    --> stoa-core/src/parser.rs:118:85
[INFO] [stdout]     |
[INFO] [stdout] 118 |         TokenValue::Identifier(s) => parse_identifier_value(identifier + " " +  &s, start_loc, parser, diagnostics),
[INFO] [stdout]     |                                                                                     ^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
[INFO] [stdout]     = note: `#[warn(clippy::only_used_in_recursion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: parameter is only used in recursion
[INFO] [stdout]    --> stoa-core/src/parser.rs:114:90
[INFO] [stdout]     |
[INFO] [stdout] 114 | ...parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<BlockValue> {
[INFO] [stdout]     |                         ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout]     |
[INFO] [stdout] note: parameter used here
[INFO] [stdout]    --> stoa-core/src/parser.rs:118:104
[INFO] [stdout]     |
[INFO] [stdout] 118 |         TokenValue::Identifier(s) => parse_identifier_value(identifier + " " +  &s, start_loc, parser, diagnostics),
[INFO] [stdout]     |                                                                                                        ^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:151:14
[INFO] [stdout]     |
[INFO] [stdout] 151 |         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 151 -         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout] 151 +         _ => Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `p`
[INFO] [stdout]    --> stoa-core/src/parser.rs:306:35
[INFO] [stdout]     |
[INFO] [stdout] 306 |             TokenValue::MacroCall(p) => {
[INFO] [stdout]     |                                   ^ help: if this is intentional, prefix it with an underscore: `_p`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> stoa-core/src/parser.rs:155:60
[INFO] [stdout]     |
[INFO] [stdout] 155 | fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 155 - fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout] 155 + fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut [Diagnostic]) -> Result<Vec<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> stoa-core/src/parser.rs:200:61
[INFO] [stdout]     |
[INFO] [stdout] 200 | fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                                             ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 200 - fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout] 200 + fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut [Diagnostic]) -> Result<Vec<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `category`, `location`, and `snippet` are never read
[INFO] [stdout]   --> stoa-core/src/diagnostic.rs:8:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | pub struct Diagnostic {
[INFO] [stdout]    |            ---------- fields in this struct
[INFO] [stdout]  8 |     category: DiagnosticCategory,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout]  9 |     location: SourceLoc,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 10 |     snippet: String,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `short_debug` is never used
[INFO] [stdout]    --> stoa-core/src/keyvalue.rs:118:8
[INFO] [stdout]     |
[INFO] [stdout]  95 | impl BlockValue {
[INFO] [stdout]     | --------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 118 |     fn short_debug(&self) -> String {
[INFO] [stdout]     |        ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `SourceLoc` which implements the `Copy` trait
[INFO] [stdout]    --> stoa-core/src/parser.rs:231:20
[INFO] [stdout]     |
[INFO] [stdout] 231 |     let location = start.source_loc.clone();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start.source_loc`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `input` is never read
[INFO] [stdout]   --> stoa-core/src/lexer.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout]  9 | struct LexIter<'a> {
[INFO] [stdout]    |        ------- field in this struct
[INFO] [stdout] 10 |     input: &'a str,
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `expand_macros` is never used
[INFO] [stdout]  --> stoa-core/src/macro.rs:5:8
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub fn expand_macros(intermediate_store: &mut KeyValueBlock) -> Result<()> {
[INFO] [stdout]   |        ^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> stoa-core/src/parser.rs:308:17
[INFO] [stdout]     |
[INFO] [stdout] 307 |                 let result = parse_macro_call(&token, &mut parser, diagnostics)?;
[INFO] [stdout]     |                 ----------------------------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 308 |                 result
[INFO] [stdout]     |                 ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 307 ~                 
[INFO] [stdout] 308 ~                 parse_macro_call(&token, &mut parser, diagnostics)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EOF` contains a capitalized acronym
[INFO] [stdout]   --> stoa-core/src/token.rs:50:5
[INFO] [stdout]    |
[INFO] [stdout] 50 |     EOF,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EOF` contains a capitalized acronym
[INFO] [stdout]   --> stoa-core/src/token.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     EOF,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `expect_object_id` is never used
[INFO] [stdout]   --> stoa-core/src/parser.rs:40:12
[INFO] [stdout]    |
[INFO] [stdout] 11 | impl<'a> Parser<'a> {
[INFO] [stdout]    | ------------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 40 |     pub fn expect_object_id(&mut self) -> Result<i64> {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `parse_identifier_value` is never used
[INFO] [stdout]    --> stoa-core/src/parser.rs:114:4
[INFO] [stdout]     |
[INFO] [stdout] 114 | fn parse_identifier_value(identifier: String, start_loc: SourceLoc, parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Resu...
[INFO] [stdout]     |    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> stoa-core/src/lexer.rs:142:20
[INFO] [stdout]     |
[INFO] [stdout] 142 |                 if !(c == '=') {
[INFO] [stdout]     |                    ^^^^^^^^^^^ help: try: `(c != '=')`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> stoa-core/src/lexer.rs:60:37
[INFO] [stdout]    |
[INFO] [stdout] 60 | pub fn lex(text: &str, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<Token>> {
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 60 - pub fn lex(text: &str, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<Token>> {
[INFO] [stdout] 60 + pub fn lex(text: &str, diagnostics: &mut [Diagnostic]) -> Result<Vec<Token>> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:34:13
[INFO] [stdout]    |
[INFO] [stdout] 34 |             return Ok(current)
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 34 -             return Ok(current)
[INFO] [stdout] 34 +             Ok(current)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:36:13
[INFO] [stdout]    |
[INFO] [stdout] 36 |             return Err(Error::UnexpectedToken((*current).clone()))
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -             return Err(Error::UnexpectedToken((*current).clone()))
[INFO] [stdout] 36 +             Err(Error::UnexpectedToken((*current).clone()))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:69:14
[INFO] [stdout]    |
[INFO] [stdout] 69 |         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 69 -         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout] 69 +         _ => Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> stoa-core/src/parser.rs:99:5
[INFO] [stdout]    |
[INFO] [stdout] 99 |     return Err(Error::UnexpectedEOF)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -     return Err(Error::UnexpectedEOF)
[INFO] [stdout] 99 +     Err(Error::UnexpectedEOF)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:110:14
[INFO] [stdout]     |
[INFO] [stdout] 110 |         _ => return Err(Error::UnexpectedToken((*token).clone()))
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -         _ => return Err(Error::UnexpectedToken((*token).clone()))
[INFO] [stdout] 110 +         _ => Err(Error::UnexpectedToken((*token).clone()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:119:30
[INFO] [stdout]     |
[INFO] [stdout] 119 |           TokenValue::Comma => return Ok(
[INFO] [stdout]     |  ______________________________^
[INFO] [stdout] 120 | |             BlockValue::Literal(identifier)
[INFO] [stdout] 121 | |         ),
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 ~         TokenValue::Comma => Ok(
[INFO] [stdout] 120 +             BlockValue::Literal(identifier)
[INFO] [stdout] 121 ~         ),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:122:14
[INFO] [stdout]     |
[INFO] [stdout] 122 |         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 122 -         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout] 122 +         _ => Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> stoa-core/src/parser.rs:118:81
[INFO] [stdout]     |
[INFO] [stdout] 118 |         TokenValue::Identifier(s) => parse_identifier_value(identifier + " " +  &s, start_loc, parser, diagnostics),
[INFO] [stdout]     |                                                                                 ^^ help: change this to: `s`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: parameter is only used in recursion
[INFO] [stdout]    --> stoa-core/src/parser.rs:114:47
[INFO] [stdout]     |
[INFO] [stdout] 114 | fn parse_identifier_value(identifier: String, start_loc: SourceLoc, parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Resu...
[INFO] [stdout]     |                                               ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_start_loc`
[INFO] [stdout]     |
[INFO] [stdout] note: parameter used here
[INFO] [stdout]    --> stoa-core/src/parser.rs:118:85
[INFO] [stdout]     |
[INFO] [stdout] 118 |         TokenValue::Identifier(s) => parse_identifier_value(identifier + " " +  &s, start_loc, parser, diagnostics),
[INFO] [stdout]     |                                                                                     ^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
[INFO] [stdout]     = note: `#[warn(clippy::only_used_in_recursion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: parameter is only used in recursion
[INFO] [stdout]    --> stoa-core/src/parser.rs:114:90
[INFO] [stdout]     |
[INFO] [stdout] 114 | ...parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<BlockValue> {
[INFO] [stdout]     |                         ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_diagnostics`
[INFO] [stdout]     |
[INFO] [stdout] note: parameter used here
[INFO] [stdout]    --> stoa-core/src/parser.rs:118:104
[INFO] [stdout]     |
[INFO] [stdout] 118 |         TokenValue::Identifier(s) => parse_identifier_value(identifier + " " +  &s, start_loc, parser, diagnostics),
[INFO] [stdout]     |                                                                                                        ^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> stoa-core/src/parser.rs:151:14
[INFO] [stdout]     |
[INFO] [stdout] 151 |         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 151 -         _ => return Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout] 151 +         _ => Err(Error::UnexpectedToken((*next).clone()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> stoa-core/src/parser.rs:155:60
[INFO] [stdout]     |
[INFO] [stdout] 155 | fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 155 - fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout] 155 + fn parse_macro_arguments(parser: &mut Parser, diagnostics: &mut [Diagnostic]) -> Result<Vec<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> stoa-core/src/parser.rs:200:61
[INFO] [stdout]     |
[INFO] [stdout] 200 | fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout]     |                                                             ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 200 - fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut Vec<Diagnostic>) -> Result<Vec<String>> {
[INFO] [stdout] 200 + fn parse_macro_parameters(parser: &mut Parser, diagnostics: &mut [Diagnostic]) -> Result<Vec<String>> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `SourceLoc` which implements the `Copy` trait
[INFO] [stdout]    --> stoa-core/src/parser.rs:231:20
[INFO] [stdout]     |
[INFO] [stdout] 231 |     let location = start.source_loc.clone();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start.source_loc`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> stoa-core/src/parser.rs:308:17
[INFO] [stdout]     |
[INFO] [stdout] 307 |                 let result = parse_macro_call(&token, &mut parser, diagnostics)?;
[INFO] [stdout]     |                 ----------------------------------------------------------------- unnecessary `let` binding
[INFO] [stdout] 308 |                 result
[INFO] [stdout]     |                 ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 307 ~                 
[INFO] [stdout] 308 ~                 parse_macro_call(&token, &mut parser, diagnostics)?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EOF` contains a capitalized acronym
[INFO] [stdout]   --> stoa-core/src/token.rs:50:5
[INFO] [stdout]    |
[INFO] [stdout] 50 |     EOF,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EOF` contains a capitalized acronym
[INFO] [stdout]   --> stoa-core/src/token.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     EOF,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> stoa-core/tests/parser.rs:3:62
[INFO] [stdout]   |
[INFO] [stdout] 3 | use stoa_core::{diagnostic::Diagnostic, lexer::lex, parser::{self, parse}};
[INFO] [stdout]   |                                                              ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling clap_derive v4.5.32
[INFO] [stderr]     Checking clap v4.5.38
[INFO] [stderr]     Checking stoa-cli v0.1.0 (/opt/rustwide/workdir/stoa-cli)
[INFO] [stdout] warning: variant `incompleteAppend` should have an upper camel case name
[INFO] [stdout]  --> stoa-cli/src/error.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     incompleteAppend,
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `IncompleteAppend`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `commands::CommandLine`
[INFO] [stdout]  --> stoa-cli/src/main.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use commands::CommandLine;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `incompleteAppend` should have an upper camel case name
[INFO] [stdout]  --> stoa-cli/src/error.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     incompleteAppend,
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `IncompleteAppend`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `commands::CommandLine`
[INFO] [stdout]  --> stoa-cli/src/main.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use commands::CommandLine;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variants `UnexpectedEOF` and `incompleteAppend` are never constructed
[INFO] [stdout]  --> stoa-cli/src/error.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub enum Error {
[INFO] [stdout]   |          ----- variants in this enum
[INFO] [stdout] ...
[INFO] [stdout] 8 |     UnexpectedEOF,
[INFO] [stdout]   |     ^^^^^^^^^^^^^
[INFO] [stdout] 9 |     incompleteAppend,
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variants `UnexpectedEOF` and `incompleteAppend` are never constructed
[INFO] [stdout]  --> stoa-cli/src/error.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub enum Error {
[INFO] [stdout]   |          ----- variants in this enum
[INFO] [stdout] ...
[INFO] [stdout] 8 |     UnexpectedEOF,
[INFO] [stdout]   |     ^^^^^^^^^^^^^
[INFO] [stdout] 9 |     incompleteAppend,
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.07s
[INFO] running `Command { std: "docker" "inspect" "40bd4d15ac190fb960dab8fcc4992766189988fa6f552452e7901d06d07e4c08", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "40bd4d15ac190fb960dab8fcc4992766189988fa6f552452e7901d06d07e4c08", kill_on_drop: false }`
[INFO] [stdout] 40bd4d15ac190fb960dab8fcc4992766189988fa6f552452e7901d06d07e4c08