[INFO] cloning repository https://github.com/Rahn-IT/toolbox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Rahn-IT/toolbox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRahn-IT%2Ftoolbox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRahn-IT%2Ftoolbox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 81ccf46994e9107ceaf5b6885d06a3fc7116ea57 [INFO] linting Rahn-IT/toolbox against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRahn-IT%2Ftoolbox" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Rahn-IT/toolbox [INFO] finished tweaking git repo https://github.com/Rahn-IT/toolbox [INFO] tweaked toml for git repo https://github.com/Rahn-IT/toolbox written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Rahn-IT/toolbox on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Rahn-IT/toolbox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded redox_syscall v0.6.0 [INFO] [stderr] Downloaded wayland-protocols-misc v0.3.9 [INFO] [stderr] Downloaded libredox v0.1.11 [INFO] [stderr] Downloaded sipper v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a190075901f7865f25cf69c15abdff97986e8e93cf4e110034bddd279f97076f [INFO] running `Command { std: "docker" "start" "-a" "a190075901f7865f25cf69c15abdff97986e8e93cf4e110034bddd279f97076f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a190075901f7865f25cf69c15abdff97986e8e93cf4e110034bddd279f97076f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a190075901f7865f25cf69c15abdff97986e8e93cf4e110034bddd279f97076f", kill_on_drop: false }` [INFO] [stdout] a190075901f7865f25cf69c15abdff97986e8e93cf4e110034bddd279f97076f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d5f5ca980ca205abf968bd43a5e8110d96b86020afbcaf66ecd00ad0eb8d0c90 [INFO] running `Command { std: "docker" "start" "-a" "d5f5ca980ca205abf968bd43a5e8110d96b86020afbcaf66ecd00ad0eb8d0c90", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling slotmap v1.1.1 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Checking lilt v0.8.1 [INFO] [stderr] Checking glam v0.25.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling naga v27.0.3 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Compiling wgpu-hal v27.0.4 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking self_cell v1.2.1 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Compiling wgpu-core v27.0.3 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Compiling wgpu v27.0.1 [INFO] [stderr] Checking syn v2.0.111 [INFO] [stderr] Compiling tiny-xlib v0.2.4 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking ctor-lite v0.1.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Compiling android-build v0.1.3 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking lru v0.16.2 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Compiling mundy v0.2.2 [INFO] [stderr] Checking kurbo v0.10.4 [INFO] [stderr] Checking etagere v0.2.15 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking nix v0.30.1 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Compiling rfd v0.17.2 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking open v5.3.3 [INFO] [stderr] Checking fontdb v0.23.0 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking iced_core v0.14.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking font-types v0.10.1 [INFO] [stderr] Checking wgpu-types v27.0.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking read-fonts v0.35.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking zvariant_utils v3.2.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling zvariant_derive v5.8.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking sipper v0.1.0 [INFO] [stderr] Compiling zvariant v5.8.0 [INFO] [stderr] Checking iced_futures v0.14.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking iced_debug v0.14.0 [INFO] [stderr] Checking iced_runtime v0.14.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking skrifa v0.37.0 [INFO] [stderr] Checking harfrust v0.3.2 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Compiling zbus_macros v5.12.0 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking softbuffer v0.4.8 [INFO] [stderr] Checking clipboard_x11 v0.4.3 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking clipboard_wayland v0.2.2 [INFO] [stderr] Checking window_clipboard v0.5.1 [INFO] [stderr] Checking zbus v5.12.0 [INFO] [stderr] Checking swash v0.2.6 [INFO] [stderr] Checking cosmic-text v0.15.0 [INFO] [stderr] Checking iced_graphics v0.14.0 [INFO] [stderr] Checking iced_tiny_skia v0.14.0 [INFO] [stderr] Checking iced_program v0.14.0 [INFO] [stderr] Checking iced_winit v0.14.0 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Checking cryoglyph v0.1.0 [INFO] [stderr] Checking iced_wgpu v0.14.0 [INFO] [stderr] Checking iced_renderer v0.14.0 [INFO] [stderr] Checking iced_widget v0.14.2 [INFO] [stderr] Checking iced v0.14.0 [INFO] [stderr] Checking toolbox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/eml.rs:67:43 [INFO] [stdout] | [INFO] [stdout] 67 | decoded_raw.extend_from_slice(&encoded_char.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `encoded_char.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/eml.rs:67:43 [INFO] [stdout] | [INFO] [stdout] 67 | decoded_raw.extend_from_slice(&encoded_char.as_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `encoded_char.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/nut/monitor.rs:95:18 [INFO] [stdout] | [INFO] [stdout] 95 | .map(|name| { [INFO] [stdout] | __________________^ [INFO] [stdout] 96 | | self.status.get(name.as_str()).map(|status| { [INFO] [stdout] 97 | | column( [INFO] [stdout] 98 | | status [INFO] [stdout] ... | [INFO] [stdout] 104 | | }) [INFO] [stdout] 105 | | .flatten() [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 95 ~ .and_then(|name| { [INFO] [stdout] 96 + self.status.get(name.as_str()).map(|status| { [INFO] [stdout] 97 + column( [INFO] [stdout] 98 + status [INFO] [stdout] 99 + .iter() [INFO] [stdout] 100 + .map(|(key, value)| row![text(key).width(300), text(value)].into()), [INFO] [stdout] 101 + ) [INFO] [stdout] 102 + .spacing(10) [INFO] [stdout] 103 + }) [INFO] [stdout] 104 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/nut.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | mod nut; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 133 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 134 | | io::ErrorKind::Other, [INFO] [stdout] 135 | | format!("Unexpected response: {}", first), [INFO] [stdout] 136 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 133 ~ return Err(io::Error::other( [INFO] [stdout] 134 ~ format!("Unexpected response: {}", first), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:153:36 [INFO] [stdout] | [INFO] [stdout] 153 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 153 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] 153 + .ok_or_else(|| io::Error::other("Missing UPS name"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:156:36 [INFO] [stdout] | [INFO] [stdout] 156 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS desc"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 156 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS desc"))?; [INFO] [stdout] 156 + .ok_or_else(|| io::Error::other("Missing UPS desc"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:201:24 [INFO] [stdout] | [INFO] [stdout] 201 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 202 | | io::ErrorKind::Other, [INFO] [stdout] 203 | | format!("Unexpected response: {}", first), [INFO] [stdout] 204 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 201 ~ return Err(io::Error::other( [INFO] [stdout] 202 ~ format!("Unexpected response: {}", first), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:221:36 [INFO] [stdout] | [INFO] [stdout] 221 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 221 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] 221 + .ok_or_else(|| io::Error::other("Missing UPS name"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:228:36 [INFO] [stdout] | [INFO] [stdout] 228 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var name"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 228 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var name"))?; [INFO] [stdout] 228 + .ok_or_else(|| io::Error::other("Missing var name"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:231:36 [INFO] [stdout] | [INFO] [stdout] 231 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var value"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 231 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var value"))?; [INFO] [stdout] 231 + .ok_or_else(|| io::Error::other("Missing var value"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | Err(io::Error::new( [INFO] [stdout] | _________________^ [INFO] [stdout] 271 | | io::ErrorKind::Other, [INFO] [stdout] 272 | | format!("Expected OK, got: {}", line), [INFO] [stdout] 273 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 270 ~ Err(io::Error::other( [INFO] [stdout] 271 ~ format!("Expected OK, got: {}", line), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/nut/monitor.rs:95:18 [INFO] [stdout] | [INFO] [stdout] 95 | .map(|name| { [INFO] [stdout] | __________________^ [INFO] [stdout] 96 | | self.status.get(name.as_str()).map(|status| { [INFO] [stdout] 97 | | column( [INFO] [stdout] 98 | | status [INFO] [stdout] ... | [INFO] [stdout] 104 | | }) [INFO] [stdout] 105 | | .flatten() [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `and_then` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 95 ~ .and_then(|name| { [INFO] [stdout] 96 + self.status.get(name.as_str()).map(|status| { [INFO] [stdout] 97 + column( [INFO] [stdout] 98 + status [INFO] [stdout] 99 + .iter() [INFO] [stdout] 100 + .map(|(key, value)| row![text(key).width(300), text(value)].into()), [INFO] [stdout] 101 + ) [INFO] [stdout] 102 + .spacing(10) [INFO] [stdout] 103 + }) [INFO] [stdout] 104 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Nut` [INFO] [stdout] --> src/nut.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Self { [INFO] [stdout] 25 | | connect: connect::Connect::new(), [INFO] [stdout] 26 | | monitor: None, [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for Nut { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/nut.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | mod nut; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PathLengthChecker` [INFO] [stdout] --> src/path_length_checker.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / pub fn new() -> Self { [INFO] [stdout] 91 | | Self { [INFO] [stdout] 92 | | selecting: false, [INFO] [stdout] 93 | | selected: None, [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 89 + impl Default for PathLengthChecker { [INFO] [stdout] 90 + fn default() -> Self { [INFO] [stdout] 91 + Self::new() [INFO] [stdout] 92 + } [INFO] [stdout] 93 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/path_length_checker.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(selected) = selected { [INFO] [stdout] 119 | | if let Some(selected) = Arc::into_inner(selected) { [INFO] [stdout] 120 | | let selected: PathBuf = selected.path().into(); [INFO] [stdout] 121 | | self.selected = Some(selected.clone()); [INFO] [stdout] ... | [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(selected) = selected [INFO] [stdout] 119 ~ && let Some(selected) = Arc::into_inner(selected) { [INFO] [stdout] 120 | let selected: PathBuf = selected.path().into(); [INFO] [stdout] 121 | self.selected = Some(selected.clone()); [INFO] [stdout] 122 | self.scan_status = ScanStatus::WaitingForStart; [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 133 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 134 | | io::ErrorKind::Other, [INFO] [stdout] 135 | | format!("Unexpected response: {}", first), [INFO] [stdout] 136 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 133 ~ return Err(io::Error::other( [INFO] [stdout] 134 ~ format!("Unexpected response: {}", first), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:153:36 [INFO] [stdout] | [INFO] [stdout] 153 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 153 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] 153 + .ok_or_else(|| io::Error::other("Missing UPS name"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:156:36 [INFO] [stdout] | [INFO] [stdout] 156 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS desc"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 156 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS desc"))?; [INFO] [stdout] 156 + .ok_or_else(|| io::Error::other("Missing UPS desc"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:201:24 [INFO] [stdout] | [INFO] [stdout] 201 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 202 | | io::ErrorKind::Other, [INFO] [stdout] 203 | | format!("Unexpected response: {}", first), [INFO] [stdout] 204 | | )); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 201 ~ return Err(io::Error::other( [INFO] [stdout] 202 ~ format!("Unexpected response: {}", first), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:221:36 [INFO] [stdout] | [INFO] [stdout] 221 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 221 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing UPS name"))?; [INFO] [stdout] 221 + .ok_or_else(|| io::Error::other("Missing UPS name"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:228:36 [INFO] [stdout] | [INFO] [stdout] 228 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var name"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 228 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var name"))?; [INFO] [stdout] 228 + .ok_or_else(|| io::Error::other("Missing var name"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:231:36 [INFO] [stdout] | [INFO] [stdout] 231 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var value"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 231 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Missing var value"))?; [INFO] [stdout] 231 + .ok_or_else(|| io::Error::other("Missing var value"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/nut/nut.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | Err(io::Error::new( [INFO] [stdout] | _________________^ [INFO] [stdout] 271 | | io::ErrorKind::Other, [INFO] [stdout] 272 | | format!("Expected OK, got: {}", line), [INFO] [stdout] 273 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 270 ~ Err(io::Error::other( [INFO] [stdout] 271 ~ format!("Expected OK, got: {}", line), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Nut` [INFO] [stdout] --> src/nut.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Self { [INFO] [stdout] 25 | | connect: connect::Connect::new(), [INFO] [stdout] 26 | | monitor: None, [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for Nut { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PathLengthChecker` [INFO] [stdout] --> src/path_length_checker.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | / pub fn new() -> Self { [INFO] [stdout] 91 | | Self { [INFO] [stdout] 92 | | selecting: false, [INFO] [stdout] 93 | | selected: None, [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 89 + impl Default for PathLengthChecker { [INFO] [stdout] 90 + fn default() -> Self { [INFO] [stdout] 91 + Self::new() [INFO] [stdout] 92 + } [INFO] [stdout] 93 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:106:54 [INFO] [stdout] | [INFO] [stdout] 106 | ... let number = u32::from_str_radix(number, 10).ok()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `number.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/path_length_checker.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(selected) = selected { [INFO] [stdout] 119 | | if let Some(selected) = Arc::into_inner(selected) { [INFO] [stdout] 120 | | let selected: PathBuf = selected.path().into(); [INFO] [stdout] 121 | | self.selected = Some(selected.clone()); [INFO] [stdout] ... | [INFO] [stdout] 124 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(selected) = selected [INFO] [stdout] 119 ~ && let Some(selected) = Arc::into_inner(selected) { [INFO] [stdout] 120 | let selected: PathBuf = selected.path().into(); [INFO] [stdout] 121 | self.selected = Some(selected.clone()); [INFO] [stdout] 122 | self.scan_status = ScanStatus::WaitingForStart; [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/main.rs:106:54 [INFO] [stdout] | [INFO] [stdout] 106 | ... let number = u32::from_str_radix(number, 10).ok()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `number.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 39s [INFO] running `Command { std: "docker" "inspect" "d5f5ca980ca205abf968bd43a5e8110d96b86020afbcaf66ecd00ad0eb8d0c90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5f5ca980ca205abf968bd43a5e8110d96b86020afbcaf66ecd00ad0eb8d0c90", kill_on_drop: false }` [INFO] [stdout] d5f5ca980ca205abf968bd43a5e8110d96b86020afbcaf66ecd00ad0eb8d0c90