[INFO] cloning repository https://github.com/RaCs55/todo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RaCs55/todo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaCs55%2Ftodo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaCs55%2Ftodo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 18088be367251ad8a3281315ced4dcc9e0db1b40 [INFO] linting RaCs55/todo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaCs55%2Ftodo" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RaCs55/todo [INFO] finished tweaking git repo https://github.com/RaCs55/todo [INFO] tweaked toml for git repo https://github.com/RaCs55/todo written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RaCs55/todo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RaCs55/todo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_json_path v0.6.7 [INFO] [stderr] Downloaded serde_json_path_core v0.1.6 [INFO] [stderr] Downloaded serde_json_path_macros_internal v0.1.1 [INFO] [stderr] Downloaded serde_json_path_macros v0.1.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a13720e146f77dbda086bd446acf4fc971325c1d82e9459d6f797c99ea29eaf [INFO] running `Command { std: "docker" "start" "-a" "6a13720e146f77dbda086bd446acf4fc971325c1d82e9459d6f797c99ea29eaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a13720e146f77dbda086bd446acf4fc971325c1d82e9459d6f797c99ea29eaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a13720e146f77dbda086bd446acf4fc971325c1d82e9459d6f797c99ea29eaf", kill_on_drop: false }` [INFO] [stdout] 6a13720e146f77dbda086bd446acf4fc971325c1d82e9459d6f797c99ea29eaf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 04197ead519e27ed6754a7761048abfce4d211d09f20bb3caac026039f4f4a31 [INFO] running `Command { std: "docker" "start" "-a" "04197ead519e27ed6754a7761048abfce4d211d09f20bb3caac026039f4f4a31", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking ajson v0.3.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling serde_json_path_macros_internal v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking serde_json_path_core v0.1.6 [INFO] [stderr] Checking serde_json_path_macros v0.1.4 [INFO] [stderr] Checking serde_json_path v0.6.7 [INFO] [stderr] Checking todo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libs/functions.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/libs/functions.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/libs/functions.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if let id = item["id"].as_u64().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/libs/functions.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | if let id = item["id"].as_u64().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/libs/functions.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match add_task(name.to_string(), completed) { [INFO] [stdout] 42 | | Ok(_) => (), [INFO] [stdout] 43 | | Err(_) => (), [INFO] [stdout] 44 | | }; [INFO] [stdout] | |_____________^ help: try: `if let Ok(_) = add_task(name.to_string(), completed) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/libs/functions.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | / match add_task(name.to_string(), true) { [INFO] [stdout] 64 | | Ok(_) => (), [INFO] [stdout] 65 | | Err(_) => (), [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_____________^ help: try: `if let Ok(_) = add_task(name.to_string(), true) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/libs/functions.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | / match add_task(name.to_string(), completed) { [INFO] [stdout] 69 | | Ok(_) => (), [INFO] [stdout] 70 | | Err(_) => (), [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____________^ help: try: `if let Ok(_) = add_task(name.to_string(), completed) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/functions.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if !metadata("tasks.json").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("tasks.json").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/libs/functions.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 87 | let last_id = match get_last_id() { [INFO] [stdout] | ___________________^ [INFO] [stdout] 88 | | Ok(id) => id, [INFO] [stdout] 89 | | Err(_) => 0, [INFO] [stdout] 90 | | }; [INFO] [stdout] | |_____^ help: replace it with: `get_last_id().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/libs/functions.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if complete == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `complete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/libs/functions.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match add_task(name.to_string(), completed) { [INFO] [stdout] 42 | | Ok(_) => (), [INFO] [stdout] 43 | | Err(_) => (), [INFO] [stdout] 44 | | }; [INFO] [stdout] | |_____________^ help: try: `if let Ok(_) = add_task(name.to_string(), completed) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/libs/functions.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | / match add_task(name.to_string(), true) { [INFO] [stdout] 64 | | Ok(_) => (), [INFO] [stdout] 65 | | Err(_) => (), [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_____________^ help: try: `if let Ok(_) = add_task(name.to_string(), true) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/libs/functions.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | / match add_task(name.to_string(), completed) { [INFO] [stdout] 69 | | Ok(_) => (), [INFO] [stdout] 70 | | Err(_) => (), [INFO] [stdout] 71 | | } [INFO] [stdout] | |_____________^ help: try: `if let Ok(_) = add_task(name.to_string(), completed) { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs/functions.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if !metadata("tasks.json").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata("tasks.json").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/libs/functions.rs:87:19 [INFO] [stdout] | [INFO] [stdout] 87 | let last_id = match get_last_id() { [INFO] [stdout] | ___________________^ [INFO] [stdout] 88 | | Ok(id) => id, [INFO] [stdout] 89 | | Err(_) => 0, [INFO] [stdout] 90 | | }; [INFO] [stdout] | |_____^ help: replace it with: `get_last_id().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/libs/functions.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if complete == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `complete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.49s [INFO] running `Command { std: "docker" "inspect" "04197ead519e27ed6754a7761048abfce4d211d09f20bb3caac026039f4f4a31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04197ead519e27ed6754a7761048abfce4d211d09f20bb3caac026039f4f4a31", kill_on_drop: false }` [INFO] [stdout] 04197ead519e27ed6754a7761048abfce4d211d09f20bb3caac026039f4f4a31