[INFO] cloning repository https://github.com/REEEhor/game_of_life [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/REEEhor/game_of_life" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FREEEhor%2Fgame_of_life", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FREEEhor%2Fgame_of_life'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9cdb227998d4f7934b652d127c53a94b2c23f56a [INFO] linting REEEhor/game_of_life against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FREEEhor%2Fgame_of_life" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/REEEhor/game_of_life [INFO] finished tweaking git repo https://github.com/REEEhor/game_of_life [INFO] tweaked toml for git repo https://github.com/REEEhor/game_of_life written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/REEEhor/game_of_life on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/REEEhor/game_of_life already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3796f09dffb8858103d343472dad44928e4385d4162a80a07d79bae623765d1c [INFO] running `Command { std: "docker" "start" "-a" "3796f09dffb8858103d343472dad44928e4385d4162a80a07d79bae623765d1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3796f09dffb8858103d343472dad44928e4385d4162a80a07d79bae623765d1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3796f09dffb8858103d343472dad44928e4385d4162a80a07d79bae623765d1c", kill_on_drop: false }` [INFO] [stdout] 3796f09dffb8858103d343472dad44928e4385d4162a80a07d79bae623765d1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eef9e9ae780e4e1b907a9b5e1531284bf4478c4066f65f9f583fcd32a4b4ba2d [INFO] running `Command { std: "docker" "start" "-a" "eef9e9ae780e4e1b907a9b5e1531284bf4478c4066f65f9f583fcd32a4b4ba2d", kill_on_drop: false }` [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return self.width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return self.width; [INFO] [stdout] 21 + self.width [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.height; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.height; [INFO] [stdout] 25 + self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / return Ok(Screen { [INFO] [stdout] 74 | | width, [INFO] [stdout] 75 | | height, [INFO] [stdout] 76 | | data, [INFO] [stdout] 77 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 ~ Ok(Screen { [INFO] [stdout] 74 + width, [INFO] [stdout] 75 + height, [INFO] [stdout] 76 + data, [INFO] [stdout] 77 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/simulation/screen.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | data_line.extend(repeat(false).take(to_add_count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(false, to_add_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/simulation/screen.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | data.extend(repeat(vec![false; width]).take(to_add_count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(vec![false; width], to_add_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return &mut self.data[y][x]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return &mut self.data[y][x]; [INFO] [stdout] 81 + &mut self.data[y][x] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return self.data[y][x]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return self.data[y][x]; [INFO] [stdout] 85 + self.data[y][x] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return result; [INFO] [stdout] 114 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/simulation/mod.rs:55:44 [INFO] [stdout] | [INFO] [stdout] 55 | *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 56 | | || (!is_alive && neighbours == 3); [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 - *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] 56 - || (!is_alive && neighbours == 3); [INFO] [stdout] 55 + *new_buffer.at_mut(x, y) = !(!is_alive && neighbours != 3 || neighbours != 2 && neighbours != 3); [INFO] [stdout] | [INFO] [stdout] 55 - *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] 56 - || (!is_alive && neighbours == 3); [INFO] [stdout] 55 + *new_buffer.at_mut(x, y) = (neighbours == 3 || neighbours == 2) && (neighbours == 3 || is_alive); [INFO] [stdout] | [INFO] [stdout] 55 - *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] 56 - || (!is_alive && neighbours == 3); [INFO] [stdout] 55 + *new_buffer.at_mut(x, y) = neighbours == 3 || is_alive && neighbours == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | InvalidAction, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / if let Some(first_word) = words.next() { [INFO] [stdout] 18 | | Some(match first_word.to_ascii_lowercase().as_str() { [INFO] [stdout] 19 | | "n" | "next" => Action::Next, [INFO] [stdout] 20 | | "p" | "prev" | "previous" => Action::Previous, [INFO] [stdout] ... | [INFO] [stdout] 27 | | None [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 ~ words.next().map(|first_word| match first_word.to_ascii_lowercase().as_str() { [INFO] [stdout] 18 + "n" | "next" => Action::Next, [INFO] [stdout] 19 + "p" | "prev" | "previous" => Action::Previous, [INFO] [stdout] 20 + "e" | "exp" | "expand" => get_number_of_steps_to_precompute(&mut words), [INFO] [stdout] 21 + "q" | "quit" => Action::Quit, [INFO] [stdout] 22 + "h" | "help" => Action::Help, [INFO] [stdout] 23 + _ => Action::InvalidAction, [INFO] [stdout] 24 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | if let Some(how_many) = next_word.parse::().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(how_many)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 33 - if let Some(how_many) = next_word.parse::().ok() { [INFO] [stdout] 33 + if let Ok(how_many) = next_word.parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return self.width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return self.width; [INFO] [stdout] 21 + self.width [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.height; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.height; [INFO] [stdout] 25 + self.height [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | / return Ok(Screen { [INFO] [stdout] 74 | | width, [INFO] [stdout] 75 | | height, [INFO] [stdout] 76 | | data, [INFO] [stdout] 77 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 ~ Ok(Screen { [INFO] [stdout] 74 + width, [INFO] [stdout] 75 + height, [INFO] [stdout] 76 + data, [INFO] [stdout] 77 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/simulation/screen.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | data_line.extend(repeat(false).take(to_add_count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(false, to_add_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/simulation/screen.rs:71:21 [INFO] [stdout] | [INFO] [stdout] 71 | data.extend(repeat(vec![false; width]).take(to_add_count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(vec![false; width], to_add_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return &mut self.data[y][x]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return &mut self.data[y][x]; [INFO] [stdout] 81 + &mut self.data[y][x] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return self.data[y][x]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return self.data[y][x]; [INFO] [stdout] 85 + self.data[y][x] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulation/screen.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return result; [INFO] [stdout] 114 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/simulation/mod.rs:55:44 [INFO] [stdout] | [INFO] [stdout] 55 | *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 56 | | || (!is_alive && neighbours == 3); [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 - *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] 56 - || (!is_alive && neighbours == 3); [INFO] [stdout] 55 + *new_buffer.at_mut(x, y) = !(!is_alive && neighbours != 3 || neighbours != 2 && neighbours != 3); [INFO] [stdout] | [INFO] [stdout] 55 - *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] 56 - || (!is_alive && neighbours == 3); [INFO] [stdout] 55 + *new_buffer.at_mut(x, y) = (neighbours == 3 || neighbours == 2) && (neighbours == 3 || is_alive); [INFO] [stdout] | [INFO] [stdout] 55 - *new_buffer.at_mut(x, y) = (is_alive && (neighbours == 2 || neighbours == 3)) [INFO] [stdout] 56 - || (!is_alive && neighbours == 3); [INFO] [stdout] 55 + *new_buffer.at_mut(x, y) = neighbours == 3 || is_alive && neighbours == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | InvalidAction, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / if let Some(first_word) = words.next() { [INFO] [stdout] 18 | | Some(match first_word.to_ascii_lowercase().as_str() { [INFO] [stdout] 19 | | "n" | "next" => Action::Next, [INFO] [stdout] 20 | | "p" | "prev" | "previous" => Action::Previous, [INFO] [stdout] ... | [INFO] [stdout] 27 | | None [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 ~ words.next().map(|first_word| match first_word.to_ascii_lowercase().as_str() { [INFO] [stdout] 18 + "n" | "next" => Action::Next, [INFO] [stdout] 19 + "p" | "prev" | "previous" => Action::Previous, [INFO] [stdout] 20 + "e" | "exp" | "expand" => get_number_of_steps_to_precompute(&mut words), [INFO] [stdout] 21 + "q" | "quit" => Action::Quit, [INFO] [stdout] 22 + "h" | "help" => Action::Help, [INFO] [stdout] 23 + _ => Action::InvalidAction, [INFO] [stdout] 24 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | if let Some(how_many) = next_word.parse::().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(how_many)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 33 - if let Some(how_many) = next_word.parse::().ok() { [INFO] [stdout] 33 + if let Ok(how_many) = next_word.parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.39s [INFO] running `Command { std: "docker" "inspect" "eef9e9ae780e4e1b907a9b5e1531284bf4478c4066f65f9f583fcd32a4b4ba2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eef9e9ae780e4e1b907a9b5e1531284bf4478c4066f65f9f583fcd32a4b4ba2d", kill_on_drop: false }` [INFO] [stdout] eef9e9ae780e4e1b907a9b5e1531284bf4478c4066f65f9f583fcd32a4b4ba2d