[INFO] cloning repository https://github.com/RBird111/rust-capstone [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RBird111/rust-capstone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRBird111%2Frust-capstone", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRBird111%2Frust-capstone'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6a0b4cd4c1beafbce44f654d9302dad1fc1fff72 [INFO] linting RBird111/rust-capstone against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRBird111%2Frust-capstone" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RBird111/rust-capstone [INFO] finished tweaking git repo https://github.com/RBird111/rust-capstone [INFO] tweaked toml for git repo https://github.com/RBird111/rust-capstone written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RBird111/rust-capstone on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RBird111/rust-capstone already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded password-auth v1.0.0 [INFO] [stderr] Downloaded dsl_auto_type v0.1.0 [INFO] [stderr] Downloaded uuid v1.8.0 [INFO] [stderr] Downloaded bigdecimal v0.4.3 [INFO] [stderr] Downloaded actix_derive v0.6.1 [INFO] [stderr] Downloaded pq-sys v0.6.0 [INFO] [stderr] Downloaded v_htmlescape v0.15.8 [INFO] [stderr] Downloaded aws-smithy-query v0.60.7 [INFO] [stderr] Downloaded crc32c v0.6.5 [INFO] [stderr] Downloaded actix-files v0.6.5 [INFO] [stderr] Downloaded aws-smithy-async v1.2.1 [INFO] [stderr] Downloaded actix-session v0.9.0 [INFO] [stderr] Downloaded actix v0.13.3 [INFO] [stderr] Downloaded base64 v0.20.0 [INFO] [stderr] Downloaded aws-sdk-ssooidc v1.30.0 [INFO] [stderr] Downloaded aws-sdk-sso v1.29.0 [INFO] [stderr] Downloaded aws-config v1.5.1 [INFO] [stderr] Downloaded aws-sdk-sts v1.29.0 [INFO] [stderr] Downloaded actix-http v3.7.0 [INFO] [stderr] Downloaded hyper v0.14.29 [INFO] [stderr] Downloaded aws-smithy-runtime v1.5.5 [INFO] [stderr] Downloaded actix-web v4.6.0 [INFO] [stderr] Downloaded p256 v0.11.1 [INFO] [stderr] Downloaded aws-smithy-runtime-api v1.6.2 [INFO] [stderr] Downloaded aws-smithy-types v1.1.10 [INFO] [stderr] Downloaded regex-lite v0.1.5 [INFO] [stderr] Downloaded diesel v2.2.0 [INFO] [stderr] Downloaded aws-runtime v1.2.2 [INFO] [stderr] Downloaded aws-smithy-http v0.60.8 [INFO] [stderr] Downloaded aws-sigv4 v1.2.1 [INFO] [stderr] Downloaded aws-types v1.3.1 [INFO] [stderr] Downloaded diesel_derives v2.2.0 [INFO] [stderr] Downloaded aws-smithy-json v0.60.7 [INFO] [stderr] Downloaded aws-smithy-eventstream v0.60.4 [INFO] [stderr] Downloaded xmlparser v0.13.6 [INFO] [stderr] Downloaded vsimd v0.8.0 [INFO] [stderr] Downloaded bytes-utils v0.1.4 [INFO] [stderr] Downloaded aws-smithy-checksums v0.60.9 [INFO] [stderr] Downloaded aws-smithy-xml v0.60.8 [INFO] [stderr] Downloaded aws-credential-types v1.2.0 [INFO] [stderr] Downloaded outref v0.5.1 [INFO] [stderr] Downloaded base64-simd v0.8.0 [INFO] [stderr] Downloaded aws-sdk-s3 v1.34.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7c86e49f5408dfa628ef33acf8225d4313f3d2be740834d1d2d3662a9b5d587 [INFO] running `Command { std: "docker" "start" "-a" "f7c86e49f5408dfa628ef33acf8225d4313f3d2be740834d1d2d3662a9b5d587", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7c86e49f5408dfa628ef33acf8225d4313f3d2be740834d1d2d3662a9b5d587", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7c86e49f5408dfa628ef33acf8225d4313f3d2be740834d1d2d3662a9b5d587", kill_on_drop: false }` [INFO] [stdout] f7c86e49f5408dfa628ef33acf8225d4313f3d2be740834d1d2d3662a9b5d587 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e70811194728976e0cdea95cca8a3599f1169e95181490ee036a4cc8ae986c45 [INFO] running `Command { std: "docker" "start" "-a" "e70811194728976e0cdea95cca8a3599f1169e95181490ee036a4cc8ae986c45", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling aws-types v1.3.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling bigdecimal v0.4.3 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling pq-sys v0.6.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking num-bigint v0.4.5 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking password-auth v1.0.0 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Compiling crc32c v0.6.5 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling darling_core v0.20.9 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.2.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking actix-rt v2.9.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking aws-smithy-types v1.1.10 [INFO] [stderr] Compiling actix_derive v0.6.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling darling_macro v0.20.9 [INFO] [stderr] Checking actix v0.13.3 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking aws-smithy-eventstream v0.60.4 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Compiling darling v0.20.9 [INFO] [stderr] Checking aws-smithy-runtime-api v1.6.2 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Compiling dsl_auto_type v0.1.0 [INFO] [stderr] Checking actix-server v2.3.0 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Compiling diesel_derives v2.2.0 [INFO] [stderr] Checking aws-smithy-http v0.60.8 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Compiling actix-web-codegen v4.2.2 [INFO] [stderr] Checking aws-sigv4 v1.2.1 [INFO] [stderr] Checking aws-smithy-checksums v0.60.9 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking aws-runtime v1.2.2 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking hyper v0.14.29 [INFO] [stderr] Checking actix-http v3.7.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking diesel v2.2.0 [INFO] [stderr] Checking actix-web v4.6.0 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.5.5 [INFO] [stderr] Checking actix-files v0.6.5 [INFO] [stderr] Checking actix-session v0.9.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.30.0 [INFO] [stderr] Checking aws-sdk-sso v1.29.0 [INFO] [stderr] Checking aws-sdk-sts v1.29.0 [INFO] [stderr] Checking aws-sdk-s3 v1.34.0 [INFO] [stderr] Checking aws-config v1.5.1 [INFO] [stderr] Checking database v0.1.0 (/opt/rustwide/workdir/database) [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | Ok(BusinessArray::new(business_array).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 21 - Ok(BusinessArray::new(business_array).eager_load(conn)?) [INFO] [stdout] 21 + BusinessArray::new(business_array).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(new_business.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 35 - Ok(new_business.eager_load(conn)?) [INFO] [stdout] 35 + new_business.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(business.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 40 - Ok(business.eager_load(conn)?) [INFO] [stdout] 40 + business.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | Ok(updated_business.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 47 - Ok(updated_business.eager_load(conn)?) [INFO] [stdout] 47 + updated_business.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Ok(image_data.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 11 - Ok(image_data.eager_load(conn)?) [INFO] [stdout] 11 + image_data.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | Ok(image.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 16 - Ok(image.eager_load(conn)?) [INFO] [stdout] 16 + image.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | Ok(image_data.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 26 - Ok(image_data.eager_load(conn)?) [INFO] [stdout] 26 + image_data.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(new_image.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 31 - Ok(new_image.eager_load(conn)?) [INFO] [stdout] 31 + new_image.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | Ok(locations.select(Location::as_select()).load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 9 - Ok(locations.select(Location::as_select()).load(conn)?) [INFO] [stdout] 9 + locations.select(Location::as_select()).load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Ok(locations.find(location_id).first(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 13 - Ok(locations.find(location_id).first(conn)?) [INFO] [stdout] 13 + locations.find(location_id).first(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / Ok(locations [INFO] [stdout] 18 | | .select(Location::as_select()) [INFO] [stdout] 19 | | .filter(address.eq(loc_address)) [INFO] [stdout] 20 | | .first(conn)?) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 17 ~ locations [INFO] [stdout] 18 | .select(Location::as_select()) [INFO] [stdout] 19 | .filter(address.eq(loc_address)) [INFO] [stdout] 20 ~ .first(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / Ok(diesel::insert_into(locations) [INFO] [stdout] 28 | | .values(location) [INFO] [stdout] 29 | | .get_result(conn)?) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 27 ~ diesel::insert_into(locations) [INFO] [stdout] 28 | .values(location) [INFO] [stdout] 29 ~ .get_result(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / Ok(diesel::update(locations.filter(id.eq(location.id))) [INFO] [stdout] 34 | | .set(location) [INFO] [stdout] 35 | | .get_result(conn)?) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 33 ~ diesel::update(locations.filter(id.eq(location.id))) [INFO] [stdout] 34 | .set(location) [INFO] [stdout] 35 ~ .get_result(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Ok(review_arr.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 12 - Ok(review_arr.eager_load(conn)?) [INFO] [stdout] 12 + review_arr.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / Ok(reviews [INFO] [stdout] 17 | | .find(review_id) [INFO] [stdout] 18 | | .first::(conn)? [INFO] [stdout] 19 | | .eager_load(conn)?) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 16 ~ reviews [INFO] [stdout] 17 | .find(review_id) [INFO] [stdout] 18 | .first::(conn)? [INFO] [stdout] 19 ~ .eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(ReviewArray::new(rand_reviews).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 31 - Ok(ReviewArray::new(rand_reviews).eager_load(conn)?) [INFO] [stdout] 31 + ReviewArray::new(rand_reviews).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | Ok(new_review.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 50 - Ok(new_review.eager_load(conn)?) [INFO] [stdout] 50 + new_review.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(updated_review.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 58 - Ok(updated_review.eager_load(conn)?) [INFO] [stdout] 58 + updated_review.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | Ok(ReviewArray::new(user_reviews).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 79 - Ok(ReviewArray::new(user_reviews).eager_load(conn)?) [INFO] [stdout] 79 + ReviewArray::new(user_reviews).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/user.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Ok(UserArray::new(all_users).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 11 - Ok(UserArray::new(all_users).eager_load(conn)?) [INFO] [stdout] 11 + UserArray::new(all_users).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/user.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Ok(users.find(user_id).first(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 15 - Ok(users.find(user_id).first(conn)?) [INFO] [stdout] 15 + users.find(user_id).first(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/user.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | Ok(updated_user.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 49 - Ok(updated_user.eager_load(conn)?) [INFO] [stdout] 49 + updated_user.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | Ok(BusinessArray::new(business_array).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 21 - Ok(BusinessArray::new(business_array).eager_load(conn)?) [INFO] [stdout] 21 + BusinessArray::new(business_array).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(new_business.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 35 - Ok(new_business.eager_load(conn)?) [INFO] [stdout] 35 + new_business.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(business.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 40 - Ok(business.eager_load(conn)?) [INFO] [stdout] 40 + business.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/business.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | Ok(updated_business.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 47 - Ok(updated_business.eager_load(conn)?) [INFO] [stdout] 47 + updated_business.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Ok(image_data.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 11 - Ok(image_data.eager_load(conn)?) [INFO] [stdout] 11 + image_data.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | Ok(image.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 16 - Ok(image.eager_load(conn)?) [INFO] [stdout] 16 + image.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | Ok(image_data.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 26 - Ok(image_data.eager_load(conn)?) [INFO] [stdout] 26 + image_data.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/image.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(new_image.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 31 - Ok(new_image.eager_load(conn)?) [INFO] [stdout] 31 + new_image.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | Ok(locations.select(Location::as_select()).load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 9 - Ok(locations.select(Location::as_select()).load(conn)?) [INFO] [stdout] 9 + locations.select(Location::as_select()).load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | Ok(locations.find(location_id).first(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 13 - Ok(locations.find(location_id).first(conn)?) [INFO] [stdout] 13 + locations.find(location_id).first(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / Ok(locations [INFO] [stdout] 18 | | .select(Location::as_select()) [INFO] [stdout] 19 | | .filter(address.eq(loc_address)) [INFO] [stdout] 20 | | .first(conn)?) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 17 ~ locations [INFO] [stdout] 18 | .select(Location::as_select()) [INFO] [stdout] 19 | .filter(address.eq(loc_address)) [INFO] [stdout] 20 ~ .first(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / Ok(diesel::insert_into(locations) [INFO] [stdout] 28 | | .values(location) [INFO] [stdout] 29 | | .get_result(conn)?) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 27 ~ diesel::insert_into(locations) [INFO] [stdout] 28 | .values(location) [INFO] [stdout] 29 ~ .get_result(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/location.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | / Ok(diesel::update(locations.filter(id.eq(location.id))) [INFO] [stdout] 34 | | .set(location) [INFO] [stdout] 35 | | .get_result(conn)?) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 33 ~ diesel::update(locations.filter(id.eq(location.id))) [INFO] [stdout] 34 | .set(location) [INFO] [stdout] 35 ~ .get_result(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | Ok(review_arr.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 12 - Ok(review_arr.eager_load(conn)?) [INFO] [stdout] 12 + review_arr.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / Ok(reviews [INFO] [stdout] 17 | | .find(review_id) [INFO] [stdout] 18 | | .first::(conn)? [INFO] [stdout] 19 | | .eager_load(conn)?) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 16 ~ reviews [INFO] [stdout] 17 | .find(review_id) [INFO] [stdout] 18 | .first::(conn)? [INFO] [stdout] 19 ~ .eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(ReviewArray::new(rand_reviews).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 31 - Ok(ReviewArray::new(rand_reviews).eager_load(conn)?) [INFO] [stdout] 31 + ReviewArray::new(rand_reviews).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | Ok(new_review.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 50 - Ok(new_review.eager_load(conn)?) [INFO] [stdout] 50 + new_review.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(updated_review.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 58 - Ok(updated_review.eager_load(conn)?) [INFO] [stdout] 58 + updated_review.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/review.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | Ok(ReviewArray::new(user_reviews).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 79 - Ok(ReviewArray::new(user_reviews).eager_load(conn)?) [INFO] [stdout] 79 + ReviewArray::new(user_reviews).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/user.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | Ok(UserArray::new(all_users).eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 11 - Ok(UserArray::new(all_users).eager_load(conn)?) [INFO] [stdout] 11 + UserArray::new(all_users).eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/user.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Ok(users.find(user_id).first(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 15 - Ok(users.find(user_id).first(conn)?) [INFO] [stdout] 15 + users.find(user_id).first(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> database/src/actions/user.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | Ok(updated_user.eager_load(conn)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 49 - Ok(updated_user.eager_load(conn)?) [INFO] [stdout] 49 + updated_user.eager_load(conn) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking server v0.1.0 (/opt/rustwide/workdir/server) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 47s [INFO] running `Command { std: "docker" "inspect" "e70811194728976e0cdea95cca8a3599f1169e95181490ee036a4cc8ae986c45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e70811194728976e0cdea95cca8a3599f1169e95181490ee036a4cc8ae986c45", kill_on_drop: false }` [INFO] [stdout] e70811194728976e0cdea95cca8a3599f1169e95181490ee036a4cc8ae986c45