[INFO] cloning repository https://github.com/RACE-Game/race-solana [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RACE-Game/race-solana" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRACE-Game%2Frace-solana", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRACE-Game%2Frace-solana'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fc2c607a713d012c0caa65ba5dc57ab2f7d11036 [INFO] linting RACE-Game/race-solana against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRACE-Game%2Frace-solana" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/RACE-Game/race-solana [INFO] finished tweaking git repo https://github.com/RACE-Game/race-solana [INFO] tweaked toml for git repo https://github.com/RACE-Game/race-solana written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/RACE-Game/race-solana on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/RACE-Game/race-solana already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror v2.0.6 [INFO] [stderr] Downloaded cpufeatures v0.2.16 [INFO] [stderr] Downloaded thiserror-impl v2.0.6 [INFO] [stderr] Downloaded spl-token v4.0.3 [INFO] [stderr] Downloaded ark-bn254 v0.4.0 [INFO] [stderr] Downloaded ark-serialize-derive v0.4.2 [INFO] [stderr] Downloaded spl-pod v0.2.5 [INFO] [stderr] Downloaded bytemuck_derive v1.8.0 [INFO] [stderr] Downloaded qualifier_attr v0.2.2 [INFO] [stderr] Downloaded tiny-bip39 v0.8.2 [INFO] [stderr] Downloaded spl-memo v4.0.4 [INFO] [stderr] Downloaded spl-discriminator-derive v0.2.0 [INFO] [stderr] Downloaded ark-poly v0.4.2 [INFO] [stderr] Downloaded solana-security-txt v1.1.1 [INFO] [stderr] Downloaded borsh v1.5.3 [INFO] [stderr] Downloaded solana-program v1.18.26 [INFO] [stderr] Downloaded winnow v0.6.20 [INFO] [stderr] Downloaded serde_with v2.3.3 [INFO] [stderr] Downloaded solana-sdk v1.18.26 [INFO] [stderr] Downloaded blake3 v1.5.5 [INFO] [stderr] Downloaded serde_json v1.0.133 [INFO] [stderr] Downloaded spl-token-2022 v3.0.5 [INFO] [stderr] Downloaded syn v2.0.90 [INFO] [stderr] Downloaded im v15.1.0 [INFO] [stderr] Downloaded ark-ec v0.4.2 [INFO] [stderr] Downloaded sized-chunks v0.6.5 [INFO] [stderr] Downloaded anyhow v1.0.94 [INFO] [stderr] Downloaded spl-tlv-account-resolution v0.6.5 [INFO] [stderr] Downloaded uriparse v0.6.4 [INFO] [stderr] Downloaded aes-gcm-siv v0.10.3 [INFO] [stderr] Downloaded assert_matches v1.5.0 [INFO] [stderr] Downloaded signature v1.6.4 [INFO] [stderr] Downloaded light-poseidon v0.2.0 [INFO] [stderr] Downloaded ed25519 v1.5.3 [INFO] [stderr] Downloaded ed25519-dalek-bip32 v0.2.0 [INFO] [stderr] Downloaded env_logger v0.9.3 [INFO] [stderr] Downloaded proc-macro-crate v3.2.0 [INFO] [stderr] Downloaded borsh-derive v1.5.3 [INFO] [stderr] Downloaded cc v1.2.3 [INFO] [stderr] Downloaded mpl-token-metadata v3.2.3 [INFO] [stderr] Downloaded redox_syscall v0.5.8 [INFO] [stderr] Downloaded curve25519-dalek v3.2.1 [INFO] [stderr] Downloaded web-sys v0.3.76 [INFO] [stderr] Downloaded rand_xoshiro v0.6.0 [INFO] [stderr] Downloaded libc v0.2.168 [INFO] [stderr] Downloaded bitmaps v2.1.0 [INFO] [stderr] Downloaded spl-token-group-interface v0.2.5 [INFO] [stderr] Downloaded spl-token-metadata-interface v0.3.5 [INFO] [stderr] Downloaded spl-transfer-hook-interface v0.6.5 [INFO] [stderr] Downloaded spl-discriminator-syn v0.2.0 [INFO] [stderr] Downloaded spl-discriminator v0.2.5 [INFO] [stderr] Downloaded derivation-path v0.2.0 [INFO] [stderr] Downloaded qstring v0.7.2 [INFO] [stderr] Downloaded serde_with_macros v2.3.3 [INFO] [stderr] Downloaded solana-logger v1.18.26 [INFO] [stderr] Downloaded spl-program-error-derive v0.4.1 [INFO] [stderr] Downloaded spl-type-length-value v0.4.6 [INFO] [stderr] Downloaded borsh-derive-internal v0.9.3 [INFO] [stderr] Downloaded borsh-derive v0.9.3 [INFO] [stderr] Downloaded borsh v0.9.3 [INFO] [stderr] Downloaded solana-sdk-macro v1.18.26 [INFO] [stderr] Downloaded spl-program-error v0.4.4 [INFO] [stderr] Downloaded spl-associated-token-account v3.0.4 [INFO] [stderr] Downloaded borsh-schema-derive-internal v0.9.3 [INFO] [stderr] Downloaded solana-frozen-abi v1.18.26 [INFO] [stderr] Downloaded solana-frozen-abi-macro v1.18.26 [INFO] [stderr] Downloaded serde v1.0.216 [INFO] [stderr] Downloaded serde_derive v1.0.216 [INFO] [stderr] Downloaded serde_bytes v0.11.15 [INFO] [stderr] Downloaded pbkdf2 v0.4.0 [INFO] [stderr] Downloaded solana-zk-token-sdk v1.18.26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 91aae1f7bea5511f62037b22c0ca5526b58839724babcb386b177b8473f405f5 [INFO] running `Command { std: "docker" "start" "-a" "91aae1f7bea5511f62037b22c0ca5526b58839724babcb386b177b8473f405f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "91aae1f7bea5511f62037b22c0ca5526b58839724babcb386b177b8473f405f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91aae1f7bea5511f62037b22c0ca5526b58839724babcb386b177b8473f405f5", kill_on_drop: false }` [INFO] [stdout] 91aae1f7bea5511f62037b22c0ca5526b58839724babcb386b177b8473f405f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b672843bbcd38e846297009dd955090149fb90d63becdf1bb6b485dfce602d39 [INFO] running `Command { std: "docker" "start" "-a" "b672843bbcd38e846297009dd955090149fb90d63becdf1bb6b485dfce602d39", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling serde v1.0.216 [INFO] [stderr] Compiling libc v0.2.168 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking cpufeatures v0.2.16 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling hashbrown v0.15.2 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.99 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling feature-probe v0.1.1 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling bv v0.11.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling solana-frozen-abi-macro v1.18.26 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling indexmap v2.7.0 [INFO] [stderr] Compiling rustversion v1.0.18 [INFO] [stderr] Compiling anyhow v1.0.94 [INFO] [stderr] Compiling borsh v1.5.3 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling cc v1.2.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling solana-frozen-abi v1.18.26 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling wasm-bindgen v0.2.99 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking bs58 v0.4.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Compiling solana-sdk v1.18.26 [INFO] [stderr] Compiling digest v0.9.0 [INFO] [stderr] Compiling libsecp256k1-core v0.2.2 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking derivation-path v0.2.0 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Checking uriparse v0.6.4 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking solana-security-txt v1.1.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling thiserror v2.0.6 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling blake3 v1.5.5 [INFO] [stderr] Compiling solana-program v1.18.26 [INFO] [stderr] Compiling libsecp256k1-gen-genmult v0.2.1 [INFO] [stderr] Compiling libsecp256k1-gen-ecmult v0.2.1 [INFO] [stderr] Compiling libsecp256k1 v0.6.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.99 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking solana-logger v1.18.26 [INFO] [stderr] Compiling serde_derive v1.0.216 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling borsh-derive v1.5.3 [INFO] [stderr] Compiling bytemuck_derive v1.8.0 [INFO] [stderr] Compiling solana-sdk-macro v1.18.26 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling num_enum_derive v0.7.3 [INFO] [stderr] Compiling qualifier_attr v0.2.2 [INFO] [stderr] Compiling spl-program-error-derive v0.4.1 [INFO] [stderr] Compiling borsh-schema-derive-internal v0.10.4 [INFO] [stderr] Compiling borsh-derive-internal v0.9.3 [INFO] [stderr] Compiling borsh-derive-internal v0.10.4 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling borsh-schema-derive-internal v0.9.3 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.99 [INFO] [stderr] Compiling thiserror-impl v2.0.6 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking num_enum v0.7.3 [INFO] [stderr] Checking bytemuck v1.20.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling spl-discriminator-syn v0.2.0 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Compiling ark-serialize-derive v0.4.2 [INFO] [stderr] Compiling ark-ff-asm v0.4.2 [INFO] [stderr] Compiling ark-ff-macros v0.4.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling borsh-derive v0.10.4 [INFO] [stderr] Compiling borsh-derive v0.9.3 [INFO] [stderr] Compiling spl-discriminator-derive v0.2.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking borsh v0.9.3 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.99 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking borsh v0.10.4 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Checking ark-std v0.4.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking pbkdf2 v0.4.0 [INFO] [stderr] Checking hmac v0.8.1 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking polyval v0.5.3 [INFO] [stderr] Checking ctr v0.8.0 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking hmac-drbg v0.3.0 [INFO] [stderr] Checking ark-serialize v0.4.2 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking aes-gcm-siv v0.10.3 [INFO] [stderr] Checking ark-ff v0.4.2 [INFO] [stderr] Checking tiny-bip39 v0.8.2 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking ed25519-dalek-bip32 v0.2.0 [INFO] [stderr] Checking ark-poly v0.4.2 [INFO] [stderr] Checking ark-ec v0.4.2 [INFO] [stderr] Checking ark-bn254 v0.4.0 [INFO] [stderr] Checking light-poseidon v0.2.0 [INFO] [stderr] Checking spl-program-error v0.4.4 [INFO] [stderr] Checking spl-discriminator v0.2.5 [INFO] [stderr] Checking spl-memo v4.0.4 [INFO] [stderr] Checking spl-token v4.0.3 [INFO] [stderr] Checking mpl-token-metadata v3.2.3 [INFO] [stderr] Checking solana-zk-token-sdk v1.18.26 [INFO] [stderr] Checking spl-pod v0.2.5 [INFO] [stderr] Checking spl-type-length-value v0.4.6 [INFO] [stderr] Checking spl-token-group-interface v0.2.5 [INFO] [stderr] Checking spl-tlv-account-resolution v0.6.5 [INFO] [stderr] Checking spl-token-metadata-interface v0.3.5 [INFO] [stderr] Checking spl-transfer-hook-interface v0.6.5 [INFO] [stderr] Checking spl-token-2022 v3.0.5 [INFO] [stderr] Checking spl-associated-token-account v3.0.4 [INFO] [stderr] Checking race-solana v0.2.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `solana` [INFO] [stdout] --> src/entrypoint.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | entrypoint!(process_instruction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `$crate::custom_heap_default` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `$crate::custom_heap_default` may come from an old version of the `solana_program` crate, try updating your dependency with `cargo update -p solana_program` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::custom_heap_default` which comes from the expansion of the macro `entrypoint` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `solana` [INFO] [stdout] --> src/entrypoint.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | entrypoint!(process_instruction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `$crate::custom_panic_default` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `$crate::custom_panic_default` may come from an old version of the `solana_program` crate, try updating your dependency with `cargo update -p solana_program` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `$crate::custom_panic_default` which comes from the expansion of the macro `entrypoint` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `solana` [INFO] [stdout] --> src/entrypoint.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | entrypoint!(process_instruction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `$crate::custom_heap_default` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `$crate::custom_heap_default` may come from an old version of the `solana_program` crate, try updating your dependency with `cargo update -p solana_program` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::custom_heap_default` which comes from the expansion of the macro `entrypoint` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `solana` [INFO] [stdout] --> src/entrypoint.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | entrypoint!(process_instruction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `amdhsa`, `android`, `cuda`, `cygwin`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `helenos`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `lynxos178`, `macos`, `managarm`, `motor`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `psx`, `qurt`, `redox`, `rtems`, `solaris`, and `solid_asp3` and 14 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `$crate::custom_panic_default` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `$crate::custom_panic_default` may come from an old version of the `solana_program` crate, try updating your dependency with `cargo update -p solana_program` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `$crate::custom_panic_default` which comes from the expansion of the macro `entrypoint` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LegacyServerState` is never constructed [INFO] [stdout] --> src/state/server.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct LegacyServerState { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LegacyPlayerState` is never constructed [INFO] [stdout] --> src/state/profile.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct LegacyPlayerState { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TokenInfo` is never constructed [INFO] [stdout] --> src/types.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct TokenInfo { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnregisterTransactorParams` is never constructed [INFO] [stdout] --> src/types.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub struct UnregisterTransactorParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RegisterGameParams` is never constructed [INFO] [stdout] --> src/types.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | pub struct RegisterGameParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnregisterGameParams` is never constructed [INFO] [stdout] --> src/types.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | pub struct UnregisterGameParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GetTransactorInfoParams` is never constructed [INFO] [stdout] --> src/types.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub struct GetTransactorInfoParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PlayerStatus` is never used [INFO] [stdout] --> src/types.rs:105:10 [INFO] [stdout] | [INFO] [stdout] 105 | pub enum PlayerStatus { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `AssetChange` is never used [INFO] [stdout] --> src/types.rs:112:10 [INFO] [stdout] | [INFO] [stdout] 112 | pub enum AssetChange { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERVER_ACCOUNT_LEN` is never used [INFO] [stdout] --> src/constants.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const SERVER_ACCOUNT_LEN: usize = 108; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/close_game.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 35 | if bonus.stake_addr.ne(&bonus_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `bonus_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_return_with_question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/close_game.rs:44:27 [INFO] [stdout] | [INFO] [stdout] 44 | validate_receiver(&owner_account.key, &bonus.token_addr, receiver_account.key)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `owner_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/close_game.rs:97:28 [INFO] [stdout] | [INFO] [stdout] 97 | if game_state.owner.ne(&owner_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `owner_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return Err(ProcessError::InvalidPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return Err(ProcessError::InvalidPDA)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | if game_account.owner.ne(&program_id) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `program_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 66 | if players_reg_account.owner.ne(&program_id) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `program_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | if is_native_mint(&token_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `token_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | if pda_stake.ne(&stake_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `stake_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_game.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_game.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | return Err(ProcessError::InvalidTokenMint)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 92 | if stake_state.mint.ne(&token_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `token_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_game.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 102 | &[&payer.key], [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_game.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | owner: payer.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:141:39 [INFO] [stdout] | [INFO] [stdout] 141 | pack_state_to_account(game_state, &game_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:141:54 [INFO] [stdout] | [INFO] [stdout] 141 | pack_state_to_account(game_state, &game_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:141:62 [INFO] [stdout] | [INFO] [stdout] 141 | pack_state_to_account(game_state, &game_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::InvalidAccountStatus)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return Err(ProgramError::AccountNotRentExempt)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(ProcessError::InvalidAccountPubkey)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_profile.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | Some(pfp_account.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*pfp_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(ProcessError::InconsistentCredentials)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_profile.rs:72:42 [INFO] [stdout] | [INFO] [stdout] 72 | pack_state_to_account(profile_state, &profile_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `profile_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_profile.rs:72:60 [INFO] [stdout] | [INFO] [stdout] 72 | pack_state_to_account(profile_state, &profile_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `owner_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_profile.rs:72:76 [INFO] [stdout] | [INFO] [stdout] 72 | pack_state_to_account(profile_state, &profile_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_registry.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | owner: payer.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/processor/join.rs:29:38 [INFO] [stdout] | [INFO] [stdout] 29 | let account_iter = &mut accounts.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return Err(ProcessError::InvalidSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(ProcessError::InvalidMint)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return Err(ProcessError::GameFullAlready)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Err(ProcessError::InvalidPosition)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:109:75 [INFO] [stdout] | [INFO] [stdout] 109 | if players::is_player_joined(&players_reg_account.try_borrow_data()?, &player_account.key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `player_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return Err(ProcessError::JoinedGameAlready)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 165 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/processor/join.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | params.amount as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `params.amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:185:15 [INFO] [stdout] | [INFO] [stdout] 185 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/join.rs:211:15 [INFO] [stdout] | [INFO] [stdout] 211 | addr: payer_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:219:47 [INFO] [stdout] | [INFO] [stdout] 219 | append_state_to_account(&player_join, &players_reg_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `players_reg_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:219:69 [INFO] [stdout] | [INFO] [stdout] 219 | append_state_to_account(&player_join, &players_reg_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:219:85 [INFO] [stdout] | [INFO] [stdout] 219 | append_state_to_account(&player_join, &players_reg_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/join.rs:223:15 [INFO] [stdout] | [INFO] [stdout] 223 | addr: payer_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:232:39 [INFO] [stdout] | [INFO] [stdout] 232 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:232:54 [INFO] [stdout] | [INFO] [stdout] 232 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:232:70 [INFO] [stdout] | [INFO] [stdout] 232 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/misc.rs:38:28 [INFO] [stdout] | [INFO] [stdout] 38 | if receiver_key.ne(&account_key) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `account_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/misc.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return Err(ProcessError::InvalidReceiverAddress)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/misc.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(ProcessError::ReceiverUninitialized)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/misc.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | &pda.key, [INFO] [stdout] | ^^^^^^^^ help: change this to: `pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | &token_program.key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `token_program.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &mint_account.key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | &ata_account.key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `ata_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | &payer.key, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 62 | &[&payer.key], [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | address: payer.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 82 | address: mint_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | .payer(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 100 | .mint(mint_account.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | .metadata(metadata_pda.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*metadata_pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | .update_authority(payer.key.clone(), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:103:25 [INFO] [stdout] | [INFO] [stdout] 103 | .mint_authority(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | .update_authority(payer.key.clone(), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 135 | .edition(edition_pda.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*edition_pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 136 | .mint(mint_account.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:137:25 [INFO] [stdout] | [INFO] [stdout] 137 | .mint_authority(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LegacyServerState` is never constructed [INFO] [stdout] --> src/state/server.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct LegacyServerState { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LegacyPlayerState` is never constructed [INFO] [stdout] --> src/state/profile.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct LegacyPlayerState { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | .update_authority(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TokenInfo` is never constructed [INFO] [stdout] --> src/types.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct TokenInfo { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnregisterTransactorParams` is never constructed [INFO] [stdout] --> src/types.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub struct UnregisterTransactorParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:139:19 [INFO] [stdout] | [INFO] [stdout] 139 | .metadata(metadata_pda.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*metadata_pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RegisterGameParams` is never constructed [INFO] [stdout] --> src/types.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | pub struct RegisterGameParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnregisterGameParams` is never constructed [INFO] [stdout] --> src/types.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 87 | pub struct UnregisterGameParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | .payer(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GetTransactorInfoParams` is never constructed [INFO] [stdout] --> src/types.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub struct GetTransactorInfoParams { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PlayerStatus` is never used [INFO] [stdout] --> src/types.rs:105:10 [INFO] [stdout] | [INFO] [stdout] 105 | pub enum PlayerStatus { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `AssetChange` is never used [INFO] [stdout] --> src/types.rs:112:10 [INFO] [stdout] | [INFO] [stdout] 112 | pub enum AssetChange { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SERVER_ACCOUNT_LEN` is never used [INFO] [stdout] --> src/constants.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | pub const SERVER_ACCOUNT_LEN: usize = 108; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return Err(ProcessError::RegistrationIsFull)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(ProcessError::RegistrationIsFull)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/processor/register_game.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / if registry_state.games.len() > 0 { [INFO] [stdout] 56 | | if registry_state [INFO] [stdout] 57 | | .games [INFO] [stdout] 58 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if registry_state.games.len() > 0 [INFO] [stdout] 56 ~ && registry_state [INFO] [stdout] 57 | .games [INFO] [stdout] ... [INFO] [stdout] 61 | return Err(ProcessError::GameAlreadyRegistered)?; [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/processor/register_game.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | if registry_state.games.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry_state.games.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(ProcessError::GameAlreadyRegistered)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/register_game.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | addr: game_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*game_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/register_game.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | bundle_addr: game_state.bundle_addr.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `game_state.bundle_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_game.rs:82:43 [INFO] [stdout] | [INFO] [stdout] 82 | pack_state_to_account(registry_state, ®istry_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `registry_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_game.rs:82:62 [INFO] [stdout] | [INFO] [stdout] 82 | pack_state_to_account(registry_state, ®istry_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_game.rs:82:70 [INFO] [stdout] | [INFO] [stdout] 82 | pack_state_to_account(registry_state, ®istry_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_server.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return Err(ProcessError::InvalidAccountStatus)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/close_game.rs:35:32 [INFO] [stdout] | [INFO] [stdout] 35 | if bonus.stake_addr.ne(&bonus_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `bonus_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_return_with_question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/close_game.rs:44:27 [INFO] [stdout] | [INFO] [stdout] 44 | validate_receiver(&owner_account.key, &bonus.token_addr, receiver_account.key)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `owner_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_server.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(ProcessError::InvalidAccountPubkey)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_server.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | return Err(ProcessError::InconsistentCredentials)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/register_server.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | addr: server_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_server.rs:59:41 [INFO] [stdout] | [INFO] [stdout] 59 | pack_state_to_account(server_state, &server_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `server_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_server.rs:59:58 [INFO] [stdout] | [INFO] [stdout] 59 | pack_state_to_account(server_state, &server_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `owner_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_server.rs:59:74 [INFO] [stdout] | [INFO] [stdout] 59 | pack_state_to_account(server_state, &server_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return Err(ProcessError::InvalidAccountStatus)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::InvalidPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return Err(ProcessError::ServerAccountNotAvailable)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/close_game.rs:97:28 [INFO] [stdout] | [INFO] [stdout] 97 | if game_state.owner.ne(&owner_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `owner_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return Err(ProcessError::InvalidPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/close_game.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return Err(ProcessError::InvalidPDA)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Err(ProcessError::DuplicateServerJoin)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(ProcessError::ServerNumberExceedsLimit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return Err(ProcessError::DuplicateServerJoin)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/processor/serve.rs:75:48 [INFO] [stdout] | [INFO] [stdout] 75 | if game_state.transactor_addr.is_none() || game_state.servers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game_state.servers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/serve.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/serve.rs:91:54 [INFO] [stdout] | [INFO] [stdout] 91 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/serve.rs:91:70 [INFO] [stdout] | [INFO] [stdout] 91 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return Err(ProcessError::InvalidSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return Err(ProcessError::InvalidNextSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | if game_account.owner.ne(&program_id) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `program_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | if pda.ne(&pda_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `pda_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Err(ProcessError::InvalidPDA)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 66 | if players_reg_account.owner.ne(&program_id) { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `program_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | if is_native_mint(&token_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `token_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:80:25 [INFO] [stdout] | [INFO] [stdout] 80 | if pda_stake.ne(&stake_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `stake_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_game.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | validate_balance(&game_state, &stake_account)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `stake_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_game.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | return Err(ProcessError::InvalidTokenMint)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | &game_account, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 92 | if stake_state.mint.ne(&token_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `token_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | &transactor_account, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `transactor_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_game.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | &system_program, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/processor/settle.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | if !(stake_amount == balance_sum + unhandled_deposit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(stake_amount != balance_sum + unhandled_deposit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 102 | &[&payer.key], [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/processor/settle.rs:211:1 [INFO] [stdout] | [INFO] [stdout] 211 | / fn handle_settles<'a, 'b, 'c, I: Iterator>>( [INFO] [stdout] 212 | | game_state: &'c mut GameState, [INFO] [stdout] 213 | | settles: Vec, [INFO] [stdout] 214 | | game_account: &'a AccountInfo<'b>, [INFO] [stdout] ... | [INFO] [stdout] 220 | | account_iter: &'c mut I, [INFO] [stdout] 221 | | ) -> ProgramResult { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:249:21 [INFO] [stdout] | [INFO] [stdout] 249 | return Err(ProcessError::InvalidSettleBalance)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:274:58 [INFO] [stdout] | [INFO] [stdout] 274 | validate_receiver(&addr, &game_state.token_mint, &receiver.key)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `receiver.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | &receiver, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/processor/settle.rs:290:1 [INFO] [stdout] | [INFO] [stdout] 290 | / fn handle_bonuses<'a, 'b, 'c, I: Iterator>>( [INFO] [stdout] 291 | | game_state: &'c mut GameState, [INFO] [stdout] 292 | | awards: Vec, [INFO] [stdout] 293 | | game_account: &'a AccountInfo<'b>, [INFO] [stdout] ... | [INFO] [stdout] 299 | | account_iter: &'c mut I, [INFO] [stdout] 300 | | ) -> ProgramResult { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:314:36 [INFO] [stdout] | [INFO] [stdout] 314 | if bonus.stake_addr.ne(&bonus_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `bonus_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | return Err(ProcessError::InvalidAwardIdentifier)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_game.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 118 | owner: payer.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:141:39 [INFO] [stdout] | [INFO] [stdout] 141 | pack_state_to_account(game_state, &game_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:141:54 [INFO] [stdout] | [INFO] [stdout] 141 | pack_state_to_account(game_state, &game_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_game.rs:141:62 [INFO] [stdout] | [INFO] [stdout] 141 | pack_state_to_account(game_state, &game_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/processor/settle.rs:359:1 [INFO] [stdout] | [INFO] [stdout] 359 | / fn handle_transfer<'a, 'b, 'c, I: Iterator>>( [INFO] [stdout] 360 | | game_state: &'c GameState, [INFO] [stdout] 361 | | transfer: Transfer, [INFO] [stdout] 362 | | game_account: &'a AccountInfo<'b>, [INFO] [stdout] ... | [INFO] [stdout] 368 | | account_iter: &'c mut I, [INFO] [stdout] 369 | | ) -> ProgramResult { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | &slot_stake_account, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `slot_stake_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:390:13 [INFO] [stdout] | [INFO] [stdout] 390 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::InvalidAccountStatus)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | return Err(ProcessError::InvalidSlotId)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return Err(ProgramError::AccountNotRentExempt)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(ProcessError::InvalidAccountPubkey)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_profile.rs:55:14 [INFO] [stdout] | [INFO] [stdout] 55 | Some(pfp_account.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*pfp_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_profile.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(ProcessError::InconsistentCredentials)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_profile.rs:72:42 [INFO] [stdout] | [INFO] [stdout] 72 | pack_state_to_account(profile_state, &profile_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `profile_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_profile.rs:72:60 [INFO] [stdout] | [INFO] [stdout] 72 | pack_state_to_account(profile_state, &profile_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `owner_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_profile.rs:72:76 [INFO] [stdout] | [INFO] [stdout] 72 | pack_state_to_account(profile_state, &profile_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(ProcessError::InvalidUnregistration)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_registry.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | owner: payer.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return Err(ProcessError::InvalidUnregistration)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/vote.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return Err(ProcessError::InvalidVoteeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/processor/join.rs:29:38 [INFO] [stdout] | [INFO] [stdout] 29 | let account_iter = &mut accounts.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/vote.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | return Err(ProcessError::InvalidVoteeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/vote.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | voter: voter_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*voter_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/vote.rs:65:24 [INFO] [stdout] | [INFO] [stdout] 65 | votee: votee_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*votee_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/vote.rs:78:39 [INFO] [stdout] | [INFO] [stdout] 78 | pack_state_to_account(game_state, &game_account, &voter_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/vote.rs:78:54 [INFO] [stdout] | [INFO] [stdout] 78 | pack_state_to_account(game_state, &game_account, &voter_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `voter_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/vote.rs:78:70 [INFO] [stdout] | [INFO] [stdout] 78 | pack_state_to_account(game_state, &game_account, &voter_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return Err(ProcessError::InvalidSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::EmptyRecipientSlots)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(ProcessError::InvalidMint)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return Err(ProcessError::GameFullAlready)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Err(ProcessError::InvalidPosition)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:109:75 [INFO] [stdout] | [INFO] [stdout] 109 | if players::is_player_joined(&players_reg_account.try_borrow_data()?, &player_account.key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `player_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | return Err(ProcessError::JoinedGameAlready)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_recipient.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | &[&payer.key], [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | return Err(ProcessError::InvalidIdentifierLength)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_recipient.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | cap_addr: Some(cap_account.key.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*cap_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_recipient.rs:103:45 [INFO] [stdout] | [INFO] [stdout] 103 | pack_state_to_account(&recipient_state, &recipient_account, &payer, system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_recipient.rs:103:65 [INFO] [stdout] | [INFO] [stdout] 103 | pack_state_to_account(&recipient_state, &recipient_account, &payer, system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 165 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/processor/join.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | params.amount as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `params.amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:185:15 [INFO] [stdout] | [INFO] [stdout] 185 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/processor/assign_recipient.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | / if target_identifier.eq(&identifier) { [INFO] [stdout] 35 | | share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] 36 | | addr: assign_account.key.clone(), [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ RecipientSlotOwner::Unassigned { identifier: target_identifier } [INFO] [stdout] 34 ~ if target_identifier.eq(&identifier) => { [INFO] [stdout] 35 | share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] 36 | addr: assign_account.key.clone(), [INFO] [stdout] 37 | } [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/processor/assign_recipient.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / match &share.owner { [INFO] [stdout] 33 | | RecipientSlotOwner::Unassigned { identifier: target_identifier } => { [INFO] [stdout] 34 | | if target_identifier.eq(&identifier) { [INFO] [stdout] 35 | | share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] ... | [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ if let RecipientSlotOwner::Unassigned { identifier: target_identifier } = &share.owner { [INFO] [stdout] 33 + if target_identifier.eq(&identifier) { [INFO] [stdout] 34 + share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] 35 + addr: assign_account.key.clone(), [INFO] [stdout] 36 + } [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/assign_recipient.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 36 | ... addr: assign_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*assign_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/assign_recipient.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 45 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/join.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/assign_recipient.rs:45:65 [INFO] [stdout] | [INFO] [stdout] 45 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/assign_recipient.rs:45:73 [INFO] [stdout] | [INFO] [stdout] 45 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/join.rs:211:15 [INFO] [stdout] | [INFO] [stdout] 211 | addr: payer_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:219:47 [INFO] [stdout] | [INFO] [stdout] 219 | append_state_to_account(&player_join, &players_reg_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `players_reg_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:219:69 [INFO] [stdout] | [INFO] [stdout] 219 | append_state_to_account(&player_join, &players_reg_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:219:85 [INFO] [stdout] | [INFO] [stdout] 219 | append_state_to_account(&player_join, &players_reg_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/join.rs:223:15 [INFO] [stdout] | [INFO] [stdout] 223 | addr: payer_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:232:39 [INFO] [stdout] | [INFO] [stdout] 232 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:232:54 [INFO] [stdout] | [INFO] [stdout] 232 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/join.rs:232:70 [INFO] [stdout] | [INFO] [stdout] 232 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:57:90 [INFO] [stdout] | [INFO] [stdout] 57 | let Some(slot) = recipient_state.slots.iter_mut().find(|slot| slot.stake_addr.eq(&slot_stake_account.key)) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `slot_stake_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:62:19 [INFO] [stdout] | [INFO] [stdout] 62 | if pda.ne(&pda_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `pda_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/recipient_claim.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return Err(ProcessError::InvalidPDA)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/misc.rs:38:28 [INFO] [stdout] | [INFO] [stdout] 38 | if receiver_key.ne(&account_key) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `account_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:102:45 [INFO] [stdout] | [INFO] [stdout] 102 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:102:65 [INFO] [stdout] | [INFO] [stdout] 102 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:102:73 [INFO] [stdout] | [INFO] [stdout] 102 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an outer doc comment and does not apply to the parent module or crate [INFO] [stdout] --> src/processor/deposit.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | ///! Player joins a game (cash, sng or tourney) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments [INFO] [stdout] = note: `#[warn(clippy::suspicious_doc_comments)]` on by default [INFO] [stdout] help: use an inner doc comment to document the parent module or crate [INFO] [stdout] | [INFO] [stdout] 4 - ///! Player joins a game (cash, sng or tourney) [INFO] [stdout] 4 + //! Player joins a game (cash, sng or tourney) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/misc.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return Err(ProcessError::InvalidReceiverAddress)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/misc.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(ProcessError::ReceiverUninitialized)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/processor/deposit.rs:13:38 [INFO] [stdout] | [INFO] [stdout] 13 | let account_iter = &mut accounts.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/misc.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | &pda.key, [INFO] [stdout] | ^^^^^^^^ help: change this to: `pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Err(ProcessError::InvalidSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return Err(ProcessError::InvalidMint)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:62:76 [INFO] [stdout] | [INFO] [stdout] 62 | if !players::is_player_joined(&players_reg_account.try_borrow_data()?, &player_account.key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `player_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return Err(ProcessError::PlayerNotInGame)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 113 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/processor/deposit.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | params.amount as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `params.amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:133:15 [INFO] [stdout] | [INFO] [stdout] 133 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/deposit.rs:160:15 [INFO] [stdout] | [INFO] [stdout] 160 | addr: payer_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:169:39 [INFO] [stdout] | [INFO] [stdout] 169 | pack_state_to_account(game_state, &game_account, &player_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:169:54 [INFO] [stdout] | [INFO] [stdout] 169 | pack_state_to_account(game_state, &game_account, &player_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `player_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:169:71 [INFO] [stdout] | [INFO] [stdout] 169 | pack_state_to_account(game_state, &game_account, &player_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | &token_program.key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `token_program.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/processor/attach_bonus.rs:29:38 [INFO] [stdout] | [INFO] [stdout] 29 | let account_iter = &mut accounts.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &mint_account.key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | &ata_account.key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `ata_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | &payer.key, [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/publish_game.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 62 | &[&payer.key], [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | address: payer.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 82 | address: mint_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/attach_bonus.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::InvalidIdentifierLength)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | .payer(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:100:15 [INFO] [stdout] | [INFO] [stdout] 100 | .mint(mint_account.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | .metadata(metadata_pda.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*metadata_pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:102:27 [INFO] [stdout] | [INFO] [stdout] 102 | .update_authority(payer.key.clone(), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:103:25 [INFO] [stdout] | [INFO] [stdout] 103 | .mint_authority(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | .update_authority(payer.key.clone(), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 135 | .edition(edition_pda.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*edition_pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 136 | .mint(mint_account.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*mint_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:137:25 [INFO] [stdout] | [INFO] [stdout] 137 | .mint_authority(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:138:27 [INFO] [stdout] | [INFO] [stdout] 138 | .update_authority(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/attach_bonus.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(ProcessError::NativeTokenNotSupported)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/attach_bonus.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | stake_addr: temp_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*temp_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:139:19 [INFO] [stdout] | [INFO] [stdout] 139 | .metadata(metadata_pda.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*metadata_pda.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/attach_bonus.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | token_addr: temp_state.mint.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `temp_state.mint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/publish_game.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | .payer(payer.key.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/attach_bonus.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 89 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return Err(ProcessError::RegistrationIsFull)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/reject_deposits.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return Err(ProcessError::DuplicatedDepositRejection)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:71:69 [INFO] [stdout] | [INFO] [stdout] 71 | if validate_receiver(&deposit.addr, &game_state.token_mint, &receiver_account.key).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `receiver_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(ProcessError::RegistrationIsFull)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/processor/register_game.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / if registry_state.games.len() > 0 { [INFO] [stdout] 56 | | if registry_state [INFO] [stdout] 57 | | .games [INFO] [stdout] 58 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if registry_state.games.len() > 0 [INFO] [stdout] 56 ~ && registry_state [INFO] [stdout] 57 | .games [INFO] [stdout] ... [INFO] [stdout] 61 | return Err(ProcessError::GameAlreadyRegistered)?; [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/processor/register_game.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | if registry_state.games.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!registry_state.games.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_game.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(ProcessError::GameAlreadyRegistered)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &game_account, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &transactor_account, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `transactor_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | &system_program, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(ProcessError::EmptyRecipientSlotShares)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/register_game.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 69 | addr: game_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*game_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/register_game.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 71 | bundle_addr: game_state.bundle_addr.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `game_state.bundle_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_game.rs:82:43 [INFO] [stdout] | [INFO] [stdout] 82 | pack_state_to_account(registry_state, ®istry_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `registry_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_game.rs:82:62 [INFO] [stdout] | [INFO] [stdout] 82 | pack_state_to_account(registry_state, ®istry_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_game.rs:82:70 [INFO] [stdout] | [INFO] [stdout] 82 | pack_state_to_account(registry_state, ®istry_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_server.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return Err(ProcessError::InvalidAccountStatus)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(ProcessError::InvalidRecipientAddress)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:47:56 [INFO] [stdout] | [INFO] [stdout] 47 | if recipient_state.cap_addr.is_some_and(|ca| ca.ne(&payer_account.key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(ProcessError::NoRecipientUpdateCap)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(ProcessError::DuplicatedRecipientSlotToken)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return Err(ProcessError::InvalidSlotId)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:79:15 [INFO] [stdout] | [INFO] [stdout] 79 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_server.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(ProcessError::InvalidAccountPubkey)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | return Err(ProcessError::InvalidIdentifierLength)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/register_server.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | return Err(ProcessError::InconsistentCredentials)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/register_server.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | addr: server_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*server_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:113:44 [INFO] [stdout] | [INFO] [stdout] 113 | pack_state_to_account(recipient_state, &recipient_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:113:64 [INFO] [stdout] | [INFO] [stdout] 113 | pack_state_to_account(recipient_state, &recipient_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:113:80 [INFO] [stdout] | [INFO] [stdout] 113 | pack_state_to_account(recipient_state, &recipient_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_server.rs:59:41 [INFO] [stdout] | [INFO] [stdout] 59 | pack_state_to_account(server_state, &server_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `server_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_server.rs:59:58 [INFO] [stdout] | [INFO] [stdout] 59 | pack_state_to_account(server_state, &server_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `owner_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/register_server.rs:59:74 [INFO] [stdout] | [INFO] [stdout] 59 | pack_state_to_account(server_state, &server_account, &owner_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return Err(ProcessError::InvalidAccountStatus)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::InvalidPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return Err(ProcessError::ServerAccountNotAvailable)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Err(ProcessError::DuplicateServerJoin)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(ProcessError::ServerNumberExceedsLimit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/serve.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return Err(ProcessError::DuplicateServerJoin)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/processor/serve.rs:75:48 [INFO] [stdout] | [INFO] [stdout] 75 | if game_state.transactor_addr.is_none() || game_state.servers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `game_state.servers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/serve.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/serve.rs:91:54 [INFO] [stdout] | [INFO] [stdout] 91 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/serve.rs:91:70 [INFO] [stdout] | [INFO] [stdout] 91 | pack_state_to_account(game_state, &game_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return Err(ProcessError::InvalidSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return Err(ProcessError::InvalidNextSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | if pda.ne(&pda_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `pda_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return Err(ProcessError::InvalidPDA)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | validate_balance(&game_state, &stake_account)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `stake_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | &game_account, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | &transactor_account, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `transactor_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | &system_program, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/processor/settle.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 203 | if !(stake_amount == balance_sum + unhandled_deposit) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(stake_amount != balance_sum + unhandled_deposit)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/processor/settle.rs:211:1 [INFO] [stdout] | [INFO] [stdout] 211 | / fn handle_settles<'a, 'b, 'c, I: Iterator>>( [INFO] [stdout] 212 | | game_state: &'c mut GameState, [INFO] [stdout] 213 | | settles: Vec, [INFO] [stdout] 214 | | game_account: &'a AccountInfo<'b>, [INFO] [stdout] ... | [INFO] [stdout] 220 | | account_iter: &'c mut I, [INFO] [stdout] 221 | | ) -> ProgramResult { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:249:21 [INFO] [stdout] | [INFO] [stdout] 249 | return Err(ProcessError::InvalidSettleBalance)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:274:58 [INFO] [stdout] | [INFO] [stdout] 274 | validate_receiver(&addr, &game_state.token_mint, &receiver.key)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `receiver.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | &receiver, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/processor/settle.rs:290:1 [INFO] [stdout] | [INFO] [stdout] 290 | / fn handle_bonuses<'a, 'b, 'c, I: Iterator>>( [INFO] [stdout] 291 | | game_state: &'c mut GameState, [INFO] [stdout] 292 | | awards: Vec, [INFO] [stdout] 293 | | game_account: &'a AccountInfo<'b>, [INFO] [stdout] ... | [INFO] [stdout] 299 | | account_iter: &'c mut I, [INFO] [stdout] 300 | | ) -> ProgramResult { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:314:36 [INFO] [stdout] | [INFO] [stdout] 314 | if bonus.stake_addr.ne(&bonus_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `bonus_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | return Err(ProcessError::InvalidAwardIdentifier)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/processor/settle.rs:359:1 [INFO] [stdout] | [INFO] [stdout] 359 | / fn handle_transfer<'a, 'b, 'c, I: Iterator>>( [INFO] [stdout] 360 | | game_state: &'c GameState, [INFO] [stdout] 361 | | transfer: Transfer, [INFO] [stdout] 362 | | game_account: &'a AccountInfo<'b>, [INFO] [stdout] ... | [INFO] [stdout] 368 | | account_iter: &'c mut I, [INFO] [stdout] 369 | | ) -> ProgramResult { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/settle.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | &slot_stake_account, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `slot_stake_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:390:13 [INFO] [stdout] | [INFO] [stdout] 390 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/settle.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | return Err(ProcessError::InvalidSlotId)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return Err(ProcessError::InvalidOwner)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(ProcessError::InvalidUnregistration)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/unregister_game.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return Err(ProcessError::InvalidUnregistration)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/vote.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return Err(ProcessError::InvalidVoteeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/vote.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | return Err(ProcessError::InvalidVoteeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/vote.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | voter: voter_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*voter_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/vote.rs:65:24 [INFO] [stdout] | [INFO] [stdout] 65 | votee: votee_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*votee_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/vote.rs:78:39 [INFO] [stdout] | [INFO] [stdout] 78 | pack_state_to_account(game_state, &game_account, &voter_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/vote.rs:78:54 [INFO] [stdout] | [INFO] [stdout] 78 | pack_state_to_account(game_state, &game_account, &voter_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `voter_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/vote.rs:78:70 [INFO] [stdout] | [INFO] [stdout] 78 | pack_state_to_account(game_state, &game_account, &voter_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::EmptyRecipientSlots)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_recipient.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 69 | &[&payer.key], [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `payer.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/create_recipient.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | return Err(ProcessError::InvalidIdentifierLength)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/create_recipient.rs:99:24 [INFO] [stdout] | [INFO] [stdout] 99 | cap_addr: Some(cap_account.key.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*cap_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_recipient.rs:103:45 [INFO] [stdout] | [INFO] [stdout] 103 | pack_state_to_account(&recipient_state, &recipient_account, &payer, system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/create_recipient.rs:103:65 [INFO] [stdout] | [INFO] [stdout] 103 | pack_state_to_account(&recipient_state, &recipient_account, &payer, system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/processor/assign_recipient.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | / if target_identifier.eq(&identifier) { [INFO] [stdout] 35 | | share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] 36 | | addr: assign_account.key.clone(), [INFO] [stdout] 37 | | } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ RecipientSlotOwner::Unassigned { identifier: target_identifier } [INFO] [stdout] 34 ~ if target_identifier.eq(&identifier) => { [INFO] [stdout] 35 | share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] 36 | addr: assign_account.key.clone(), [INFO] [stdout] 37 | } [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/processor/assign_recipient.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / match &share.owner { [INFO] [stdout] 33 | | RecipientSlotOwner::Unassigned { identifier: target_identifier } => { [INFO] [stdout] 34 | | if target_identifier.eq(&identifier) { [INFO] [stdout] 35 | | share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] ... | [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 32 ~ if let RecipientSlotOwner::Unassigned { identifier: target_identifier } = &share.owner { [INFO] [stdout] 33 + if target_identifier.eq(&identifier) { [INFO] [stdout] 34 + share.owner = RecipientSlotOwner::Assigned { [INFO] [stdout] 35 + addr: assign_account.key.clone(), [INFO] [stdout] 36 + } [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/assign_recipient.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 36 | ... addr: assign_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*assign_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/assign_recipient.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 45 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/assign_recipient.rs:45:65 [INFO] [stdout] | [INFO] [stdout] 45 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/assign_recipient.rs:45:73 [INFO] [stdout] | [INFO] [stdout] 45 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:57:90 [INFO] [stdout] | [INFO] [stdout] 57 | let Some(slot) = recipient_state.slots.iter_mut().find(|slot| slot.stake_addr.eq(&slot_stake_account.key)) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `slot_stake_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:62:19 [INFO] [stdout] | [INFO] [stdout] 62 | if pda.ne(&pda_account.key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `pda_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/recipient_claim.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return Err(ProcessError::InvalidPDA)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:102:45 [INFO] [stdout] | [INFO] [stdout] 102 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:102:65 [INFO] [stdout] | [INFO] [stdout] 102 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^ help: change this to: `payer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/recipient_claim.rs:102:73 [INFO] [stdout] | [INFO] [stdout] 102 | pack_state_to_account(&recipient_state, &recipient_account, &payer, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/state/registry.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | pub games: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] = note: `#[warn(clippy::box_collection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an outer doc comment and does not apply to the parent module or crate [INFO] [stdout] --> src/processor/deposit.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | ///! Player joins a game (cash, sng or tourney) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments [INFO] [stdout] = note: `#[warn(clippy::suspicious_doc_comments)]` on by default [INFO] [stdout] help: use an inner doc comment to document the parent module or crate [INFO] [stdout] | [INFO] [stdout] 4 - ///! Player joins a game (cash, sng or tourney) [INFO] [stdout] 4 + //! Player joins a game (cash, sng or tourney) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/processor/deposit.rs:13:38 [INFO] [stdout] | [INFO] [stdout] 13 | let account_iter = &mut accounts.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return Err(ProcessError::InvalidSettleVersion)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(ProcessError::InvalidStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return Err(ProcessError::InvalidMint)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:62:76 [INFO] [stdout] | [INFO] [stdout] 62 | if !players::is_player_joined(&players_reg_account.try_borrow_data()?, &player_account.key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `player_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return Err(ProcessError::PlayerNotInGame)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | return Err(ProcessError::InvalidPaymentParams)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 113 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/processor/deposit.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | params.amount as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `params.amount` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:133:15 [INFO] [stdout] | [INFO] [stdout] 133 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/deposit.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | return Err(ProcessError::InvalidDeposit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/deposit.rs:160:15 [INFO] [stdout] | [INFO] [stdout] 160 | addr: payer_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:169:39 [INFO] [stdout] | [INFO] [stdout] 169 | pack_state_to_account(game_state, &game_account, &player_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:169:54 [INFO] [stdout] | [INFO] [stdout] 169 | pack_state_to_account(game_state, &game_account, &player_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `player_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/deposit.rs:169:71 [INFO] [stdout] | [INFO] [stdout] 169 | pack_state_to_account(game_state, &game_account, &player_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/processor/attach_bonus.rs:29:38 [INFO] [stdout] | [INFO] [stdout] 29 | let account_iter = &mut accounts.into_iter(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/attach_bonus.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(ProcessError::InvalidIdentifierLength)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/attach_bonus.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return Err(ProcessError::NativeTokenNotSupported)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/attach_bonus.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | stake_addr: temp_account.key.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*temp_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pubkey` which implements the `Copy` trait [INFO] [stdout] --> src/processor/attach_bonus.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | token_addr: temp_state.mint.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `temp_state.mint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/attach_bonus.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 89 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return Err(ProcessError::InvalidPlayersRegAccountForInit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/reject_deposits.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | return Err(ProcessError::DuplicatedDepositRejection)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:71:69 [INFO] [stdout] | [INFO] [stdout] 71 | if validate_receiver(&deposit.addr, &game_state.token_mint, &receiver_account.key).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `receiver_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | &game_account, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `game_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &transactor_account, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `transactor_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/reject_deposits.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | &system_program, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(ProcessError::EmptyRecipientSlotShares)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(ProcessError::InvalidRecipientAddress)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 74 | let size = get_players_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:80:34 [INFO] [stdout] | [INFO] [stdout] 80 | let size = get_players_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(ProcessError::CantDecreasePlayersRegAccountSize)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return Ok(None); [INFO] [stdout] 129 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/state/players.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | if &id_v == &data[id_start..id_end] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 119 - if &id_v == &data[id_start..id_end] { [INFO] [stdout] 119 + if id_v == data[id_start..id_end] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:47:56 [INFO] [stdout] | [INFO] [stdout] 47 | if recipient_state.cap_addr.is_some_and(|ca| ca.ne(&payer_account.key)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(ProcessError::NoRecipientUpdateCap)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Ok(None); [INFO] [stdout] 151 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(ProcessError::DuplicatedRecipientSlotToken)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return Err(ProcessError::InvalidSlotId)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | return Err(ProcessError::InvalidSlotStakeAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return Err(ProcessError::MalformedPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:79:15 [INFO] [stdout] | [INFO] [stdout] 79 | &[&payer_account.key], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `payer_account.key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/state/players.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 180 | if f & (&data[POSITION_OFFSET + i as usize]) != 0 { [INFO] [stdout] | ^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `data[POSITION_OFFSET + i as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return Ok(()); [INFO] [stdout] 201 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/processor/add_recipient_slot.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | return Err(ProcessError::InvalidIdentifierLength)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(ProcessError::MalformedPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:113:44 [INFO] [stdout] | [INFO] [stdout] 113 | pack_state_to_account(recipient_state, &recipient_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `recipient_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:113:64 [INFO] [stdout] | [INFO] [stdout] 113 | pack_state_to_account(recipient_state, &recipient_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `payer_account` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/processor/add_recipient_slot.rs:113:80 [INFO] [stdout] | [INFO] [stdout] 113 | pack_state_to_account(recipient_state, &recipient_account, &payer_account, &system_program)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `system_program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | return Err(ProcessError::GameFullAlready)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Err(ProcessError::GameFullAlready)?; [INFO] [stdout] 213 + Err(ProcessError::GameFullAlready)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 - return Ok(()); [INFO] [stdout] 219 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:228:39 [INFO] [stdout] | [INFO] [stdout] 228 | let slots_count = get_slots_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:236:39 [INFO] [stdout] | [INFO] [stdout] 236 | let slots_count = get_slots_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/state/players.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 255 | if &[0; 32] != &data[start..(start + PUBKEY_LEN)] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 255 - if &[0; 32] != &data[start..(start + PUBKEY_LEN)] { [INFO] [stdout] 255 + if [0; 32] != data[start..(start + PUBKEY_LEN)] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 145 | pub settles: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | pub awards: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | pub checkpoint: Box>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:153:26 [INFO] [stdout] | [INFO] [stdout] 153 | pub accept_deposits: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:195:16 [INFO] [stdout] | [INFO] [stdout] 195 | pub slots: Box> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/state/registry.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | pub games: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] = note: `#[warn(clippy::box_collection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | /// Rest are the bonus stake account and receiver(owner)'s ATA [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 34 | /// Rest are the bonus stake account and receiver(owner)'s ATA [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | /// Following: [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 72 | /// Following: [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | /// `[]` Every players' account to get paid, must be in the same order with payment settles [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 73 | /// `[]` Every players' account to get paid, must be in the same order with payment settles [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | /// `[]` Every recipient slot accounts to receive transfer [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 74 | /// `[]` Every recipient slot accounts to receive transfer [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | /// `[]` Every bonus account and the receiver account to receive bonus [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 75 | /// `[]` Every bonus account and the receiver account to receive bonus [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | /// (Optional)11. `[]` Other account to receive the payment. For EntryType::Ticket [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 128 | /// (Optional)11. `[]` Other account to receive the payment. For EntryType::Ticket [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | /// 4+n. `[]` The Nth staking account for slots [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 153 | /// 4+n. `[]` The Nth staking account for slots [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | /// Rest are stake account to pays and ATA to receive [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 172 | /// Rest are stake account to pays and ATA to receive [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | /// `[]` The PDA account as the owner of the stake account [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 173 | /// `[]` The PDA account as the owner of the stake account [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | /// `[writable]` The stake account [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 174 | /// `[writable]` The stake account [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | /// `[writable]` ATA to receive tokens [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 175 | /// `[writable]` ATA to receive tokens [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | /// Rest. `[writable]` The temp account for each bonuses [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 200 | /// Rest. `[writable]` The temp account for each bonuses [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | /// Rest. `[]` The receiver for each rejected deposit [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 213 | /// Rest. `[]` The receiver for each rejected deposit [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return Err(ProcessError::InvalidPlayersRegAccountForInit)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:74:34 [INFO] [stdout] | [INFO] [stdout] 74 | let size = get_players_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:80:34 [INFO] [stdout] | [INFO] [stdout] 80 | let size = get_players_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(ProcessError::CantDecreasePlayersRegAccountSize)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return Ok(None); [INFO] [stdout] 129 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/state/players.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | if &id_v == &data[id_start..id_end] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 119 - if &id_v == &data[id_start..id_end] { [INFO] [stdout] 119 + if id_v == data[id_start..id_end] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return Ok(None); [INFO] [stdout] 151 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return Err(ProcessError::MalformedPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/state/players.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 180 | if f & (&data[POSITION_OFFSET + i as usize]) != 0 { [INFO] [stdout] | ^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `data[POSITION_OFFSET + i as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return Ok(()); [INFO] [stdout] 201 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement with `?` operator [INFO] [stdout] --> src/state/players.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return Err(ProcessError::MalformedPlayersRegAccount)?; [INFO] [stdout] | ^^^^^^^ help: remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return_with_question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:213:5 [INFO] [stdout] | [INFO] [stdout] 213 | return Err(ProcessError::GameFullAlready)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Err(ProcessError::GameFullAlready)?; [INFO] [stdout] 213 + Err(ProcessError::GameFullAlready)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state/players.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 - return Ok(()); [INFO] [stdout] 219 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:228:39 [INFO] [stdout] | [INFO] [stdout] 228 | let slots_count = get_slots_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/state/players.rs:236:39 [INFO] [stdout] | [INFO] [stdout] 236 | let slots_count = get_slots_count(&data)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/state/players.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 255 | if &[0; 32] != &data[start..(start + PUBKEY_LEN)] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 255 - if &[0; 32] != &data[start..(start + PUBKEY_LEN)] { [INFO] [stdout] 255 + if [0; 32] != data[start..(start + PUBKEY_LEN)] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `validate_account_data` doesn't need a mutable reference [INFO] [stdout] --> src/state/players.rs:296:31 [INFO] [stdout] | [INFO] [stdout] 296 | validate_account_data(&mut v).unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 296 - validate_account_data(&mut v).unwrap(); [INFO] [stdout] 296 + validate_account_data(&v).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `validate_account_data` doesn't need a mutable reference [INFO] [stdout] --> src/state/players.rs:304:31 [INFO] [stdout] | [INFO] [stdout] 304 | validate_account_data(&mut v).unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 304 - validate_account_data(&mut v).unwrap(); [INFO] [stdout] 304 + validate_account_data(&v).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:361:9 [INFO] [stdout] | [INFO] [stdout] 361 | assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 361 - assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] 361 + assert!(!is_position_occupied(&data, 1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 367 | assert_eq!(is_position_occupied(&data, 0).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 367 - assert_eq!(is_position_occupied(&data, 0).unwrap(), false); [INFO] [stdout] 367 + assert!(!is_position_occupied(&data, 0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | assert_eq!(is_position_occupied(&data, 0).unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 371 - assert_eq!(is_position_occupied(&data, 0).unwrap(), true); [INFO] [stdout] 371 + assert!(is_position_occupied(&data, 0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:375:9 [INFO] [stdout] | [INFO] [stdout] 375 | assert_eq!(is_position_occupied(&data, 0).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 375 - assert_eq!(is_position_occupied(&data, 0).unwrap(), false); [INFO] [stdout] 375 + assert!(!is_position_occupied(&data, 0).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:377:9 [INFO] [stdout] | [INFO] [stdout] 377 | assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 377 - assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] 377 + assert!(!is_position_occupied(&data, 1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 381 | assert_eq!(is_position_occupied(&data, 1).unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 381 - assert_eq!(is_position_occupied(&data, 1).unwrap(), true); [INFO] [stdout] 381 + assert!(is_position_occupied(&data, 1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 385 - assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] 385 + assert!(!is_position_occupied(&data, 1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:397:9 [INFO] [stdout] | [INFO] [stdout] 397 | assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 397 - assert_eq!(is_position_occupied(&data, 1).unwrap(), false); [INFO] [stdout] 397 + assert!(!is_position_occupied(&data, 1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/state/players.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | assert_eq!(is_position_occupied(&data, 1).unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 399 - assert_eq!(is_position_occupied(&data, 1).unwrap(), true); [INFO] [stdout] 399 + assert!(is_position_occupied(&data, 1).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 145 | pub settles: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | pub awards: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | pub checkpoint: Box>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:153:26 [INFO] [stdout] | [INFO] [stdout] 153 | pub accept_deposits: Box>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/types.rs:195:16 [INFO] [stdout] | [INFO] [stdout] 195 | pub slots: Box> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | /// Rest are the bonus stake account and receiver(owner)'s ATA [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 34 | /// Rest are the bonus stake account and receiver(owner)'s ATA [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | /// Following: [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 72 | /// Following: [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | /// `[]` Every players' account to get paid, must be in the same order with payment settles [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 73 | /// `[]` Every players' account to get paid, must be in the same order with payment settles [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | /// `[]` Every recipient slot accounts to receive transfer [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 74 | /// `[]` Every recipient slot accounts to receive transfer [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | /// `[]` Every bonus account and the receiver account to receive bonus [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 75 | /// `[]` Every bonus account and the receiver account to receive bonus [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | /// (Optional)11. `[]` Other account to receive the payment. For EntryType::Ticket [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 128 | /// (Optional)11. `[]` Other account to receive the payment. For EntryType::Ticket [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | /// 4+n. `[]` The Nth staking account for slots [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 153 | /// 4+n. `[]` The Nth staking account for slots [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | /// Rest are stake account to pays and ATA to receive [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 172 | /// Rest are stake account to pays and ATA to receive [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | /// `[]` The PDA account as the owner of the stake account [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 173 | /// `[]` The PDA account as the owner of the stake account [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | /// `[writable]` The stake account [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 174 | /// `[writable]` The stake account [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | /// `[writable]` ATA to receive tokens [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 175 | /// `[writable]` ATA to receive tokens [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | /// Rest. `[writable]` The temp account for each bonuses [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 200 | /// Rest. `[writable]` The temp account for each bonuses [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/instruction.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | /// Rest. `[]` The receiver for each rejected deposit [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 213 | /// Rest. `[]` The receiver for each rejected deposit [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `Command { std: "docker" "inspect" "b672843bbcd38e846297009dd955090149fb90d63becdf1bb6b485dfce602d39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b672843bbcd38e846297009dd955090149fb90d63becdf1bb6b485dfce602d39", kill_on_drop: false }` [INFO] [stdout] b672843bbcd38e846297009dd955090149fb90d63becdf1bb6b485dfce602d39