[INFO] cloning repository https://github.com/R-G-Mocoratioen/sysy-live [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/R-G-Mocoratioen/sysy-live" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FR-G-Mocoratioen%2Fsysy-live", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FR-G-Mocoratioen%2Fsysy-live'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fbac0d738cd9712e41cf980f094ab6dfd96c7cc5 [INFO] linting R-G-Mocoratioen/sysy-live against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FR-G-Mocoratioen%2Fsysy-live" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/R-G-Mocoratioen/sysy-live [INFO] finished tweaking git repo https://github.com/R-G-Mocoratioen/sysy-live [INFO] tweaked toml for git repo https://github.com/R-G-Mocoratioen/sysy-live written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/R-G-Mocoratioen/sysy-live on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/R-G-Mocoratioen/sysy-live already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded key-node-list v0.0.5 [INFO] [stderr] Downloaded koopa v0.0.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 561fe10d8edfcd0315455c421a4c60bbdf5acb7192daf454d7e3c5e97138dc7f [INFO] running `Command { std: "docker" "start" "-a" "561fe10d8edfcd0315455c421a4c60bbdf5acb7192daf454d7e3c5e97138dc7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "561fe10d8edfcd0315455c421a4c60bbdf5acb7192daf454d7e3c5e97138dc7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "561fe10d8edfcd0315455c421a4c60bbdf5acb7192daf454d7e3c5e97138dc7f", kill_on_drop: false }` [INFO] [stdout] 561fe10d8edfcd0315455c421a4c60bbdf5acb7192daf454d7e3c5e97138dc7f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a751fc919469ffe84e0b5c64d6fc01fef5d11265ccc25b3bec300450148f177e [INFO] running `Command { std: "docker" "start" "-a" "a751fc919469ffe84e0b5c64d6fc01fef5d11265ccc25b3bec300450148f177e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling hashbrown v0.15.3 [INFO] [stderr] Compiling log v0.4.27 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling pico-args v0.5.0 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Checking key-node-list v0.0.5 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Checking koopa v0.0.8 [INFO] [stderr] Compiling indexmap v2.9.0 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling string_cache v0.8.9 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking lalrpop-util v0.20.2 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling lalrpop v0.20.2 [INFO] [stderr] Compiling compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8132:27 [INFO] [stdout] | [INFO] [stdout] 8132 | return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_defs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8132:49 [INFO] [stdout] | [INFO] [stdout] 8132 | return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_var_defs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8164:77 [INFO] [stdout] | [INFO] [stdout] 8164 | func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8164:85 [INFO] [stdout] | [INFO] [stdout] 8164 | func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8185:78 [INFO] [stdout] | [INFO] [stdout] 8185 | func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8185:86 [INFO] [stdout] | [INFO] [stdout] 8185 | func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8132:27 [INFO] [stdout] | [INFO] [stdout] 8132 | return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_defs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8132:49 [INFO] [stdout] | [INFO] [stdout] 8132 | return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_var_defs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8164:77 [INFO] [stdout] | [INFO] [stdout] 8164 | func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8164:85 [INFO] [stdout] | [INFO] [stdout] 8164 | func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8185:78 [INFO] [stdout] | [INFO] [stdout] 8185 | func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8185:86 [INFO] [stdout] | [INFO] [stdout] 8185 | func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9894:24 [INFO] [stdout] | [INFO] [stdout] 9894 | return Score { bars: bars }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9894:24 [INFO] [stdout] | [INFO] [stdout] 9894 | return Score { bars: bars }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:11694:1 [INFO] [stdout] | [INFO] [stdout] 11694 | / #[allow(clippy::type_complexity, dead_code)] [INFO] [stdout] 11695 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11696 | pub trait __ToTriple<'input, > [INFO] [stdout] | --------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:11694:1 [INFO] [stdout] | [INFO] [stdout] 11694 | / #[allow(clippy::type_complexity, dead_code)] [INFO] [stdout] 11695 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11696 | pub trait __ToTriple<'input, > [INFO] [stdout] | --------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/tokoopa.rs:878:19 [INFO] [stdout] | [INFO] [stdout] 878 | } else { [INFO] [stdout] | ___________________^ [INFO] [stdout] 879 | | } [INFO] [stdout] | |_________________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else` branch is empty [INFO] [stdout] --> src/tokoopa.rs:878:19 [INFO] [stdout] | [INFO] [stdout] 878 | } else { [INFO] [stdout] | ___________________^ [INFO] [stdout] 879 | | } [INFO] [stdout] | |_________________^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_else [INFO] [stdout] = note: `#[warn(clippy::needless_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | Variant26(Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | Variant26(Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:4248:18 [INFO] [stdout] | [INFO] [stdout] 4248 | ) -> (usize, Vec>, usize) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8132:9 [INFO] [stdout] | [INFO] [stdout] 8132 | return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8132 - return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] 8132 + CompUnit { func_defs: func_defs, global_var_defs: global_var_defs } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8163:9 [INFO] [stdout] | [INFO] [stdout] 8163 | / return GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8164 | | func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8165 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8163 ~ GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8164 + func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8165 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8184:9 [INFO] [stdout] | [INFO] [stdout] 8184 | / return GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8185 | | func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8186 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8184 ~ GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8185 + func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8186 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8206:9 [INFO] [stdout] | [INFO] [stdout] 8206 | return params; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8206 - return params; [INFO] [stdout] 8206 + params [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8241:9 [INFO] [stdout] | [INFO] [stdout] 8241 | return FuncParam::Array(id, exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8241 - return FuncParam::Array(id, exps); [INFO] [stdout] 8241 + FuncParam::Array(id, exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8264:9 [INFO] [stdout] | [INFO] [stdout] 8264 | return VarDef::ScoreInit(id, Box::new(score)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8264 - return VarDef::ScoreInit(id, Box::new(score)); [INFO] [stdout] 8264 + VarDef::ScoreInit(id, Box::new(score)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8295:9 [INFO] [stdout] | [INFO] [stdout] 8295 | return VarDef::NoteInit(id, Box::new(note), fz, fm); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8295 - return VarDef::NoteInit(id, Box::new(note), fz, fm); [INFO] [stdout] 8295 + VarDef::NoteInit(id, Box::new(note), fz, fm) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8318:9 [INFO] [stdout] | [INFO] [stdout] 8318 | return VarDef::BarInit(id, Box::new(bar)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8318 - return VarDef::BarInit(id, Box::new(bar)); [INFO] [stdout] 8318 + VarDef::BarInit(id, Box::new(bar)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8337:9 [INFO] [stdout] | [INFO] [stdout] 8337 | return VarDef::BarCopy(id, Box::new(y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8337 - return VarDef::BarCopy(id, Box::new(y)); [INFO] [stdout] 8337 + VarDef::BarCopy(id, Box::new(y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8353:9 [INFO] [stdout] | [INFO] [stdout] 8353 | return VarDef::Bar(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8353 - return VarDef::Bar(id); [INFO] [stdout] 8353 + VarDef::Bar(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8372:9 [INFO] [stdout] | [INFO] [stdout] 8372 | return VarDef::ScoreCopy(id, Box::new(y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8372 - return VarDef::ScoreCopy(id, Box::new(y)); [INFO] [stdout] 8372 + VarDef::ScoreCopy(id, Box::new(y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8388:9 [INFO] [stdout] | [INFO] [stdout] 8388 | return VarDef::Score(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8388 - return VarDef::Score(id); [INFO] [stdout] 8388 + VarDef::Score(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8409:9 [INFO] [stdout] | [INFO] [stdout] 8409 | return VarDef::TrackCopy(id, Box::new(y), Box::new(z)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8409 - return VarDef::TrackCopy(id, Box::new(y), Box::new(z)); [INFO] [stdout] 8409 + VarDef::TrackCopy(id, Box::new(y), Box::new(z)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8428:9 [INFO] [stdout] | [INFO] [stdout] 8428 | return VarDef::TrackLoad(id, Box::new(y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8428 - return VarDef::TrackLoad(id, Box::new(y)); [INFO] [stdout] 8428 + VarDef::TrackLoad(id, Box::new(y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8444:9 [INFO] [stdout] | [INFO] [stdout] 8444 | return VarDef::Track(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8444 - return VarDef::Track(id); [INFO] [stdout] 8444 + VarDef::Track(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8466:9 [INFO] [stdout] | [INFO] [stdout] 8466 | return Decl {defs: decl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8466 - return Decl {defs: decl}; [INFO] [stdout] 8466 + Decl {defs: decl} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8489:9 [INFO] [stdout] | [INFO] [stdout] 8489 | return Decl {defs: decl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8489 - return Decl {defs: decl}; [INFO] [stdout] 8489 + Decl {defs: decl} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8548:9 [INFO] [stdout] | [INFO] [stdout] 8548 | return ArrayInit::Multiple(exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8548 - return ArrayInit::Multiple(exps); [INFO] [stdout] 8548 + ArrayInit::Multiple(exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8593:9 [INFO] [stdout] | [INFO] [stdout] 8593 | return VarDef::Array(id, exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8593 - return VarDef::Array(id, exps); [INFO] [stdout] 8593 + VarDef::Array(id, exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8614:9 [INFO] [stdout] | [INFO] [stdout] 8614 | return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8614 - return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] 8614 + VarDef::ArrayInit(id, exps, Box::new(init)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8649:9 [INFO] [stdout] | [INFO] [stdout] 8649 | return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8649 - return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] 8649 + VarDef::ArrayInit(id, exps, Box::new(init)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8693:5 [INFO] [stdout] | [INFO] [stdout] 8693 | return Block { vecitem: block }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8693 - return Block { vecitem: block }; [INFO] [stdout] 8693 + Block { vecitem: block } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8757:9 [INFO] [stdout] | [INFO] [stdout] 8757 | return Stmt::Sing(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d), Box::new(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8757 - return Stmt::Sing(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d), Box::new(e)); [INFO] [stdout] 8757 + Stmt::Sing(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d), Box::new(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8777:9 [INFO] [stdout] | [INFO] [stdout] 8777 | return Stmt::PushBar(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8777 - return Stmt::PushBar(Box::new(x), Box::new(a)); [INFO] [stdout] 8777 + Stmt::PushBar(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8797:9 [INFO] [stdout] | [INFO] [stdout] 8797 | return Stmt::PushNote(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8797 - return Stmt::PushNote(Box::new(x), Box::new(a)); [INFO] [stdout] 8797 + Stmt::PushNote(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8817:9 [INFO] [stdout] | [INFO] [stdout] 8817 | return Stmt::SetBarBpm(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8817 - return Stmt::SetBarBpm(Box::new(x), Box::new(a)); [INFO] [stdout] 8817 + Stmt::SetBarBpm(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8837:9 [INFO] [stdout] | [INFO] [stdout] 8837 | return Stmt::SetScoreBpm(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8837 - return Stmt::SetScoreBpm(Box::new(x), Box::new(a)); [INFO] [stdout] 8837 + Stmt::SetScoreBpm(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8857:9 [INFO] [stdout] | [INFO] [stdout] 8857 | return Stmt::IncScorePitch(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8857 - return Stmt::IncScorePitch(Box::new(x), Box::new(a)); [INFO] [stdout] 8857 + Stmt::IncScorePitch(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8877:9 [INFO] [stdout] | [INFO] [stdout] 8877 | return Stmt::SetScoreDuration(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8877 - return Stmt::SetScoreDuration(Box::new(x), Box::new(a)); [INFO] [stdout] 8877 + Stmt::SetScoreDuration(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8897:9 [INFO] [stdout] | [INFO] [stdout] 8897 | return Stmt::IncBarPitch(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8897 - return Stmt::IncBarPitch(Box::new(x), Box::new(a)); [INFO] [stdout] 8897 + Stmt::IncBarPitch(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8917:9 [INFO] [stdout] | [INFO] [stdout] 8917 | return Stmt::SetBarDuration(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8917 - return Stmt::SetBarDuration(Box::new(x), Box::new(a)); [INFO] [stdout] 8917 + Stmt::SetBarDuration(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8937:9 [INFO] [stdout] | [INFO] [stdout] 8937 | return Stmt::Append(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8937 - return Stmt::Append(Box::new(x), Box::new(a)); [INFO] [stdout] 8937 + Stmt::Append(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8959:9 [INFO] [stdout] | [INFO] [stdout] 8959 | return Stmt::ReplaceBar(Box::new(x), Box::new(a), Box::new(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8959 - return Stmt::ReplaceBar(Box::new(x), Box::new(a), Box::new(b)); [INFO] [stdout] 8959 + Stmt::ReplaceBar(Box::new(x), Box::new(a), Box::new(b)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8979:9 [INFO] [stdout] | [INFO] [stdout] 8979 | return Stmt::AppendTrack(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8979 - return Stmt::AppendTrack(Box::new(x), Box::new(a)); [INFO] [stdout] 8979 + Stmt::AppendTrack(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9005:9 [INFO] [stdout] | [INFO] [stdout] 9005 | return Stmt::AppendSilence(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9005 - return Stmt::AppendSilence(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d)); [INFO] [stdout] 9005 + Stmt::AppendSilence(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9025:9 [INFO] [stdout] | [INFO] [stdout] 9025 | return Stmt::StackTrack(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9025 - return Stmt::StackTrack(Box::new(x), Box::new(a)); [INFO] [stdout] 9025 + Stmt::StackTrack(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9047:9 [INFO] [stdout] | [INFO] [stdout] 9047 | return Stmt::SetVol(Box::new(x), Box::new(fz), Box::new(fm)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9047 - return Stmt::SetVol(Box::new(x), Box::new(fz), Box::new(fm)); [INFO] [stdout] 9047 + Stmt::SetVol(Box::new(x), Box::new(fz), Box::new(fm)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9290:9 [INFO] [stdout] | [INFO] [stdout] 9290 | return LVal::Array(id, exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9290 - return LVal::Array(id, exps); [INFO] [stdout] 9290 + LVal::Array(id, exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9366:27 [INFO] [stdout] | [INFO] [stdout] 9366 | (_, args, _): (usize, Vec>, usize), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9420:6 [INFO] [stdout] | [INFO] [stdout] 9420 | ) -> Vec> [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9428:9 [INFO] [stdout] | [INFO] [stdout] 9428 | return args; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9428 - return args; [INFO] [stdout] 9428 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9803:5 [INFO] [stdout] | [INFO] [stdout] 9803 | i32::from_str_radix(__0, 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9815:5 [INFO] [stdout] | [INFO] [stdout] 9815 | i32::from_str_radix(__0, 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9894:9 [INFO] [stdout] | [INFO] [stdout] 9894 | return Score { bars: bars }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9894 - return Score { bars: bars }; [INFO] [stdout] 9894 + Score { bars: bars } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9912:5 [INFO] [stdout] | [INFO] [stdout] 9912 | return Bar { notes: note_elems }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9912 - return Bar { notes: note_elems }; [INFO] [stdout] 9912 + Bar { notes: note_elems } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9968:9 [INFO] [stdout] | [INFO] [stdout] 9968 | return NoteElem::Notes(note_elems); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9968 - return NoteElem::Notes(note_elems); [INFO] [stdout] 9968 + NoteElem::Notes(note_elems) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9984:9 [INFO] [stdout] | [INFO] [stdout] 9984 | return a.up(dot_count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9984 - return a.up(dot_count); [INFO] [stdout] 9984 + a.up(dot_count) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10022:9 [INFO] [stdout] | [INFO] [stdout] 10022 | return a; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10022 - return a; [INFO] [stdout] 10022 + a [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10038:9 [INFO] [stdout] | [INFO] [stdout] 10038 | return a.up(-dot_count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10038 - return a.up(-dot_count); [INFO] [stdout] 10038 + a.up(-dot_count) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10079:9 [INFO] [stdout] | [INFO] [stdout] 10079 | return Note::Semitone(new_s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10079 - return Note::Semitone(new_s); [INFO] [stdout] 10079 + Note::Semitone(new_s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10092:5 [INFO] [stdout] | [INFO] [stdout] 10092 | i32::from_str_radix(__0, 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10107:5 [INFO] [stdout] | [INFO] [stdout] 10107 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10107 - return s; [INFO] [stdout] 10107 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10987:6 [INFO] [stdout] | [INFO] [stdout] 10987 | ) -> Vec> [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:11013:6 [INFO] [stdout] | [INFO] [stdout] 11013 | ) -> Vec> [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return curtype; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return curtype; [INFO] [stdout] 14 + curtype [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return (firstok, curcur); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return (firstok, curcur); [INFO] [stdout] 32 + (firstok, curcur) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/arrayinit.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 19 | let mut firstok: i32 = i as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arrayinit.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | cur = cur * lens[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur *= lens[i as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return ptrval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return ptrval; [INFO] [stdout] 59 + ptrval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/arrayinit.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | ats.push(tmp % i.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/arrayinit.rs:51:59 [INFO] [stdout] | [INFO] [stdout] 51 | let indexval = data.dfg_mut().new_value().integer(i.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return curvec; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return curvec; [INFO] [stdout] 114 + curvec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/arrayinit.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | ... .fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/arrayinit.rs:107:35 [INFO] [stdout] | [INFO] [stdout] 107 | let all = lens.iter().fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | return program.new_value().aggregate(elems); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return program.new_value().aggregate(elems); [INFO] [stdout] 143 + program.new_value().aggregate(elems) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/arrayinit.rs:131:49 [INFO] [stdout] | [INFO] [stdout] 131 | let each = len.clone()[1..].to_vec().iter().fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 16 | Array(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | pub vecitem: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 82 | Array(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:94:15 [INFO] [stdout] | [INFO] [stdout] 94 | pub defs: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 100 | Multiple(Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 106 | Array(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 107 | ArrayInit(String, Vec>, Box), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:125:22 [INFO] [stdout] | [INFO] [stdout] 125 | FuncCall(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:193:11 [INFO] [stdout] | [INFO] [stdout] 193 | Notes(Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/optimize_loadstore.rs:64:28 [INFO] [stdout] | [INFO] [stdout] 64 | if !res.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `res.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_none` [INFO] [stdout] --> src/optimize_loadstore.rs:65:59 [INFO] [stdout] | [INFO] [stdout] 64 | if !res.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 65 | replacing.push((inst.clone(), res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | bb: bb.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `bb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | t.insts.push(inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 44 | paramlist.insert(par.clone(), true); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*par` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:51:49 [INFO] [stdout] | [INFO] [stdout] 51 | let kind = self.dfg_mut().value(inst.clone()).kind().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&src).is_some()` [INFO] [stdout] --> src/optimize_loadstore.rs:56:38 [INFO] [stdout] | [INFO] [stdout] 56 | if paramlist.get(&src).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:59:39 [INFO] [stdout] | [INFO] [stdout] 59 | stored.insert(dst.clone(), src.clone()); // stored[dst] = src [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:59:52 [INFO] [stdout] | [INFO] [stdout] 59 | stored.insert(dst.clone(), src.clone()); // stored[dst] = src [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:65:45 [INFO] [stdout] | [INFO] [stdout] 65 | ... replacing.push((inst.clone(), res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:65:59 [INFO] [stdout] | [INFO] [stdout] 65 | ... replacing.push((inst.clone(), res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*res.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 68 | ... stored.insert(src.clone(), inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:68:56 [INFO] [stdout] | [INFO] [stdout] 68 | ... stored.insert(src.clone(), inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:75:47 [INFO] [stdout] | [INFO] [stdout] 75 | let usedby = self.dfg().value(inst.clone()).used_by().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:77:44 [INFO] [stdout] | [INFO] [stdout] 77 | match self.dfg().value(user.clone()).kind().clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:82:39 [INFO] [stdout] | [INFO] [stdout] 82 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:83:39 [INFO] [stdout] | [INFO] [stdout] 83 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:86:39 [INFO] [stdout] | [INFO] [stdout] 86 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:89:53 [INFO] [stdout] | [INFO] [stdout] 89 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:95:63 [INFO] [stdout] | [INFO] [stdout] 95 | ... self.dfg_mut().replace_value_with(user.clone()).branch( [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:96:33 [INFO] [stdout] | [INFO] [stdout] 96 | ... replacer.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:107:40 [INFO] [stdout] | [INFO] [stdout] 107 | ... if v.clone() == inst.clone() { [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:107:53 [INFO] [stdout] | [INFO] [stdout] 107 | ... if v.clone() == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | ... replacer.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:110:41 [INFO] [stdout] | [INFO] [stdout] 110 | ... v.clone() [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:115:53 [INFO] [stdout] | [INFO] [stdout] 115 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:122:39 [INFO] [stdout] | [INFO] [stdout] 122 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:123:39 [INFO] [stdout] | [INFO] [stdout] 123 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:125:39 [INFO] [stdout] | [INFO] [stdout] 125 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:126:39 [INFO] [stdout] | [INFO] [stdout] 126 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:129:53 [INFO] [stdout] | [INFO] [stdout] 129 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:136:39 [INFO] [stdout] | [INFO] [stdout] 136 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:138:39 [INFO] [stdout] | [INFO] [stdout] 138 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:139:39 [INFO] [stdout] | [INFO] [stdout] 139 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:142:53 [INFO] [stdout] | [INFO] [stdout] 142 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:147:53 [INFO] [stdout] | [INFO] [stdout] 147 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:148:39 [INFO] [stdout] | [INFO] [stdout] 148 | ... .load(replacer.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:152:53 [INFO] [stdout] | [INFO] [stdout] 152 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:153:43 [INFO] [stdout] | [INFO] [stdout] 153 | ... .ret(Some(replacer.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:158:39 [INFO] [stdout] | [INFO] [stdout] 158 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:159:39 [INFO] [stdout] | [INFO] [stdout] 159 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:161:39 [INFO] [stdout] | [INFO] [stdout] 161 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:162:39 [INFO] [stdout] | [INFO] [stdout] 162 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:165:53 [INFO] [stdout] | [INFO] [stdout] 165 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:173:44 [INFO] [stdout] | [INFO] [stdout] 173 | let len = self.dfg().value(inst.clone()).used_by().len(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:179:57 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = self.dfg_mut().remove_value(inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:42:47 [INFO] [stdout] | [INFO] [stdout] 42 | self.gen_global_data(ret, nval.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*nval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/riscv.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return ret; [INFO] [stdout] 109 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:64:45 [INFO] [stdout] | [INFO] [stdout] 64 | let valkind = self.borrow_value(gval.clone()).kind().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*gval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 69 | pos.insert(gval.clone(), Position::Global(myname.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*gval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/riscv.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | / match myfunc.ty().kind() { [INFO] [stdout] 95 | | types::TypeKind::Function(_, restype) => { [INFO] [stdout] 96 | | funcname.insert( [INFO] [stdout] 97 | | func.clone(), [INFO] [stdout] ... | [INFO] [stdout] 101 | | _ => {} [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 ~ if let types::TypeKind::Function(_, restype) = myfunc.ty().kind() { [INFO] [stdout] 95 + funcname.insert( [INFO] [stdout] 96 + func.clone(), [INFO] [stdout] 97 + (myfunc.name().to_string(), !restype.is_unit()), [INFO] [stdout] 98 + ); [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Function` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | func.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/riscv.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - ret.push_str(&format!(" mv x{}, x{}\n", id, reg)); [INFO] [stdout] 161 - return; [INFO] [stdout] 160 + ret.push_str(&format!(" mv x{}, x{}\n", id, reg)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:157:30 [INFO] [stdout] | [INFO] [stdout] 157 | gen_lw_x_sp(ret, id.clone(), offset.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | gen_lw_x_sp(ret, id.clone(), offset.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:188:23 [INFO] [stdout] | [INFO] [stdout] 188 | ret.push_str(&format!(" add t1, sp, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t1, sp, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:189:23 [INFO] [stdout] | [INFO] [stdout] 189 | ret.push_str(&format!(" sw t0, 0(t1)\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sw t0, 0(t1)\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/riscv.rs:531:9 [INFO] [stdout] | [INFO] [stdout] 531 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 531 - return ret; [INFO] [stdout] 531 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/riscv.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 199 | if self.layout_mut().bbs_mut().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.layout_mut().bbs_mut().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:221:21 [INFO] [stdout] | [INFO] [stdout] 221 | bb: bb.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `bb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:225:30 [INFO] [stdout] | [INFO] [stdout] 225 | t.insts.push(inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:232:49 [INFO] [stdout] | [INFO] [stdout] 232 | let kind = self.dfg_mut().value(inst.clone()).kind().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:241:54 [INFO] [stdout] | [INFO] [stdout] 241 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:265:31 [INFO] [stdout] | [INFO] [stdout] 265 | ret.push_str(&format!(" add sp, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add sp, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/riscv.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | for val0 in self.params() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, val0) in self.params().iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:273:27 [INFO] [stdout] | [INFO] [stdout] 273 | let val = val0.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*val0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:286:26 [INFO] [stdout] | [INFO] [stdout] 286 | let bb = blockval.bb.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `blockval.bb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:299:28 [INFO] [stdout] | [INFO] [stdout] 299 | let inst = inst0.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*inst0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:304:58 [INFO] [stdout] | [INFO] [stdout] 304 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/riscv.rs:305:25 [INFO] [stdout] | [INFO] [stdout] 305 | let sz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `sz` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 305 ~ [INFO] [stdout] 306 ~ let sz = match ptrty.kind() { [INFO] [stdout] 307 | types::TypeKind::Pointer(t) => { [INFO] [stdout] 308 ~ t.size() as i32 [INFO] [stdout] 309 | } [INFO] [stdout] 310 | _ => unreachable!(), [INFO] [stdout] 311 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:319:43 [INFO] [stdout] | [INFO] [stdout] 319 | ... ret.push_str(&format!(" add t0, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:326:53 [INFO] [stdout] | [INFO] [stdout] 326 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:327:39 [INFO] [stdout] | [INFO] [stdout] 327 | ret.push_str(&format!(" lw t0, 0(t0)\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" lw t0, 0(t0)\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:335:53 [INFO] [stdout] | [INFO] [stdout] 335 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:336:53 [INFO] [stdout] | [INFO] [stdout] 336 | maket(self.dfg(), &mut ret, &pos, dst, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:337:39 [INFO] [stdout] | [INFO] [stdout] 337 | ret.push_str(&format!(" sw t0, 0(t1)\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sw t0, 0(t1)\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:342:53 [INFO] [stdout] | [INFO] [stdout] 342 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:343:53 [INFO] [stdout] | [INFO] [stdout] 343 | maket(self.dfg(), &mut ret, &pos, index, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/riscv.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | let sz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `sz` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 344 ~ [INFO] [stdout] 345 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] 346 ~ let sz = match ptrty.kind() { [INFO] [stdout] 347 | types::TypeKind::Pointer(t) => { [INFO] [stdout] 348 ~ t.size() as i32 [INFO] [stdout] 349 | } [INFO] [stdout] 350 | _ => unreachable!(), [INFO] [stdout] 351 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:345:58 [INFO] [stdout] | [INFO] [stdout] 345 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:353:39 [INFO] [stdout] | [INFO] [stdout] 353 | ret.push_str(&format!(" mul t1, t1, t2\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mul t1, t1, t2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:354:39 [INFO] [stdout] | [INFO] [stdout] 354 | ret.push_str(&format!(" add t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:362:53 [INFO] [stdout] | [INFO] [stdout] 362 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:363:53 [INFO] [stdout] | [INFO] [stdout] 363 | maket(self.dfg(), &mut ret, &pos, index, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/riscv.rs:364:25 [INFO] [stdout] | [INFO] [stdout] 364 | let sz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `sz` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 364 ~ [INFO] [stdout] 365 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] 366 ~ let sz = match ptrty.kind() { [INFO] [stdout] 367 | types::TypeKind::Pointer(t) => { [INFO] [stdout] 368 ~ t.size() as i32 [INFO] [stdout] 369 | } [INFO] [stdout] 370 | _ => unreachable!(), [INFO] [stdout] 371 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:365:58 [INFO] [stdout] | [INFO] [stdout] 365 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:373:39 [INFO] [stdout] | [INFO] [stdout] 373 | ret.push_str(&format!(" mul t1, t1, t2\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mul t1, t1, t2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:374:39 [INFO] [stdout] | [INFO] [stdout] 374 | ret.push_str(&format!(" add t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:382:39 [INFO] [stdout] | [INFO] [stdout] 382 | ret.push_str(&format!(" j ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" j ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:390:53 [INFO] [stdout] | [INFO] [stdout] 390 | maket(self.dfg(), &mut ret, &pos, cond, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:391:39 [INFO] [stdout] | [INFO] [stdout] 391 | ret.push_str(&format!(" beqz t0, ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" beqz t0, ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:395:39 [INFO] [stdout] | [INFO] [stdout] 395 | ret.push_str(&format!(" j ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" j ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:402:39 [INFO] [stdout] | [INFO] [stdout] 402 | ret.push_str(&format!(" j ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" j ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:410:61 [INFO] [stdout] | [INFO] [stdout] 410 | ... makex(self.dfg(), &mut ret, &pos, v, 10); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:416:55 [INFO] [stdout] | [INFO] [stdout] 416 | ... ret.push_str(&format!(" add sp, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add sp, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:419:47 [INFO] [stdout] | [INFO] [stdout] 419 | ... ret.push_str(&format!(" ret\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" ret\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:427:55 [INFO] [stdout] | [INFO] [stdout] 427 | ... ret.push_str(&format!(" add sp, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add sp, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:430:47 [INFO] [stdout] | [INFO] [stdout] 430 | ... ret.push_str(&format!(" ret\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" ret\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:437:53 [INFO] [stdout] | [INFO] [stdout] 437 | maket(self.dfg(), &mut ret, &pos, lhs, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:438:53 [INFO] [stdout] | [INFO] [stdout] 438 | maket(self.dfg(), &mut ret, &pos, rhs, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:441:47 [INFO] [stdout] | [INFO] [stdout] 441 | ... ret.push_str(&format!(" sub t1, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sub t1, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:442:47 [INFO] [stdout] | [INFO] [stdout] 442 | ... ret.push_str(&format!(" snez t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" snez t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:445:47 [INFO] [stdout] | [INFO] [stdout] 445 | ... ret.push_str(&format!(" sub t1, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sub t1, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:446:47 [INFO] [stdout] | [INFO] [stdout] 446 | ... ret.push_str(&format!(" seqz t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" seqz t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:449:47 [INFO] [stdout] | [INFO] [stdout] 449 | ... ret.push_str(&format!(" sgt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sgt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:452:47 [INFO] [stdout] | [INFO] [stdout] 452 | ... ret.push_str(&format!(" slt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" slt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:455:47 [INFO] [stdout] | [INFO] [stdout] 455 | ... ret.push_str(&format!(" slt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" slt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:456:47 [INFO] [stdout] | [INFO] [stdout] 456 | ... ret.push_str(&format!(" xori t0, t0, 1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" xori t0, t0, 1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:459:47 [INFO] [stdout] | [INFO] [stdout] 459 | ... ret.push_str(&format!(" sgt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sgt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:460:47 [INFO] [stdout] | [INFO] [stdout] 460 | ... ret.push_str(&format!(" xori t0, t0, 1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" xori t0, t0, 1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:463:47 [INFO] [stdout] | [INFO] [stdout] 463 | ... ret.push_str(&format!(" add t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:466:47 [INFO] [stdout] | [INFO] [stdout] 466 | ... ret.push_str(&format!(" sub t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sub t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:469:47 [INFO] [stdout] | [INFO] [stdout] 469 | ... ret.push_str(&format!(" mul t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mul t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:472:47 [INFO] [stdout] | [INFO] [stdout] 472 | ... ret.push_str(&format!(" div t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" div t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:475:47 [INFO] [stdout] | [INFO] [stdout] 475 | ... ret.push_str(&format!(" rem t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" rem t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:479:47 [INFO] [stdout] | [INFO] [stdout] 479 | ... ret.push_str(&format!(" and t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" and t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:482:47 [INFO] [stdout] | [INFO] [stdout] 482 | ... ret.push_str(&format!(" or t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" or t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:485:47 [INFO] [stdout] | [INFO] [stdout] 485 | ... ret.push_str(&format!(" xor t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" xor t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/riscv.rs:497:25 [INFO] [stdout] | [INFO] [stdout] 497 | for arg in call.args() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, arg) in call.args().iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:499:61 [INFO] [stdout] | [INFO] [stdout] 499 | ... makex(self.dfg(), &mut ret, &pos, arg.clone(), 10 + i); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:499:67 [INFO] [stdout] | [INFO] [stdout] 499 | ... makex(self.dfg(), &mut ret, &pos, arg.clone(), 10 + i); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:501:61 [INFO] [stdout] | [INFO] [stdout] 501 | ... maket(self.dfg(), &mut ret, &pos, arg.clone(), 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:501:67 [INFO] [stdout] | [INFO] [stdout] 501 | ... maket(self.dfg(), &mut ret, &pos, arg.clone(), 0); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:506:39 [INFO] [stdout] | [INFO] [stdout] 506 | ret.push_str(&format!(" mv t0, ra\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mv t0, ra\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:511:39 [INFO] [stdout] | [INFO] [stdout] 511 | ret.push_str(&format!(" call ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" call ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:513:25 [INFO] [stdout] | [INFO] [stdout] 513 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:516:39 [INFO] [stdout] | [INFO] [stdout] 516 | ret.push_str(&format!(" mv ra, t0\n")); // reload ra [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mv ra, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:519:43 [INFO] [stdout] | [INFO] [stdout] 519 | ... ret.push_str(&format!(" mv t0, a0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mv t0, a0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tokoopa.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | ("@".to_owned() + &id).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `("@".to_owned() + &id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:285:59 [INFO] [stdout] | [INFO] [stdout] 285 | ... tmpmap.insert(id.clone(), res.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `res` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:368:66 [INFO] [stdout] | [INFO] [stdout] 368 | ... let me = program.new_value().integer(tmpmap.get(id).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tmpmap.get(id).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:373:66 [INFO] [stdout] | [INFO] [stdout] 373 | ... let me = program.new_value().integer(tmpmap.get(id).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tmpmap.get(id).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tokoopa.rs:427:17 [INFO] [stdout] | [INFO] [stdout] 427 | ("@".to_owned() + &func.id).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `("@".to_owned() + &func.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `id` is used as a loop counter [INFO] [stdout] --> src/tokoopa.rs:459:9 [INFO] [stdout] | [INFO] [stdout] 459 | for param in self.params.iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (id, param) in self.params.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/tokoopa.rs:546:34 [INFO] [stdout] | [INFO] [stdout] 546 | ... .fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/tokoopa.rs:550:39 [INFO] [stdout] | [INFO] [stdout] 550 | let all = lens.iter().fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:589:44 [INFO] [stdout] | [INFO] [stdout] 589 | IdentValue::ConstValue(get_const_int(data, val).unwrap().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `get_const_int(data, val).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:644:71 [INFO] [stdout] | [INFO] [stdout] 644 | let it = gen_note(data, entry, var, (**note).clone(), fz.clone(), fm.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*fz` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:644:83 [INFO] [stdout] | [INFO] [stdout] 644 | let it = gen_note(data, entry, var, (**note).clone(), fz.clone(), fm.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*fm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:815:33 [INFO] [stdout] | [INFO] [stdout] 815 | while_cond: while_cond.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `while_cond` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:816:32 [INFO] [stdout] | [INFO] [stdout] 816 | while_end: while_end.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `while_end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:818:36 [INFO] [stdout] | [INFO] [stdout] 818 | let curwhilebody = while_body.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `while_body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:928:36 [INFO] [stdout] | [INFO] [stdout] 928 | let func = var.get("score_sing".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_sing"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:942:36 [INFO] [stdout] | [INFO] [stdout] 942 | let func = var.get("score_push".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_push"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:953:36 [INFO] [stdout] | [INFO] [stdout] 953 | let func = var.get("bar_push".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_push"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:964:36 [INFO] [stdout] | [INFO] [stdout] 964 | let func = var.get("bar_setbpm".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_setbpm"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:975:36 [INFO] [stdout] | [INFO] [stdout] 975 | let func = var.get("score_append".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_append"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:986:36 [INFO] [stdout] | [INFO] [stdout] 986 | let func = var.get("score_setbpm".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_setbpm"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:998:36 [INFO] [stdout] | [INFO] [stdout] 998 | let func = var.get("score_replace".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_replace"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1009:36 [INFO] [stdout] | [INFO] [stdout] 1009 | let func = var.get("score_inc_pitch".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_inc_pitch"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1020:36 [INFO] [stdout] | [INFO] [stdout] 1020 | let func = var.get("bar_inc_pitch".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_inc_pitch"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1031:36 [INFO] [stdout] | [INFO] [stdout] 1031 | let func = var.get("score_set_duration".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_set_duration"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1042:36 [INFO] [stdout] | [INFO] [stdout] 1042 | let func = var.get("bar_set_duration".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_set_duration"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1053:36 [INFO] [stdout] | [INFO] [stdout] 1053 | let func = var.get("track_append".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_append"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1064:36 [INFO] [stdout] | [INFO] [stdout] 1064 | let func = var.get("track_stack".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_stack"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1076:36 [INFO] [stdout] | [INFO] [stdout] 1076 | let func = var.get("track_set_volume".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_set_volume"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1090:36 [INFO] [stdout] | [INFO] [stdout] 1090 | let func = var.get("track_append_silence".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_append_silence"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1131:33 [INFO] [stdout] | [INFO] [stdout] 1131 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1131 - return load; [INFO] [stdout] 1131 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1133:33 [INFO] [stdout] | [INFO] [stdout] 1133 | ... return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1133 - return val; [INFO] [stdout] 1133 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1143:29 [INFO] [stdout] | [INFO] [stdout] 1143 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1143 - return load; [INFO] [stdout] 1143 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1152:29 [INFO] [stdout] | [INFO] [stdout] 1152 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1152 - return load; [INFO] [stdout] 1152 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1156:29 [INFO] [stdout] | [INFO] [stdout] 1156 | ... return nval; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1156 - return nval; [INFO] [stdout] 1156 + nval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1198:33 [INFO] [stdout] | [INFO] [stdout] 1198 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1198 - return load; [INFO] [stdout] 1198 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1203:33 [INFO] [stdout] | [INFO] [stdout] 1203 | ... return ptrval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1203 - return ptrval; [INFO] [stdout] 1203 + ptrval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1227:33 [INFO] [stdout] | [INFO] [stdout] 1227 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1227 - return load; [INFO] [stdout] 1227 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1232:33 [INFO] [stdout] | [INFO] [stdout] 1232 | ... return ptrval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1232 - return ptrval; [INFO] [stdout] 1232 + ptrval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tokoopa.rs:1175:33 [INFO] [stdout] | [INFO] [stdout] 1175 | ... let newptr: Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `newptr` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1175 ~ [INFO] [stdout] 1176 ~ let newptr: Value = if fir { [INFO] [stdout] 1177 ~ data.dfg_mut().new_value().get_ptr(ptrval, expval) [INFO] [stdout] 1178 | } else { [INFO] [stdout] 1179 ~ data.dfg_mut().new_value().get_elem_ptr(ptrval, expval) [INFO] [stdout] 1180 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tokoopa.rs:1190:33 [INFO] [stdout] | [INFO] [stdout] 1190 | ... let load: Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `load` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1190 ~ [INFO] [stdout] 1191 | let zero = data.dfg_mut().new_value().integer(0); [INFO] [stdout] 1192 ~ let load: Value = if exps.len() as i32 == dim { [INFO] [stdout] 1193 ~ data.dfg_mut().new_value().load(ptrval) [INFO] [stdout] 1194 | } else { [INFO] [stdout] 1195 ~ data.dfg_mut().new_value().get_elem_ptr(ptrval, zero) [INFO] [stdout] 1196 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tokoopa.rs:1219:33 [INFO] [stdout] | [INFO] [stdout] 1219 | ... let load: Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `load` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1219 ~ [INFO] [stdout] 1220 | let zero = data.dfg_mut().new_value().integer(0); [INFO] [stdout] 1221 ~ let load: Value = if exps.len() as i32 == dim { [INFO] [stdout] 1222 ~ data.dfg_mut().new_value().load(ptrval) [INFO] [stdout] 1223 | } else { [INFO] [stdout] 1224 ~ data.dfg_mut().new_value().get_elem_ptr(ptrval, zero) [INFO] [stdout] 1225 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/tokoopa.rs:1262:17 [INFO] [stdout] | [INFO] [stdout] 1261 | let val = lval.gen_ir(data, entry, var, true); [INFO] [stdout] | ---------------------------------------------- unnecessary `let` binding [INFO] [stdout] 1262 | val [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 1261 ~ [INFO] [stdout] 1262 ~ lval.gen_ir(data, entry, var, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1580:17 [INFO] [stdout] | [INFO] [stdout] 1580 | return getres; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1580 - return getres; [INFO] [stdout] 1580 + getres [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1646:17 [INFO] [stdout] | [INFO] [stdout] 1646 | return getres; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1646 - return getres; [INFO] [stdout] 1646 + getres [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | return call; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return call; [INFO] [stdout] 20 + call [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Function` which implements the `Copy` trait [INFO] [stdout] --> src/gen_music.rs:18:56 [INFO] [stdout] | [INFO] [stdout] 18 | let call = data.dfg_mut().new_value().call(func.clone(), args); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return it; [INFO] [stdout] 40 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return it; [INFO] [stdout] 45 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/gen_music.rs:43:58 [INFO] [stdout] | [INFO] [stdout] 43 | let num = data.dfg_mut().new_value().integer(num.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/gen_music.rs:73:58 [INFO] [stdout] | [INFO] [stdout] 73 | let num = data.dfg_mut().new_value().integer(num.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return it; [INFO] [stdout] 96 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return it; [INFO] [stdout] 112 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:4248:18 [INFO] [stdout] | [INFO] [stdout] 4248 | ) -> (usize, Vec>, usize) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8132:9 [INFO] [stdout] | [INFO] [stdout] 8132 | return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8132 - return CompUnit { func_defs: func_defs, global_var_defs: global_var_defs }; [INFO] [stdout] 8132 + CompUnit { func_defs: func_defs, global_var_defs: global_var_defs } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8163:9 [INFO] [stdout] | [INFO] [stdout] 8163 | / return GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8164 | | func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8165 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8163 ~ GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8164 + func_type: FuncType::Int, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8165 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8184:9 [INFO] [stdout] | [INFO] [stdout] 8184 | / return GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8185 | | func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8186 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8184 ~ GlobalDef::FuncDef(FuncDef { [INFO] [stdout] 8185 + func_type: FuncType::Void, params: params.unwrap_or(Vec::new()), id: id, block: block [INFO] [stdout] 8186 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8206:9 [INFO] [stdout] | [INFO] [stdout] 8206 | return params; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8206 - return params; [INFO] [stdout] 8206 + params [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8241:9 [INFO] [stdout] | [INFO] [stdout] 8241 | return FuncParam::Array(id, exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8241 - return FuncParam::Array(id, exps); [INFO] [stdout] 8241 + FuncParam::Array(id, exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8264:9 [INFO] [stdout] | [INFO] [stdout] 8264 | return VarDef::ScoreInit(id, Box::new(score)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8264 - return VarDef::ScoreInit(id, Box::new(score)); [INFO] [stdout] 8264 + VarDef::ScoreInit(id, Box::new(score)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8295:9 [INFO] [stdout] | [INFO] [stdout] 8295 | return VarDef::NoteInit(id, Box::new(note), fz, fm); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8295 - return VarDef::NoteInit(id, Box::new(note), fz, fm); [INFO] [stdout] 8295 + VarDef::NoteInit(id, Box::new(note), fz, fm) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8318:9 [INFO] [stdout] | [INFO] [stdout] 8318 | return VarDef::BarInit(id, Box::new(bar)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8318 - return VarDef::BarInit(id, Box::new(bar)); [INFO] [stdout] 8318 + VarDef::BarInit(id, Box::new(bar)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8337:9 [INFO] [stdout] | [INFO] [stdout] 8337 | return VarDef::BarCopy(id, Box::new(y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8337 - return VarDef::BarCopy(id, Box::new(y)); [INFO] [stdout] 8337 + VarDef::BarCopy(id, Box::new(y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8353:9 [INFO] [stdout] | [INFO] [stdout] 8353 | return VarDef::Bar(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8353 - return VarDef::Bar(id); [INFO] [stdout] 8353 + VarDef::Bar(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8372:9 [INFO] [stdout] | [INFO] [stdout] 8372 | return VarDef::ScoreCopy(id, Box::new(y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8372 - return VarDef::ScoreCopy(id, Box::new(y)); [INFO] [stdout] 8372 + VarDef::ScoreCopy(id, Box::new(y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8388:9 [INFO] [stdout] | [INFO] [stdout] 8388 | return VarDef::Score(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8388 - return VarDef::Score(id); [INFO] [stdout] 8388 + VarDef::Score(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8409:9 [INFO] [stdout] | [INFO] [stdout] 8409 | return VarDef::TrackCopy(id, Box::new(y), Box::new(z)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8409 - return VarDef::TrackCopy(id, Box::new(y), Box::new(z)); [INFO] [stdout] 8409 + VarDef::TrackCopy(id, Box::new(y), Box::new(z)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8428:9 [INFO] [stdout] | [INFO] [stdout] 8428 | return VarDef::TrackLoad(id, Box::new(y)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8428 - return VarDef::TrackLoad(id, Box::new(y)); [INFO] [stdout] 8428 + VarDef::TrackLoad(id, Box::new(y)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8444:9 [INFO] [stdout] | [INFO] [stdout] 8444 | return VarDef::Track(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8444 - return VarDef::Track(id); [INFO] [stdout] 8444 + VarDef::Track(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8466:9 [INFO] [stdout] | [INFO] [stdout] 8466 | return Decl {defs: decl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8466 - return Decl {defs: decl}; [INFO] [stdout] 8466 + Decl {defs: decl} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8489:9 [INFO] [stdout] | [INFO] [stdout] 8489 | return Decl {defs: decl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8489 - return Decl {defs: decl}; [INFO] [stdout] 8489 + Decl {defs: decl} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8548:9 [INFO] [stdout] | [INFO] [stdout] 8548 | return ArrayInit::Multiple(exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8548 - return ArrayInit::Multiple(exps); [INFO] [stdout] 8548 + ArrayInit::Multiple(exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8593:9 [INFO] [stdout] | [INFO] [stdout] 8593 | return VarDef::Array(id, exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8593 - return VarDef::Array(id, exps); [INFO] [stdout] 8593 + VarDef::Array(id, exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8614:9 [INFO] [stdout] | [INFO] [stdout] 8614 | return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8614 - return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] 8614 + VarDef::ArrayInit(id, exps, Box::new(init)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8649:9 [INFO] [stdout] | [INFO] [stdout] 8649 | return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8649 - return VarDef::ArrayInit(id, exps, Box::new(init)); [INFO] [stdout] 8649 + VarDef::ArrayInit(id, exps, Box::new(init)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8693:5 [INFO] [stdout] | [INFO] [stdout] 8693 | return Block { vecitem: block }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8693 - return Block { vecitem: block }; [INFO] [stdout] 8693 + Block { vecitem: block } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8757:9 [INFO] [stdout] | [INFO] [stdout] 8757 | return Stmt::Sing(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d), Box::new(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8757 - return Stmt::Sing(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d), Box::new(e)); [INFO] [stdout] 8757 + Stmt::Sing(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d), Box::new(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8777:9 [INFO] [stdout] | [INFO] [stdout] 8777 | return Stmt::PushBar(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8777 - return Stmt::PushBar(Box::new(x), Box::new(a)); [INFO] [stdout] 8777 + Stmt::PushBar(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8797:9 [INFO] [stdout] | [INFO] [stdout] 8797 | return Stmt::PushNote(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8797 - return Stmt::PushNote(Box::new(x), Box::new(a)); [INFO] [stdout] 8797 + Stmt::PushNote(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8817:9 [INFO] [stdout] | [INFO] [stdout] 8817 | return Stmt::SetBarBpm(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8817 - return Stmt::SetBarBpm(Box::new(x), Box::new(a)); [INFO] [stdout] 8817 + Stmt::SetBarBpm(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8837:9 [INFO] [stdout] | [INFO] [stdout] 8837 | return Stmt::SetScoreBpm(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8837 - return Stmt::SetScoreBpm(Box::new(x), Box::new(a)); [INFO] [stdout] 8837 + Stmt::SetScoreBpm(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8857:9 [INFO] [stdout] | [INFO] [stdout] 8857 | return Stmt::IncScorePitch(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8857 - return Stmt::IncScorePitch(Box::new(x), Box::new(a)); [INFO] [stdout] 8857 + Stmt::IncScorePitch(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8877:9 [INFO] [stdout] | [INFO] [stdout] 8877 | return Stmt::SetScoreDuration(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8877 - return Stmt::SetScoreDuration(Box::new(x), Box::new(a)); [INFO] [stdout] 8877 + Stmt::SetScoreDuration(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8897:9 [INFO] [stdout] | [INFO] [stdout] 8897 | return Stmt::IncBarPitch(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8897 - return Stmt::IncBarPitch(Box::new(x), Box::new(a)); [INFO] [stdout] 8897 + Stmt::IncBarPitch(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8917:9 [INFO] [stdout] | [INFO] [stdout] 8917 | return Stmt::SetBarDuration(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8917 - return Stmt::SetBarDuration(Box::new(x), Box::new(a)); [INFO] [stdout] 8917 + Stmt::SetBarDuration(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8937:9 [INFO] [stdout] | [INFO] [stdout] 8937 | return Stmt::Append(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8937 - return Stmt::Append(Box::new(x), Box::new(a)); [INFO] [stdout] 8937 + Stmt::Append(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8959:9 [INFO] [stdout] | [INFO] [stdout] 8959 | return Stmt::ReplaceBar(Box::new(x), Box::new(a), Box::new(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8959 - return Stmt::ReplaceBar(Box::new(x), Box::new(a), Box::new(b)); [INFO] [stdout] 8959 + Stmt::ReplaceBar(Box::new(x), Box::new(a), Box::new(b)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:8979:9 [INFO] [stdout] | [INFO] [stdout] 8979 | return Stmt::AppendTrack(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8979 - return Stmt::AppendTrack(Box::new(x), Box::new(a)); [INFO] [stdout] 8979 + Stmt::AppendTrack(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9005:9 [INFO] [stdout] | [INFO] [stdout] 9005 | return Stmt::AppendSilence(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9005 - return Stmt::AppendSilence(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d)); [INFO] [stdout] 9005 + Stmt::AppendSilence(Box::new(x), Box::new(a), Box::new(b), Box::new(c), Box::new(d)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9025:9 [INFO] [stdout] | [INFO] [stdout] 9025 | return Stmt::StackTrack(Box::new(x), Box::new(a)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9025 - return Stmt::StackTrack(Box::new(x), Box::new(a)); [INFO] [stdout] 9025 + Stmt::StackTrack(Box::new(x), Box::new(a)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9047:9 [INFO] [stdout] | [INFO] [stdout] 9047 | return Stmt::SetVol(Box::new(x), Box::new(fz), Box::new(fm)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9047 - return Stmt::SetVol(Box::new(x), Box::new(fz), Box::new(fm)); [INFO] [stdout] 9047 + Stmt::SetVol(Box::new(x), Box::new(fz), Box::new(fm)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9290:9 [INFO] [stdout] | [INFO] [stdout] 9290 | return LVal::Array(id, exps); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9290 - return LVal::Array(id, exps); [INFO] [stdout] 9290 + LVal::Array(id, exps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9366:27 [INFO] [stdout] | [INFO] [stdout] 9366 | (_, args, _): (usize, Vec>, usize), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9420:6 [INFO] [stdout] | [INFO] [stdout] 9420 | ) -> Vec> [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9428:9 [INFO] [stdout] | [INFO] [stdout] 9428 | return args; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9428 - return args; [INFO] [stdout] 9428 + args [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9803:5 [INFO] [stdout] | [INFO] [stdout] 9803 | i32::from_str_radix(__0, 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9815:5 [INFO] [stdout] | [INFO] [stdout] 9815 | i32::from_str_radix(__0, 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9894:9 [INFO] [stdout] | [INFO] [stdout] 9894 | return Score { bars: bars }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9894 - return Score { bars: bars }; [INFO] [stdout] 9894 + Score { bars: bars } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9912:5 [INFO] [stdout] | [INFO] [stdout] 9912 | return Bar { notes: note_elems }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9912 - return Bar { notes: note_elems }; [INFO] [stdout] 9912 + Bar { notes: note_elems } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9968:9 [INFO] [stdout] | [INFO] [stdout] 9968 | return NoteElem::Notes(note_elems); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9968 - return NoteElem::Notes(note_elems); [INFO] [stdout] 9968 + NoteElem::Notes(note_elems) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:9984:9 [INFO] [stdout] | [INFO] [stdout] 9984 | return a.up(dot_count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9984 - return a.up(dot_count); [INFO] [stdout] 9984 + a.up(dot_count) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10022:9 [INFO] [stdout] | [INFO] [stdout] 10022 | return a; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10022 - return a; [INFO] [stdout] 10022 + a [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10038:9 [INFO] [stdout] | [INFO] [stdout] 10038 | return a.up(-dot_count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10038 - return a.up(-dot_count); [INFO] [stdout] 10038 + a.up(-dot_count) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10079:9 [INFO] [stdout] | [INFO] [stdout] 10079 | return Note::Semitone(new_s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10079 - return Note::Semitone(new_s); [INFO] [stdout] 10079 + Note::Semitone(new_s) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10092:5 [INFO] [stdout] | [INFO] [stdout] 10092 | i32::from_str_radix(__0, 10).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `__0.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10107:5 [INFO] [stdout] | [INFO] [stdout] 10107 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10107 - return s; [INFO] [stdout] 10107 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:10987:6 [INFO] [stdout] | [INFO] [stdout] 10987 | ) -> Vec> [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> /opt/rustwide/target/debug/build/compiler-327c1061fbeb24cf/out/sysy.rs:11013:6 [INFO] [stdout] | [INFO] [stdout] 11013 | ) -> Vec> [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return curtype; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return curtype; [INFO] [stdout] 14 + curtype [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return (firstok, curcur); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return (firstok, curcur); [INFO] [stdout] 32 + (firstok, curcur) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/arrayinit.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 19 | let mut firstok: i32 = i as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/arrayinit.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | cur = cur * lens[i as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur *= lens[i as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return ptrval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return ptrval; [INFO] [stdout] 59 + ptrval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/arrayinit.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | ats.push(tmp % i.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/arrayinit.rs:51:59 [INFO] [stdout] | [INFO] [stdout] 51 | let indexval = data.dfg_mut().new_value().integer(i.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return curvec; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return curvec; [INFO] [stdout] 114 + curvec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/arrayinit.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | ... .fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/arrayinit.rs:107:35 [INFO] [stdout] | [INFO] [stdout] 107 | let all = lens.iter().fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/arrayinit.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | return program.new_value().aggregate(elems); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return program.new_value().aggregate(elems); [INFO] [stdout] 143 + program.new_value().aggregate(elems) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/arrayinit.rs:131:49 [INFO] [stdout] | [INFO] [stdout] 131 | let each = len.clone()[1..].to_vec().iter().fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:16:19 [INFO] [stdout] | [INFO] [stdout] 16 | Array(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | pub vecitem: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:82:19 [INFO] [stdout] | [INFO] [stdout] 82 | Array(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:94:15 [INFO] [stdout] | [INFO] [stdout] 94 | pub defs: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:100:14 [INFO] [stdout] | [INFO] [stdout] 100 | Multiple(Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:106:19 [INFO] [stdout] | [INFO] [stdout] 106 | Array(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 107 | ArrayInit(String, Vec>, Box), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:125:22 [INFO] [stdout] | [INFO] [stdout] 125 | FuncCall(String, Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/ast.rs:193:11 [INFO] [stdout] | [INFO] [stdout] 193 | Notes(Vec>), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/optimize_loadstore.rs:64:28 [INFO] [stdout] | [INFO] [stdout] 64 | if !res.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `res.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res` after checking its variant with `is_none` [INFO] [stdout] --> src/optimize_loadstore.rs:65:59 [INFO] [stdout] | [INFO] [stdout] 64 | if !res.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 65 | replacing.push((inst.clone(), res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | bb: bb.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `bb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 38 | t.insts.push(inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 44 | paramlist.insert(par.clone(), true); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*par` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:51:49 [INFO] [stdout] | [INFO] [stdout] 51 | let kind = self.dfg_mut().value(inst.clone()).kind().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&src).is_some()` [INFO] [stdout] --> src/optimize_loadstore.rs:56:38 [INFO] [stdout] | [INFO] [stdout] 56 | if paramlist.get(&src).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&src)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:59:39 [INFO] [stdout] | [INFO] [stdout] 59 | stored.insert(dst.clone(), src.clone()); // stored[dst] = src [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:59:52 [INFO] [stdout] | [INFO] [stdout] 59 | stored.insert(dst.clone(), src.clone()); // stored[dst] = src [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:65:45 [INFO] [stdout] | [INFO] [stdout] 65 | ... replacing.push((inst.clone(), res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:65:59 [INFO] [stdout] | [INFO] [stdout] 65 | ... replacing.push((inst.clone(), res.unwrap().clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*res.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 68 | ... stored.insert(src.clone(), inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:68:56 [INFO] [stdout] | [INFO] [stdout] 68 | ... stored.insert(src.clone(), inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:75:47 [INFO] [stdout] | [INFO] [stdout] 75 | let usedby = self.dfg().value(inst.clone()).used_by().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:77:44 [INFO] [stdout] | [INFO] [stdout] 77 | match self.dfg().value(user.clone()).kind().clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:82:39 [INFO] [stdout] | [INFO] [stdout] 82 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:83:39 [INFO] [stdout] | [INFO] [stdout] 83 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:86:39 [INFO] [stdout] | [INFO] [stdout] 86 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:89:53 [INFO] [stdout] | [INFO] [stdout] 89 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:95:63 [INFO] [stdout] | [INFO] [stdout] 95 | ... self.dfg_mut().replace_value_with(user.clone()).branch( [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:96:33 [INFO] [stdout] | [INFO] [stdout] 96 | ... replacer.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:107:40 [INFO] [stdout] | [INFO] [stdout] 107 | ... if v.clone() == inst.clone() { [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:107:53 [INFO] [stdout] | [INFO] [stdout] 107 | ... if v.clone() == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | ... replacer.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:110:41 [INFO] [stdout] | [INFO] [stdout] 110 | ... v.clone() [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:115:53 [INFO] [stdout] | [INFO] [stdout] 115 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:122:39 [INFO] [stdout] | [INFO] [stdout] 122 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:123:39 [INFO] [stdout] | [INFO] [stdout] 123 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:125:39 [INFO] [stdout] | [INFO] [stdout] 125 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:126:39 [INFO] [stdout] | [INFO] [stdout] 126 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:129:53 [INFO] [stdout] | [INFO] [stdout] 129 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:136:39 [INFO] [stdout] | [INFO] [stdout] 136 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:138:39 [INFO] [stdout] | [INFO] [stdout] 138 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:139:39 [INFO] [stdout] | [INFO] [stdout] 139 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:142:53 [INFO] [stdout] | [INFO] [stdout] 142 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:147:53 [INFO] [stdout] | [INFO] [stdout] 147 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:148:39 [INFO] [stdout] | [INFO] [stdout] 148 | ... .load(replacer.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:152:53 [INFO] [stdout] | [INFO] [stdout] 152 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:153:43 [INFO] [stdout] | [INFO] [stdout] 153 | ... .ret(Some(replacer.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:158:39 [INFO] [stdout] | [INFO] [stdout] 158 | ... if lhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:159:39 [INFO] [stdout] | [INFO] [stdout] 159 | ... lhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:161:39 [INFO] [stdout] | [INFO] [stdout] 161 | ... if rhs == inst.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:162:39 [INFO] [stdout] | [INFO] [stdout] 162 | ... rhs = replacer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*replacer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:165:53 [INFO] [stdout] | [INFO] [stdout] 165 | ... .replace_value_with(user.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:173:44 [INFO] [stdout] | [INFO] [stdout] 173 | let len = self.dfg().value(inst.clone()).used_by().len(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/optimize_loadstore.rs:179:57 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = self.dfg_mut().remove_value(inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:42:47 [INFO] [stdout] | [INFO] [stdout] 42 | self.gen_global_data(ret, nval.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*nval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/riscv.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return ret; [INFO] [stdout] 109 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:64:45 [INFO] [stdout] | [INFO] [stdout] 64 | let valkind = self.borrow_value(gval.clone()).kind().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*gval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 69 | pos.insert(gval.clone(), Position::Global(myname.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*gval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/riscv.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | / match myfunc.ty().kind() { [INFO] [stdout] 95 | | types::TypeKind::Function(_, restype) => { [INFO] [stdout] 96 | | funcname.insert( [INFO] [stdout] 97 | | func.clone(), [INFO] [stdout] ... | [INFO] [stdout] 101 | | _ => {} [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 ~ if let types::TypeKind::Function(_, restype) = myfunc.ty().kind() { [INFO] [stdout] 95 + funcname.insert( [INFO] [stdout] 96 + func.clone(), [INFO] [stdout] 97 + (myfunc.name().to_string(), !restype.is_unit()), [INFO] [stdout] 98 + ); [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Function` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | func.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/riscv.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - ret.push_str(&format!(" mv x{}, x{}\n", id, reg)); [INFO] [stdout] 161 - return; [INFO] [stdout] 160 + ret.push_str(&format!(" mv x{}, x{}\n", id, reg)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:157:30 [INFO] [stdout] | [INFO] [stdout] 157 | gen_lw_x_sp(ret, id.clone(), offset.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | gen_lw_x_sp(ret, id.clone(), offset.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:188:23 [INFO] [stdout] | [INFO] [stdout] 188 | ret.push_str(&format!(" add t1, sp, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t1, sp, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:189:23 [INFO] [stdout] | [INFO] [stdout] 189 | ret.push_str(&format!(" sw t0, 0(t1)\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sw t0, 0(t1)\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/riscv.rs:531:9 [INFO] [stdout] | [INFO] [stdout] 531 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 531 - return ret; [INFO] [stdout] 531 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/riscv.rs:199:12 [INFO] [stdout] | [INFO] [stdout] 199 | if self.layout_mut().bbs_mut().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.layout_mut().bbs_mut().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:221:21 [INFO] [stdout] | [INFO] [stdout] 221 | bb: bb.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `bb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:225:30 [INFO] [stdout] | [INFO] [stdout] 225 | t.insts.push(inst.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:232:49 [INFO] [stdout] | [INFO] [stdout] 232 | let kind = self.dfg_mut().value(inst.clone()).kind().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:241:54 [INFO] [stdout] | [INFO] [stdout] 241 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:265:31 [INFO] [stdout] | [INFO] [stdout] 265 | ret.push_str(&format!(" add sp, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add sp, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/riscv.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | for val0 in self.params() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, val0) in self.params().iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:273:27 [INFO] [stdout] | [INFO] [stdout] 273 | let val = val0.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*val0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:286:26 [INFO] [stdout] | [INFO] [stdout] 286 | let bb = blockval.bb.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `blockval.bb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:299:28 [INFO] [stdout] | [INFO] [stdout] 299 | let inst = inst0.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*inst0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:304:58 [INFO] [stdout] | [INFO] [stdout] 304 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/riscv.rs:305:25 [INFO] [stdout] | [INFO] [stdout] 305 | let sz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `sz` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 305 ~ [INFO] [stdout] 306 ~ let sz = match ptrty.kind() { [INFO] [stdout] 307 | types::TypeKind::Pointer(t) => { [INFO] [stdout] 308 ~ t.size() as i32 [INFO] [stdout] 309 | } [INFO] [stdout] 310 | _ => unreachable!(), [INFO] [stdout] 311 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:319:43 [INFO] [stdout] | [INFO] [stdout] 319 | ... ret.push_str(&format!(" add t0, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:326:53 [INFO] [stdout] | [INFO] [stdout] 326 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:327:39 [INFO] [stdout] | [INFO] [stdout] 327 | ret.push_str(&format!(" lw t0, 0(t0)\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" lw t0, 0(t0)\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:335:53 [INFO] [stdout] | [INFO] [stdout] 335 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:336:53 [INFO] [stdout] | [INFO] [stdout] 336 | maket(self.dfg(), &mut ret, &pos, dst, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:337:39 [INFO] [stdout] | [INFO] [stdout] 337 | ret.push_str(&format!(" sw t0, 0(t1)\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sw t0, 0(t1)\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:342:53 [INFO] [stdout] | [INFO] [stdout] 342 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:343:53 [INFO] [stdout] | [INFO] [stdout] 343 | maket(self.dfg(), &mut ret, &pos, index, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/riscv.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | let sz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `sz` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 344 ~ [INFO] [stdout] 345 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] 346 ~ let sz = match ptrty.kind() { [INFO] [stdout] 347 | types::TypeKind::Pointer(t) => { [INFO] [stdout] 348 ~ t.size() as i32 [INFO] [stdout] 349 | } [INFO] [stdout] 350 | _ => unreachable!(), [INFO] [stdout] 351 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:345:58 [INFO] [stdout] | [INFO] [stdout] 345 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:353:39 [INFO] [stdout] | [INFO] [stdout] 353 | ret.push_str(&format!(" mul t1, t1, t2\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mul t1, t1, t2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:354:39 [INFO] [stdout] | [INFO] [stdout] 354 | ret.push_str(&format!(" add t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:362:53 [INFO] [stdout] | [INFO] [stdout] 362 | maket(self.dfg(), &mut ret, &pos, src, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:363:53 [INFO] [stdout] | [INFO] [stdout] 363 | maket(self.dfg(), &mut ret, &pos, index, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/riscv.rs:364:25 [INFO] [stdout] | [INFO] [stdout] 364 | let sz; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `sz` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 364 ~ [INFO] [stdout] 365 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] 366 ~ let sz = match ptrty.kind() { [INFO] [stdout] 367 | types::TypeKind::Pointer(t) => { [INFO] [stdout] 368 ~ t.size() as i32 [INFO] [stdout] 369 | } [INFO] [stdout] 370 | _ => unreachable!(), [INFO] [stdout] 371 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:365:58 [INFO] [stdout] | [INFO] [stdout] 365 | let ptrty = self.dfg_mut().value(inst.clone()).ty().clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `inst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:373:39 [INFO] [stdout] | [INFO] [stdout] 373 | ret.push_str(&format!(" mul t1, t1, t2\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mul t1, t1, t2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:374:39 [INFO] [stdout] | [INFO] [stdout] 374 | ret.push_str(&format!(" add t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:382:39 [INFO] [stdout] | [INFO] [stdout] 382 | ret.push_str(&format!(" j ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" j ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:390:53 [INFO] [stdout] | [INFO] [stdout] 390 | maket(self.dfg(), &mut ret, &pos, cond, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:391:39 [INFO] [stdout] | [INFO] [stdout] 391 | ret.push_str(&format!(" beqz t0, ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" beqz t0, ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:395:39 [INFO] [stdout] | [INFO] [stdout] 395 | ret.push_str(&format!(" j ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" j ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:402:39 [INFO] [stdout] | [INFO] [stdout] 402 | ret.push_str(&format!(" j ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" j ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:410:61 [INFO] [stdout] | [INFO] [stdout] 410 | ... makex(self.dfg(), &mut ret, &pos, v, 10); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:416:55 [INFO] [stdout] | [INFO] [stdout] 416 | ... ret.push_str(&format!(" add sp, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add sp, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:419:47 [INFO] [stdout] | [INFO] [stdout] 419 | ... ret.push_str(&format!(" ret\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" ret\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:427:55 [INFO] [stdout] | [INFO] [stdout] 427 | ... ret.push_str(&format!(" add sp, sp, t0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add sp, sp, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:430:47 [INFO] [stdout] | [INFO] [stdout] 430 | ... ret.push_str(&format!(" ret\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" ret\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:437:53 [INFO] [stdout] | [INFO] [stdout] 437 | maket(self.dfg(), &mut ret, &pos, lhs, 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:438:53 [INFO] [stdout] | [INFO] [stdout] 438 | maket(self.dfg(), &mut ret, &pos, rhs, 1); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:441:47 [INFO] [stdout] | [INFO] [stdout] 441 | ... ret.push_str(&format!(" sub t1, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sub t1, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:442:47 [INFO] [stdout] | [INFO] [stdout] 442 | ... ret.push_str(&format!(" snez t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" snez t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:445:47 [INFO] [stdout] | [INFO] [stdout] 445 | ... ret.push_str(&format!(" sub t1, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sub t1, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:446:47 [INFO] [stdout] | [INFO] [stdout] 446 | ... ret.push_str(&format!(" seqz t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" seqz t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:449:47 [INFO] [stdout] | [INFO] [stdout] 449 | ... ret.push_str(&format!(" sgt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sgt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:452:47 [INFO] [stdout] | [INFO] [stdout] 452 | ... ret.push_str(&format!(" slt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" slt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:455:47 [INFO] [stdout] | [INFO] [stdout] 455 | ... ret.push_str(&format!(" slt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" slt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:456:47 [INFO] [stdout] | [INFO] [stdout] 456 | ... ret.push_str(&format!(" xori t0, t0, 1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" xori t0, t0, 1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:459:47 [INFO] [stdout] | [INFO] [stdout] 459 | ... ret.push_str(&format!(" sgt t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sgt t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:460:47 [INFO] [stdout] | [INFO] [stdout] 460 | ... ret.push_str(&format!(" xori t0, t0, 1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" xori t0, t0, 1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:463:47 [INFO] [stdout] | [INFO] [stdout] 463 | ... ret.push_str(&format!(" add t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" add t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:466:47 [INFO] [stdout] | [INFO] [stdout] 466 | ... ret.push_str(&format!(" sub t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" sub t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:469:47 [INFO] [stdout] | [INFO] [stdout] 469 | ... ret.push_str(&format!(" mul t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mul t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:472:47 [INFO] [stdout] | [INFO] [stdout] 472 | ... ret.push_str(&format!(" div t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" div t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:475:47 [INFO] [stdout] | [INFO] [stdout] 475 | ... ret.push_str(&format!(" rem t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" rem t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:479:47 [INFO] [stdout] | [INFO] [stdout] 479 | ... ret.push_str(&format!(" and t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" and t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:482:47 [INFO] [stdout] | [INFO] [stdout] 482 | ... ret.push_str(&format!(" or t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" or t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:485:47 [INFO] [stdout] | [INFO] [stdout] 485 | ... ret.push_str(&format!(" xor t0, t0, t1\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" xor t0, t0, t1\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/riscv.rs:497:25 [INFO] [stdout] | [INFO] [stdout] 497 | for arg in call.args() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, arg) in call.args().iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:499:61 [INFO] [stdout] | [INFO] [stdout] 499 | ... makex(self.dfg(), &mut ret, &pos, arg.clone(), 10 + i); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:499:67 [INFO] [stdout] | [INFO] [stdout] 499 | ... makex(self.dfg(), &mut ret, &pos, arg.clone(), 10 + i); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/riscv.rs:501:61 [INFO] [stdout] | [INFO] [stdout] 501 | ... maket(self.dfg(), &mut ret, &pos, arg.clone(), 0); [INFO] [stdout] | ^^^^ help: change this to: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Value` which implements the `Copy` trait [INFO] [stdout] --> src/riscv.rs:501:67 [INFO] [stdout] | [INFO] [stdout] 501 | ... maket(self.dfg(), &mut ret, &pos, arg.clone(), 0); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:506:39 [INFO] [stdout] | [INFO] [stdout] 506 | ret.push_str(&format!(" mv t0, ra\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mv t0, ra\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:511:39 [INFO] [stdout] | [INFO] [stdout] 511 | ret.push_str(&format!(" call ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" call ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/riscv.rs:513:25 [INFO] [stdout] | [INFO] [stdout] 513 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:516:39 [INFO] [stdout] | [INFO] [stdout] 516 | ret.push_str(&format!(" mv ra, t0\n")); // reload ra [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mv ra, t0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/riscv.rs:519:43 [INFO] [stdout] | [INFO] [stdout] 519 | ... ret.push_str(&format!(" mv t0, a0\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" mv t0, a0\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tokoopa.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | ("@".to_owned() + &id).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `("@".to_owned() + &id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:285:59 [INFO] [stdout] | [INFO] [stdout] 285 | ... tmpmap.insert(id.clone(), res.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `res` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:368:66 [INFO] [stdout] | [INFO] [stdout] 368 | ... let me = program.new_value().integer(tmpmap.get(id).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tmpmap.get(id).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:373:66 [INFO] [stdout] | [INFO] [stdout] 373 | ... let me = program.new_value().integer(tmpmap.get(id).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tmpmap.get(id).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tokoopa.rs:427:17 [INFO] [stdout] | [INFO] [stdout] 427 | ("@".to_owned() + &func.id).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `("@".to_owned() + &func.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `id` is used as a loop counter [INFO] [stdout] --> src/tokoopa.rs:459:9 [INFO] [stdout] | [INFO] [stdout] 459 | for param in self.params.iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (id, param) in self.params.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/tokoopa.rs:546:34 [INFO] [stdout] | [INFO] [stdout] 546 | ... .fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/tokoopa.rs:550:39 [INFO] [stdout] | [INFO] [stdout] 550 | let all = lens.iter().fold(1, |acc, x| acc * x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:589:44 [INFO] [stdout] | [INFO] [stdout] 589 | IdentValue::ConstValue(get_const_int(data, val).unwrap().clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `get_const_int(data, val).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:644:71 [INFO] [stdout] | [INFO] [stdout] 644 | let it = gen_note(data, entry, var, (**note).clone(), fz.clone(), fm.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*fz` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:644:83 [INFO] [stdout] | [INFO] [stdout] 644 | let it = gen_note(data, entry, var, (**note).clone(), fz.clone(), fm.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*fm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:815:33 [INFO] [stdout] | [INFO] [stdout] 815 | while_cond: while_cond.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `while_cond` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:816:32 [INFO] [stdout] | [INFO] [stdout] 816 | while_end: while_end.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `while_end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BasicBlock` which implements the `Copy` trait [INFO] [stdout] --> src/tokoopa.rs:818:36 [INFO] [stdout] | [INFO] [stdout] 818 | let curwhilebody = while_body.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `while_body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:928:36 [INFO] [stdout] | [INFO] [stdout] 928 | let func = var.get("score_sing".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_sing"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:942:36 [INFO] [stdout] | [INFO] [stdout] 942 | let func = var.get("score_push".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_push"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:953:36 [INFO] [stdout] | [INFO] [stdout] 953 | let func = var.get("bar_push".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_push"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:964:36 [INFO] [stdout] | [INFO] [stdout] 964 | let func = var.get("bar_setbpm".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_setbpm"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:975:36 [INFO] [stdout] | [INFO] [stdout] 975 | let func = var.get("score_append".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_append"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:986:36 [INFO] [stdout] | [INFO] [stdout] 986 | let func = var.get("score_setbpm".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_setbpm"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:998:36 [INFO] [stdout] | [INFO] [stdout] 998 | let func = var.get("score_replace".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_replace"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1009:36 [INFO] [stdout] | [INFO] [stdout] 1009 | let func = var.get("score_inc_pitch".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_inc_pitch"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1020:36 [INFO] [stdout] | [INFO] [stdout] 1020 | let func = var.get("bar_inc_pitch".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_inc_pitch"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1031:36 [INFO] [stdout] | [INFO] [stdout] 1031 | let func = var.get("score_set_duration".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"score_set_duration"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1042:36 [INFO] [stdout] | [INFO] [stdout] 1042 | let func = var.get("bar_set_duration".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"bar_set_duration"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1053:36 [INFO] [stdout] | [INFO] [stdout] 1053 | let func = var.get("track_append".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_append"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1064:36 [INFO] [stdout] | [INFO] [stdout] 1064 | let func = var.get("track_stack".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_stack"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1076:36 [INFO] [stdout] | [INFO] [stdout] 1076 | let func = var.get("track_set_volume".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_set_volume"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/tokoopa.rs:1090:36 [INFO] [stdout] | [INFO] [stdout] 1090 | let func = var.get("track_append_silence".into()).unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"track_append_silence"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1131:33 [INFO] [stdout] | [INFO] [stdout] 1131 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1131 - return load; [INFO] [stdout] 1131 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1133:33 [INFO] [stdout] | [INFO] [stdout] 1133 | ... return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1133 - return val; [INFO] [stdout] 1133 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1143:29 [INFO] [stdout] | [INFO] [stdout] 1143 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1143 - return load; [INFO] [stdout] 1143 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1152:29 [INFO] [stdout] | [INFO] [stdout] 1152 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1152 - return load; [INFO] [stdout] 1152 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1156:29 [INFO] [stdout] | [INFO] [stdout] 1156 | ... return nval; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1156 - return nval; [INFO] [stdout] 1156 + nval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1198:33 [INFO] [stdout] | [INFO] [stdout] 1198 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1198 - return load; [INFO] [stdout] 1198 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1203:33 [INFO] [stdout] | [INFO] [stdout] 1203 | ... return ptrval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1203 - return ptrval; [INFO] [stdout] 1203 + ptrval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1227:33 [INFO] [stdout] | [INFO] [stdout] 1227 | ... return load; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1227 - return load; [INFO] [stdout] 1227 + load [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1232:33 [INFO] [stdout] | [INFO] [stdout] 1232 | ... return ptrval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1232 - return ptrval; [INFO] [stdout] 1232 + ptrval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tokoopa.rs:1175:33 [INFO] [stdout] | [INFO] [stdout] 1175 | ... let newptr: Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `newptr` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1175 ~ [INFO] [stdout] 1176 ~ let newptr: Value = if fir { [INFO] [stdout] 1177 ~ data.dfg_mut().new_value().get_ptr(ptrval, expval) [INFO] [stdout] 1178 | } else { [INFO] [stdout] 1179 ~ data.dfg_mut().new_value().get_elem_ptr(ptrval, expval) [INFO] [stdout] 1180 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tokoopa.rs:1190:33 [INFO] [stdout] | [INFO] [stdout] 1190 | ... let load: Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `load` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1190 ~ [INFO] [stdout] 1191 | let zero = data.dfg_mut().new_value().integer(0); [INFO] [stdout] 1192 ~ let load: Value = if exps.len() as i32 == dim { [INFO] [stdout] 1193 ~ data.dfg_mut().new_value().load(ptrval) [INFO] [stdout] 1194 | } else { [INFO] [stdout] 1195 ~ data.dfg_mut().new_value().get_elem_ptr(ptrval, zero) [INFO] [stdout] 1196 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/tokoopa.rs:1219:33 [INFO] [stdout] | [INFO] [stdout] 1219 | ... let load: Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `load` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1219 ~ [INFO] [stdout] 1220 | let zero = data.dfg_mut().new_value().integer(0); [INFO] [stdout] 1221 ~ let load: Value = if exps.len() as i32 == dim { [INFO] [stdout] 1222 ~ data.dfg_mut().new_value().load(ptrval) [INFO] [stdout] 1223 | } else { [INFO] [stdout] 1224 ~ data.dfg_mut().new_value().get_elem_ptr(ptrval, zero) [INFO] [stdout] 1225 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/tokoopa.rs:1262:17 [INFO] [stdout] | [INFO] [stdout] 1261 | let val = lval.gen_ir(data, entry, var, true); [INFO] [stdout] | ---------------------------------------------- unnecessary `let` binding [INFO] [stdout] 1262 | val [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 1261 ~ [INFO] [stdout] 1262 ~ lval.gen_ir(data, entry, var, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1580:17 [INFO] [stdout] | [INFO] [stdout] 1580 | return getres; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1580 - return getres; [INFO] [stdout] 1580 + getres [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tokoopa.rs:1646:17 [INFO] [stdout] | [INFO] [stdout] 1646 | return getres; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1646 - return getres; [INFO] [stdout] 1646 + getres [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | return call; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return call; [INFO] [stdout] 20 + call [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Function` which implements the `Copy` trait [INFO] [stdout] --> src/gen_music.rs:18:56 [INFO] [stdout] | [INFO] [stdout] 18 | let call = data.dfg_mut().new_value().call(func.clone(), args); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return it; [INFO] [stdout] 40 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return it; [INFO] [stdout] 45 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/gen_music.rs:43:58 [INFO] [stdout] | [INFO] [stdout] 43 | let num = data.dfg_mut().new_value().integer(num.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/gen_music.rs:73:58 [INFO] [stdout] | [INFO] [stdout] 73 | let num = data.dfg_mut().new_value().integer(num.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return it; [INFO] [stdout] 96 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gen_music.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | return it; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return it; [INFO] [stdout] 112 + it [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.77s [INFO] running `Command { std: "docker" "inspect" "a751fc919469ffe84e0b5c64d6fc01fef5d11265ccc25b3bec300450148f177e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a751fc919469ffe84e0b5c64d6fc01fef5d11265ccc25b3bec300450148f177e", kill_on_drop: false }` [INFO] [stdout] a751fc919469ffe84e0b5c64d6fc01fef5d11265ccc25b3bec300450148f177e