[INFO] cloning repository https://github.com/Pyrodash/jmath [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Pyrodash/jmath" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPyrodash%2Fjmath", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPyrodash%2Fjmath'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 092248801590c3f91d5eb65bd41832410a71d200 [INFO] linting Pyrodash/jmath against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPyrodash%2Fjmath" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Pyrodash/jmath [INFO] finished tweaking git repo https://github.com/Pyrodash/jmath [INFO] tweaked toml for git repo https://github.com/Pyrodash/jmath written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Pyrodash/jmath on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Pyrodash/jmath already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror-impl v1.0.32 [INFO] [stderr] Downloaded utf8parse v0.2.0 [INFO] [stderr] Downloaded unicode-ident v1.0.3 [INFO] [stderr] Downloaded clipboard-win v4.4.2 [INFO] [stderr] Downloaded fd-lock v3.0.6 [INFO] [stderr] Downloaded thiserror v1.0.32 [INFO] [stderr] Downloaded rustyline v10.0.0 [INFO] [stderr] Downloaded rustix v0.35.9 [INFO] [stderr] Downloaded nix v0.24.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0f7d86da3555f2355d0ed400466572d88268bca179e3e59e4ba27dc17871942 [INFO] running `Command { std: "docker" "start" "-a" "b0f7d86da3555f2355d0ed400466572d88268bca179e3e59e4ba27dc17871942", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0f7d86da3555f2355d0ed400466572d88268bca179e3e59e4ba27dc17871942", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0f7d86da3555f2355d0ed400466572d88268bca179e3e59e4ba27dc17871942", kill_on_drop: false }` [INFO] [stdout] b0f7d86da3555f2355d0ed400466572d88268bca179e3e59e4ba27dc17871942 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a3de32ac8c9fe90146e07a495d17f83eafd922783f286430bea856596aac736 [INFO] running `Command { std: "docker" "start" "-a" "3a3de32ac8c9fe90146e07a495d17f83eafd922783f286430bea856596aac736", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling io-lifetimes v0.7.3 [INFO] [stderr] Compiling rustix v0.35.9 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking fd-lock v3.0.6 [INFO] [stderr] Checking rustyline v10.0.0 [INFO] [stderr] Checking jmath v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/ast.rs:83:48 [INFO] [stdout] | [INFO] [stdout] 83 | Node::Function { name, parameters, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/interpreter.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 0..cols { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/ast.rs:83:48 [INFO] [stdout] | [INFO] [stdout] 83 | Node::Function { name, parameters, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:169:33 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `kind` [INFO] [stdout] --> src/interpreter.rs:169:39 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `kind: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parameters` [INFO] [stdout] --> src/interpreter.rs:170:36 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `parameters: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/interpreter.rs:170:48 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return &self.kind [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return &self.kind [INFO] [stdout] 36 + &self.kind [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return &self.value [INFO] [stdout] 40 + &self.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `self.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 105 | nodes.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `param` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:160:29 [INFO] [stdout] | [INFO] [stdout] 157 | if param.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = param` [INFO] [stdout] ... [INFO] [stdout] 160 | params.push(param.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:186:27 [INFO] [stdout] | [INFO] [stdout] 183 | if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 186 | match token.unwrap().kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/parser.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | / match token.unwrap().kind() { [INFO] [stdout] 187 | | &TokenKind::Assign => { [INFO] [stdout] 188 | | self.parse_assignment(name) [INFO] [stdout] 189 | | }, [INFO] [stdout] ... | [INFO] [stdout] 193 | | _ => Ok(Node::Variable(name)), [INFO] [stdout] 194 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 186 ~ match *token.unwrap().kind() { [INFO] [stdout] 187 ~ TokenKind::Assign => { [INFO] [stdout] 188 | self.parse_assignment(name) [INFO] [stdout] 189 | }, [INFO] [stdout] 190 ~ TokenKind::LeftParen => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/interpreter.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 0..cols { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 224 | if node.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = node` [INFO] [stdout] ... [INFO] [stdout] 227 | nodes.push(node.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 233 | if token.unwrap().kind() != &TokenKind::Separator { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:269:76 [INFO] [stdout] | [INFO] [stdout] 269 | &TokenKind::Add | &TokenKind::Sub => self.parse_unary_op().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:272:67 [INFO] [stdout] | [INFO] [stdout] 272 | &TokenKind::Identifier => self.parse_identifier().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:273:66 [INFO] [stdout] | [INFO] [stdout] 273 | &TokenKind::LeftParen => self.parse_paren_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:274:67 [INFO] [stdout] | [INFO] [stdout] 274 | &TokenKind::ArrayStart => self.parse_array_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 282 | let token_prec: usize = if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 285 | token.unwrap().precedence() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:304:41 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 304 | let next_prec = token.unwrap().precedence(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:169:33 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `kind` [INFO] [stdout] --> src/interpreter.rs:169:39 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `kind: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:329:53 [INFO] [stdout] | [INFO] [stdout] 329 | self.parse_expr_right(1, left.unwrap()).map(|node| Option::from(node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parameters` [INFO] [stdout] --> src/interpreter.rs:170:36 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `parameters: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/interpreter.rs:170:48 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:338:16 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:339:26 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 339 | vec.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SymbolTable<'a>` [INFO] [stdout] --> src/symbol.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> SymbolTable<'a> { [INFO] [stdout] 19 | | let mut table = SymbolTable { members: HashMap::new() }; [INFO] [stdout] 20 | | [INFO] [stdout] 21 | | table.define(Number); [INFO] [stdout] ... | [INFO] [stdout] 25 | | table [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl<'a> Default for SymbolTable<'a> { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/symbol.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | let symName: &'a str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `symName` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 29 ~ [INFO] [stdout] 30 | [INFO] [stdout] 31 ~ let symName: &'a str = match symbol { [INFO] [stdout] 32 ~ Symbol::Native { name } => name, [INFO] [stdout] 33 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return &self.kind [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return &self.kind [INFO] [stdout] 36 + &self.kind [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return &self.value [INFO] [stdout] 40 + &self.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `self.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:108:47 [INFO] [stdout] | [INFO] [stdout] 108 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 108 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] 108 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x + y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:197:47 [INFO] [stdout] | [INFO] [stdout] 197 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 197 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] 197 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x - y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:311:21 [INFO] [stdout] | [INFO] [stdout] 311 | return Value::Array(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return Value::Array(res); [INFO] [stdout] 311 + Value::Array(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:275:30 [INFO] [stdout] | [INFO] [stdout] 275 | let c1 = lhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `lhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] = note: `#[warn(clippy::iter_next_slice)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 276 | let c2 = rhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `rhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ActivationRecord` [INFO] [stdout] --> src/memory.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | / pub fn new() -> ActivationRecord { [INFO] [stdout] 422 | | ActivationRecord { [INFO] [stdout] 423 | | members: HashMap::new() [INFO] [stdout] 424 | | } [INFO] [stdout] 425 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 420 + impl Default for ActivationRecord { [INFO] [stdout] 421 + fn default() -> Self { [INFO] [stdout] 422 + Self::new() [INFO] [stdout] 423 + } [INFO] [stdout] 424 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | return self.members.get(key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return self.members.get(key) [INFO] [stdout] 428 + self.members.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CallStack` [INFO] [stdout] --> src/memory.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | / pub fn new() -> CallStack { [INFO] [stdout] 443 | | CallStack { [INFO] [stdout] 444 | | records: Vec::new(), [INFO] [stdout] 445 | | } [INFO] [stdout] 446 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 441 + impl Default for CallStack { [INFO] [stdout] 442 + fn default() -> Self { [INFO] [stdout] 443 + Self::new() [INFO] [stdout] 444 + } [INFO] [stdout] 445 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CallStack` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/memory.rs:472:5 [INFO] [stdout] | [INFO] [stdout] 472 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 105 | nodes.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `mat` [INFO] [stdout] --> src/interpreter.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..rows { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..rows { [INFO] [stdout] 34 + for (i, ) in mat.iter().enumerate().take(rows) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return ar; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ar; [INFO] [stdout] 53 + ar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `param` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:160:29 [INFO] [stdout] | [INFO] [stdout] 157 | if param.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = param` [INFO] [stdout] ... [INFO] [stdout] 160 | params.push(param.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Interpreter` [INFO] [stdout] --> src/interpreter.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | / pub fn new() -> Interpreter { [INFO] [stdout] 68 | | Interpreter { [INFO] [stdout] 69 | | stack: CallStack::from_record( [INFO] [stdout] 70 | | ActivationRecord::with_natives() [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 66 + impl Default for Interpreter { [INFO] [stdout] 67 + fn default() -> Self { [INFO] [stdout] 68 + Self::new() [INFO] [stdout] 69 + } [INFO] [stdout] 70 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:186:27 [INFO] [stdout] | [INFO] [stdout] 183 | if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 186 | match token.unwrap().kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:95:53 [INFO] [stdout] | [INFO] [stdout] 95 | Node::Number(value) => Ok(Value::Number(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:96:55 [INFO] [stdout] | [INFO] [stdout] 96 | Node::Decimal(value) => Ok(Value::Decimal(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/parser.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | / match token.unwrap().kind() { [INFO] [stdout] 187 | | &TokenKind::Assign => { [INFO] [stdout] 188 | | self.parse_assignment(name) [INFO] [stdout] 189 | | }, [INFO] [stdout] ... | [INFO] [stdout] 193 | | _ => Ok(Node::Variable(name)), [INFO] [stdout] 194 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 186 ~ match *token.unwrap().kind() { [INFO] [stdout] 187 ~ TokenKind::Assign => { [INFO] [stdout] 188 | self.parse_assignment(name) [INFO] [stdout] 189 | }, [INFO] [stdout] 190 ~ TokenKind::LeftParen => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 224 | if node.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = node` [INFO] [stdout] ... [INFO] [stdout] 227 | nodes.push(node.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 233 | if token.unwrap().kind() != &TokenKind::Separator { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:269:76 [INFO] [stdout] | [INFO] [stdout] 269 | &TokenKind::Add | &TokenKind::Sub => self.parse_unary_op().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:272:67 [INFO] [stdout] | [INFO] [stdout] 272 | &TokenKind::Identifier => self.parse_identifier().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:273:66 [INFO] [stdout] | [INFO] [stdout] 273 | &TokenKind::LeftParen => self.parse_paren_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/parser.rs:356:46 [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser { [INFO] [stdout] | -- -- ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `Number` should have an upper case name [INFO] [stdout] --> src/symbol.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub const Number: Symbol = Symbol::Native { name: "Number" }; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `NUMBER` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:274:67 [INFO] [stdout] | [INFO] [stdout] 274 | &TokenKind::ArrayStart => self.parse_array_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `Decimal` should have an upper case name [INFO] [stdout] --> src/symbol.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub const Decimal: Symbol = Symbol::Native { name: "Decimal" }; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `DECIMAL` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `Array` should have an upper case name [INFO] [stdout] --> src/symbol.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | pub const Array: Symbol = Symbol::Native { name: "Array" }; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `ARRAY` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `symName` should have a snake case name [INFO] [stdout] --> src/symbol.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | let symName: &'a str; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `sym_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 282 | let token_prec: usize = if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 285 | token.unwrap().precedence() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:304:41 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 304 | let next_prec = token.unwrap().precedence(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:329:53 [INFO] [stdout] | [INFO] [stdout] 329 | self.parse_expr_right(1, left.unwrap()).map(|node| Option::from(node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:338:16 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:339:26 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 339 | vec.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SymbolTable<'a>` [INFO] [stdout] --> src/symbol.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> SymbolTable<'a> { [INFO] [stdout] 19 | | let mut table = SymbolTable { members: HashMap::new() }; [INFO] [stdout] 20 | | [INFO] [stdout] 21 | | table.define(Number); [INFO] [stdout] ... | [INFO] [stdout] 25 | | table [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl<'a> Default for SymbolTable<'a> { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/symbol.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | let symName: &'a str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `symName` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 29 ~ [INFO] [stdout] 30 | [INFO] [stdout] 31 ~ let symName: &'a str = match symbol { [INFO] [stdout] 32 ~ Symbol::Native { name } => name, [INFO] [stdout] 33 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:108:47 [INFO] [stdout] | [INFO] [stdout] 108 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 108 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] 108 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x + y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:197:47 [INFO] [stdout] | [INFO] [stdout] 197 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 197 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] 197 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x - y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:311:21 [INFO] [stdout] | [INFO] [stdout] 311 | return Value::Array(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return Value::Array(res); [INFO] [stdout] 311 + Value::Array(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:275:30 [INFO] [stdout] | [INFO] [stdout] 275 | let c1 = lhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `lhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] = note: `#[warn(clippy::iter_next_slice)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 276 | let c2 = rhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `rhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ActivationRecord` [INFO] [stdout] --> src/memory.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | / pub fn new() -> ActivationRecord { [INFO] [stdout] 422 | | ActivationRecord { [INFO] [stdout] 423 | | members: HashMap::new() [INFO] [stdout] 424 | | } [INFO] [stdout] 425 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 420 + impl Default for ActivationRecord { [INFO] [stdout] 421 + fn default() -> Self { [INFO] [stdout] 422 + Self::new() [INFO] [stdout] 423 + } [INFO] [stdout] 424 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | return self.members.get(key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return self.members.get(key) [INFO] [stdout] 428 + self.members.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CallStack` [INFO] [stdout] --> src/memory.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | / pub fn new() -> CallStack { [INFO] [stdout] 443 | | CallStack { [INFO] [stdout] 444 | | records: Vec::new(), [INFO] [stdout] 445 | | } [INFO] [stdout] 446 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 441 + impl Default for CallStack { [INFO] [stdout] 442 + fn default() -> Self { [INFO] [stdout] 443 + Self::new() [INFO] [stdout] 444 + } [INFO] [stdout] 445 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CallStack` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/memory.rs:472:5 [INFO] [stdout] | [INFO] [stdout] 472 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `mat` [INFO] [stdout] --> src/interpreter.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..rows { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..rows { [INFO] [stdout] 34 + for (i, ) in mat.iter().enumerate().take(rows) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return ar; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ar; [INFO] [stdout] 53 + ar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Interpreter` [INFO] [stdout] --> src/interpreter.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | / pub fn new() -> Interpreter { [INFO] [stdout] 68 | | Interpreter { [INFO] [stdout] 69 | | stack: CallStack::from_record( [INFO] [stdout] 70 | | ActivationRecord::with_natives() [INFO] [stdout] ... | [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 66 + impl Default for Interpreter { [INFO] [stdout] 67 + fn default() -> Self { [INFO] [stdout] 68 + Self::new() [INFO] [stdout] 69 + } [INFO] [stdout] 70 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:95:53 [INFO] [stdout] | [INFO] [stdout] 95 | Node::Number(value) => Ok(Value::Number(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:96:55 [INFO] [stdout] | [INFO] [stdout] 96 | Node::Decimal(value) => Ok(Value::Decimal(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/parser.rs:356:46 [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser { [INFO] [stdout] | -- -- ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `Number` should have an upper case name [INFO] [stdout] --> src/symbol.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub const Number: Symbol = Symbol::Native { name: "Number" }; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `NUMBER` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `Decimal` should have an upper case name [INFO] [stdout] --> src/symbol.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub const Decimal: Symbol = Symbol::Native { name: "Decimal" }; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper case: `DECIMAL` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `Array` should have an upper case name [INFO] [stdout] --> src/symbol.rs:11:11 [INFO] [stdout] | [INFO] [stdout] 11 | pub const Array: Symbol = Symbol::Native { name: "Array" }; [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `ARRAY` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `symName` should have a snake case name [INFO] [stdout] --> src/symbol.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | let symName: &'a str; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `sym_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/ast.rs:83:48 [INFO] [stdout] | [INFO] [stdout] 83 | Node::Function { name, parameters, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/interpreter.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 0..cols { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:169:33 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `kind` [INFO] [stdout] --> src/interpreter.rs:169:39 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `kind: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parameters` [INFO] [stdout] --> src/interpreter.rs:170:36 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `parameters: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/interpreter.rs:170:48 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | pub struct Block<'a>(pub Vec>); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Block` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `powi` is never used [INFO] [stdout] --> src/memory.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 379 | impl Value { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 380 | pub fn powi(self, rhs: i32) -> Value { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `pop` and `len` are never used [INFO] [stdout] --> src/memory.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 441 | impl CallStack { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 468 | pub fn pop(&mut self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 472 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `from_record` and `from_stack` are never used [INFO] [stdout] --> src/interpreter.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl Interpreter { [INFO] [stdout] | ---------------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 75 | pub fn from_record(record: ActivationRecord) -> Interpreter { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn from_stack(stack: CallStack) -> Interpreter { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return &self.kind [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return &self.kind [INFO] [stdout] 36 + &self.kind [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return &self.value [INFO] [stdout] 40 + &self.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `self.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/ast.rs:83:48 [INFO] [stdout] | [INFO] [stdout] 83 | Node::Function { name, parameters, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 105 | nodes.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `param` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:160:29 [INFO] [stdout] | [INFO] [stdout] 157 | if param.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = param` [INFO] [stdout] ... [INFO] [stdout] 160 | params.push(param.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:186:27 [INFO] [stdout] | [INFO] [stdout] 183 | if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 186 | match token.unwrap().kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/parser.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | / match token.unwrap().kind() { [INFO] [stdout] 187 | | &TokenKind::Assign => { [INFO] [stdout] 188 | | self.parse_assignment(name) [INFO] [stdout] 189 | | }, [INFO] [stdout] ... | [INFO] [stdout] 193 | | _ => Ok(Node::Variable(name)), [INFO] [stdout] 194 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 186 ~ match *token.unwrap().kind() { [INFO] [stdout] 187 ~ TokenKind::Assign => { [INFO] [stdout] 188 | self.parse_assignment(name) [INFO] [stdout] 189 | }, [INFO] [stdout] 190 ~ TokenKind::LeftParen => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 224 | if node.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = node` [INFO] [stdout] ... [INFO] [stdout] 227 | nodes.push(node.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 233 | if token.unwrap().kind() != &TokenKind::Separator { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:269:76 [INFO] [stdout] | [INFO] [stdout] 269 | &TokenKind::Add | &TokenKind::Sub => self.parse_unary_op().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:272:67 [INFO] [stdout] | [INFO] [stdout] 272 | &TokenKind::Identifier => self.parse_identifier().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:273:66 [INFO] [stdout] | [INFO] [stdout] 273 | &TokenKind::LeftParen => self.parse_paren_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:274:67 [INFO] [stdout] | [INFO] [stdout] 274 | &TokenKind::ArrayStart => self.parse_array_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 282 | let token_prec: usize = if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 285 | token.unwrap().precedence() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:304:41 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 304 | let next_prec = token.unwrap().precedence(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:329:53 [INFO] [stdout] | [INFO] [stdout] 329 | self.parse_expr_right(1, left.unwrap()).map(|node| Option::from(node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:338:16 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:339:26 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 339 | vec.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/interpreter.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | for i in 0..cols { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:108:47 [INFO] [stdout] | [INFO] [stdout] 108 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 108 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] 108 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x + y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:169:33 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `kind` [INFO] [stdout] --> src/interpreter.rs:169:39 [INFO] [stdout] | [INFO] [stdout] 169 | Node::Declaration { name, kind } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `kind: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/interpreter.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `parameters` [INFO] [stdout] --> src/interpreter.rs:170:36 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `parameters: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/interpreter.rs:170:48 [INFO] [stdout] | [INFO] [stdout] 170 | Node::Function { name, parameters, body } => todo!("Unimplemented"), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:197:47 [INFO] [stdout] | [INFO] [stdout] 197 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 197 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] 197 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x - y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:311:21 [INFO] [stdout] | [INFO] [stdout] 311 | return Value::Array(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return Value::Array(res); [INFO] [stdout] 311 + Value::Array(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:275:30 [INFO] [stdout] | [INFO] [stdout] 275 | let c1 = lhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `lhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] = note: `#[warn(clippy::iter_next_slice)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 276 | let c2 = rhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `rhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/ast.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | pub struct Block<'a>(pub Vec>); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Block` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `powi` is never used [INFO] [stdout] --> src/memory.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 379 | impl Value { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 380 | pub fn powi(self, rhs: i32) -> Value { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `pop` and `len` are never used [INFO] [stdout] --> src/memory.rs:468:12 [INFO] [stdout] | [INFO] [stdout] 441 | impl CallStack { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 468 | pub fn pop(&mut self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 472 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `from_record` and `from_stack` are never used [INFO] [stdout] --> src/interpreter.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl Interpreter { [INFO] [stdout] | ---------------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 75 | pub fn from_record(record: ActivationRecord) -> Interpreter { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | pub fn from_stack(stack: CallStack) -> Interpreter { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | return self.members.get(key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return self.members.get(key) [INFO] [stdout] 428 + self.members.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return &self.kind [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return &self.kind [INFO] [stdout] 36 + &self.kind [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return &self.value [INFO] [stdout] 40 + &self.value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | return &self.value [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `self.value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `mat` [INFO] [stdout] --> src/interpreter.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..rows { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..rows { [INFO] [stdout] 34 + for (i, ) in mat.iter().enumerate().take(rows) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return ar; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ar; [INFO] [stdout] 53 + ar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:95:53 [INFO] [stdout] | [INFO] [stdout] 95 | Node::Number(value) => Ok(Value::Number(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:96:55 [INFO] [stdout] | [INFO] [stdout] 96 | Node::Decimal(value) => Ok(Value::Decimal(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:34:20 [INFO] [stdout] | [INFO] [stdout] 34 | if nodes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: recursing into entrypoint `main` [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | main(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using another function for this recursion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#main_recursion [INFO] [stdout] = note: `#[warn(clippy::main_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/parser.rs:356:46 [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser { [INFO] [stdout] | -- -- ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 104 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 105 | nodes.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `param` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:160:29 [INFO] [stdout] | [INFO] [stdout] 157 | if param.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = param` [INFO] [stdout] ... [INFO] [stdout] 160 | params.push(param.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:186:27 [INFO] [stdout] | [INFO] [stdout] 183 | if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 186 | match token.unwrap().kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/parser.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | / match token.unwrap().kind() { [INFO] [stdout] 187 | | &TokenKind::Assign => { [INFO] [stdout] 188 | | self.parse_assignment(name) [INFO] [stdout] 189 | | }, [INFO] [stdout] ... | [INFO] [stdout] 193 | | _ => Ok(Node::Variable(name)), [INFO] [stdout] 194 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 186 ~ match *token.unwrap().kind() { [INFO] [stdout] 187 ~ TokenKind::Assign => { [INFO] [stdout] 188 | self.parse_assignment(name) [INFO] [stdout] 189 | }, [INFO] [stdout] 190 ~ TokenKind::LeftParen => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:227:28 [INFO] [stdout] | [INFO] [stdout] 224 | if node.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = node` [INFO] [stdout] ... [INFO] [stdout] 227 | nodes.push(node.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:233:20 [INFO] [stdout] | [INFO] [stdout] 232 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 233 | if token.unwrap().kind() != &TokenKind::Separator { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:269:76 [INFO] [stdout] | [INFO] [stdout] 269 | &TokenKind::Add | &TokenKind::Sub => self.parse_unary_op().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:272:67 [INFO] [stdout] | [INFO] [stdout] 272 | &TokenKind::Identifier => self.parse_identifier().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:273:66 [INFO] [stdout] | [INFO] [stdout] 273 | &TokenKind::LeftParen => self.parse_paren_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:274:67 [INFO] [stdout] | [INFO] [stdout] 274 | &TokenKind::ArrayStart => self.parse_array_expr().map(|node| Option::from(node)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:303:24 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 282 | let token_prec: usize = if token.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = token` [INFO] [stdout] ... [INFO] [stdout] 285 | token.unwrap().precedence() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:304:41 [INFO] [stdout] | [INFO] [stdout] 303 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 304 | let next_prec = token.unwrap().precedence(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:329:53 [INFO] [stdout] | [INFO] [stdout] 329 | self.parse_expr_right(1, left.unwrap()).map(|node| Option::from(node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Option::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:338:16 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expr.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `expr` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:339:26 [INFO] [stdout] | [INFO] [stdout] 338 | if !expr.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 339 | vec.push(expr.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:108:47 [INFO] [stdout] | [INFO] [stdout] 108 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 108 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x + y).collect(); [INFO] [stdout] 108 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x + y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/memory.rs:197:47 [INFO] [stdout] | [INFO] [stdout] 197 | let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 197 - let arr = rhs.into_iter().zip(lhs.into_iter()).map(|(x, y)| x - y).collect(); [INFO] [stdout] 197 + let arr = rhs.into_iter().zip(lhs).map(|(x, y)| x - y).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:311:21 [INFO] [stdout] | [INFO] [stdout] 311 | return Value::Array(res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return Value::Array(res); [INFO] [stdout] 311 + Value::Array(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:275:30 [INFO] [stdout] | [INFO] [stdout] 275 | let c1 = lhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `lhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] = note: `#[warn(clippy::iter_next_slice)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.iter().next()` on an array [INFO] [stdout] --> src/memory.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 276 | let c2 = rhs.iter().next().unwrap().as_array().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try calling: `rhs.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_next_slice [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | return self.members.get(key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - return self.members.get(key) [INFO] [stdout] 428 + self.members.get(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `mat` [INFO] [stdout] --> src/interpreter.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..rows { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..rows { [INFO] [stdout] 34 + for (i, ) in mat.iter().enumerate().take(rows) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return ar; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ar; [INFO] [stdout] 53 + ar [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:95:53 [INFO] [stdout] | [INFO] [stdout] 95 | Node::Number(value) => Ok(Value::Number(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/interpreter.rs:96:55 [INFO] [stdout] | [INFO] [stdout] 96 | Node::Decimal(value) => Ok(Value::Decimal(value.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:34:20 [INFO] [stdout] | [INFO] [stdout] 34 | if nodes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nodes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/parser.rs:356:46 [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser { [INFO] [stdout] | -- -- ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 356 | pub fn new(source: &'a mut Lexer<'a>) -> Parser<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.34s [INFO] running `Command { std: "docker" "inspect" "3a3de32ac8c9fe90146e07a495d17f83eafd922783f286430bea856596aac736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a3de32ac8c9fe90146e07a495d17f83eafd922783f286430bea856596aac736", kill_on_drop: false }` [INFO] [stdout] 3a3de32ac8c9fe90146e07a495d17f83eafd922783f286430bea856596aac736