[INFO] cloning repository https://github.com/ProfMYK/animation-library [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ProfMYK/animation-library" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProfMYK%2Fanimation-library", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProfMYK%2Fanimation-library'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 173766e6276c8d0de439f0297ef74cbf5986e5b1 [INFO] linting ProfMYK/animation-library against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProfMYK%2Fanimation-library" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ProfMYK/animation-library [INFO] finished tweaking git repo https://github.com/ProfMYK/animation-library [INFO] tweaked toml for git repo https://github.com/ProfMYK/animation-library written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ProfMYK/animation-library on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ProfMYK/animation-library already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded chlorine v1.0.13 [INFO] [stderr] Downloaded raylib v5.5.1 [INFO] [stderr] Downloaded raylib_imgui_rs v0.5.0 [INFO] [stderr] Downloaded imgui v0.12.0 [INFO] [stderr] Downloaded imgui-sys v0.12.0 [INFO] [stderr] Downloaded raylib-sys v5.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3288ccd984951f0ebd043494327e6075a3a1ebf090730b54f01efe4f95cf476 [INFO] running `Command { std: "docker" "start" "-a" "b3288ccd984951f0ebd043494327e6075a3a1ebf090730b54f01efe4f95cf476", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3288ccd984951f0ebd043494327e6075a3a1ebf090730b54f01efe4f95cf476", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3288ccd984951f0ebd043494327e6075a3a1ebf090730b54f01efe4f95cf476", kill_on_drop: false }` [INFO] [stdout] b3288ccd984951f0ebd043494327e6075a3a1ebf090730b54f01efe4f95cf476 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e234d77e11da1a07bceef50774ed1fdba5751f653096ab455a993df352cc58be [INFO] running `Command { std: "docker" "start" "-a" "e234d77e11da1a07bceef50774ed1fdba5751f653096ab455a993df352cc58be", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling libloading v0.8.9 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking chlorine v1.0.13 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling cc v1.2.43 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling imgui-sys v0.12.0 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking imgui v0.12.0 [INFO] [stderr] Compiling raylib-sys v5.5.1 [INFO] [stderr] Checking raylib v5.5.1 [INFO] [stderr] Checking raylib_imgui_rs v0.5.0 [INFO] [stderr] Checking animation_library v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/objects/group.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | Group { objects: objects } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/objects/group.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | Group { objects: objects } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/objects/text.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn font(mut self, font_name: &str, rl: &mut RaylibHandle, thread: &RaylibThread) -> Self { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thread` [INFO] [stdout] --> src/objects/text.rs:42:67 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn font(mut self, font_name: &str, rl: &mut RaylibHandle, thread: &RaylibThread) -> Self { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `font_data` [INFO] [stdout] --> src/objects/text.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let font_data = rl.load_font_data(&font_file_data, 64, None, 1).expect("Failed to load font data"); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_font_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sdf_font` [INFO] [stdout] --> src/objects/text.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | let sdf_font: Font = unsafe { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sdf_font` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/objects/circle.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / pub fn new() -> CircleBuilder { [INFO] [stdout] 47 | | CircleBuilder { [INFO] [stdout] 48 | | radius: SCALE / 2.0, position: rvec2(0.0, 0.0), [INFO] [stdout] 49 | | thickness: 3.0, color: Color::LIGHTBLUE, styles: HashSet::new()} [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/objects/text.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / pub fn new(content: &str) -> TextBuilder { [INFO] [stdout] 69 | | TextBuilder { [INFO] [stdout] 70 | | content: content.to_string(), font_size: 30.0, [INFO] [stdout] 71 | | position: rvec2(0.0, 0.0), color: Color::WHITE, font: None, [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/objects/text.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.font.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.font.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.font` after checking its variant with `is_none` [INFO] [stdout] --> src/objects/text.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.font.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 81 | let font = self.font.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/objects/square.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / pub fn new() -> SquareBuilder { [INFO] [stdout] 47 | | SquareBuilder { [INFO] [stdout] 48 | | side: SCALE, position: rvec2(0.0, 0.0), [INFO] [stdout] 49 | | thickness: 2.0, color: Color::LIGHTBLUE, styles: HashSet::new() [INFO] [stdout] 50 | | } [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/objects/text.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn font(mut self, font_name: &str, rl: &mut RaylibHandle, thread: &RaylibThread) -> Self { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `thread` [INFO] [stdout] --> src/objects/text.rs:42:67 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn font(mut self, font_name: &str, rl: &mut RaylibHandle, thread: &RaylibThread) -> Self { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `font_data` [INFO] [stdout] --> src/objects/text.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let font_data = rl.load_font_data(&font_file_data, 64, None, 1).expect("Failed to load font data"); [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_font_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sdf_font` [INFO] [stdout] --> src/objects/text.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | let sdf_font: Font = unsafe { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sdf_font` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/objects/circle.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / pub fn new() -> CircleBuilder { [INFO] [stdout] 47 | | CircleBuilder { [INFO] [stdout] 48 | | radius: SCALE / 2.0, position: rvec2(0.0, 0.0), [INFO] [stdout] 49 | | thickness: 3.0, color: Color::LIGHTBLUE, styles: HashSet::new()} [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/objects/text.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / pub fn new(content: &str) -> TextBuilder { [INFO] [stdout] 69 | | TextBuilder { [INFO] [stdout] 70 | | content: content.to_string(), font_size: 30.0, [INFO] [stdout] 71 | | position: rvec2(0.0, 0.0), color: Color::WHITE, font: None, [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/objects/text.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.font.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.font.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.font` after checking its variant with `is_none` [INFO] [stdout] --> src/objects/text.rs:81:24 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.font.is_none() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] 81 | let font = self.font.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/objects/square.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / pub fn new() -> SquareBuilder { [INFO] [stdout] 47 | | SquareBuilder { [INFO] [stdout] 48 | | side: SCALE, position: rvec2(0.0, 0.0), [INFO] [stdout] 49 | | thickness: 2.0, color: Color::LIGHTBLUE, styles: HashSet::new() [INFO] [stdout] 50 | | } [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 45.64s [INFO] running `Command { std: "docker" "inspect" "e234d77e11da1a07bceef50774ed1fdba5751f653096ab455a993df352cc58be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e234d77e11da1a07bceef50774ed1fdba5751f653096ab455a993df352cc58be", kill_on_drop: false }` [INFO] [stdout] e234d77e11da1a07bceef50774ed1fdba5751f653096ab455a993df352cc58be