[INFO] cloning repository https://github.com/PolyLinear/advent2021 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PolyLinear/advent2021" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPolyLinear%2Fadvent2021", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPolyLinear%2Fadvent2021'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2e62217c203093c61a0abbf56df906c7394768c2 [INFO] linting PolyLinear/advent2021 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPolyLinear%2Fadvent2021" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PolyLinear/advent2021 [INFO] finished tweaking git repo https://github.com/PolyLinear/advent2021 [INFO] tweaked toml for git repo https://github.com/PolyLinear/advent2021 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PolyLinear/advent2021 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PolyLinear/advent2021 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 546fbabd99a1ebc757cce5315c6418c4d90503e7d405d8b55e5453ae9dea4350 [INFO] running `Command { std: "docker" "start" "-a" "546fbabd99a1ebc757cce5315c6418c4d90503e7d405d8b55e5453ae9dea4350", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "546fbabd99a1ebc757cce5315c6418c4d90503e7d405d8b55e5453ae9dea4350", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "546fbabd99a1ebc757cce5315c6418c4d90503e7d405d8b55e5453ae9dea4350", kill_on_drop: false }` [INFO] [stdout] 546fbabd99a1ebc757cce5315c6418c4d90503e7d405d8b55e5453ae9dea4350 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff486fd03a14d7f6fea96329c71236ab2349f6b065d498bb75261d323ab0c321 [INFO] running `Command { std: "docker" "start" "-a" "ff486fd03a14d7f6fea96329c71236ab2349f6b065d498bb75261d323ab0c321", kill_on_drop: false }` [INFO] [stderr] Checking advent2021 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/day1.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / #[cfg(test)] [INFO] [stdout] 5 | | [INFO] [stdout] | |_^ [INFO] [stdout] 6 | fn parse_input(path: &str) -> Result, Box> { [INFO] [stdout] | -------------- the attribute applies to this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day10.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / (top == b'{' && b == b'}') [INFO] [stdout] 15 | | || (top == b'(' && b == b')') [INFO] [stdout] 16 | | || (top == b'<' && b == b'>') [INFO] [stdout] 17 | | || (top == b'{' && b == b'}') [INFO] [stdout] | |_____________________________________^ help: try: `top == b'{' && b == b'}' || top == b'(' && b == b')' || top == b'<' && b == b'>'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/day11.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | let (row, col) = stack.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 28 ~ while let Some((row, col)) = stack.pop() { [INFO] [stdout] 29 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day11.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Some(val) = data.get_mut(row_i).and_then(|r| r.get_mut(col_i)) { [INFO] [stdout] 38 | | if *val != b'0' { [INFO] [stdout] 39 | | *val += 1; [INFO] [stdout] 40 | | stack.push((row_i, col_i)); [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Some(val) = data.get_mut(row_i).and_then(|r| r.get_mut(col_i)) [INFO] [stdout] 38 ~ && *val != b'0' { [INFO] [stdout] 39 | *val += 1; [INFO] [stdout] 40 | stack.push((row_i, col_i)); [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day10.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / (top == b'{' && b == b'}') [INFO] [stdout] 15 | | || (top == b'(' && b == b')') [INFO] [stdout] 16 | | || (top == b'<' && b == b'>') [INFO] [stdout] 17 | | || (top == b'{' && b == b'}') [INFO] [stdout] | |_____________________________________^ help: try: `top == b'{' && b == b'}' || top == b'(' && b == b')' || top == b'<' && b == b'>'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Map, {closure@src/day5.rs:16:59: 16:67}>` [INFO] [stdout] --> src/day5.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 16 | return Box::new((y1.min(y2)..=y1.max(y2)).map(move |y| (x1, y)).into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(y1.min(y2)..=y1.max(y2)).map(move |y| (x1, y))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Map, {closure@src/day5.rs:18:48: 18:56}>` [INFO] [stdout] --> src/day5.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | Box::new((x1.min(x2)..=x1.max(x2)).map(move |x| (x, y1)).into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(x1.min(x2)..=x1.max(x2)).map(move |x| (x, y1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day6.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | data.into_iter().fold(0, |acc, val| acc + val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u64; 9]` which implements the `Copy` trait [INFO] [stdout] --> src/day6.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | simulate(data.clone(), 80) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u64; 9]` which implements the `Copy` trait [INFO] [stdout] --> src/day6.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 33 | simulate(data.clone(), 256) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/day11.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | let (row, col) = stack.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 28 ~ while let Some((row, col)) = stack.pop() { [INFO] [stdout] 29 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day11.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / if let Some(val) = data.get_mut(row_i).and_then(|r| r.get_mut(col_i)) { [INFO] [stdout] 38 | | if *val != b'0' { [INFO] [stdout] 39 | | *val += 1; [INFO] [stdout] 40 | | stack.push((row_i, col_i)); [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Some(val) = data.get_mut(row_i).and_then(|r| r.get_mut(col_i)) [INFO] [stdout] 38 ~ && *val != b'0' { [INFO] [stdout] 39 | *val += 1; [INFO] [stdout] 40 | stack.push((row_i, col_i)); [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/day9.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/day9.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | let (row, col) = stack.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 46 ~ while let Some((row, col)) = stack.pop() { [INFO] [stdout] 47 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Map, {closure@src/day5.rs:16:59: 16:67}>` [INFO] [stdout] --> src/day5.rs:16:29 [INFO] [stdout] | [INFO] [stdout] 16 | return Box::new((y1.min(y2)..=y1.max(y2)).map(move |y| (x1, y)).into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(y1.min(y2)..=y1.max(y2)).map(move |y| (x1, y))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Map, {closure@src/day5.rs:18:48: 18:56}>` [INFO] [stdout] --> src/day5.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | Box::new((x1.min(x2)..=x1.max(x2)).map(move |x| (x, y1)).into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(x1.min(x2)..=x1.max(x2)).map(move |x| (x, y1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day6.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | data.into_iter().fold(0, |acc, val| acc + val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u64; 9]` which implements the `Copy` trait [INFO] [stdout] --> src/day6.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | simulate(data.clone(), 80) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u64; 9]` which implements the `Copy` trait [INFO] [stdout] --> src/day6.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 33 | simulate(data.clone(), 256) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/day9.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/day9.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | let (row, col) = stack.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 46 ~ while let Some((row, col)) = stack.pop() { [INFO] [stdout] 47 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "ff486fd03a14d7f6fea96329c71236ab2349f6b065d498bb75261d323ab0c321", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff486fd03a14d7f6fea96329c71236ab2349f6b065d498bb75261d323ab0c321", kill_on_drop: false }` [INFO] [stdout] ff486fd03a14d7f6fea96329c71236ab2349f6b065d498bb75261d323ab0c321