[INFO] cloning repository https://github.com/PlacidFireball/csci-460-hw1-rust-project [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PlacidFireball/csci-460-hw1-rust-project" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPlacidFireball%2Fcsci-460-hw1-rust-project", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPlacidFireball%2Fcsci-460-hw1-rust-project'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 16b5a37f1a6fb0d9a55cfd6754cf88cde8146a64 [INFO] linting PlacidFireball/csci-460-hw1-rust-project against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPlacidFireball%2Fcsci-460-hw1-rust-project" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PlacidFireball/csci-460-hw1-rust-project [INFO] finished tweaking git repo https://github.com/PlacidFireball/csci-460-hw1-rust-project [INFO] tweaked toml for git repo https://github.com/PlacidFireball/csci-460-hw1-rust-project written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PlacidFireball/csci-460-hw1-rust-project on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PlacidFireball/csci-460-hw1-rust-project already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dd96899928e1984a351a7f7b36b69529c1c89d945116ef1e4a7ef73eab064f9a [INFO] running `Command { std: "docker" "start" "-a" "dd96899928e1984a351a7f7b36b69529c1c89d945116ef1e4a7ef73eab064f9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dd96899928e1984a351a7f7b36b69529c1c89d945116ef1e4a7ef73eab064f9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd96899928e1984a351a7f7b36b69529c1c89d945116ef1e4a7ef73eab064f9a", kill_on_drop: false }` [INFO] [stdout] dd96899928e1984a351a7f7b36b69529c1c89d945116ef1e4a7ef73eab064f9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54d4660a4271aea12457028b0a44b1dacb707e74b74f2ba1a66e9da8167dbfc1 [INFO] running `Command { std: "docker" "start" "-a" "54d4660a4271aea12457028b0a44b1dacb707e74b74f2ba1a66e9da8167dbfc1", kill_on_drop: false }` [INFO] [stderr] Checking csci-460-hw1-project v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `job_page_num` is never read [INFO] [stdout] --> src/main.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 108 | struct PMT { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 109 | job_page_num: Vec, // page numbers for the job {0, 1, 2 .... n} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PMT` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pages` is never read [INFO] [stdout] --> src/main.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 195 | struct Memory { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 196 | status: Vec, [INFO] [stdout] 197 | pages: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Memory` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Job` [INFO] [stdout] --> src/main.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / enum JobStatus { [INFO] [stdout] 45 | | JobNotDone, [INFO] [stdout] 46 | | JobWaiting, [INFO] [stdout] 47 | | JobDone, [INFO] [stdout] 48 | | JobRemoved, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `job_page_num` is never read [INFO] [stdout] --> src/main.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 108 | struct PMT { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 109 | job_page_num: Vec, // page numbers for the job {0, 1, 2 .... n} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PMT` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pages` is never read [INFO] [stdout] --> src/main.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 195 | struct Memory { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 196 | status: Vec, [INFO] [stdout] 197 | pages: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Memory` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Job` [INFO] [stdout] --> src/main.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / enum JobStatus { [INFO] [stdout] 45 | | JobNotDone, [INFO] [stdout] 46 | | JobWaiting, [INFO] [stdout] 47 | | JobDone, [INFO] [stdout] 48 | | JobRemoved, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | let page_req; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `page_req` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 77 ~ [INFO] [stdout] 78 ~ let page_req = if memory_req % PAGE_SIZE == 0 { [INFO] [stdout] 79 ~ memory_req/PAGE_SIZE [INFO] [stdout] 80 | } [INFO] [stdout] 81 | else { [INFO] [stdout] 82 ~ memory_req/PAGE_SIZE + 1 [INFO] [stdout] 83 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if memory_req % PAGE_SIZE == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `memory_req.is_multiple_of(PAGE_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | let page_req; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `page_req` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 77 ~ [INFO] [stdout] 78 ~ let page_req = if memory_req % PAGE_SIZE == 0 { [INFO] [stdout] 79 ~ memory_req/PAGE_SIZE [INFO] [stdout] 80 | } [INFO] [stdout] 81 | else { [INFO] [stdout] 82 ~ memory_req/PAGE_SIZE + 1 [INFO] [stdout] 83 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 78 | if memory_req % PAGE_SIZE == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `memory_req.is_multiple_of(PAGE_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PMT` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | struct PMT { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PMT` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:108:8 [INFO] [stdout] | [INFO] [stdout] 108 | struct PMT { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:167:40 [INFO] [stdout] | [INFO] [stdout] 167 | if self.page_num_mem.contains(&(page_number as i32)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `{ page_number }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:167:40 [INFO] [stdout] | [INFO] [stdout] 167 | if self.page_num_mem.contains(&(page_number as i32)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `{ page_number }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/main.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | pages_vec.push(PAGE_SIZE); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![PAGE_SIZE;SIZE]` [INFO] [stdout] = help: or `pages_vec.extend(std::iter::repeat_n(PAGE_SIZE, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:216:29 [INFO] [stdout] | [INFO] [stdout] 216 | fn show(&self, job_vec: &Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 216 - fn show(&self, job_vec: &Vec) { [INFO] [stdout] 216 + fn show(&self, job_vec: &[Job]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/main.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | pages_vec.push(PAGE_SIZE); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![PAGE_SIZE;SIZE]` [INFO] [stdout] = help: or `pages_vec.extend(std::iter::repeat_n(PAGE_SIZE, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `job_vec` [INFO] [stdout] --> src/main.rs:219:22 [INFO] [stdout] | [INFO] [stdout] 219 | for j in 0..job_vec.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 219 - for j in 0..job_vec.len() { [INFO] [stdout] 219 + for in &job_vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:216:29 [INFO] [stdout] | [INFO] [stdout] 216 | fn show(&self, job_vec: &Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 216 - fn show(&self, job_vec: &Vec) { [INFO] [stdout] 216 + fn show(&self, job_vec: &[Job]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `job_vec` [INFO] [stdout] --> src/main.rs:219:22 [INFO] [stdout] | [INFO] [stdout] 219 | for j in 0..job_vec.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 219 - for j in 0..job_vec.len() { [INFO] [stdout] 219 + for in &job_vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 305 | if !args[1].to_string().parse::().is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[1].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 341 | else if !args[0].to_string().parse::().is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[0].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:305:20 [INFO] [stdout] | [INFO] [stdout] 305 | if !args[1].to_string().parse::().is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[1].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:342:16 [INFO] [stdout] | [INFO] [stdout] 342 | && !args[1].to_string().parse::().is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[1].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 341 | else if !args[0].to_string().parse::().is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[0].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:342:16 [INFO] [stdout] | [INFO] [stdout] 342 | && !args[1].to_string().parse::().is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[1].to_string().parse::().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:261:21 [INFO] [stdout] | [INFO] [stdout] 261 | tx.send(x.clone()).unwrap(); // send the data off to the main thread [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:261:21 [INFO] [stdout] | [INFO] [stdout] 261 | tx.send(x.clone()).unwrap(); // send the data off to the main thread [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:308:30 [INFO] [stdout] | [INFO] [stdout] 308 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 308 - for i in 0..jobs.len() { [INFO] [stdout] 308 + for in &jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:308:30 [INFO] [stdout] | [INFO] [stdout] 308 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 308 - for i in 0..jobs.len() { [INFO] [stdout] 308 + for in &jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:315:36 [INFO] [stdout] | [INFO] [stdout] 315 | println!("{}", "| Please provide a valid job number\n| Syntax: pjobs "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 315 - println!("{}", "| Please provide a valid job number\n| Syntax: pjobs "); [INFO] [stdout] 315 + println!("| Please provide a valid job number\n| Syntax: pjobs "); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:315:36 [INFO] [stdout] | [INFO] [stdout] 315 | println!("{}", "| Please provide a valid job number\n| Syntax: pjobs "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 315 - println!("{}", "| Please provide a valid job number\n| Syntax: pjobs "); [INFO] [stdout] 315 + println!("| Please provide a valid job number\n| Syntax: pjobs "); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:320:26 [INFO] [stdout] | [INFO] [stdout] 320 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 320 - for i in 0..jobs.len() { [INFO] [stdout] 320 + for in &jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:326:22 [INFO] [stdout] | [INFO] [stdout] 326 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 326 - for i in 0..jobs.len() { [INFO] [stdout] 326 + for in &mut jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | / if jobs[i].status == JobWaiting { [INFO] [stdout] 328 | | if jobs[i].pmt.insert_job(&mut memory) { [INFO] [stdout] 329 | | print!( [INFO] [stdout] 330 | | "Insert success! Job {} inserted into memory!", [INFO] [stdout] ... | [INFO] [stdout] 337 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 327 ~ if jobs[i].status == JobWaiting [INFO] [stdout] 328 ~ && jobs[i].pmt.insert_job(&mut memory) { [INFO] [stdout] 329 | print!( [INFO] [stdout] ... [INFO] [stdout] 335 | jobs[i].start_time = most_recent_time - jobs[i].start_time; [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:320:26 [INFO] [stdout] | [INFO] [stdout] 320 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 320 - for i in 0..jobs.len() { [INFO] [stdout] 320 + for in &jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:326:22 [INFO] [stdout] | [INFO] [stdout] 326 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 326 - for i in 0..jobs.len() { [INFO] [stdout] 326 + for in &mut jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | / if jobs[i].status == JobWaiting { [INFO] [stdout] 328 | | if jobs[i].pmt.insert_job(&mut memory) { [INFO] [stdout] 329 | | print!( [INFO] [stdout] 330 | | "Insert success! Job {} inserted into memory!", [INFO] [stdout] ... | [INFO] [stdout] 337 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 327 ~ if jobs[i].status == JobWaiting [INFO] [stdout] 328 ~ && jobs[i].pmt.insert_job(&mut memory) { [INFO] [stdout] 329 | print!( [INFO] [stdout] ... [INFO] [stdout] 335 | jobs[i].start_time = most_recent_time - jobs[i].start_time; [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:349:26 [INFO] [stdout] | [INFO] [stdout] 349 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 349 - for i in 0..jobs.len() { [INFO] [stdout] 349 + for in &mut jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:349:26 [INFO] [stdout] | [INFO] [stdout] 349 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 349 - for i in 0..jobs.len() { [INFO] [stdout] 349 + for in &mut jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:383:28 [INFO] [stdout] | [INFO] [stdout] 383 | println!("{}", "| Not a valid command, please try '?' for help."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 383 - println!("{}", "| Not a valid command, please try '?' for help."); [INFO] [stdout] 383 + println!("| Not a valid command, please try '?' for help."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:386:18 [INFO] [stdout] | [INFO] [stdout] 386 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 386 - for i in 0..jobs.len() { [INFO] [stdout] 386 + for in &mut jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:383:28 [INFO] [stdout] | [INFO] [stdout] 383 | println!("{}", "| Not a valid command, please try '?' for help."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 383 - println!("{}", "| Not a valid command, please try '?' for help."); [INFO] [stdout] 383 + println!("| Not a valid command, please try '?' for help."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `jobs` [INFO] [stdout] --> src/main.rs:386:18 [INFO] [stdout] | [INFO] [stdout] 386 | for i in 0..jobs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 386 - for i in 0..jobs.len() { [INFO] [stdout] 386 + for in &mut jobs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "54d4660a4271aea12457028b0a44b1dacb707e74b74f2ba1a66e9da8167dbfc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54d4660a4271aea12457028b0a44b1dacb707e74b74f2ba1a66e9da8167dbfc1", kill_on_drop: false }` [INFO] [stdout] 54d4660a4271aea12457028b0a44b1dacb707e74b74f2ba1a66e9da8167dbfc1