[INFO] cloning repository https://github.com/PiradeepG/SearchApi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PiradeepG/SearchApi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPiradeepG%2FSearchApi", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPiradeepG%2FSearchApi'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 77239736b71d13ed5ba142b41cf08d1a3f6bd2ad [INFO] linting PiradeepG/SearchApi against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPiradeepG%2FSearchApi" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PiradeepG/SearchApi [INFO] finished tweaking git repo https://github.com/PiradeepG/SearchApi [INFO] tweaked toml for git repo https://github.com/PiradeepG/SearchApi written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PiradeepG/SearchApi on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PiradeepG/SearchApi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de2319c50ec54ae70eeaac5ce512f6adb06a0e371852a78ede24b0e918abd89d [INFO] running `Command { std: "docker" "start" "-a" "de2319c50ec54ae70eeaac5ce512f6adb06a0e371852a78ede24b0e918abd89d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de2319c50ec54ae70eeaac5ce512f6adb06a0e371852a78ede24b0e918abd89d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de2319c50ec54ae70eeaac5ce512f6adb06a0e371852a78ede24b0e918abd89d", kill_on_drop: false }` [INFO] [stdout] de2319c50ec54ae70eeaac5ce512f6adb06a0e371852a78ede24b0e918abd89d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f6b73b67d1d9aa00ccde57527e07110aaa2efa0ece7e63bd73ba4589d01f7fea [INFO] running `Command { std: "docker" "start" "-a" "f6b73b67d1d9aa00ccde57527e07110aaa2efa0ece7e63bd73ba4589d01f7fea", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking search_api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/lib.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/functions.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | / if query_parts[i+1] == ")" || query_parts[i+1]=="("{ [INFO] [stdout] 38 | | return Err(Error::InvalidQuery); [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ "and" | "or" [INFO] [stdout] 37 ~ if (query_parts[i+1] == ")" || query_parts[i+1]=="("=> ){ [INFO] [stdout] 38 | return Err(Error::InvalidQuery); [INFO] [stdout] 39 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/functions.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 32 | if let None = stack.pop() { [INFO] [stdout] | -------^^^^-------------- help: try: `if stack.pop().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 59 | keys: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 ~ keys: &[String], [INFO] [stdout] 60 | query_vec: &Vec, [INFO] [stdout] ... [INFO] [stdout] 74 | [INFO] [stdout] 75 ~ let keys = Arc::new(keys.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | query_vec: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 ~ query_vec: &[String], [INFO] [stdout] 61 | ) -> Result, Error> { [INFO] [stdout] ... [INFO] [stdout] 75 | let keys = Arc::new(keys.clone()); [INFO] [stdout] 76 ~ let query_vec = Arc::new(query_vec.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/functions.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | let chunk_size = (lines.len() + num_threads - 1) / num_threads; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `lines.len().div_ceil(num_threads)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:99:47 [INFO] [stdout] | [INFO] [stdout] 99 | ... temp_str.push_str(&value.to_string().trim_matches('"')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `value.to_string().trim_matches('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 133 | if !(&query_vec[*index + 1] == "(") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&query_vec[*index + 1] != "(")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions.rs:159:24 [INFO] [stdout] | [INFO] [stdout] 159 | if !(&query_vec[*index + 1] == "(") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&query_vec[*index + 1] != "(")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/functions.rs:145:40 [INFO] [stdout] | [INFO] [stdout] 145 | ... if let Some(_) = stack.last() { [INFO] [stdout] | -------^^^^^^^--------------- help: try: `if stack.last().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/functions.rs:171:40 [INFO] [stdout] | [INFO] [stdout] 171 | ... if let Some(_) = stack.last() { [INFO] [stdout] | -------^^^^^^^--------------- help: try: `if stack.last().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/functions.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | / if query_parts[i+1] == ")" || query_parts[i+1]=="("{ [INFO] [stdout] 38 | | return Err(Error::InvalidQuery); [INFO] [stdout] 39 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ "and" | "or" [INFO] [stdout] 37 ~ if (query_parts[i+1] == ")" || query_parts[i+1]=="("=> ){ [INFO] [stdout] 38 | return Err(Error::InvalidQuery); [INFO] [stdout] 39 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/functions.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 32 | if let None = stack.pop() { [INFO] [stdout] | -------^^^^-------------- help: try: `if stack.pop().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:59:11 [INFO] [stdout] | [INFO] [stdout] 59 | keys: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 ~ keys: &[String], [INFO] [stdout] 60 | query_vec: &Vec, [INFO] [stdout] ... [INFO] [stdout] 74 | [INFO] [stdout] 75 ~ let keys = Arc::new(keys.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/functions.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | query_vec: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 ~ query_vec: &[String], [INFO] [stdout] 61 | ) -> Result, Error> { [INFO] [stdout] ... [INFO] [stdout] 75 | let keys = Arc::new(keys.clone()); [INFO] [stdout] 76 ~ let query_vec = Arc::new(query_vec.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/functions.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | let chunk_size = (lines.len() + num_threads - 1) / num_threads; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `lines.len().div_ceil(num_threads)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/functions.rs:99:47 [INFO] [stdout] | [INFO] [stdout] 99 | ... temp_str.push_str(&value.to_string().trim_matches('"')); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `value.to_string().trim_matches('"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 133 | if !(&query_vec[*index + 1] == "(") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&query_vec[*index + 1] != "(")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/functions.rs:159:24 [INFO] [stdout] | [INFO] [stdout] 159 | if !(&query_vec[*index + 1] == "(") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&query_vec[*index + 1] != "(")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/functions.rs:145:40 [INFO] [stdout] | [INFO] [stdout] 145 | ... if let Some(_) = stack.last() { [INFO] [stdout] | -------^^^^^^^--------------- help: try: `if stack.last().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/functions.rs:171:40 [INFO] [stdout] | [INFO] [stdout] 171 | ... if let Some(_) = stack.last() { [INFO] [stdout] | -------^^^^^^^--------------- help: try: `if stack.last().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.29s [INFO] running `Command { std: "docker" "inspect" "f6b73b67d1d9aa00ccde57527e07110aaa2efa0ece7e63bd73ba4589d01f7fea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6b73b67d1d9aa00ccde57527e07110aaa2efa0ece7e63bd73ba4589d01f7fea", kill_on_drop: false }` [INFO] [stdout] f6b73b67d1d9aa00ccde57527e07110aaa2efa0ece7e63bd73ba4589d01f7fea