[INFO] cloning repository https://github.com/PiotrGog/face-viewer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PiotrGog/face-viewer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPiotrGog%2Fface-viewer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPiotrGog%2Fface-viewer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a589b452389ac81d260093d3b0a0f39a383c5f82 [INFO] linting PiotrGog/face-viewer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPiotrGog%2Fface-viewer" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PiotrGog/face-viewer [INFO] finished tweaking git repo https://github.com/PiotrGog/face-viewer [INFO] tweaked toml for git repo https://github.com/PiotrGog/face-viewer written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PiotrGog/face-viewer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PiotrGog/face-viewer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded relm-derive v0.21.0 [INFO] [stderr] Downloaded relm v0.21.0 [INFO] [stderr] Downloaded gdk-pixbuf-sys v0.10.0 [INFO] [stderr] Downloaded version-compare v0.0.10 [INFO] [stderr] Downloaded strum_macros v0.18.0 [INFO] [stderr] Downloaded system-deps v1.3.2 [INFO] [stderr] Downloaded takeable-option v0.5.0 [INFO] [stderr] Downloaded simba v0.5.1 [INFO] [stderr] Downloaded blas-src v0.6.1 [INFO] [stderr] Downloaded pango-sys v0.10.0 [INFO] [stderr] Downloaded wayland-sys v0.28.5 [INFO] [stderr] Downloaded hdf5-types v0.7.1 [INFO] [stderr] Downloaded wayland-egl v0.28.5 [INFO] [stderr] Downloaded gdk-pixbuf v0.9.0 [INFO] [stderr] Downloaded rustc-demangle v0.1.19 [INFO] [stderr] Downloaded wayland-commons v0.28.5 [INFO] [stderr] Downloaded addr2line v0.15.2 [INFO] [stderr] Downloaded backtrace v0.3.60 [INFO] [stderr] Downloaded wayland-client v0.28.5 [INFO] [stderr] Downloaded wayland-protocols v0.28.5 [INFO] [stderr] Downloaded syn v1.0.73 [INFO] [stderr] Downloaded hdf5 v0.7.1 [INFO] [stderr] Downloaded gio v0.9.1 [INFO] [stderr] Downloaded gtk-sys v0.10.0 [INFO] [stderr] Downloaded glib v0.10.3 [INFO] [stderr] Downloaded object v0.25.3 [INFO] [stderr] Downloaded ndarray v0.14.0 [INFO] [stderr] Downloaded glib-sys v0.10.1 [INFO] [stderr] Downloaded matrixmultiply v0.3.1 [INFO] [stderr] Downloaded gdk v0.13.2 [INFO] [stderr] Downloaded atk-sys v0.10.0 [INFO] [stderr] Downloaded nalgebra v0.27.1 [INFO] [stderr] Downloaded gdk-sys v0.10.0 [INFO] [stderr] Downloaded gio-sys v0.10.1 [INFO] [stderr] Downloaded typenum v1.13.0 [INFO] [stderr] Downloaded anyhow v1.0.41 [INFO] [stderr] Downloaded pango v0.9.1 [INFO] [stderr] Downloaded wayland-scanner v0.28.5 [INFO] [stderr] Downloaded libc v0.2.97 [INFO] [stderr] Downloaded hdf5-sys v0.7.1 [INFO] [stderr] Downloaded ascii v1.0.0 [INFO] [stderr] Downloaded gtk v0.9.2 [INFO] [stderr] Downloaded num-complex v0.3.1 [INFO] [stderr] Downloaded atk v0.9.0 [INFO] [stderr] Downloaded cairo-rs v0.9.1 [INFO] [stderr] Downloaded pin-project-lite v0.2.6 [INFO] [stderr] Downloaded gobject-sys v0.10.0 [INFO] [stderr] Downloaded wayland-cursor v0.28.5 [INFO] [stderr] Downloaded winreg v0.8.0 [INFO] [stderr] Downloaded gimli v0.24.0 [INFO] [stderr] Downloaded paste v1.0.5 [INFO] [stderr] Downloaded hdf5-derive v0.7.1 [INFO] [stderr] Downloaded cairo-sys-rs v0.10.0 [INFO] [stderr] Downloaded strum v0.18.0 [INFO] [stderr] Downloaded unicode-segmentation v1.7.1 [INFO] [stderr] Downloaded nalgebra-macros v0.1.0 [INFO] [stderr] Downloaded proc-macro-nested v0.1.7 [INFO] [stderr] Downloaded glib-macros v0.10.1 [INFO] [stderr] Downloaded glium v0.29.1 [INFO] [stderr] Downloaded openblas-src v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d75dd98416df4a13d810e5c279305561e5f2b248a2769b44902c666433c6917 [INFO] running `Command { std: "docker" "start" "-a" "7d75dd98416df4a13d810e5c279305561e5f2b248a2769b44902c666433c6917", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d75dd98416df4a13d810e5c279305561e5f2b248a2769b44902c666433c6917", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d75dd98416df4a13d810e5c279305561e5f2b248a2769b44902c666433c6917", kill_on_drop: false }` [INFO] [stdout] 7d75dd98416df4a13d810e5c279305561e5f2b248a2769b44902c666433c6917 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2debb8c07bdfb80849088148d00d0923951318f8df2466c51a19fa9f1e39b861 [INFO] running `Command { std: "docker" "start" "-a" "2debb8c07bdfb80849088148d00d0923951318f8df2466c51a19fa9f1e39b861", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling strum v0.18.0 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Compiling wayland-scanner v0.28.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling anyhow v1.0.41 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Compiling wayland-sys v0.28.5 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling regex-syntax v0.6.25 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling gio v0.9.1 [INFO] [stderr] Compiling libloading v0.6.7 [INFO] [stderr] Compiling cairo-rs v0.9.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling openblas-src v0.9.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling gdk-pixbuf v0.9.0 [INFO] [stderr] Compiling pango v0.9.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Compiling atk v0.9.0 [INFO] [stderr] Compiling gdk v0.13.2 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Checking nom v6.1.2 [INFO] [stderr] Compiling gtk v0.9.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling ndarray v0.14.0 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Checking gimli v0.24.0 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Checking object v0.25.3 [INFO] [stderr] Checking quote v0.6.13 [INFO] [stderr] Checking matrixmultiply v0.2.4 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking approx v0.5.0 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Compiling glium v0.29.1 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Compiling wayland-client v0.28.5 [INFO] [stderr] Compiling wayland-protocols v0.28.5 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking nix v0.18.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking x11-dl v2.18.5 [INFO] [stderr] Compiling backtrace v0.3.60 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking cblas-sys v0.1.4 [INFO] [stderr] Compiling hdf5 v0.7.1 [INFO] [stderr] Compiling paste v1.0.5 [INFO] [stderr] Checking ascii v1.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.19 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hdf5-types v0.7.1 [INFO] [stderr] Checking simba v0.5.1 [INFO] [stderr] Checking xcursor v0.3.3 [INFO] [stderr] Compiling regex v1.5.4 [INFO] [stderr] Checking addr2line v0.15.2 [INFO] [stderr] Checking matrixmultiply v0.3.1 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking glutin_glx_sys v0.1.7 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling hdf5-sys v0.7.1 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking wayland-commons v0.28.5 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling glib-macros v0.10.1 [INFO] [stderr] Compiling hdf5-derive v0.7.1 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Compiling relm-derive v0.21.0 [INFO] [stderr] Checking wayland-cursor v0.28.5 [INFO] [stderr] Checking wayland-egl v0.28.5 [INFO] [stderr] Compiling thiserror v1.0.25 [INFO] [stderr] Compiling system-deps v1.3.2 [INFO] [stderr] Checking nalgebra v0.27.1 [INFO] [stderr] Compiling glib-sys v0.10.1 [INFO] [stderr] Compiling gobject-sys v0.10.0 [INFO] [stderr] Compiling gio-sys v0.10.1 [INFO] [stderr] Compiling cairo-sys-rs v0.10.0 [INFO] [stderr] Compiling pango-sys v0.10.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.10.0 [INFO] [stderr] Compiling gdk-sys v0.10.0 [INFO] [stderr] Compiling atk-sys v0.10.0 [INFO] [stderr] Compiling gtk-sys v0.10.0 [INFO] [stderr] Checking futures-executor v0.3.15 [INFO] [stderr] Checking glib v0.10.3 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking winit v0.24.0 [INFO] [stderr] Checking glutin v0.26.0 [INFO] [stderr] Checking relm v0.21.0 [INFO] [stderr] Checking blas-src v0.6.1 [INFO] [stderr] Checking face-viewer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | pca_basis: pca_basis, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pca_basis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | pca_basis: pca_basis, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pca_basis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | pca_variance: pca_variance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pca_variance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | pca_variance: pca_variance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pca_variance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | rescaled_pca_basis: rescaled_pca_basis, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rescaled_pca_basis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | rescaled_pca_basis: rescaled_pca_basis, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rescaled_pca_basis` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `shape`, `color`, and `expression` are never read [INFO] [stdout] --> src/control_panel/mod.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 22 | #[relm_derive::widget] [INFO] [stdout] | ---------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 60 | #[name="color"] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | #[name="shape"] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | #[name="expression"] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `__ControlPanelWidgets` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `expression`, `shape`, and `color` are never read [INFO] [stdout] --> src/control_panel/mod.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 22 | #[relm_derive::widget] [INFO] [stdout] | ---------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 60 | #[name="color"] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | #[name="shape"] [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 93 | #[name="expression"] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `__ControlPanelWidgets` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | Self::load_array(&file, &format!("{}{}", param, "/model/pcaBasis"))?; [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | Self::load_array(&file, &format!("{}{}", param, "/model/pcaBasis"))?; [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | Self::load_array(&file, &format!("{}{}", param, "/model/pcaVariance"))?; [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | Self::load_array(&file, &format!("{}{}", param, "/model/pcaVariance"))?; [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | mean: Self::load_array(&file, &format!("{}{}", param, "/model/mean"))?, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | mean: Self::load_array(&file, &format!("{}{}", param, "/model/mean"))?, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | &file, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | &file, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | &file, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | &file, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | &file, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | &file, [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/basel_face_model/hdf5/model_params.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/basel_face_model/hdf5/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | Ok(morphable_model::MorphableModel::load_from_file(file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 7 - Ok(morphable_model::MorphableModel::load_from_file(file)?) [INFO] [stdout] 7 + morphable_model::MorphableModel::load_from_file(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/basel_face_model/hdf5/morphable_model.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/basel_face_model/hdf5/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | Ok(morphable_model::MorphableModel::load_from_file(file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 7 - Ok(morphable_model::MorphableModel::load_from_file(file)?) [INFO] [stdout] 7 + morphable_model::MorphableModel::load_from_file(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/control_panel/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / return Model { [INFO] [stdout] 35 | | color: coefficients.0, [INFO] [stdout] 36 | | expression: coefficients.1, [INFO] [stdout] 37 | | shape: coefficients.2, [INFO] [stdout] 38 | | is_running: coefficients.3, [INFO] [stdout] 39 | | model_updated: coefficients.4, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 ~ Model { [INFO] [stdout] 35 + color: coefficients.0, [INFO] [stdout] 36 + expression: coefficients.1, [INFO] [stdout] 37 + shape: coefficients.2, [INFO] [stdout] 38 + is_running: coefficients.3, [INFO] [stdout] 39 + model_updated: coefficients.4, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/control_panel/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / return Model { [INFO] [stdout] 35 | | color: coefficients.0, [INFO] [stdout] 36 | | expression: coefficients.1, [INFO] [stdout] 37 | | shape: coefficients.2, [INFO] [stdout] 38 | | is_running: coefficients.3, [INFO] [stdout] 39 | | model_updated: coefficients.4, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 ~ Model { [INFO] [stdout] 35 + color: coefficients.0, [INFO] [stdout] 36 + expression: coefficients.1, [INFO] [stdout] 37 + shape: coefficients.2, [INFO] [stdout] 38 + is_running: coefficients.3, [INFO] [stdout] 39 + model_updated: coefficients.4, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/control_panel/mod.rs:156:43 [INFO] [stdout] | [INFO] [stdout] 156 | let coefficients = Arc::clone(&coefficients); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `coefficients` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/control_panel/mod.rs:156:43 [INFO] [stdout] | [INFO] [stdout] 156 | let coefficients = Arc::clone(&coefficients); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `coefficients` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/control_panel/mod.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | let is_updated = Arc::clone(&model_updated); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `model_updated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/control_panel/mod.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | let is_updated = Arc::clone(&model_updated); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `model_updated` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/control_panel/mod.rs:162:21 [INFO] [stdout] | [INFO] [stdout] 162 | num[index as usize] = x as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/control_panel/mod.rs:162:21 [INFO] [stdout] | [INFO] [stdout] 162 | num[index as usize] = x as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/view_3d/mod.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / match ev { [INFO] [stdout] 83 | | glutin::event::Event::WindowEvent { event, .. } => match event { [INFO] [stdout] 84 | | glutin::event::WindowEvent::CloseRequested => { [INFO] [stdout] 85 | | *control_flow = glutin::event_loop::ControlFlow::Exit; [INFO] [stdout] ... | [INFO] [stdout] 92 | | _ => (), [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ if let glutin::event::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stdout] 83 + glutin::event::WindowEvent::CloseRequested => { [INFO] [stdout] 84 + *control_flow = glutin::event_loop::ControlFlow::Exit; [INFO] [stdout] 85 + return; [INFO] [stdout] 86 + } [INFO] [stdout] 87 + _ => { [INFO] [stdout] 88 + return; [INFO] [stdout] 89 + } [INFO] [stdout] 90 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/view_3d/mod.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / match ev { [INFO] [stdout] 83 | | glutin::event::Event::WindowEvent { event, .. } => match event { [INFO] [stdout] 84 | | glutin::event::WindowEvent::CloseRequested => { [INFO] [stdout] 85 | | *control_flow = glutin::event_loop::ControlFlow::Exit; [INFO] [stdout] ... | [INFO] [stdout] 92 | | _ => (), [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ if let glutin::event::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stdout] 83 + glutin::event::WindowEvent::CloseRequested => { [INFO] [stdout] 84 + *control_flow = glutin::event_loop::ControlFlow::Exit; [INFO] [stdout] 85 + return; [INFO] [stdout] 86 + } [INFO] [stdout] 87 + _ => { [INFO] [stdout] 88 + return; [INFO] [stdout] 89 + } [INFO] [stdout] 90 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view_3d/mod.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | &program, [INFO] [stdout] | ^^^^^^^^ help: change this to: `program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view_3d/mod.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | &program, [INFO] [stdout] | ^^^^^^^^ help: change this to: `program` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view_3d/mod.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | ¶ms, [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view_3d/mod.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | ¶ms, [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/view_3d/mod.rs:176:1 [INFO] [stdout] | [INFO] [stdout] 176 | / fn update_shape_and_color_buffer( [INFO] [stdout] 177 | | shape_and_color_buffer: &mut glium::VertexBuffer, [INFO] [stdout] 178 | | model: &basel_face_model::hdf5::morphable_model::MorphableModel, [INFO] [stdout] 179 | | color: Arc>>, [INFO] [stdout] ... | [INFO] [stdout] 185 | | shape_and_color: &mut Vec, [INFO] [stdout] 186 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/view_3d/mod.rs:176:1 [INFO] [stdout] | [INFO] [stdout] 176 | / fn update_shape_and_color_buffer( [INFO] [stdout] 177 | | shape_and_color_buffer: &mut glium::VertexBuffer, [INFO] [stdout] 178 | | model: &basel_face_model::hdf5::morphable_model::MorphableModel, [INFO] [stdout] 179 | | color: Arc>>, [INFO] [stdout] ... | [INFO] [stdout] 185 | | shape_and_color: &mut Vec, [INFO] [stdout] 186 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view_3d/mod.rs:215:34 [INFO] [stdout] | [INFO] [stdout] 215 | shape_and_color_buffer.write(&shape_and_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `shape_and_color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/view_3d/mod.rs:215:34 [INFO] [stdout] | [INFO] [stdout] 215 | shape_and_color_buffer.write(&shape_and_color); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `shape_and_color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7m 01s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: hdf5 v0.7.1, nalgebra v0.27.1, nom v6.1.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "2debb8c07bdfb80849088148d00d0923951318f8df2466c51a19fa9f1e39b861", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2debb8c07bdfb80849088148d00d0923951318f8df2466c51a19fa9f1e39b861", kill_on_drop: false }` [INFO] [stdout] 2debb8c07bdfb80849088148d00d0923951318f8df2466c51a19fa9f1e39b861