[INFO] cloning repository https://github.com/PhillipTaylor/csv-verify [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PhillipTaylor/csv-verify" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPhillipTaylor%2Fcsv-verify", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPhillipTaylor%2Fcsv-verify'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 825750984a955f485e9c7719f8752cd4911db98a [INFO] linting PhillipTaylor/csv-verify against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPhillipTaylor%2Fcsv-verify" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PhillipTaylor/csv-verify [INFO] finished tweaking git repo https://github.com/PhillipTaylor/csv-verify [INFO] tweaked toml for git repo https://github.com/PhillipTaylor/csv-verify written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PhillipTaylor/csv-verify on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PhillipTaylor/csv-verify already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.104 [INFO] [stderr] Downloaded custom_derive v0.1.7 [INFO] [stderr] Downloaded conv v0.3.3 [INFO] [stderr] Downloaded rusttype v0.9.3 [INFO] [stderr] Downloaded rand_distr v0.2.2 [INFO] [stderr] Downloaded ryu v1.0.22 [INFO] [stderr] Downloaded clap v4.5.54 [INFO] [stderr] Downloaded simba v0.7.3 [INFO] [stderr] Downloaded owned_ttf_parser v0.15.2 [INFO] [stderr] Downloaded wide v0.7.33 [INFO] [stderr] Downloaded ttf-parser v0.15.2 [INFO] [stderr] Downloaded clap_builder v4.5.54 [INFO] [stderr] Downloaded syn v2.0.113 [INFO] [stderr] Downloaded nalgebra v0.30.1 [INFO] [stderr] Downloaded libc v0.2.179 [INFO] [stderr] Downloaded imageproc v0.23.0 [INFO] [stderr] Downloaded image v0.24.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc0cc69eb98edb7f6b1ebcda08202aeb439e68165207ed0324d432ff20f1b8d0 [INFO] running `Command { std: "docker" "start" "-a" "dc0cc69eb98edb7f6b1ebcda08202aeb439e68165207ed0324d432ff20f1b8d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc0cc69eb98edb7f6b1ebcda08202aeb439e68165207ed0324d432ff20f1b8d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc0cc69eb98edb7f6b1ebcda08202aeb439e68165207ed0324d432ff20f1b8d0", kill_on_drop: false }` [INFO] [stdout] dc0cc69eb98edb7f6b1ebcda08202aeb439e68165207ed0324d432ff20f1b8d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7831851944578ff89156f988fe1d5dbebbcdd631c4b68a3742e1c730b56d4f5 [INFO] running `Command { std: "docker" "start" "-a" "f7831851944578ff89156f988fe1d5dbebbcdd631c4b68a3742e1c730b56d4f5", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling proc-macro2 v1.0.104 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking image v0.24.8 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking nalgebra v0.30.1 [INFO] [stderr] Checking imageproc v0.23.0 [INFO] [stderr] Checking csv-verify v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/lib.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{BufWriter, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:65:54 [INFO] [stdout] | [INFO] [stdout] 65 | let mut next: Vec = Vec::with_capacity((prev.len() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `prev.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | /// Validates each hash is 64 hex chars and decodes to 32 bytes. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 134 | /// Validates each hash is 64 hex chars and decodes to 32 bytes. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if rec.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/lib.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{BufWriter, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | let root_hash = hex::encode(&levels.last().unwrap()[0].hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `levels.last().unwrap()[0].hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:260:37 [INFO] [stdout] | [INFO] [stdout] 260 | let title = hex::encode(&node.hash); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `node.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:313:1 [INFO] [stdout] | [INFO] [stdout] 313 | / pub fn draw_merkle_tree_png( [INFO] [stdout] 314 | | tree: &Tree, [INFO] [stdout] 315 | | out_path: &Path, [INFO] [stdout] 316 | | node_radius: i32, [INFO] [stdout] ... | [INFO] [stdout] 321 | | label_len: usize, [INFO] [stdout] 322 | | ) -> Result<(), Box> { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:65:54 [INFO] [stdout] | [INFO] [stdout] 65 | let mut next: Vec = Vec::with_capacity((prev.len() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `prev.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | /// Validates each hash is 64 hex chars and decodes to 32 bytes. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 134 | /// Validates each hash is 64 hex chars and decodes to 32 bytes. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if rec.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | let root_hash = hex::encode(&levels.last().unwrap()[0].hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `levels.last().unwrap()[0].hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:260:37 [INFO] [stdout] | [INFO] [stdout] 260 | let title = hex::encode(&node.hash); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `node.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:313:1 [INFO] [stdout] | [INFO] [stdout] 313 | / pub fn draw_merkle_tree_png( [INFO] [stdout] 314 | | tree: &Tree, [INFO] [stdout] 315 | | out_path: &Path, [INFO] [stdout] 316 | | node_radius: i32, [INFO] [stdout] ... | [INFO] [stdout] 321 | | label_len: usize, [INFO] [stdout] 322 | | ) -> Result<(), Box> { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `HashSet` [INFO] [stdout] --> src/main.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `HashSet` [INFO] [stdout] --> src/main.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/main.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::{BufWriter, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/main.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::{BufWriter, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:117:54 [INFO] [stdout] | [INFO] [stdout] 117 | let mut next: Vec = Vec::with_capacity((prev.len() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `prev.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / fn draw_merkle_tree_png( [INFO] [stdout] 175 | | tree: &Tree, [INFO] [stdout] 176 | | out_path: &PathBuf, [INFO] [stdout] 177 | | node_radius: i32, [INFO] [stdout] ... | [INFO] [stdout] 182 | | label_len: usize, [INFO] [stdout] 183 | | ) -> Result<(), Box> { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:345:33 [INFO] [stdout] | [INFO] [stdout] 345 | let root_hash = hex::encode(&levels.last().unwrap()[0].hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `levels.last().unwrap()[0].hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:117:54 [INFO] [stdout] | [INFO] [stdout] 117 | let mut next: Vec = Vec::with_capacity((prev.len() + 1) / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `prev.len().div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:374:37 [INFO] [stdout] | [INFO] [stdout] 374 | let title = hex::encode(&node.hash); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `node.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:440:20 [INFO] [stdout] | [INFO] [stdout] 440 | let mode_png = args.png || (!args.png && !args.html); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 440 - let mode_png = args.png || (!args.png && !args.html); [INFO] [stdout] 440 + let mode_png = !(!args.png && args.html); [INFO] [stdout] | [INFO] [stdout] 440 - let mode_png = args.png || (!args.png && !args.html); [INFO] [stdout] 440 + let mode_png = args.png || !args.html; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / fn draw_merkle_tree_png( [INFO] [stdout] 175 | | tree: &Tree, [INFO] [stdout] 176 | | out_path: &PathBuf, [INFO] [stdout] 177 | | node_radius: i32, [INFO] [stdout] ... | [INFO] [stdout] 182 | | label_len: usize, [INFO] [stdout] 183 | | ) -> Result<(), Box> { [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:345:33 [INFO] [stdout] | [INFO] [stdout] 345 | let root_hash = hex::encode(&levels.last().unwrap()[0].hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `levels.last().unwrap()[0].hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:374:37 [INFO] [stdout] | [INFO] [stdout] 374 | let title = hex::encode(&node.hash); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `node.hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:440:20 [INFO] [stdout] | [INFO] [stdout] 440 | let mode_png = args.png || (!args.png && !args.html); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 440 - let mode_png = args.png || (!args.png && !args.html); [INFO] [stdout] 440 + let mode_png = !(!args.png && args.html); [INFO] [stdout] | [INFO] [stdout] 440 - let mode_png = args.png || (!args.png && !args.html); [INFO] [stdout] 440 + let mode_png = args.png || !args.html; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.80s [INFO] running `Command { std: "docker" "inspect" "f7831851944578ff89156f988fe1d5dbebbcdd631c4b68a3742e1c730b56d4f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7831851944578ff89156f988fe1d5dbebbcdd631c4b68a3742e1c730b56d4f5", kill_on_drop: false }` [INFO] [stdout] f7831851944578ff89156f988fe1d5dbebbcdd631c4b68a3742e1c730b56d4f5