[INFO] cloning repository https://github.com/PedroManse/MMDKit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PedroManse/MMDKit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPedroManse%2FMMDKit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPedroManse%2FMMDKit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1742727bad06399948200c825666333173bb950c [INFO] linting PedroManse/MMDKit against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPedroManse%2FMMDKit" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PedroManse/MMDKit [INFO] finished tweaking git repo https://github.com/PedroManse/MMDKit [INFO] tweaked toml for git repo https://github.com/PedroManse/MMDKit written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PedroManse/MMDKit on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PedroManse/MMDKit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.87 [INFO] [stderr] Downloaded regex v1.11.0 [INFO] [stderr] Downloaded syn v2.0.79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03d19d2048f7ca2541927c6ebb6afae71e8ac8299b0f08bbe23e57c1e20a41c7 [INFO] running `Command { std: "docker" "start" "-a" "03d19d2048f7ca2541927c6ebb6afae71e8ac8299b0f08bbe23e57c1e20a41c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03d19d2048f7ca2541927c6ebb6afae71e8ac8299b0f08bbe23e57c1e20a41c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03d19d2048f7ca2541927c6ebb6afae71e8ac8299b0f08bbe23e57c1e20a41c7", kill_on_drop: false }` [INFO] [stdout] 03d19d2048f7ca2541927c6ebb6afae71e8ac8299b0f08bbe23e57c1e20a41c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80c80fa9e3ae6e56e8ecdae414c3f3d2877726fabd5ec2a0d8faa27b60af80dc [INFO] running `Command { std: "docker" "start" "-a" "80c80fa9e3ae6e56e8ecdae414c3f3d2877726fabd5ec2a0d8faa27b60af80dc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.87 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking regex v1.11.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking mmdkit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `vars` is never read [INFO] [stdout] --> src/plex.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct SetVars { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 47 | vars: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SetVars` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `vars` is never read [INFO] [stdout] --> src/plex.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct SetVars { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 47 | vars: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SetVars` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/fmt.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 13 - write!(f, "\n")?; [INFO] [stdout] 13 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/fmt.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 13 - write!(f, "\n")?; [INFO] [stdout] 13 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fmt.rs:27:55 [INFO] [stdout] | [INFO] [stdout] 27 | let t = self.expr.fmt_tree(self.expr.depth(), &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/fmt.rs:27:55 [INFO] [stdout] | [INFO] [stdout] 27 | let t = self.expr.fmt_tree(self.expr.depth(), &self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/logic.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | !(a && !b) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!a || b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/logic.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | !(a && !b) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!a || b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/logic.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | !(a && !b) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!a || b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/logic.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | !(a && !b) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!a || b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/plex.rs:53:47 [INFO] [stdout] | [INFO] [stdout] 53 | let var_map = HashMap::from_iter(vars.into_iter().map(|v| (*v, false))); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/plex.rs:53:47 [INFO] [stdout] | [INFO] [stdout] 53 | let var_map = HashMap::from_iter(vars.into_iter().map(|v| (*v, false))); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.29s [INFO] running `Command { std: "docker" "inspect" "80c80fa9e3ae6e56e8ecdae414c3f3d2877726fabd5ec2a0d8faa27b60af80dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80c80fa9e3ae6e56e8ecdae414c3f3d2877726fabd5ec2a0d8faa27b60af80dc", kill_on_drop: false }` [INFO] [stdout] 80c80fa9e3ae6e56e8ecdae414c3f3d2877726fabd5ec2a0d8faa27b60af80dc