[INFO] cloning repository https://github.com/Paulistaken/cppcheckr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Paulistaken/cppcheckr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPaulistaken%2Fcppcheckr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPaulistaken%2Fcppcheckr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c7dab0a7f9d08135e7cdbc3caa22f22d4c64e7d4 [INFO] linting Paulistaken/cppcheckr against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPaulistaken%2Fcppcheckr" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Paulistaken/cppcheckr [INFO] finished tweaking git repo https://github.com/Paulistaken/cppcheckr [INFO] tweaked toml for git repo https://github.com/Paulistaken/cppcheckr written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Paulistaken/cppcheckr on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Paulistaken/cppcheckr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syn-mid v0.5.4 [INFO] [stderr] Downloaded proc-macro-error-attr v0.4.12 [INFO] [stderr] Downloaded clap_derive-v3 v3.0.0-beta.1 [INFO] [stderr] Downloaded proc-macro-error v0.4.12 [INFO] [stderr] Downloaded clap-v3 v3.0.0-beta.1 [INFO] [stderr] Downloaded libc v0.2.161 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6828dac72be832d686c4076578d7b9db54170abc189a77762b4948d86883f48b [INFO] running `Command { std: "docker" "start" "-a" "6828dac72be832d686c4076578d7b9db54170abc189a77762b4948d86883f48b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6828dac72be832d686c4076578d7b9db54170abc189a77762b4948d86883f48b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6828dac72be832d686c4076578d7b9db54170abc189a77762b4948d86883f48b", kill_on_drop: false }` [INFO] [stdout] 6828dac72be832d686c4076578d7b9db54170abc189a77762b4948d86883f48b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e1951861490f2129e4831ffa3ae40426548ab73aae12413a6f35cabd41c2e98 [INFO] running `Command { std: "docker" "start" "-a" "6e1951861490f2129e4831ffa3ae40426548ab73aae12413a6f35cabd41c2e98", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.9.3 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn-mid v0.5.4 [INFO] [stderr] Compiling clap_derive-v3 v3.0.0-beta.1 [INFO] [stderr] Checking clap-v3 v3.0.0-beta.1 [INFO] [stderr] Checking cppcheckr v1.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:11:51 [INFO] [stdout] | [INFO] [stdout] 11 | if Path::new(&pth).try_exists().is_ok_and(|x| x == false) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 24 | .is_ok_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | if !(out == tmp) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(out != tmp)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | .is_ok_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:54:24 [INFO] [stdout] | [INFO] [stdout] 54 | .is_ok_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:11:51 [INFO] [stdout] | [INFO] [stdout] 11 | if Path::new(&pth).try_exists().is_ok_and(|x| x == false) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 24 | .is_ok_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | if !(out == tmp) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(out != tmp)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | .is_ok_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:54:24 [INFO] [stdout] | [INFO] [stdout] 54 | .is_ok_and(|x| x == false) [INFO] [stdout] | ^^^^^^^^^^ help: try: `!x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.29s [INFO] running `Command { std: "docker" "inspect" "6e1951861490f2129e4831ffa3ae40426548ab73aae12413a6f35cabd41c2e98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e1951861490f2129e4831ffa3ae40426548ab73aae12413a6f35cabd41c2e98", kill_on_drop: false }` [INFO] [stdout] 6e1951861490f2129e4831ffa3ae40426548ab73aae12413a6f35cabd41c2e98