[INFO] cloning repository https://github.com/PauSala/countMyHours [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PauSala/countMyHours" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPauSala%2FcountMyHours", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPauSala%2FcountMyHours'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] decf3a376fcbac617b4fdef535af0656b79d459d [INFO] linting PauSala/countMyHours against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPauSala%2FcountMyHours" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PauSala/countMyHours [INFO] finished tweaking git repo https://github.com/PauSala/countMyHours [INFO] tweaked toml for git repo https://github.com/PauSala/countMyHours written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PauSala/countMyHours on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PauSala/countMyHours already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4ee344a007d6b6103a348282900cd3235cceec872c55122ae4a762035ba1eceb [INFO] running `Command { std: "docker" "start" "-a" "4ee344a007d6b6103a348282900cd3235cceec872c55122ae4a762035ba1eceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4ee344a007d6b6103a348282900cd3235cceec872c55122ae4a762035ba1eceb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ee344a007d6b6103a348282900cd3235cceec872c55122ae4a762035ba1eceb", kill_on_drop: false }` [INFO] [stdout] 4ee344a007d6b6103a348282900cd3235cceec872c55122ae4a762035ba1eceb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ca16f6ad63609310ec433a270bbfe1a84b0a110723d0c89dc78b65c87f9057a [INFO] running `Command { std: "docker" "start" "-a" "4ca16f6ad63609310ec433a270bbfe1a84b0a110723d0c89dc78b65c87f9057a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking serde v1.0.203 [INFO] [stderr] Checking cmh v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | return Ok((counter, total, number_of_days)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Ok((counter, total, number_of_days)); [INFO] [stdout] 92 + Ok((counter, total, number_of_days)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/commands.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | return Ok((counter, total, number_of_days)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Ok((counter, total, number_of_days)); [INFO] [stdout] 92 + Ok((counter, total, number_of_days)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/commands.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | let res; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `res` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 152 ~ [INFO] [stdout] 153 ~ let res = match mode { [INFO] [stdout] 154 ~ "t" => working_days * working_minutes.minutes as i64 / 60, [INFO] [stdout] 155 ~ "p" => today * working_minutes.minutes as i64 / 60, [INFO] [stdout] 156 | _ => panic!("Wrong parameter"), [INFO] [stdout] 157 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/commands.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | let res; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `res` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 152 ~ [INFO] [stdout] 153 ~ let res = match mode { [INFO] [stdout] 154 ~ "t" => working_days * working_minutes.minutes as i64 / 60, [INFO] [stdout] 155 ~ "p" => today * working_minutes.minutes as i64 / 60, [INFO] [stdout] 156 | _ => panic!("Wrong parameter"), [INFO] [stdout] 157 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/config_loader.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | / pub fn default() -> Self { [INFO] [stdout] 88 | | Config { [INFO] [stdout] 89 | | colors: Colors::default(), [INFO] [stdout] 90 | | schedule: Schedule::default(), [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config_loader.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | return Config::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Config::default(); [INFO] [stdout] 108 + Config::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/file_utils.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | let last_line = reader.lines().filter_map(Result::ok).last(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/file_utils.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | let last_line = reader.lines().filter_map(Result::ok).last(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/file_utils.rs:44:35 [INFO] [stdout] | [INFO] [stdout] 44 | let time = Time::from_str(&content)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/config_loader.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | / pub fn default() -> Self { [INFO] [stdout] 88 | | Config { [INFO] [stdout] 89 | | colors: Colors::default(), [INFO] [stdout] 90 | | schedule: Schedule::default(), [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/file_utils.rs:57:38 [INFO] [stdout] | [INFO] [stdout] 57 | let mut file = OpenOptions::new().write(true).append(true).open(path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config_loader.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | return Config::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Config::default(); [INFO] [stdout] 108 + Config::default() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/file_utils.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | let last_line = reader.lines().filter_map(Result::ok).last(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/file_utils.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | let last_line = reader.lines().filter_map(Result::ok).last(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/file_utils.rs:44:35 [INFO] [stdout] | [INFO] [stdout] 44 | let time = Time::from_str(&content)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/file_utils.rs:57:38 [INFO] [stdout] | [INFO] [stdout] 57 | let mut file = OpenOptions::new().write(true).append(true).open(path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cli.undo && cli.add.is_some() [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | || cli.undo && cli.balance [INFO] [stdout] 86 | | || cli.undo && cli.distribute.is_some() [INFO] [stdout] 87 | | || cli.undo && cli.init_balance [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 87 - || cli.undo && cli.init_balance [INFO] [stdout] 84 + if !(!cli.undo || cli.add.is_none() && !cli.balance && cli.distribute.is_none() && !cli.init_balance) [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 87 - || cli.undo && cli.init_balance [INFO] [stdout] 84 + if (cli.init_balance || cli.distribute.is_some() || cli.balance || cli.add.is_some()) && cli.undo [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cli.undo && cli.add.is_some() [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | || cli.undo && cli.balance [INFO] [stdout] 86 | | || cli.undo && cli.distribute.is_some() [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 84 + if !(!cli.undo || cli.add.is_none() && !cli.balance && cli.distribute.is_none()) [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 84 + if (cli.distribute.is_some() || cli.balance || cli.add.is_some()) && cli.undo [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cli.undo && cli.add.is_some() [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | || cli.undo && cli.balance [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 84 + if !(!cli.undo || cli.add.is_none() && !cli.balance) [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 84 + if (cli.balance || cli.add.is_some()) && cli.undo [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cli.undo && cli.add.is_some() [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | || cli.undo && cli.balance [INFO] [stdout] 86 | | || cli.undo && cli.distribute.is_some() [INFO] [stdout] 87 | | || cli.undo && cli.init_balance [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 87 - || cli.undo && cli.init_balance [INFO] [stdout] 84 + if !(!cli.undo || cli.add.is_none() && !cli.balance && cli.distribute.is_none() && !cli.init_balance) [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 87 - || cli.undo && cli.init_balance [INFO] [stdout] 84 + if (cli.init_balance || cli.distribute.is_some() || cli.balance || cli.add.is_some()) && cli.undo [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cli.undo && cli.add.is_some() [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | || cli.undo && cli.balance [INFO] [stdout] 86 | | || cli.undo && cli.distribute.is_some() [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 84 + if !(!cli.undo || cli.add.is_none() && !cli.balance && cli.distribute.is_none()) [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 86 - || cli.undo && cli.distribute.is_some() [INFO] [stdout] 84 + if (cli.distribute.is_some() || cli.balance || cli.add.is_some()) && cli.undo [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | if cli.undo && cli.add.is_some() [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | || cli.undo && cli.balance [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 84 + if !(!cli.undo || cli.add.is_none() && !cli.balance) [INFO] [stdout] | [INFO] [stdout] 84 - if cli.undo && cli.add.is_some() [INFO] [stdout] 85 - || cli.undo && cli.balance [INFO] [stdout] 84 + if (cli.balance || cli.add.is_some()) && cli.undo [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.31s [INFO] running `Command { std: "docker" "inspect" "4ca16f6ad63609310ec433a270bbfe1a84b0a110723d0c89dc78b65c87f9057a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ca16f6ad63609310ec433a270bbfe1a84b0a110723d0c89dc78b65c87f9057a", kill_on_drop: false }` [INFO] [stdout] 4ca16f6ad63609310ec433a270bbfe1a84b0a110723d0c89dc78b65c87f9057a