[INFO] cloning repository https://github.com/PashaKopka/hue_game [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PashaKopka/hue_game" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPashaKopka%2Fhue_game", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPashaKopka%2Fhue_game'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9e4bb6ffaa3adfc24b15f8af808fb83b373c7747 [INFO] linting PashaKopka/hue_game against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPashaKopka%2Fhue_game" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PashaKopka/hue_game [INFO] finished tweaking git repo https://github.com/PashaKopka/hue_game [INFO] tweaked toml for git repo https://github.com/PashaKopka/hue_game written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PashaKopka/hue_game on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PashaKopka/hue_game already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d51520f910afacdab88c5c60d67ae91d089482dca96c5cc6446e114a61d618e [INFO] running `Command { std: "docker" "start" "-a" "7d51520f910afacdab88c5c60d67ae91d089482dca96c5cc6446e114a61d618e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d51520f910afacdab88c5c60d67ae91d089482dca96c5cc6446e114a61d618e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d51520f910afacdab88c5c60d67ae91d089482dca96c5cc6446e114a61d618e", kill_on_drop: false }` [INFO] [stdout] 7d51520f910afacdab88c5c60d67ae91d089482dca96c5cc6446e114a61d618e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 018060ff641eb51ae2f51cc2a22346b9c240891396256074e1430bdf4b1073db [INFO] running `Command { std: "docker" "start" "-a" "018060ff641eb51ae2f51cc2a22346b9c240891396256074e1430bdf4b1073db", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling find-msvc-tools v0.1.7 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling wgpu-hal v27.0.4 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling cc v1.2.52 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Compiling wgpu-core v27.0.3 [INFO] [stderr] Checking epaint_default_fonts v0.33.3 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Compiling wgpu v27.0.1 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking type-map v0.5.1 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking calloop v0.14.4 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking emath v0.33.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wgpu-types v27.0.1 [INFO] [stderr] Checking ecolor v0.33.3 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking epaint v0.33.3 [INFO] [stderr] Checking naga v27.0.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking egui v0.33.3 [INFO] [stderr] Checking webbrowser v1.1.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking egui-winit v0.33.3 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Checking egui-wgpu v0.33.3 [INFO] [stderr] Checking gradient v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/grid.rs:280:14 [INFO] [stdout] | [INFO] [stdout] 280 | for (i, ((&[x, y], &angle), color)) in coordinates [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/grid.rs:355:44 [INFO] [stdout] | [INFO] [stdout] 355 | fn is_corner(coordinates: &[[f32; 2]], x: f32, y: f32) -> bool { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/grid.rs:280:14 [INFO] [stdout] | [INFO] [stdout] 280 | for (i, ((&[x, y], &angle), color)) in coordinates [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/grid.rs:355:44 [INFO] [stdout] | [INFO] [stdout] 355 | fn is_corner(coordinates: &[[f32; 2]], x: f32, y: f32) -> bool { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `shape` is never read [INFO] [stdout] --> src/grid.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Grid { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 43 | pub cell_size: f32, [INFO] [stdout] 44 | pub shape: GridShape, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Grid` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `shape`, `swap_target_index`, `as_squares_mut`, and `as_triangles_mut` are never used [INFO] [stdout] --> src/grid.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 541 | impl GridVariant { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 553 | pub fn shape(&self) -> GridShape { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 581 | pub fn swap_target_index(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 650 | pub fn as_squares_mut(&mut self) -> Option<&mut Grid> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 664 | pub fn as_triangles_mut(&mut self) -> Option<&mut Grid> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `correct_position` and `color` are never used [INFO] [stdout] --> src/grid.rs:758:8 [INFO] [stdout] | [INFO] [stdout] 755 | pub trait PuzzlePiece { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 758 | fn correct_position(&self) -> [f32; 2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 763 | fn color(&self) -> [f32; 3]; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/grid.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 87 | .zip(colors.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 87 - .zip(colors.into_iter()) [INFO] [stdout] 87 + .zip(colors) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/grid.rs:283:18 [INFO] [stdout] | [INFO] [stdout] 283 | .zip(colors.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 283 - .zip(colors.into_iter()) [INFO] [stdout] 283 + .zip(colors) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `shape` is never read [INFO] [stdout] --> src/grid.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Grid { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 43 | pub cell_size: f32, [INFO] [stdout] 44 | pub shape: GridShape, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Grid` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `shape`, `swap_target_index`, `as_squares_mut`, and `as_triangles_mut` are never used [INFO] [stdout] --> src/grid.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 541 | impl GridVariant { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 553 | pub fn shape(&self) -> GridShape { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 581 | pub fn swap_target_index(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 650 | pub fn as_squares_mut(&mut self) -> Option<&mut Grid> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 664 | pub fn as_triangles_mut(&mut self) -> Option<&mut Grid> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `correct_position` and `color` are never used [INFO] [stdout] --> src/grid.rs:758:8 [INFO] [stdout] | [INFO] [stdout] 755 | pub trait PuzzlePiece { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 758 | fn correct_position(&self) -> [f32; 2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 763 | fn color(&self) -> [f32; 3]; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/game_state/ui/primitives.rs:138:1 [INFO] [stdout] | [INFO] [stdout] 138 | / fn push_corner_arc( [INFO] [stdout] 139 | | vertices: &mut Vec, [INFO] [stdout] 140 | | indices: &mut Vec, [INFO] [stdout] 141 | | center: [f32; 2], [INFO] [stdout] ... | [INFO] [stdout] 146 | | color: [f32; 3], [INFO] [stdout] 147 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/grid.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 87 | .zip(colors.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 87 - .zip(colors.into_iter()) [INFO] [stdout] 87 + .zip(colors) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/grid.rs:283:18 [INFO] [stdout] | [INFO] [stdout] 283 | .zip(colors.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 283 - .zip(colors.into_iter()) [INFO] [stdout] 283 + .zip(colors) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_state/mod.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | / match (code, is_pressed) { [INFO] [stdout] 297 | | (winit::keyboard::KeyCode::Escape, true) => event_loop.exit(), [INFO] [stdout] 298 | | _ => {} [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________^ help: try: `if let (winit::keyboard::KeyCode::Escape, true) = (code, is_pressed) { event_loop.exit() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_state/mod.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | / match self.get_piece_on() { [INFO] [stdout] 316 | | Some(i) => { [INFO] [stdout] 317 | | if self.phase != GamePhase::Playing { [INFO] [stdout] 318 | | return; [INFO] [stdout] ... | [INFO] [stdout] 322 | | None => {} [INFO] [stdout] 323 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 315 ~ if let Some(i) = self.get_piece_on() { [INFO] [stdout] 316 + if self.phase != GamePhase::Playing { [INFO] [stdout] 317 + return; [INFO] [stdout] 318 + } [INFO] [stdout] 319 + self.drag_piece(i); [INFO] [stdout] 320 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_state/mod.rs:325:17 [INFO] [stdout] | [INFO] [stdout] 325 | / match self.get_button_on() { [INFO] [stdout] 326 | | Some(kind) => { [INFO] [stdout] 327 | | match kind { [INFO] [stdout] 328 | | ButtonKind::Restart => { [INFO] [stdout] ... | [INFO] [stdout] 339 | | None => {} [INFO] [stdout] 340 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 325 ~ if let Some(kind) = self.get_button_on() { [INFO] [stdout] 326 + match kind { [INFO] [stdout] 327 + ButtonKind::Restart => { [INFO] [stdout] 328 + self.show_start_time = Instant::now(); [INFO] [stdout] 329 + self.phase = GamePhase::Showing; [INFO] [stdout] 330 + self.solve_grid(gpu); [INFO] [stdout] 331 + self.show_grid(gpu); [INFO] [stdout] 332 + }, [INFO] [stdout] 333 + ButtonKind::Settings => { [INFO] [stdout] 334 + self.phase = GamePhase::Settings; [INFO] [stdout] 335 + }, [INFO] [stdout] 336 + } [INFO] [stdout] 337 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game_state/mod.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 381 | / if let Some(drag_idx) = self.grid.dragging_index() { [INFO] [stdout] 382 | | if let Some(target_idx) = self.get_piece_on() { [INFO] [stdout] 383 | | if drag_idx != target_idx && self.grid.piece(target_idx).is_movable() { [INFO] [stdout] 384 | | let drag_pos = self.grid.piece(drag_idx).prev_position(); [INFO] [stdout] ... | [INFO] [stdout] 416 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 381 ~ if let Some(drag_idx) = self.grid.dragging_index() [INFO] [stdout] 382 ~ && let Some(target_idx) = self.get_piece_on() { [INFO] [stdout] 383 | if drag_idx != target_idx && self.grid.piece(target_idx).is_movable() { [INFO] [stdout] ... [INFO] [stdout] 414 | } [INFO] [stdout] 415 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/settings_state/mod.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | / match (code, is_pressed) { [INFO] [stdout] 375 | | (winit::keyboard::KeyCode::Escape, true) => event_loop.exit(), [INFO] [stdout] 376 | | _ => {} [INFO] [stdout] 377 | | } [INFO] [stdout] | |_________^ help: try: `if let (winit::keyboard::KeyCode::Escape, true) = (code, is_pressed) { event_loop.exit() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | let _ = app::run().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 10 - let _ = app::run().unwrap(); [INFO] [stdout] 10 + app::run().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/game_state/ui/primitives.rs:138:1 [INFO] [stdout] | [INFO] [stdout] 138 | / fn push_corner_arc( [INFO] [stdout] 139 | | vertices: &mut Vec, [INFO] [stdout] 140 | | indices: &mut Vec, [INFO] [stdout] 141 | | center: [f32; 2], [INFO] [stdout] ... | [INFO] [stdout] 146 | | color: [f32; 3], [INFO] [stdout] 147 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_state/mod.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | / match (code, is_pressed) { [INFO] [stdout] 297 | | (winit::keyboard::KeyCode::Escape, true) => event_loop.exit(), [INFO] [stdout] 298 | | _ => {} [INFO] [stdout] 299 | | } [INFO] [stdout] | |_________^ help: try: `if let (winit::keyboard::KeyCode::Escape, true) = (code, is_pressed) { event_loop.exit() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_state/mod.rs:315:17 [INFO] [stdout] | [INFO] [stdout] 315 | / match self.get_piece_on() { [INFO] [stdout] 316 | | Some(i) => { [INFO] [stdout] 317 | | if self.phase != GamePhase::Playing { [INFO] [stdout] 318 | | return; [INFO] [stdout] ... | [INFO] [stdout] 322 | | None => {} [INFO] [stdout] 323 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 315 ~ if let Some(i) = self.get_piece_on() { [INFO] [stdout] 316 + if self.phase != GamePhase::Playing { [INFO] [stdout] 317 + return; [INFO] [stdout] 318 + } [INFO] [stdout] 319 + self.drag_piece(i); [INFO] [stdout] 320 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/game_state/mod.rs:325:17 [INFO] [stdout] | [INFO] [stdout] 325 | / match self.get_button_on() { [INFO] [stdout] 326 | | Some(kind) => { [INFO] [stdout] 327 | | match kind { [INFO] [stdout] 328 | | ButtonKind::Restart => { [INFO] [stdout] ... | [INFO] [stdout] 339 | | None => {} [INFO] [stdout] 340 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 325 ~ if let Some(kind) = self.get_button_on() { [INFO] [stdout] 326 + match kind { [INFO] [stdout] 327 + ButtonKind::Restart => { [INFO] [stdout] 328 + self.show_start_time = Instant::now(); [INFO] [stdout] 329 + self.phase = GamePhase::Showing; [INFO] [stdout] 330 + self.solve_grid(gpu); [INFO] [stdout] 331 + self.show_grid(gpu); [INFO] [stdout] 332 + }, [INFO] [stdout] 333 + ButtonKind::Settings => { [INFO] [stdout] 334 + self.phase = GamePhase::Settings; [INFO] [stdout] 335 + }, [INFO] [stdout] 336 + } [INFO] [stdout] 337 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/game_state/mod.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 381 | / if let Some(drag_idx) = self.grid.dragging_index() { [INFO] [stdout] 382 | | if let Some(target_idx) = self.get_piece_on() { [INFO] [stdout] 383 | | if drag_idx != target_idx && self.grid.piece(target_idx).is_movable() { [INFO] [stdout] 384 | | let drag_pos = self.grid.piece(drag_idx).prev_position(); [INFO] [stdout] ... | [INFO] [stdout] 416 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 381 ~ if let Some(drag_idx) = self.grid.dragging_index() [INFO] [stdout] 382 ~ && let Some(target_idx) = self.get_piece_on() { [INFO] [stdout] 383 | if drag_idx != target_idx && self.grid.piece(target_idx).is_movable() { [INFO] [stdout] ... [INFO] [stdout] 414 | } [INFO] [stdout] 415 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/settings_state/mod.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 374 | / match (code, is_pressed) { [INFO] [stdout] 375 | | (winit::keyboard::KeyCode::Escape, true) => event_loop.exit(), [INFO] [stdout] 376 | | _ => {} [INFO] [stdout] 377 | | } [INFO] [stdout] | |_________^ help: try: `if let (winit::keyboard::KeyCode::Escape, true) = (code, is_pressed) { event_loop.exit() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | let _ = app::run().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 10 - let _ = app::run().unwrap(); [INFO] [stdout] 10 + app::run().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 52.55s [INFO] running `Command { std: "docker" "inspect" "018060ff641eb51ae2f51cc2a22346b9c240891396256074e1430bdf4b1073db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "018060ff641eb51ae2f51cc2a22346b9c240891396256074e1430bdf4b1073db", kill_on_drop: false }` [INFO] [stdout] 018060ff641eb51ae2f51cc2a22346b9c240891396256074e1430bdf4b1073db