[INFO] cloning repository https://github.com/Parsanta/Server-side [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Parsanta/Server-side" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FParsanta%2FServer-side", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FParsanta%2FServer-side'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] df59e4d4543cc4c31f8c1c126d1e181701a85d04 [INFO] linting Parsanta/Server-side against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FParsanta%2FServer-side" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Parsanta/Server-side [INFO] finished tweaking git repo https://github.com/Parsanta/Server-side [INFO] tweaked toml for git repo https://github.com/Parsanta/Server-side written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Parsanta/Server-side on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Parsanta/Server-side already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libc v0.2.149 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] edd64e1447d684cfd20505b57f5f390dcf85754091dc89845db028828095d6a7 [INFO] running `Command { std: "docker" "start" "-a" "edd64e1447d684cfd20505b57f5f390dcf85754091dc89845db028828095d6a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "edd64e1447d684cfd20505b57f5f390dcf85754091dc89845db028828095d6a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edd64e1447d684cfd20505b57f5f390dcf85754091dc89845db028828095d6a7", kill_on_drop: false }` [INFO] [stdout] edd64e1447d684cfd20505b57f5f390dcf85754091dc89845db028828095d6a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45dc37e4ae1a44aedc7d0ccfe7ba9d1ec1d1525918399fad1139b425a88ae96b [INFO] running `Command { std: "docker" "start" "-a" "45dc37e4ae1a44aedc7d0ccfe7ba9d1ec1d1525918399fad1139b425a88ae96b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/server_fucntions.rs:29:26 [INFO] [stdout] | [INFO] [stdout] 29 | for (_key, value) in clients { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 29 - for (_key, value) in clients { [INFO] [stdout] 29 + for value in clients.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `attempts` [INFO] [stdout] --> src/server_unit_test.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | let (word, attempts) = word(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_attempts` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/server_fucntions.rs:29:26 [INFO] [stdout] | [INFO] [stdout] 29 | for (_key, value) in clients { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 29 - for (_key, value) in clients { [INFO] [stdout] 29 + for value in clients.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/server_unit_test.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | assert_eq!(game.process_guess('a'), true); // Correct guess [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 21 - assert_eq!(game.process_guess('a'), true); // Correct guess [INFO] [stdout] 21 + assert!(game.process_guess('a')); // Correct guess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/server_unit_test.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | assert_eq!(game.process_guess('b'), false); // Incorrect guess [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 22 - assert_eq!(game.process_guess('b'), false); // Incorrect guess [INFO] [stdout] 22 + assert!(!game.process_guess('b')); // Incorrect guess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/server_unit_test.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | assert_eq!(game.process_guess('a'), false); // Already guessed [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 23 - assert_eq!(game.process_guess('a'), false); // Already guessed [INFO] [stdout] 23 + assert!(!game.process_guess('a')); // Already guessed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/server_unit_test.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | assert_eq!(game.is_game_over(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 29 - assert_eq!(game.is_game_over(), false); [INFO] [stdout] 29 + assert!(!game.is_game_over()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/server_unit_test.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!(game.is_game_over(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 32 - assert_eq!(game.is_game_over(), true); [INFO] [stdout] 32 + assert!(game.is_game_over()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | if !(client_address == *key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(client_address != *key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/main.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if !clients.contains_key(&client_address) { [INFO] [stdout] 29 | | clients.insert(client_address, 0); [INFO] [stdout] 30 | | let new_user_message = format!( [INFO] [stdout] 31 | | "Game Status: {}\nAttempt left: {} Your Score: 0", [INFO] [stdout] ... | [INFO] [stdout] 37 | | continue; [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ if let std::collections::hash_map::Entry::Vacant(e) = clients.entry(client_address) { [INFO] [stdout] 29 + e.insert(0); [INFO] [stdout] 30 + let new_user_message = format!( [INFO] [stdout] 31 + "Game Status: {}\nAttempt left: {} Your Score: 0", [INFO] [stdout] 32 + game.display_word, game.attempts_left [INFO] [stdout] 33 + ); [INFO] [stdout] 34 + if let Err(err) = server_socket.send_to(new_user_message.as_bytes(), client_address) { [INFO] [stdout] 35 + eprintln!("Error sending data to the client: {}", err); [INFO] [stdout] 36 + } [INFO] [stdout] 37 + continue; [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | key.clone(), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | if !(client_address == *key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(client_address != *key)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/main.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if !clients.contains_key(&client_address) { [INFO] [stdout] 29 | | clients.insert(client_address, 0); [INFO] [stdout] 30 | | let new_user_message = format!( [INFO] [stdout] 31 | | "Game Status: {}\nAttempt left: {} Your Score: 0", [INFO] [stdout] ... | [INFO] [stdout] 37 | | continue; [INFO] [stdout] 38 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ if let std::collections::hash_map::Entry::Vacant(e) = clients.entry(client_address) { [INFO] [stdout] 29 + e.insert(0); [INFO] [stdout] 30 + let new_user_message = format!( [INFO] [stdout] 31 + "Game Status: {}\nAttempt left: {} Your Score: 0", [INFO] [stdout] 32 + game.display_word, game.attempts_left [INFO] [stdout] 33 + ); [INFO] [stdout] 34 + if let Err(err) = server_socket.send_to(new_user_message.as_bytes(), client_address) { [INFO] [stdout] 35 + eprintln!("Error sending data to the client: {}", err); [INFO] [stdout] 36 + } [INFO] [stdout] 37 + continue; [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | key.clone(), [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.60s [INFO] running `Command { std: "docker" "inspect" "45dc37e4ae1a44aedc7d0ccfe7ba9d1ec1d1525918399fad1139b425a88ae96b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45dc37e4ae1a44aedc7d0ccfe7ba9d1ec1d1525918399fad1139b425a88ae96b", kill_on_drop: false }` [INFO] [stdout] 45dc37e4ae1a44aedc7d0ccfe7ba9d1ec1d1525918399fad1139b425a88ae96b