[INFO] cloning repository https://github.com/Pantonshire/okay [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Pantonshire/okay" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPantonshire%2Fokay", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPantonshire%2Fokay'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4fa4578614f17f429eb13fd99b1b91fc7a71783b [INFO] linting Pantonshire/okay against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPantonshire%2Fokay" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Pantonshire/okay [INFO] finished tweaking git repo https://github.com/Pantonshire/okay [INFO] tweaked toml for git repo https://github.com/Pantonshire/okay written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Pantonshire/okay on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Pantonshire/okay already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crc32fast v1.2.2 [INFO] [stderr] Downloaded qoi v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7b61be1e3bff1a360800e86c2bea7fecb48c27104a4ac77e1562bc596ca8b6d [INFO] running `Command { std: "docker" "start" "-a" "c7b61be1e3bff1a360800e86c2bea7fecb48c27104a4ac77e1562bc596ca8b6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7b61be1e3bff1a360800e86c2bea7fecb48c27104a4ac77e1562bc596ca8b6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7b61be1e3bff1a360800e86c2bea7fecb48c27104a4ac77e1562bc596ca8b6d", kill_on_drop: false }` [INFO] [stdout] c7b61be1e3bff1a360800e86c2bea7fecb48c27104a4ac77e1562bc596ca8b6d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb4d79878d9b35638730ef9fa878b2fe86545f8d3b2f051b210da471db2c057f [INFO] running `Command { std: "docker" "start" "-a" "cb4d79878d9b35638730ef9fa878b2fe86545f8d3b2f051b210da471db2c057f", kill_on_drop: false }` [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling crc32fast v1.2.2 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking qoi v0.4.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking okay v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/decode.rs:200:42 [INFO] [stdout] | [INFO] [stdout] 200 | let (num_pixels, exhausted) = if !usize::try_from(self.remaining).is_ok() || buf.len() < self.remaining as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `usize::try_from(self.remaining).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `buf` [INFO] [stdout] --> src/decode.rs:206:18 [INFO] [stdout] | [INFO] [stdout] 206 | for i in 0..num_pixels { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 206 - for i in 0..num_pixels { [INFO] [stdout] 206 + for in buf.iter_mut().take(num_pixels) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `.map().collect()` can be replaced with `.try_for_each()` [INFO] [stdout] --> src/hex.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / self.bytes [INFO] [stdout] 22 | | .iter() [INFO] [stdout] 23 | | .copied() [INFO] [stdout] 24 | | .map(byte_to_hex) [INFO] [stdout] 25 | | .map(|(h1, h2)| write!(f, "{}{}", h1, h2)) [INFO] [stdout] 26 | | .collect() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_collect_result_unit [INFO] [stdout] = note: `#[warn(clippy::map_collect_result_unit)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ self.bytes [INFO] [stdout] 22 + .iter() [INFO] [stdout] 23 + .copied() [INFO] [stdout] 24 + .map(byte_to_hex).try_for_each(|(h1, h2)| write!(f, "{}{}", h1, h2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/decode.rs:200:42 [INFO] [stdout] | [INFO] [stdout] 200 | let (num_pixels, exhausted) = if !usize::try_from(self.remaining).is_ok() || buf.len() < self.remaining as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `usize::try_from(self.remaining).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `buf` [INFO] [stdout] --> src/decode.rs:206:18 [INFO] [stdout] | [INFO] [stdout] 206 | for i in 0..num_pixels { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 206 - for i in 0..num_pixels { [INFO] [stdout] 206 + for in buf.iter_mut().take(num_pixels) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `.map().collect()` can be replaced with `.try_for_each()` [INFO] [stdout] --> src/hex.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / self.bytes [INFO] [stdout] 22 | | .iter() [INFO] [stdout] 23 | | .copied() [INFO] [stdout] 24 | | .map(byte_to_hex) [INFO] [stdout] 25 | | .map(|(h1, h2)| write!(f, "{}{}", h1, h2)) [INFO] [stdout] 26 | | .collect() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_collect_result_unit [INFO] [stdout] = note: `#[warn(clippy::map_collect_result_unit)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ self.bytes [INFO] [stdout] 22 + .iter() [INFO] [stdout] 23 + .copied() [INFO] [stdout] 24 + .map(byte_to_hex).try_for_each(|(h1, h2)| write!(f, "{}{}", h1, h2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/qoi_to_png.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | let bytes = fs::read(&in_path).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `in_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bin/qoi_to_png.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | encoder.write_image(&rgba, header.width() as u32, header.height() as u32, image::ColorType::Rgba8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `header.width()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bin/qoi_to_png.rs:30:55 [INFO] [stdout] | [INFO] [stdout] 30 | encoder.write_image(&rgba, header.width() as u32, header.height() as u32, image::ColorType::Rgba8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.height()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/qoi_to_png.rs:18:26 [INFO] [stdout] | [INFO] [stdout] 18 | let bytes = fs::read(&in_path).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `in_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bin/qoi_to_png.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | encoder.write_image(&rgba, header.width() as u32, header.height() as u32, image::ColorType::Rgba8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `header.width()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bin/qoi_to_png.rs:30:55 [INFO] [stdout] | [INFO] [stdout] 30 | encoder.write_image(&rgba, header.width() as u32, header.height() as u32, image::ColorType::Rgba8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `header.height()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.38s [INFO] running `Command { std: "docker" "inspect" "cb4d79878d9b35638730ef9fa878b2fe86545f8d3b2f051b210da471db2c057f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb4d79878d9b35638730ef9fa878b2fe86545f8d3b2f051b210da471db2c057f", kill_on_drop: false }` [INFO] [stdout] cb4d79878d9b35638730ef9fa878b2fe86545f8d3b2f051b210da471db2c057f