[INFO] cloning repository https://github.com/Pancia/player-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Pancia/player-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPancia%2Fplayer-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPancia%2Fplayer-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 23da781b31f06fe9e3dc49c093a92e2b90087cb3 [INFO] linting Pancia/player-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPancia%2Fplayer-rs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Pancia/player-rs [INFO] finished tweaking git repo https://github.com/Pancia/player-rs [INFO] tweaked toml for git repo https://github.com/Pancia/player-rs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Pancia/player-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Pancia/player-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded uuid v0.4.0 [INFO] [stderr] Downloaded env_logger v0.3.5 [INFO] [stderr] Downloaded bitflags v0.7.0 [INFO] [stderr] Downloaded fuchsia-zircon-sys v0.2.0 [INFO] [stderr] Downloaded rand v0.3.18 [INFO] [stderr] Downloaded ansi_term v0.9.0 [INFO] [stderr] Downloaded redox_termios v0.1.1 [INFO] [stderr] Downloaded strsim v0.6.0 [INFO] [stderr] Downloaded atty v0.2.3 [INFO] [stderr] Downloaded bitflags v0.9.1 [INFO] [stderr] Downloaded winapi-build v0.1.1 [INFO] [stderr] Downloaded thread-id v2.0.0 [INFO] [stderr] Downloaded termion v1.5.1 [INFO] [stderr] Downloaded thread_local v0.2.7 [INFO] [stderr] Downloaded fuchsia-zircon v0.2.1 [INFO] [stderr] Downloaded vec_map v0.8.0 [INFO] [stderr] Downloaded memchr v0.1.11 [INFO] [stderr] Downloaded itertools v0.7.3 [INFO] [stderr] Downloaded regex-syntax v0.3.9 [INFO] [stderr] Downloaded libc v0.2.33 [INFO] [stderr] Downloaded kernel32-sys v0.2.2 [INFO] [stderr] Downloaded quickcheck v0.4.1 [INFO] [stderr] Downloaded clap v2.27.1 [INFO] [stderr] Downloaded utf8-ranges v0.1.3 [INFO] [stderr] Downloaded regex v0.1.80 [INFO] [stderr] Downloaded aho-corasick v0.5.3 [INFO] [stderr] Downloaded textwrap v0.9.0 [INFO] [stderr] Downloaded unicode-width v0.1.4 [INFO] [stderr] Downloaded either v1.4.0 [INFO] [stderr] Downloaded redox_syscall v0.1.31 [INFO] [stderr] Downloaded log v0.3.8 [INFO] [stderr] Downloaded winapi v0.2.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c8ad37ff8f9b39e842b5e07cefd8f24d5f5fb09b2bb8c4ac8125a5582b73a208 [INFO] running `Command { std: "docker" "start" "-a" "c8ad37ff8f9b39e842b5e07cefd8f24d5f5fb09b2bb8c4ac8125a5582b73a208", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c8ad37ff8f9b39e842b5e07cefd8f24d5f5fb09b2bb8c4ac8125a5582b73a208", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8ad37ff8f9b39e842b5e07cefd8f24d5f5fb09b2bb8c4ac8125a5582b73a208", kill_on_drop: false }` [INFO] [stdout] c8ad37ff8f9b39e842b5e07cefd8f24d5f5fb09b2bb8c4ac8125a5582b73a208 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ca4a772d25e69f533bf954f28ebb64b352ed976fc8a00944e8b13b20238e5e7 [INFO] running `Command { std: "docker" "start" "-a" "1ca4a772d25e69f533bf954f28ebb64b352ed976fc8a00944e8b13b20238e5e7", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.33 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking log v0.3.8 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking either v1.4.0 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking itertools v0.7.3 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking rand v0.3.18 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking quickcheck v0.4.1 [INFO] [stderr] Checking player-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/shuffle.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | fn shuffle(coll: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 10 - fn shuffle(coll: &mut Vec) { [INFO] [stdout] 10 + fn shuffle(coll: &mut [T]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/shuffle.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | fn shuffle(coll: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 10 - fn shuffle(coll: &mut Vec) { [INFO] [stdout] 10 + fn shuffle(coll: &mut [T]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:44:14 [INFO] [stdout] | [INFO] [stdout] 44 | .map(|s| Path::new(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Path::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match input { [INFO] [stdout] 57 | | _ => tx.send("kill").unwrap(), [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `tx.send("kill").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | .args(&["-v", volume_str]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["-v", volume_str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:45 [INFO] [stdout] | [INFO] [stdout] 70 | while child.try_wait().ok().map(|x| !x.is_some()).unwrap_or(true) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `x.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:44:14 [INFO] [stdout] | [INFO] [stdout] 44 | .map(|s| Path::new(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Path::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / match input { [INFO] [stdout] 57 | | _ => tx.send("kill").unwrap(), [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________^ help: consider using the match body instead: `tx.send("kill").unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 66 | .args(&["-v", volume_str]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["-v", volume_str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:45 [INFO] [stdout] | [INFO] [stdout] 70 | while child.try_wait().ok().map(|x| !x.is_some()).unwrap_or(true) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `x.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.36s [INFO] running `Command { std: "docker" "inspect" "1ca4a772d25e69f533bf954f28ebb64b352ed976fc8a00944e8b13b20238e5e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ca4a772d25e69f533bf954f28ebb64b352ed976fc8a00944e8b13b20238e5e7", kill_on_drop: false }` [INFO] [stdout] 1ca4a772d25e69f533bf954f28ebb64b352ed976fc8a00944e8b13b20238e5e7