[INFO] cloning repository https://github.com/PJB3005/bsdiff-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PJB3005/bsdiff-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPJB3005%2Fbsdiff-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPJB3005%2Fbsdiff-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e84234fb5a2c0020209fa3135a0ba0c9ca56c77a [INFO] linting PJB3005/bsdiff-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPJB3005%2Fbsdiff-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/PJB3005/bsdiff-rs [INFO] finished tweaking git repo https://github.com/PJB3005/bsdiff-rs [INFO] tweaked toml for git repo https://github.com/PJB3005/bsdiff-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/PJB3005/bsdiff-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/PJB3005/bsdiff-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libc v0.2.24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d75a18bf951185d1ffa950a10145f9d691b0f0c36b1cd146c08217f58cdd750 [INFO] running `Command { std: "docker" "start" "-a" "6d75a18bf951185d1ffa950a10145f9d691b0f0c36b1cd146c08217f58cdd750", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d75a18bf951185d1ffa950a10145f9d691b0f0c36b1cd146c08217f58cdd750", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d75a18bf951185d1ffa950a10145f9d691b0f0c36b1cd146c08217f58cdd750", kill_on_drop: false }` [INFO] [stdout] 6d75a18bf951185d1ffa950a10145f9d691b0f0c36b1cd146c08217f58cdd750 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b9371565e21a65ae16386d55bf4b9061c8d608046ab0a45d638891c00fb82f6 [INFO] running `Command { std: "docker" "start" "-a" "4b9371565e21a65ae16386d55bf4b9061c8d608046ab0a45d638891c00fb82f6", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.24 [INFO] [stderr] Checking bsdiff v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/diff.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | I: I, [INFO] [stdout] | ^^^^ help: replace it with: `I` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/diff.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | I: I, [INFO] [stdout] | ^^^^ help: replace it with: `I` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/diff.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | buffer: buffer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:65:34 [INFO] [stdout] | [INFO] [stdout] 65 | libc::free(req.buffer as (*mut libc::c_void)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - libc::free(req.buffer as (*mut libc::c_void)); [INFO] [stdout] 65 + libc::free(req.buffer as *mut libc::c_void); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | libc::free(req.I as (*mut libc::c_void)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - libc::free(req.I as (*mut libc::c_void)); [INFO] [stdout] 66 + libc::free(req.I as *mut libc::c_void); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | 'loop31: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | 'loop34: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | 'loop36: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | 'loop2: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/diff.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | buffer: buffer, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:65:34 [INFO] [stdout] | [INFO] [stdout] 65 | libc::free(req.buffer as (*mut libc::c_void)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 65 - libc::free(req.buffer as (*mut libc::c_void)); [INFO] [stdout] 65 + libc::free(req.buffer as *mut libc::c_void); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | libc::free(req.I as (*mut libc::c_void)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - libc::free(req.I as (*mut libc::c_void)); [INFO] [stdout] 66 + libc::free(req.I as *mut libc::c_void); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | 'loop31: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | 'loop34: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | 'loop36: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | 'loop4: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | 'loop2: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | 'loop4: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | 'loop5: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | 'loop5: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | 'loop9: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | 'loop1: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:210:22 [INFO] [stdout] | [INFO] [stdout] 210 | buckets[i as (usize)] = 0isize; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - buckets[i as (usize)] = 0isize; [INFO] [stdout] 210 + buckets[i as usize] = 0isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | 'loop3: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:219:51 [INFO] [stdout] | [INFO] [stdout] 219 | let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] 219 + let _lhs = &mut buckets[*old.offset(i) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:220:33 [INFO] [stdout] | [INFO] [stdout] 220 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 220 - *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] 220 + *_lhs = *_lhs + _rhs as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 224 | 'loop5: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:228:44 [INFO] [stdout] | [INFO] [stdout] 228 | let _rhs = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 228 - let _rhs = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] 228 + let _rhs = buckets[(i - 1isize) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:229:38 [INFO] [stdout] | [INFO] [stdout] 229 | let _lhs = &mut buckets[i as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - let _lhs = &mut buckets[i as (usize)]; [INFO] [stdout] 229 + let _lhs = &mut buckets[i as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | 'loop7: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:238:22 [INFO] [stdout] | [INFO] [stdout] 238 | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 238 - buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] 238 + buckets[i as usize] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:238:57 [INFO] [stdout] | [INFO] [stdout] 238 | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 238 - buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] 238 + buckets[i as (usize)] = buckets[(i - 1isize) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | 'loop9: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:249:65 [INFO] [stdout] | [INFO] [stdout] 249 | let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 249 - let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] 249 + let _lhs = &mut buckets[*old.offset(i) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:250:47 [INFO] [stdout] | [INFO] [stdout] 250 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 250 - *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] 250 + *_lhs = *_lhs + _rhs as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | 'loop11: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:261:50 [INFO] [stdout] | [INFO] [stdout] 261 | *V.offset(i) = buckets[*old.offset(i) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 261 - *V.offset(i) = buckets[*old.offset(i) as (usize)]; [INFO] [stdout] 261 + *V.offset(i) = buckets[*old.offset(i) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 266 | 'loop13: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:270:25 [INFO] [stdout] | [INFO] [stdout] 270 | if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 270 - if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] 270 + if buckets[i as usize] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | 'loop9: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | 'loop1: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:270:61 [INFO] [stdout] | [INFO] [stdout] 270 | if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 270 - if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] 270 + if buckets[i as (usize)] == buckets[(i - 1isize) as usize] + 1isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:271:36 [INFO] [stdout] | [INFO] [stdout] 271 | *I.offset(buckets[i as (usize)]) = -1isize; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - *I.offset(buckets[i as (usize)]) = -1isize; [INFO] [stdout] 271 + *I.offset(buckets[i as usize]) = -1isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | 'loop15: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | 'loop22: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 306 | 'loop17: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | 'loop1: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:326:30 [INFO] [stdout] | [INFO] [stdout] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 326 - if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] 326 + if *old.offset(i) as i32 != *new.offset(i) as (i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:326:57 [INFO] [stdout] | [INFO] [stdout] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 326 - if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] 326 + if *old.offset(i) as (i32) != *new.offset(i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/diff.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | (if x > y { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 360 | }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 354 ~ if x > y { [INFO] [stdout] 355 | *pos = *I.offset(st); [INFO] [stdout] ... [INFO] [stdout] 359 | y [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/diff.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | (if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 373 | }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 363 ~ if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] 364 | new as (*const libc::c_void), [INFO] [stdout] ... [INFO] [stdout] 372 | search(I, old, oldsize, new, newsize, st, x, pos) [INFO] [stdout] 373 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:363:48 [INFO] [stdout] | [INFO] [stdout] 363 | (if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 363 - (if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] 363 + (if memcmp(old.offset(*I.offset(x)) as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:364:27 [INFO] [stdout] | [INFO] [stdout] 364 | new as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 364 - new as (*const libc::c_void), [INFO] [stdout] 364 + new as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:369:25 [INFO] [stdout] | [INFO] [stdout] 369 | } as (usize)) < 0i32 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 369 - } as (usize)) < 0i32 { [INFO] [stdout] 369 + } as usize) < 0i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:384:45 [INFO] [stdout] | [INFO] [stdout] 384 | *buf.offset(0isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 384 - *buf.offset(0isize) = (y % 256isize) as (u8); [INFO] [stdout] 384 + *buf.offset(0isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:210:22 [INFO] [stdout] | [INFO] [stdout] 210 | buckets[i as (usize)] = 0isize; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 210 - buckets[i as (usize)] = 0isize; [INFO] [stdout] 210 + buckets[i as usize] = 0isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 214 | 'loop3: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:219:51 [INFO] [stdout] | [INFO] [stdout] 219 | let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] 219 + let _lhs = &mut buckets[*old.offset(i) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:220:33 [INFO] [stdout] | [INFO] [stdout] 220 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 220 - *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] 220 + *_lhs = *_lhs + _rhs as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 224 | 'loop5: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:228:44 [INFO] [stdout] | [INFO] [stdout] 228 | let _rhs = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 228 - let _rhs = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] 228 + let _rhs = buckets[(i - 1isize) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:229:38 [INFO] [stdout] | [INFO] [stdout] 229 | let _lhs = &mut buckets[i as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 229 - let _lhs = &mut buckets[i as (usize)]; [INFO] [stdout] 229 + let _lhs = &mut buckets[i as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | 'loop7: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:385:36 [INFO] [stdout] | [INFO] [stdout] 385 | y = y - *buf.offset(0isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 385 - y = y - *buf.offset(0isize) as (isize); [INFO] [stdout] 385 + y = y - *buf.offset(0isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:238:22 [INFO] [stdout] | [INFO] [stdout] 238 | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 238 - buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] 238 + buckets[i as usize] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:238:57 [INFO] [stdout] | [INFO] [stdout] 238 | buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 238 - buckets[i as (usize)] = buckets[(i - 1isize) as (usize)]; [INFO] [stdout] 238 + buckets[i as (usize)] = buckets[(i - 1isize) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | 'loop9: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:249:65 [INFO] [stdout] | [INFO] [stdout] 249 | let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 249 - let _lhs = &mut buckets[*old.offset(i) as (usize)]; [INFO] [stdout] 249 + let _lhs = &mut buckets[*old.offset(i) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:250:47 [INFO] [stdout] | [INFO] [stdout] 250 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 250 - *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] 250 + *_lhs = *_lhs + _rhs as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | 'loop11: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:261:50 [INFO] [stdout] | [INFO] [stdout] 261 | *V.offset(i) = buckets[*old.offset(i) as (usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 261 - *V.offset(i) = buckets[*old.offset(i) as (usize)]; [INFO] [stdout] 261 + *V.offset(i) = buckets[*old.offset(i) as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 266 | 'loop13: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:270:25 [INFO] [stdout] | [INFO] [stdout] 270 | if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 270 - if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] 270 + if buckets[i as usize] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:270:61 [INFO] [stdout] | [INFO] [stdout] 270 | if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 270 - if buckets[i as (usize)] == buckets[(i - 1isize) as (usize)] + 1isize { [INFO] [stdout] 270 + if buckets[i as (usize)] == buckets[(i - 1isize) as usize] + 1isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:271:36 [INFO] [stdout] | [INFO] [stdout] 271 | *I.offset(buckets[i as (usize)]) = -1isize; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - *I.offset(buckets[i as (usize)]) = -1isize; [INFO] [stdout] 271 + *I.offset(buckets[i as usize]) = -1isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | 'loop15: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | 'loop22: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 306 | 'loop17: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | 'loop1: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:326:30 [INFO] [stdout] | [INFO] [stdout] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 326 - if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] 326 + if *old.offset(i) as i32 != *new.offset(i) as (i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:326:57 [INFO] [stdout] | [INFO] [stdout] 326 | if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 326 - if *old.offset(i) as (i32) != *new.offset(i) as (i32) { [INFO] [stdout] 326 + if *old.offset(i) as (i32) != *new.offset(i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/diff.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | (if x > y { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 360 | }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 354 ~ if x > y { [INFO] [stdout] 355 | *pos = *I.offset(st); [INFO] [stdout] ... [INFO] [stdout] 359 | y [INFO] [stdout] 360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:387:45 [INFO] [stdout] | [INFO] [stdout] 387 | *buf.offset(1isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 387 - *buf.offset(1isize) = (y % 256isize) as (u8); [INFO] [stdout] 387 + *buf.offset(1isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/diff.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | (if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 373 | }) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 363 ~ if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] 364 | new as (*const libc::c_void), [INFO] [stdout] ... [INFO] [stdout] 372 | search(I, old, oldsize, new, newsize, st, x, pos) [INFO] [stdout] 373 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:363:48 [INFO] [stdout] | [INFO] [stdout] 363 | (if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 363 - (if memcmp(old.offset(*I.offset(x)) as (*const libc::c_void), [INFO] [stdout] 363 + (if memcmp(old.offset(*I.offset(x)) as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:388:36 [INFO] [stdout] | [INFO] [stdout] 388 | y = y - *buf.offset(1isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 388 - y = y - *buf.offset(1isize) as (isize); [INFO] [stdout] 388 + y = y - *buf.offset(1isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:364:27 [INFO] [stdout] | [INFO] [stdout] 364 | new as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 364 - new as (*const libc::c_void), [INFO] [stdout] 364 + new as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:390:45 [INFO] [stdout] | [INFO] [stdout] 390 | *buf.offset(2isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 390 - *buf.offset(2isize) = (y % 256isize) as (u8); [INFO] [stdout] 390 + *buf.offset(2isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:369:25 [INFO] [stdout] | [INFO] [stdout] 369 | } as (usize)) < 0i32 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 369 - } as (usize)) < 0i32 { [INFO] [stdout] 369 + } as usize) < 0i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:391:36 [INFO] [stdout] | [INFO] [stdout] 391 | y = y - *buf.offset(2isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - y = y - *buf.offset(2isize) as (isize); [INFO] [stdout] 391 + y = y - *buf.offset(2isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:384:45 [INFO] [stdout] | [INFO] [stdout] 384 | *buf.offset(0isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 384 - *buf.offset(0isize) = (y % 256isize) as (u8); [INFO] [stdout] 384 + *buf.offset(0isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:393:45 [INFO] [stdout] | [INFO] [stdout] 393 | *buf.offset(3isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 393 - *buf.offset(3isize) = (y % 256isize) as (u8); [INFO] [stdout] 393 + *buf.offset(3isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:385:36 [INFO] [stdout] | [INFO] [stdout] 385 | y = y - *buf.offset(0isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 385 - y = y - *buf.offset(0isize) as (isize); [INFO] [stdout] 385 + y = y - *buf.offset(0isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:394:36 [INFO] [stdout] | [INFO] [stdout] 394 | y = y - *buf.offset(3isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 394 - y = y - *buf.offset(3isize) as (isize); [INFO] [stdout] 394 + y = y - *buf.offset(3isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:387:45 [INFO] [stdout] | [INFO] [stdout] 387 | *buf.offset(1isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 387 - *buf.offset(1isize) = (y % 256isize) as (u8); [INFO] [stdout] 387 + *buf.offset(1isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:396:45 [INFO] [stdout] | [INFO] [stdout] 396 | *buf.offset(4isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 396 - *buf.offset(4isize) = (y % 256isize) as (u8); [INFO] [stdout] 396 + *buf.offset(4isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:388:36 [INFO] [stdout] | [INFO] [stdout] 388 | y = y - *buf.offset(1isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 388 - y = y - *buf.offset(1isize) as (isize); [INFO] [stdout] 388 + y = y - *buf.offset(1isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:397:36 [INFO] [stdout] | [INFO] [stdout] 397 | y = y - *buf.offset(4isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 397 - y = y - *buf.offset(4isize) as (isize); [INFO] [stdout] 397 + y = y - *buf.offset(4isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:390:45 [INFO] [stdout] | [INFO] [stdout] 390 | *buf.offset(2isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 390 - *buf.offset(2isize) = (y % 256isize) as (u8); [INFO] [stdout] 390 + *buf.offset(2isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:399:45 [INFO] [stdout] | [INFO] [stdout] 399 | *buf.offset(5isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 399 - *buf.offset(5isize) = (y % 256isize) as (u8); [INFO] [stdout] 399 + *buf.offset(5isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:391:36 [INFO] [stdout] | [INFO] [stdout] 391 | y = y - *buf.offset(2isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 391 - y = y - *buf.offset(2isize) as (isize); [INFO] [stdout] 391 + y = y - *buf.offset(2isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:400:36 [INFO] [stdout] | [INFO] [stdout] 400 | y = y - *buf.offset(5isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 400 - y = y - *buf.offset(5isize) as (isize); [INFO] [stdout] 400 + y = y - *buf.offset(5isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:393:45 [INFO] [stdout] | [INFO] [stdout] 393 | *buf.offset(3isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 393 - *buf.offset(3isize) = (y % 256isize) as (u8); [INFO] [stdout] 393 + *buf.offset(3isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:394:36 [INFO] [stdout] | [INFO] [stdout] 394 | y = y - *buf.offset(3isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 394 - y = y - *buf.offset(3isize) as (isize); [INFO] [stdout] 394 + y = y - *buf.offset(3isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:396:45 [INFO] [stdout] | [INFO] [stdout] 396 | *buf.offset(4isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 396 - *buf.offset(4isize) = (y % 256isize) as (u8); [INFO] [stdout] 396 + *buf.offset(4isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:397:36 [INFO] [stdout] | [INFO] [stdout] 397 | y = y - *buf.offset(4isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 397 - y = y - *buf.offset(4isize) as (isize); [INFO] [stdout] 397 + y = y - *buf.offset(4isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:399:45 [INFO] [stdout] | [INFO] [stdout] 399 | *buf.offset(5isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 399 - *buf.offset(5isize) = (y % 256isize) as (u8); [INFO] [stdout] 399 + *buf.offset(5isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:402:45 [INFO] [stdout] | [INFO] [stdout] 402 | *buf.offset(6isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 402 - *buf.offset(6isize) = (y % 256isize) as (u8); [INFO] [stdout] 402 + *buf.offset(6isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:403:36 [INFO] [stdout] | [INFO] [stdout] 403 | y = y - *buf.offset(6isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 403 - y = y - *buf.offset(6isize) as (isize); [INFO] [stdout] 403 + y = y - *buf.offset(6isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:405:45 [INFO] [stdout] | [INFO] [stdout] 405 | *buf.offset(7isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 405 - *buf.offset(7isize) = (y % 256isize) as (u8); [INFO] [stdout] 405 + *buf.offset(7isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:409:27 [INFO] [stdout] | [INFO] [stdout] 409 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 409 - *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] 409 + *_lhs = (*_lhs as i32 | _rhs) as (u8); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:409:44 [INFO] [stdout] | [INFO] [stdout] 409 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 409 - *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] 409 + *_lhs = (*_lhs as (i32) | _rhs) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:400:36 [INFO] [stdout] | [INFO] [stdout] 400 | y = y - *buf.offset(5isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 400 - y = y - *buf.offset(5isize) as (isize); [INFO] [stdout] 400 + y = y - *buf.offset(5isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:463:21 [INFO] [stdout] | [INFO] [stdout] 463 | libc::free(V as (*mut libc::c_void)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 463 - libc::free(V as (*mut libc::c_void)); [INFO] [stdout] 463 + libc::free(V as *mut libc::c_void); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:402:45 [INFO] [stdout] | [INFO] [stdout] 402 | *buf.offset(6isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 402 - *buf.offset(6isize) = (y % 256isize) as (u8); [INFO] [stdout] 402 + *buf.offset(6isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:471:5 [INFO] [stdout] | [INFO] [stdout] 471 | 'loop2: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 480 | 'loop5: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:403:36 [INFO] [stdout] | [INFO] [stdout] 403 | y = y - *buf.offset(6isize) as (isize); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 403 - y = y - *buf.offset(6isize) as (isize); [INFO] [stdout] 403 + y = y - *buf.offset(6isize) as isize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:484:31 [INFO] [stdout] | [INFO] [stdout] 484 | len = search(I as (*const isize), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 484 - len = search(I as (*const isize), [INFO] [stdout] 484 + len = search(I as *const isize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:405:45 [INFO] [stdout] | [INFO] [stdout] 405 | *buf.offset(7isize) = (y % 256isize) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 405 - *buf.offset(7isize) = (y % 256isize) as (u8); [INFO] [stdout] 405 + *buf.offset(7isize) = (y % 256isize) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:409:27 [INFO] [stdout] | [INFO] [stdout] 409 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 409 - *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] 409 + *_lhs = (*_lhs as i32 | _rhs) as (u8); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:491:41 [INFO] [stdout] | [INFO] [stdout] 491 | ... &mut pos as (*mut isize)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 491 - &mut pos as (*mut isize)); [INFO] [stdout] 491 + &mut pos as *mut isize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:492:13 [INFO] [stdout] | [INFO] [stdout] 492 | 'loop7: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:409:44 [INFO] [stdout] | [INFO] [stdout] 409 | *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 409 - *_lhs = (*_lhs as (i32) | _rhs) as (u8); [INFO] [stdout] 409 + *_lhs = (*_lhs as (i32) | _rhs) as u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:497:60 [INFO] [stdout] | [INFO] [stdout] 497 | (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 497 - (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stdout] 497 + (*req.old.offset(scsc + lastoffset) as i32 == [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:463:21 [INFO] [stdout] | [INFO] [stdout] 463 | libc::free(V as (*mut libc::c_void)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 463 - libc::free(V as (*mut libc::c_void)); [INFO] [stdout] 463 + libc::free(V as *mut libc::c_void); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:471:5 [INFO] [stdout] | [INFO] [stdout] 471 | 'loop2: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 480 | 'loop5: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:498:46 [INFO] [stdout] | [INFO] [stdout] 498 | *req.new.offset(scsc) as (i32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 498 - *req.new.offset(scsc) as (i32)) { [INFO] [stdout] 498 + *req.new.offset(scsc) as i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:484:31 [INFO] [stdout] | [INFO] [stdout] 484 | len = search(I as (*const isize), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 484 - len = search(I as (*const isize), [INFO] [stdout] 484 + len = search(I as *const isize, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:507:56 [INFO] [stdout] | [INFO] [stdout] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 507 - (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] 507 + (*req.old.offset(scan + lastoffset) as i32 == *req.new.offset(scan) as (i32)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:491:41 [INFO] [stdout] | [INFO] [stdout] 491 | ... &mut pos as (*mut isize)); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 491 - &mut pos as (*mut isize)); [INFO] [stdout] 491 + &mut pos as *mut isize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:492:13 [INFO] [stdout] | [INFO] [stdout] 492 | 'loop7: loop { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:507:90 [INFO] [stdout] | [INFO] [stdout] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 507 - (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] 507 + (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:497:60 [INFO] [stdout] | [INFO] [stdout] 497 | (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 497 - (*req.old.offset(scsc + lastoffset) as (i32) == [INFO] [stdout] 497 + (*req.old.offset(scsc + lastoffset) as i32 == [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:519:9 [INFO] [stdout] | [INFO] [stdout] 519 | 'loop14: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:498:46 [INFO] [stdout] | [INFO] [stdout] 498 | *req.new.offset(scsc) as (i32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 498 - *req.new.offset(scsc) as (i32)) { [INFO] [stdout] 498 + *req.new.offset(scsc) as i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:523:48 [INFO] [stdout] | [INFO] [stdout] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 523 - if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] 523 + if *req.old.offset(lastpos + i) as i32 == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:523:90 [INFO] [stdout] | [INFO] [stdout] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 523 - if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] 523 + if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:538:13 [INFO] [stdout] | [INFO] [stdout] 538 | 'loop17: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:507:56 [INFO] [stdout] | [INFO] [stdout] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 507 - (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] 507 + (*req.old.offset(scan + lastoffset) as i32 == *req.new.offset(scan) as (i32)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:542:48 [INFO] [stdout] | [INFO] [stdout] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] 542 + if *req.old.offset(pos - i) as i32 == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:542:86 [INFO] [stdout] | [INFO] [stdout] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] 542 + if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:558:13 [INFO] [stdout] | [INFO] [stdout] 558 | 'loop20: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:562:70 [INFO] [stdout] | [INFO] [stdout] 562 | if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 562 - if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stdout] 562 + if *req.new.offset(lastscan + lenf - overlap + i) as i32 == [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:563:70 [INFO] [stdout] | [INFO] [stdout] 563 | *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 563 - *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stdout] 563 + *req.old.offset(lastpos + lenf - overlap + i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:566:56 [INFO] [stdout] | [INFO] [stdout] 566 | if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 566 - if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stdout] 566 + if *req.new.offset(scan - lenb + i) as i32 == [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:567:56 [INFO] [stdout] | [INFO] [stdout] 567 | *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 567 - *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stdout] 567 + *req.old.offset(pos - lenb + i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:585:45 [INFO] [stdout] | [INFO] [stdout] 585 | buf.as_mut_ptr() as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 585 - buf.as_mut_ptr() as (*const libc::c_void), [INFO] [stdout] 585 + buf.as_mut_ptr() as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:586:62 [INFO] [stdout] | [INFO] [stdout] 586 | ::std::mem::size_of::<[u8; 24]>() as (isize))?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 586 - ::std::mem::size_of::<[u8; 24]>() as (isize))?; [INFO] [stdout] 586 + ::std::mem::size_of::<[u8; 24]>() as isize)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:588:9 [INFO] [stdout] | [INFO] [stdout] 588 | 'loop24: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:592:67 [INFO] [stdout] | [INFO] [stdout] 592 | *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 592 - *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stdout] 592 + *buffer.offset(i) = (*req.new.offset(lastscan + i) as i32 - [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:593:69 [INFO] [stdout] | [INFO] [stdout] 593 | ... *req.old.offset(lastpos + i) as (i32)) as [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 593 - *req.old.offset(lastpos + i) as (i32)) as [INFO] [stdout] 593 + *req.old.offset(lastpos + i) as i32) as [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:594:33 [INFO] [stdout] | [INFO] [stdout] 594 | ... (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 594 - (u8); [INFO] [stdout] 594 + u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:507:90 [INFO] [stdout] | [INFO] [stdout] 507 | (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 507 - (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as (i32)) { [INFO] [stdout] 507 + (*req.old.offset(scan + lastoffset) as (i32) == *req.new.offset(scan) as i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:519:9 [INFO] [stdout] | [INFO] [stdout] 519 | 'loop14: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:523:48 [INFO] [stdout] | [INFO] [stdout] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 523 - if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] 523 + if *req.old.offset(lastpos + i) as i32 == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:523:90 [INFO] [stdout] | [INFO] [stdout] 523 | if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 523 - if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as (i32) { [INFO] [stdout] 523 + if *req.old.offset(lastpos + i) as (i32) == *req.new.offset(lastscan + i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:538:13 [INFO] [stdout] | [INFO] [stdout] 538 | 'loop17: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:542:48 [INFO] [stdout] | [INFO] [stdout] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] 542 + if *req.old.offset(pos - i) as i32 == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:542:86 [INFO] [stdout] | [INFO] [stdout] 542 | if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 542 - if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as (i32) { [INFO] [stdout] 542 + if *req.old.offset(pos - i) as (i32) == *req.new.offset(scan - i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:558:13 [INFO] [stdout] | [INFO] [stdout] 558 | 'loop20: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:562:70 [INFO] [stdout] | [INFO] [stdout] 562 | if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 562 - if *req.new.offset(lastscan + lenf - overlap + i) as (i32) == [INFO] [stdout] 562 + if *req.new.offset(lastscan + lenf - overlap + i) as i32 == [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:563:70 [INFO] [stdout] | [INFO] [stdout] 563 | *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 563 - *req.old.offset(lastpos + lenf - overlap + i) as (i32) { [INFO] [stdout] 563 + *req.old.offset(lastpos + lenf - overlap + i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:566:56 [INFO] [stdout] | [INFO] [stdout] 566 | if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 566 - if *req.new.offset(scan - lenb + i) as (i32) == [INFO] [stdout] 566 + if *req.new.offset(scan - lenb + i) as i32 == [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:567:56 [INFO] [stdout] | [INFO] [stdout] 567 | *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 567 - *req.old.offset(pos - lenb + i) as (i32) { [INFO] [stdout] 567 + *req.old.offset(pos - lenb + i) as i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:597:37 [INFO] [stdout] | [INFO] [stdout] 597 | writedata(writer, buffer as (*const libc::c_void), lenf)?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 597 - writedata(writer, buffer as (*const libc::c_void), lenf)?; [INFO] [stdout] 597 + writedata(writer, buffer as *const libc::c_void, lenf)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:599:9 [INFO] [stdout] | [INFO] [stdout] 599 | 'loop27: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:607:35 [INFO] [stdout] | [INFO] [stdout] 607 | buffer as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 607 - buffer as (*const libc::c_void), [INFO] [stdout] 607 + buffer as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] 91 + y = (buf[7] as i32 & 0x7Fi32) as (i64); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] 91 + y = (buf[7] as (i32) & 0x7Fi32) as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 93 | y = y + buf[6] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 93 - y = y + buf[6] as (i64); [INFO] [stdout] 93 + y = y + buf[6] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 95 | y = y + buf[5] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - y = y + buf[5] as (i64); [INFO] [stdout] 95 + y = y + buf[5] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 97 | y = y + buf[4] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 97 - y = y + buf[4] as (i64); [INFO] [stdout] 97 + y = y + buf[4] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:99:23 [INFO] [stdout] | [INFO] [stdout] 99 | y = y + buf[3] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 99 - y = y + buf[3] as (i64); [INFO] [stdout] 99 + y = y + buf[3] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:101:23 [INFO] [stdout] | [INFO] [stdout] 101 | y = y + buf[2] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - y = y + buf[2] as (i64); [INFO] [stdout] 101 + y = y + buf[2] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:103:23 [INFO] [stdout] | [INFO] [stdout] 103 | y = y + buf[1] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 103 - y = y + buf[1] as (i64); [INFO] [stdout] 103 + y = y + buf[1] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:105:23 [INFO] [stdout] | [INFO] [stdout] 105 | y = y + buf[0] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 105 - y = y + buf[0] as (i64); [INFO] [stdout] 105 + y = y + buf[0] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stdout] 106 + if buf[7] as i32 & 0x80i32 != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:585:45 [INFO] [stdout] | [INFO] [stdout] 585 | buf.as_mut_ptr() as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 585 - buf.as_mut_ptr() as (*const libc::c_void), [INFO] [stdout] 585 + buf.as_mut_ptr() as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:586:62 [INFO] [stdout] | [INFO] [stdout] 586 | ::std::mem::size_of::<[u8; 24]>() as (isize))?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 586 - ::std::mem::size_of::<[u8; 24]>() as (isize))?; [INFO] [stdout] 586 + ::std::mem::size_of::<[u8; 24]>() as isize)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:588:9 [INFO] [stdout] | [INFO] [stdout] 588 | 'loop24: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:592:67 [INFO] [stdout] | [INFO] [stdout] 592 | *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 592 - *buffer.offset(i) = (*req.new.offset(lastscan + i) as (i32) - [INFO] [stdout] 592 + *buffer.offset(i) = (*req.new.offset(lastscan + i) as i32 - [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:593:69 [INFO] [stdout] | [INFO] [stdout] 593 | ... *req.old.offset(lastpos + i) as (i32)) as [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 593 - *req.old.offset(lastpos + i) as (i32)) as [INFO] [stdout] 593 + *req.old.offset(lastpos + i) as i32) as [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:594:33 [INFO] [stdout] | [INFO] [stdout] 594 | ... (u8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 594 - (u8); [INFO] [stdout] 594 + u8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:597:37 [INFO] [stdout] | [INFO] [stdout] 597 | writedata(writer, buffer as (*const libc::c_void), lenf)?; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 597 - writedata(writer, buffer as (*const libc::c_void), lenf)?; [INFO] [stdout] 597 + writedata(writer, buffer as *const libc::c_void, lenf)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused label [INFO] [stdout] --> src/diff.rs:599:9 [INFO] [stdout] | [INFO] [stdout] 599 | 'loop27: loop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diff.rs:607:35 [INFO] [stdout] | [INFO] [stdout] 607 | buffer as (*const libc::c_void), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 607 - buffer as (*const libc::c_void), [INFO] [stdout] 607 + buffer as *const libc::c_void, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] 91 + y = (buf[7] as i32 & 0x7Fi32) as (i64); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 91 - y = (buf[7] as (i32) & 0x7Fi32) as (i64); [INFO] [stdout] 91 + y = (buf[7] as (i32) & 0x7Fi32) as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:93:23 [INFO] [stdout] | [INFO] [stdout] 93 | y = y + buf[6] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 93 - y = y + buf[6] as (i64); [INFO] [stdout] 93 + y = y + buf[6] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 95 | y = y + buf[5] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 95 - y = y + buf[5] as (i64); [INFO] [stdout] 95 + y = y + buf[5] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 97 | y = y + buf[4] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 97 - y = y + buf[4] as (i64); [INFO] [stdout] 97 + y = y + buf[4] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:99:23 [INFO] [stdout] | [INFO] [stdout] 99 | y = y + buf[3] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 99 - y = y + buf[3] as (i64); [INFO] [stdout] 99 + y = y + buf[3] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:101:23 [INFO] [stdout] | [INFO] [stdout] 101 | y = y + buf[2] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 101 - y = y + buf[2] as (i64); [INFO] [stdout] 101 + y = y + buf[2] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:103:23 [INFO] [stdout] | [INFO] [stdout] 103 | y = y + buf[1] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 103 - y = y + buf[1] as (i64); [INFO] [stdout] 103 + y = y + buf[1] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:105:23 [INFO] [stdout] | [INFO] [stdout] 105 | y = y + buf[0] as (i64); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 105 - y = y + buf[0] as (i64); [INFO] [stdout] 105 + y = y + buf[0] as i64; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/patch.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - if buf[7] as (i32) & 0x80i32 != 0 { [INFO] [stdout] 106 + if buf[7] as i32 & 0x80i32 != 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/diff.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | if I == ptr::null_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `I.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] = note: `#[warn(clippy::cmp_null)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/diff.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc I.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc I.")); [INFO] [stdout] 46 + return Err(io::Error::other("Failed to malloc I.")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/diff.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if buffer == ptr::null_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/diff.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc buffer.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 52 - return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc buffer.")); [INFO] [stdout] 52 + return Err(io::Error::other("Failed to malloc buffer.")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:92:16 [INFO] [stdout] | [INFO] [stdout] 92 | if !(k < start + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(k >= start + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | if !(k + i < start + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(k + i >= start + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 116 | if !(i < j) { [INFO] [stdout] | ^^^^^^^^ help: try: `(i >= j)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | if !(i < start + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= start + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/diff.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | if I == ptr::null_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `I.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] = note: `#[warn(clippy::cmp_null)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/diff.rs:46:24 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc I.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc I.")); [INFO] [stdout] 46 + return Err(io::Error::other("Failed to malloc I.")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !(i < jj) { [INFO] [stdout] | ^^^^^^^^^ help: try: `(i >= jj)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 168 | if !(jj + j < kk) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(jj + j >= kk)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/diff.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if buffer == ptr::null_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | if !(i < kk - jj) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= kk - jj)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/diff.rs:52:24 [INFO] [stdout] | [INFO] [stdout] 52 | return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc buffer.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 52 - return Err(io::Error::new(io::ErrorKind::Other, "Failed to malloc buffer.")); [INFO] [stdout] 52 + return Err(io::Error::other("Failed to malloc buffer.")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:92:16 [INFO] [stdout] | [INFO] [stdout] 92 | if !(k < start + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(k >= start + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | if !(k + i < start + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(k + i >= start + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 116 | if !(i < j) { [INFO] [stdout] | ^^^^^^^^ help: try: `(i >= j)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | if !(i < start + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= start + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !(i < jj) { [INFO] [stdout] | ^^^^^^^^^ help: try: `(i >= jj)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 168 | if !(jj + j < kk) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(jj + j >= kk)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | if !(i < kk - jj) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= kk - jj)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | j = j + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 110 | j = j + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | k = k + j; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `k += j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | jj = jj + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `jj += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | k = k + j; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `k += j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | jj = jj + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `jj += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | kk = kk + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `kk += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | kk = kk + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `kk += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | jj = jj + start; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `jj += start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | kk = kk + jj; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `kk += jj` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:159:17 [INFO] [stdout] | [INFO] [stdout] 159 | j = j + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | jj = jj + start; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `jj += start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | kk = kk + jj; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `kk += jj` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 164 | k = k + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:159:17 [INFO] [stdout] | [INFO] [stdout] 159 | j = j + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 164 | k = k + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | j = j + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | j = j + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `j += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:177:17 [INFO] [stdout] | [INFO] [stdout] 177 | k = k + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:177:17 [INFO] [stdout] | [INFO] [stdout] 177 | k = k + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `k += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 207 | if !(i < 256isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i >= 256isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if !(i < oldsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= oldsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 207 | if !(i < 256isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i >= 256isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 225 | if !(i < 256isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i >= 256isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if !(i < oldsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= oldsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 235 | if !(i > 0isize) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(i <= 0isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 225 | if !(i < 256isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i >= 256isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 244 | if !(i < oldsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= oldsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 258 | if !(i < oldsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= oldsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 267 | if !(i < 256isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i >= 256isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 278 | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*I.offset(0isize) == -(oldsize + 1isize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:284:16 [INFO] [stdout] | [INFO] [stdout] 284 | if !(i < oldsize + 1isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i >= oldsize + 1isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 307 | if !(i < oldsize + 1isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i >= oldsize + 1isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 235 | if !(i > 0isize) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(i <= 0isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 244 | if !(i < oldsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= oldsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 258 | if !(i < oldsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= oldsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 267 | if !(i < 256isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i >= 256isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 278 | if !(*I.offset(0isize) != -(oldsize + 1isize)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*I.offset(0isize) == -(oldsize + 1isize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:284:16 [INFO] [stdout] | [INFO] [stdout] 284 | if !(i < oldsize + 1isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i >= oldsize + 1isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 307 | if !(i < oldsize + 1isize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i >= oldsize + 1isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | *_lhs = *_lhs + _rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | *_lhs = *_lhs + _rhs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | i = i - 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i -= 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | i = i - 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i -= 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:250:23 [INFO] [stdout] | [INFO] [stdout] 250 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:250:23 [INFO] [stdout] | [INFO] [stdout] 250 | *_lhs = *_lhs + _rhs as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*_lhs += _rhs as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | len = len - *I.offset(i); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len -= *I.offset(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | len = len - *I.offset(i); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `len -= *I.offset(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:296:17 [INFO] [stdout] | [INFO] [stdout] 296 | i = i + len; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `i += len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:296:17 [INFO] [stdout] | [INFO] [stdout] 296 | i = i + len; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `i += len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 329 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/diff.rs:334:1 [INFO] [stdout] | [INFO] [stdout] 334 | / unsafe fn search(mut I: *const isize, [INFO] [stdout] 335 | | mut old: *const u8, [INFO] [stdout] 336 | | mut oldsize: isize, [INFO] [stdout] 337 | | mut new: *const u8, [INFO] [stdout] ... | [INFO] [stdout] 341 | | mut pos: *mut isize) [INFO] [stdout] 342 | | -> isize { [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/diff.rs:334:1 [INFO] [stdout] | [INFO] [stdout] 334 | / unsafe fn search(mut I: *const isize, [INFO] [stdout] 335 | | mut old: *const u8, [INFO] [stdout] 336 | | mut oldsize: isize, [INFO] [stdout] 337 | | mut new: *const u8, [INFO] [stdout] ... | [INFO] [stdout] 341 | | mut pos: *mut isize) [INFO] [stdout] 342 | | -> isize { [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:385:5 [INFO] [stdout] | [INFO] [stdout] 385 | y = y - *buf.offset(0isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(0isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:385:5 [INFO] [stdout] | [INFO] [stdout] 385 | y = y - *buf.offset(0isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(0isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:386:5 [INFO] [stdout] | [INFO] [stdout] 386 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:386:5 [INFO] [stdout] | [INFO] [stdout] 386 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:388:5 [INFO] [stdout] | [INFO] [stdout] 388 | y = y - *buf.offset(1isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(1isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:388:5 [INFO] [stdout] | [INFO] [stdout] 388 | y = y - *buf.offset(1isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(1isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 389 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 389 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | y = y - *buf.offset(2isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(2isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | y = y - *buf.offset(2isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(2isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:392:5 [INFO] [stdout] | [INFO] [stdout] 392 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:392:5 [INFO] [stdout] | [INFO] [stdout] 392 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 394 | y = y - *buf.offset(3isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(3isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 394 | y = y - *buf.offset(3isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(3isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:395:5 [INFO] [stdout] | [INFO] [stdout] 395 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:395:5 [INFO] [stdout] | [INFO] [stdout] 395 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:397:5 [INFO] [stdout] | [INFO] [stdout] 397 | y = y - *buf.offset(4isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(4isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:397:5 [INFO] [stdout] | [INFO] [stdout] 397 | y = y - *buf.offset(4isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(4isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 398 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:398:5 [INFO] [stdout] | [INFO] [stdout] 398 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | y = y - *buf.offset(5isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(5isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | y = y - *buf.offset(5isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(5isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:401:5 [INFO] [stdout] | [INFO] [stdout] 401 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:401:5 [INFO] [stdout] | [INFO] [stdout] 401 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | y = y - *buf.offset(6isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(6isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | y = y - *buf.offset(6isize) as (isize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= *buf.offset(6isize) as (isize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:404:5 [INFO] [stdout] | [INFO] [stdout] 404 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:404:5 [INFO] [stdout] | [INFO] [stdout] 404 | y = y / 256isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `y /= 256isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:417:22 [INFO] [stdout] | [INFO] [stdout] 417 | writer.write_all(&slice::from_raw_parts(buffer as *mut u8, length as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `slice::from_raw_parts(buffer as *mut u8, length as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:472:12 [INFO] [stdout] | [INFO] [stdout] 472 | if !(scan < req.newsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(scan >= req.newsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:481:16 [INFO] [stdout] | [INFO] [stdout] 481 | if !(scan < req.newsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(scan >= req.newsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:493:20 [INFO] [stdout] | [INFO] [stdout] 493 | if !(scsc < scan + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(scsc >= scan + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:527:16 [INFO] [stdout] | [INFO] [stdout] 527 | if !(s * 2isize - i > Sf * 2isize - lenf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(s * 2isize - i <= Sf * 2isize - lenf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:559:20 [INFO] [stdout] | [INFO] [stdout] 559 | if !(i < overlap) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= overlap)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:589:16 [INFO] [stdout] | [INFO] [stdout] 589 | if !(i < lenf) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(i >= lenf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:600:16 [INFO] [stdout] | [INFO] [stdout] 600 | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i >= scan - lenb - (lastscan + lenf))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/diff.rs:458:8 [INFO] [stdout] | [INFO] [stdout] 458 | if V == ptr::null_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `V.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/diff.rs:459:20 [INFO] [stdout] | [INFO] [stdout] 459 | return Err(io::Error::new(io::ErrorKind::Other, "Failed to allocate V.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 459 - return Err(io::Error::new(io::ErrorKind::Other, "Failed to allocate V.")); [INFO] [stdout] 459 + return Err(io::Error::other("Failed to allocate V.")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:477:13 [INFO] [stdout] | [INFO] [stdout] 477 | scan = scan + len; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `scan += len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:499:21 [INFO] [stdout] | [INFO] [stdout] 499 | oldscore = oldscore + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:501:17 [INFO] [stdout] | [INFO] [stdout] 501 | scsc = scsc + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scsc += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:508:17 [INFO] [stdout] | [INFO] [stdout] 508 | oldscore = oldscore - 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore -= 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:510:13 [INFO] [stdout] | [INFO] [stdout] 510 | scan = scan + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:524:17 [INFO] [stdout] | [INFO] [stdout] 524 | s = s + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:526:13 [INFO] [stdout] | [INFO] [stdout] 526 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:543:21 [INFO] [stdout] | [INFO] [stdout] 543 | s = s + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:549:17 [INFO] [stdout] | [INFO] [stdout] 549 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:564:21 [INFO] [stdout] | [INFO] [stdout] 564 | s = s + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:568:21 [INFO] [stdout] | [INFO] [stdout] 568 | s = s - 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s -= 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:574:17 [INFO] [stdout] | [INFO] [stdout] 574 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:576:13 [INFO] [stdout] | [INFO] [stdout] 576 | lenf = lenf + (lens - overlap); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lenf += (lens - overlap)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:577:13 [INFO] [stdout] | [INFO] [stdout] 577 | lenb = lenb - lens; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lenb -= lens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:595:13 [INFO] [stdout] | [INFO] [stdout] 595 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:604:13 [INFO] [stdout] | [INFO] [stdout] 604 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `ctrl` [INFO] [stdout] --> src/patch.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 46 | for i in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 46 - for i in 0..3 { [INFO] [stdout] 46 + for in &mut ctrl { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/patch.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if newpos as i64 + ctrl[0] > new.len() as i64 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `newpos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | y = y + buf[6] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[6] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | y = y + buf[5] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[5] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | y = y + buf[4] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[4] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | y = y + buf[3] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[3] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | y = y + buf[2] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[2] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | y = y + buf[1] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[1] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | y = y + buf[0] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[0] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/diff.rs:417:22 [INFO] [stdout] | [INFO] [stdout] 417 | writer.write_all(&slice::from_raw_parts(buffer as *mut u8, length as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `slice::from_raw_parts(buffer as *mut u8, length as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:472:12 [INFO] [stdout] | [INFO] [stdout] 472 | if !(scan < req.newsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(scan >= req.newsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:481:16 [INFO] [stdout] | [INFO] [stdout] 481 | if !(scan < req.newsize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(scan >= req.newsize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:493:20 [INFO] [stdout] | [INFO] [stdout] 493 | if !(scsc < scan + len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(scsc >= scan + len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:527:16 [INFO] [stdout] | [INFO] [stdout] 527 | if !(s * 2isize - i > Sf * 2isize - lenf) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(s * 2isize - i <= Sf * 2isize - lenf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:559:20 [INFO] [stdout] | [INFO] [stdout] 559 | if !(i < overlap) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(i >= overlap)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:589:16 [INFO] [stdout] | [INFO] [stdout] 589 | if !(i < lenf) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(i >= lenf)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/diff.rs:600:16 [INFO] [stdout] | [INFO] [stdout] 600 | if !(i < scan - lenb - (lastscan + lenf)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i >= scan - lenb - (lastscan + lenf))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/diff.rs:458:8 [INFO] [stdout] | [INFO] [stdout] 458 | if V == ptr::null_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `V.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/diff.rs:459:20 [INFO] [stdout] | [INFO] [stdout] 459 | return Err(io::Error::new(io::ErrorKind::Other, "Failed to allocate V.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 459 - return Err(io::Error::new(io::ErrorKind::Other, "Failed to allocate V.")); [INFO] [stdout] 459 + return Err(io::Error::other("Failed to allocate V.")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:477:13 [INFO] [stdout] | [INFO] [stdout] 477 | scan = scan + len; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `scan += len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:499:21 [INFO] [stdout] | [INFO] [stdout] 499 | oldscore = oldscore + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:501:17 [INFO] [stdout] | [INFO] [stdout] 501 | scsc = scsc + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scsc += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:508:17 [INFO] [stdout] | [INFO] [stdout] 508 | oldscore = oldscore - 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oldscore -= 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:510:13 [INFO] [stdout] | [INFO] [stdout] 510 | scan = scan + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:524:17 [INFO] [stdout] | [INFO] [stdout] 524 | s = s + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:526:13 [INFO] [stdout] | [INFO] [stdout] 526 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:543:21 [INFO] [stdout] | [INFO] [stdout] 543 | s = s + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:549:17 [INFO] [stdout] | [INFO] [stdout] 549 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:564:21 [INFO] [stdout] | [INFO] [stdout] 564 | s = s + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:568:21 [INFO] [stdout] | [INFO] [stdout] 568 | s = s - 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `s -= 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:574:17 [INFO] [stdout] | [INFO] [stdout] 574 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:576:13 [INFO] [stdout] | [INFO] [stdout] 576 | lenf = lenf + (lens - overlap); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lenf += (lens - overlap)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:577:13 [INFO] [stdout] | [INFO] [stdout] 577 | lenb = lenb - lens; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lenb -= lens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:595:13 [INFO] [stdout] | [INFO] [stdout] 595 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/diff.rs:604:13 [INFO] [stdout] | [INFO] [stdout] 604 | i = i + 1isize; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `i += 1isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `ctrl` [INFO] [stdout] --> src/patch.rs:46:18 [INFO] [stdout] | [INFO] [stdout] 46 | for i in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 46 - for i in 0..3 { [INFO] [stdout] 46 + for in &mut ctrl { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i64` -> `i64`) [INFO] [stdout] --> src/patch.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if newpos as i64 + ctrl[0] > new.len() as i64 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `newpos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | y = y + buf[6] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[6] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | y = y + buf[5] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[5] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | y = y + buf[4] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[4] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | y = y + buf[3] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[3] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | y = y + buf[2] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[2] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | y = y + buf[1] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[1] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | y = y * 256; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `y *= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/patch.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | y = y + buf[0] as (i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += buf[0] as (i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `Command { std: "docker" "inspect" "4b9371565e21a65ae16386d55bf4b9061c8d608046ab0a45d638891c00fb82f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b9371565e21a65ae16386d55bf4b9061c8d608046ab0a45d638891c00fb82f6", kill_on_drop: false }` [INFO] [stdout] 4b9371565e21a65ae16386d55bf4b9061c8d608046ab0a45d638891c00fb82f6