[INFO] cloning repository https://github.com/OzanBarsal/aoc-2024-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/OzanBarsal/aoc-2024-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOzanBarsal%2Faoc-2024-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOzanBarsal%2Faoc-2024-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 80588ab20ef08aa634c7c837ddf6730d5db96dfc [INFO] linting OzanBarsal/aoc-2024-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOzanBarsal%2Faoc-2024-rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/OzanBarsal/aoc-2024-rust [INFO] finished tweaking git repo https://github.com/OzanBarsal/aoc-2024-rust [INFO] tweaked toml for git repo https://github.com/OzanBarsal/aoc-2024-rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/OzanBarsal/aoc-2024-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/OzanBarsal/aoc-2024-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5ec87f10596a3c9ff0f3b5202b40eb5af9ebbe8405c76b4d1f7dd095e1437b0 [INFO] running `Command { std: "docker" "start" "-a" "f5ec87f10596a3c9ff0f3b5202b40eb5af9ebbe8405c76b4d1f7dd095e1437b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5ec87f10596a3c9ff0f3b5202b40eb5af9ebbe8405c76b4d1f7dd095e1437b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5ec87f10596a3c9ff0f3b5202b40eb5af9ebbe8405c76b4d1f7dd095e1437b0", kill_on_drop: false }` [INFO] [stdout] f5ec87f10596a3c9ff0f3b5202b40eb5af9ebbe8405c76b4d1f7dd095e1437b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f679f39d4a4fd03f8bad110eca1be2450f8a8a631255b53af7b800b9338dca67 [INFO] running `Command { std: "docker" "start" "-a" "f679f39d4a4fd03f8bad110eca1be2450f8a8a631255b53af7b800b9338dca67", kill_on_drop: false }` [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking fancy-regex v0.14.0 [INFO] [stderr] Checking aoc-2024-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the loop variable `i` is only used to index `cols` [INFO] [stdout] --> src/day1.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | for i in 0..cols[0].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 30 - for i in 0..cols[0].len() { [INFO] [stdout] 30 + for in cols.iter().take(cols[0].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day2.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | fn validate_line(values: &Vec) -> Result<(), usize> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn validate_line(values: &Vec) -> Result<(), usize> { [INFO] [stdout] 3 + fn validate_line(values: &[i32]) -> Result<(), usize> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day3.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | rx.captures_iter(&input).fold(0, |acc, result| { [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 20 | rows: &Vec<&str>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - rows: &Vec<&str>, [INFO] [stdout] 20 + rows: &[&str], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day4.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !check_direction_for_letter(x_coord, y_coord, rows, direction, letter).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_direction_for_letter(x_coord, y_coord, rows, direction, letter).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:32 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] 3 + pub fn count_occurrences(vec1: &[String], vec2: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:52 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] 3 + pub fn count_occurrences(vec1: &Vec, vec2: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `cols` [INFO] [stdout] --> src/day1.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | for i in 0..cols[0].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 30 - for i in 0..cols[0].len() { [INFO] [stdout] 30 + for in cols.iter().take(cols[0].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day2.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | fn validate_line(values: &Vec) -> Result<(), usize> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn validate_line(values: &Vec) -> Result<(), usize> { [INFO] [stdout] 3 + fn validate_line(values: &[i32]) -> Result<(), usize> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day3.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | rx.captures_iter(&input).fold(0, |acc, result| { [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 20 | rows: &Vec<&str>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - rows: &Vec<&str>, [INFO] [stdout] 20 + rows: &[&str], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day4.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !check_direction_for_letter(x_coord, y_coord, rows, direction, letter).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_direction_for_letter(x_coord, y_coord, rows, direction, letter).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:32 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] 3 + pub fn count_occurrences(vec1: &[String], vec2: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:3:52 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn count_occurrences(vec1: &Vec, vec2: &Vec) -> Vec { [INFO] [stdout] 3 + pub fn count_occurrences(vec1: &Vec, vec2: &[String]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.10s [INFO] running `Command { std: "docker" "inspect" "f679f39d4a4fd03f8bad110eca1be2450f8a8a631255b53af7b800b9338dca67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f679f39d4a4fd03f8bad110eca1be2450f8a8a631255b53af7b800b9338dca67", kill_on_drop: false }` [INFO] [stdout] f679f39d4a4fd03f8bad110eca1be2450f8a8a631255b53af7b800b9338dca67