[INFO] cloning repository https://github.com/Osso/browser-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Osso/browser-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOsso%2Fbrowser-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOsso%2Fbrowser-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 05d46a3d744d4e4b160322a6e993fcc8109800ae [INFO] linting Osso/browser-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOsso%2Fbrowser-cli" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Osso/browser-cli [INFO] finished tweaking git repo https://github.com/Osso/browser-cli [INFO] tweaked toml for git repo https://github.com/Osso/browser-cli written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Osso/browser-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Osso/browser-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zmij v1.0.18 [INFO] [stderr] Downloaded data-encoding v2.10.0 [INFO] [stderr] Downloaded clap v4.5.56 [INFO] [stderr] Downloaded clap_builder v4.5.56 [INFO] [stderr] Downloaded cc v1.2.55 [INFO] [stderr] Downloaded zerocopy-derive v0.8.37 [INFO] [stderr] Downloaded zerocopy v0.8.37 [INFO] [stderr] Downloaded rustls v0.23.36 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 476ac67556cd22ac676211407d5943c171207d1755d37bc443ff152b73740a01 [INFO] running `Command { std: "docker" "start" "-a" "476ac67556cd22ac676211407d5943c171207d1755d37bc443ff152b73740a01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "476ac67556cd22ac676211407d5943c171207d1755d37bc443ff152b73740a01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "476ac67556cd22ac676211407d5943c171207d1755d37bc443ff152b73740a01", kill_on_drop: false }` [INFO] [stdout] 476ac67556cd22ac676211407d5943c171207d1755d37bc443ff152b73740a01 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f18db1e9f7f8e8f6773493e789b7792c2c6075528f20cb69e142b37457758077 [INFO] running `Command { std: "docker" "start" "-a" "f18db1e9f7f8e8f6773493e789b7792c2c6075528f20cb69e142b37457758077", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling zerocopy v0.8.37 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling zmij v1.0.18 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking clap_builder v4.5.56 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.56 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking browser-cli v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/cdp.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / for candidate in CANDIDATES { [INFO] [stdout] 89 | | if std::process::Command::new("which") [INFO] [stdout] 90 | | .arg(candidate) [INFO] [stdout] 91 | | .output() [INFO] [stdout] ... | [INFO] [stdout] 98 | | None [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] help: replace with an iterator [INFO] [stdout] | [INFO] [stdout] 88 ~ CANDIDATES.iter().find(|&candidate| std::process::Command::new("which") [INFO] [stdout] 89 + .arg(candidate) [INFO] [stdout] 90 + .output() [INFO] [stdout] 91 + .map(|o| o.status.success()) [INFO] [stdout] 92 + .unwrap_or(false)).map(|v| v as _) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 | / pub async fn cmd_snapshot( [INFO] [stdout] 144 | | port: u16, [INFO] [stdout] 145 | | interactive: bool, [INFO] [stdout] 146 | | compact: bool, [INFO] [stdout] ... | [INFO] [stdout] 151 | | mini: bool, [INFO] [stdout] 152 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/cdp.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / for candidate in CANDIDATES { [INFO] [stdout] 89 | | if std::process::Command::new("which") [INFO] [stdout] 90 | | .arg(candidate) [INFO] [stdout] 91 | | .output() [INFO] [stdout] ... | [INFO] [stdout] 98 | | None [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] help: replace with an iterator [INFO] [stdout] | [INFO] [stdout] 88 ~ CANDIDATES.iter().find(|&candidate| std::process::Command::new("which") [INFO] [stdout] 89 + .arg(candidate) [INFO] [stdout] 90 + .output() [INFO] [stdout] 91 + .map(|o| o.status.success()) [INFO] [stdout] 92 + .unwrap_or(false)).map(|v| v as _) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 216 | | if depth > max { [INFO] [stdout] 217 | | return; [INFO] [stdout] 218 | | } [INFO] [stdout] 219 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 216 ~ && depth > max { [INFO] [stdout] 217 | return; [INFO] [stdout] 218 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:324:5 [INFO] [stdout] | [INFO] [stdout] 324 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 325 | | if depth > max { [INFO] [stdout] 326 | | return; [INFO] [stdout] 327 | | } [INFO] [stdout] 328 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 324 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 325 ~ && depth > max { [INFO] [stdout] 326 | return; [INFO] [stdout] 327 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 347 | / if !node.is_component { [INFO] [stdout] 348 | | if let Some(ref name) = node.aria_name { [INFO] [stdout] 349 | | line.push_str(&format!(" \"{}\"", name)); [INFO] [stdout] 350 | | } [INFO] [stdout] 351 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 347 ~ if !node.is_component [INFO] [stdout] 348 ~ && let Some(ref name) = node.aria_name { [INFO] [stdout] 349 | line.push_str(&format!(" \"{}\"", name)); [INFO] [stdout] 350 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands.rs:143:1 [INFO] [stdout] | [INFO] [stdout] 143 | / pub async fn cmd_snapshot( [INFO] [stdout] 144 | | port: u16, [INFO] [stdout] 145 | | interactive: bool, [INFO] [stdout] 146 | | compact: bool, [INFO] [stdout] ... | [INFO] [stdout] 151 | | mini: bool, [INFO] [stdout] 152 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/snapshot.rs:422:5 [INFO] [stdout] | [INFO] [stdout] 422 | !parts.last().is_some_and(|p| !p.is_empty()) || pos == text.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parts.last().is_none_or(|p| p.is_empty())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:446:5 [INFO] [stdout] | [INFO] [stdout] 446 | / if !node.is_component { [INFO] [stdout] 447 | | if let Some(ref tag) = node.tag { [INFO] [stdout] 448 | | if INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | | return true; [INFO] [stdout] ... | [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 446 ~ if !node.is_component [INFO] [stdout] 447 ~ && let Some(ref tag) = node.tag { [INFO] [stdout] 448 | if INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | return true; [INFO] [stdout] 450 | } [INFO] [stdout] 451 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | / if let Some(ref tag) = node.tag { [INFO] [stdout] 448 | | if INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | | return true; [INFO] [stdout] 450 | | } [INFO] [stdout] 451 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 447 ~ if let Some(ref tag) = node.tag [INFO] [stdout] 448 ~ && INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | return true; [INFO] [stdout] 450 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:486:5 [INFO] [stdout] | [INFO] [stdout] 486 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 487 | | if depth > max { [INFO] [stdout] 488 | | return; [INFO] [stdout] 489 | | } [INFO] [stdout] 490 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 486 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 487 ~ && depth > max { [INFO] [stdout] 488 | return; [INFO] [stdout] 489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/snapshot.rs:606:65 [INFO] [stdout] | [INFO] [stdout] 606 | if node.text.as_ref().map_or(true, |t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `node.text.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/snapshot.rs:606:12 [INFO] [stdout] | [INFO] [stdout] 606 | if node.text.as_ref().map_or(true, |t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 606 - if node.text.as_ref().map_or(true, |t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] 606 + if node.text.as_ref().is_none_or(|t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:685:5 [INFO] [stdout] | [INFO] [stdout] 685 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 686 | | if depth > max { [INFO] [stdout] 687 | | return; [INFO] [stdout] 688 | | } [INFO] [stdout] 689 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 685 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 686 ~ && depth > max { [INFO] [stdout] 687 | return; [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:708:5 [INFO] [stdout] | [INFO] [stdout] 708 | / if node.children.len() == 1 { [INFO] [stdout] 709 | | if let Some(ref text) = node.children[0].text { [INFO] [stdout] 710 | | if node.children[0].tag.is_none() { [INFO] [stdout] 711 | | line.push_str(&format!(" \"{}\"", text)); [INFO] [stdout] ... | [INFO] [stdout] 716 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 708 ~ if node.children.len() == 1 [INFO] [stdout] 709 ~ && let Some(ref text) = node.children[0].text { [INFO] [stdout] 710 | if node.children[0].tag.is_none() { [INFO] [stdout] ... [INFO] [stdout] 714 | } [INFO] [stdout] 715 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:709:9 [INFO] [stdout] | [INFO] [stdout] 709 | / if let Some(ref text) = node.children[0].text { [INFO] [stdout] 710 | | if node.children[0].tag.is_none() { [INFO] [stdout] 711 | | line.push_str(&format!(" \"{}\"", text)); [INFO] [stdout] 712 | | lines.push(line); [INFO] [stdout] ... | [INFO] [stdout] 715 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 709 ~ if let Some(ref text) = node.children[0].text [INFO] [stdout] 710 ~ && node.children[0].tag.is_none() { [INFO] [stdout] 711 | line.push_str(&format!(" \"{}\"", text)); [INFO] [stdout] 712 | lines.push(line); [INFO] [stdout] 713 | return; [INFO] [stdout] 714 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 216 | | if depth > max { [INFO] [stdout] 217 | | return; [INFO] [stdout] 218 | | } [INFO] [stdout] 219 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 216 ~ && depth > max { [INFO] [stdout] 217 | return; [INFO] [stdout] 218 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:324:5 [INFO] [stdout] | [INFO] [stdout] 324 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 325 | | if depth > max { [INFO] [stdout] 326 | | return; [INFO] [stdout] 327 | | } [INFO] [stdout] 328 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 324 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 325 ~ && depth > max { [INFO] [stdout] 326 | return; [INFO] [stdout] 327 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:347:5 [INFO] [stdout] | [INFO] [stdout] 347 | / if !node.is_component { [INFO] [stdout] 348 | | if let Some(ref name) = node.aria_name { [INFO] [stdout] 349 | | line.push_str(&format!(" \"{}\"", name)); [INFO] [stdout] 350 | | } [INFO] [stdout] 351 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 347 ~ if !node.is_component [INFO] [stdout] 348 ~ && let Some(ref name) = node.aria_name { [INFO] [stdout] 349 | line.push_str(&format!(" \"{}\"", name)); [INFO] [stdout] 350 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/snapshot.rs:422:5 [INFO] [stdout] | [INFO] [stdout] 422 | !parts.last().is_some_and(|p| !p.is_empty()) || pos == text.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parts.last().is_none_or(|p| p.is_empty())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:446:5 [INFO] [stdout] | [INFO] [stdout] 446 | / if !node.is_component { [INFO] [stdout] 447 | | if let Some(ref tag) = node.tag { [INFO] [stdout] 448 | | if INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | | return true; [INFO] [stdout] ... | [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 446 ~ if !node.is_component [INFO] [stdout] 447 ~ && let Some(ref tag) = node.tag { [INFO] [stdout] 448 | if INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | return true; [INFO] [stdout] 450 | } [INFO] [stdout] 451 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | / if let Some(ref tag) = node.tag { [INFO] [stdout] 448 | | if INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | | return true; [INFO] [stdout] 450 | | } [INFO] [stdout] 451 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 447 ~ if let Some(ref tag) = node.tag [INFO] [stdout] 448 ~ && INTERACTIVE_TAGS.contains(&tag.as_str()) { [INFO] [stdout] 449 | return true; [INFO] [stdout] 450 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:486:5 [INFO] [stdout] | [INFO] [stdout] 486 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 487 | | if depth > max { [INFO] [stdout] 488 | | return; [INFO] [stdout] 489 | | } [INFO] [stdout] 490 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 486 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 487 ~ && depth > max { [INFO] [stdout] 488 | return; [INFO] [stdout] 489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/snapshot.rs:606:65 [INFO] [stdout] | [INFO] [stdout] 606 | if node.text.as_ref().map_or(true, |t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `node.text.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/snapshot.rs:606:12 [INFO] [stdout] | [INFO] [stdout] 606 | if node.text.as_ref().map_or(true, |t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 606 - if node.text.as_ref().map_or(true, |t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] 606 + if node.text.as_ref().is_none_or(|t| t.is_empty()) && !node.text.is_some() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:685:5 [INFO] [stdout] | [INFO] [stdout] 685 | / if let Some(max) = opts.max_depth { [INFO] [stdout] 686 | | if depth > max { [INFO] [stdout] 687 | | return; [INFO] [stdout] 688 | | } [INFO] [stdout] 689 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 685 ~ if let Some(max) = opts.max_depth [INFO] [stdout] 686 ~ && depth > max { [INFO] [stdout] 687 | return; [INFO] [stdout] 688 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:708:5 [INFO] [stdout] | [INFO] [stdout] 708 | / if node.children.len() == 1 { [INFO] [stdout] 709 | | if let Some(ref text) = node.children[0].text { [INFO] [stdout] 710 | | if node.children[0].tag.is_none() { [INFO] [stdout] 711 | | line.push_str(&format!(" \"{}\"", text)); [INFO] [stdout] ... | [INFO] [stdout] 716 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 708 ~ if node.children.len() == 1 [INFO] [stdout] 709 ~ && let Some(ref text) = node.children[0].text { [INFO] [stdout] 710 | if node.children[0].tag.is_none() { [INFO] [stdout] ... [INFO] [stdout] 714 | } [INFO] [stdout] 715 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/snapshot.rs:709:9 [INFO] [stdout] | [INFO] [stdout] 709 | / if let Some(ref text) = node.children[0].text { [INFO] [stdout] 710 | | if node.children[0].tag.is_none() { [INFO] [stdout] 711 | | line.push_str(&format!(" \"{}\"", text)); [INFO] [stdout] 712 | | lines.push(line); [INFO] [stdout] ... | [INFO] [stdout] 715 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 709 ~ if let Some(ref text) = node.children[0].text [INFO] [stdout] 710 ~ && node.children[0].tag.is_none() { [INFO] [stdout] 711 | line.push_str(&format!(" \"{}\"", text)); [INFO] [stdout] 712 | lines.push(line); [INFO] [stdout] 713 | return; [INFO] [stdout] 714 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.02s [INFO] running `Command { std: "docker" "inspect" "f18db1e9f7f8e8f6773493e789b7792c2c6075528f20cb69e142b37457758077", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f18db1e9f7f8e8f6773493e789b7792c2c6075528f20cb69e142b37457758077", kill_on_drop: false }` [INFO] [stdout] f18db1e9f7f8e8f6773493e789b7792c2c6075528f20cb69e142b37457758077