[INFO] cloning repository https://github.com/Olof-Tingskull/alg-mastery-1
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Olof-Tingskull/alg-mastery-1" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOlof-Tingskull%2Falg-mastery-1", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOlof-Tingskull%2Falg-mastery-1'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 32a8e22090ece91297b48792ca30a65a71d0cc0f
[INFO] linting Olof-Tingskull/alg-mastery-1 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOlof-Tingskull%2Falg-mastery-1" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Olof-Tingskull/alg-mastery-1
[INFO] finished tweaking git repo https://github.com/Olof-Tingskull/alg-mastery-1
[INFO] tweaked toml for git repo https://github.com/Olof-Tingskull/alg-mastery-1 written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Olof-Tingskull/alg-mastery-1 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Olof-Tingskull/alg-mastery-1 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 90f33de873a2c2d538f258460b5631eebb7e7a04a2e58c416e7a67c62912be35
[INFO] running `Command { std: "docker" "start" "-a" "90f33de873a2c2d538f258460b5631eebb7e7a04a2e58c416e7a67c62912be35", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "90f33de873a2c2d538f258460b5631eebb7e7a04a2e58c416e7a67c62912be35", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "90f33de873a2c2d538f258460b5631eebb7e7a04a2e58c416e7a67c62912be35", kill_on_drop: false }`
[INFO] [stdout] 90f33de873a2c2d538f258460b5631eebb7e7a04a2e58c416e7a67c62912be35
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] cfc7d59a248730e0714609e933bb3ea65ed8d16a3a278e7e0fe4d6f2fe9ee157
[INFO] running `Command { std: "docker" "start" "-a" "cfc7d59a248730e0714609e933bb3ea65ed8d16a3a278e7e0fe4d6f2fe9ee157", kill_on_drop: false }`
[INFO] [stderr]     Checking alg-mastery-1 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/problems/caveat_venditor.rs:17:41
[INFO] [stdout]    |
[INFO] [stdout] 17 | pub fn run(total_to_buy: usize, offers: &Vec<Offer>, price_per_movie: f64) -> f64 {
[INFO] [stdout]    |                                         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 17 - pub fn run(total_to_buy: usize, offers: &Vec<Offer>, price_per_movie: f64) -> f64 {
[INFO] [stdout] 17 + pub fn run(total_to_buy: usize, offers: &[Offer], price_per_movie: f64) -> f64 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/problems/caveat_venditor.rs:42:21
[INFO] [stdout]    |
[INFO] [stdout] 42 |                     return Some(p);
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -                     return Some(p);
[INFO] [stdout] 42 +                     Some(p)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/problems/caveat_venditor.rs:57:21
[INFO] [stdout]    |
[INFO] [stdout] 57 |                     return Some(p);
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 57 -                     return Some(p);
[INFO] [stdout] 57 +                     Some(p)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/problems/coniunctis_viribus.rs:27:20
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 if !end_ref.as_mut().is_some_and(|t| t.len() < trains_here.len()) {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `end_ref.as_mut().is_none_or(|t| t.len() >= trains_here.len())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/problems/quid_pro_quo.rs:5:27
[INFO] [stdout]   |
[INFO] [stdout] 5 | fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout]   |                           ^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout] 5 + fn get_surplus(resources: &[i32], goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/problems/quid_pro_quo.rs:5:45
[INFO] [stdout]   |
[INFO] [stdout] 5 | fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout]   |                                             ^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout] 5 + fn get_surplus(resources: &Vec<i32>, goals: &[i32]) -> Vec<i32> {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/problems/quid_pro_quo.rs:147:5
[INFO] [stdout]     |
[INFO] [stdout] 147 |     return false;
[INFO] [stdout]     |     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 147 -     return false;
[INFO] [stdout] 147 +     false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `k` is used to index `character_surplus`
[INFO] [stdout]   --> src/problems/quid_pro_quo.rs:92:22
[INFO] [stdout]    |
[INFO] [stdout] 92 |             for k in 0..m {
[INFO] [stdout]    |                      ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 92 -             for k in 0..m {
[INFO] [stdout] 92 +             for (k, <item>) in character_surplus.iter().enumerate().take(m) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/problems/caveat_venditor.rs:17:41
[INFO] [stdout]    |
[INFO] [stdout] 17 | pub fn run(total_to_buy: usize, offers: &Vec<Offer>, price_per_movie: f64) -> f64 {
[INFO] [stdout]    |                                         ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 17 - pub fn run(total_to_buy: usize, offers: &Vec<Offer>, price_per_movie: f64) -> f64 {
[INFO] [stdout] 17 + pub fn run(total_to_buy: usize, offers: &[Offer], price_per_movie: f64) -> f64 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/problems/caveat_venditor.rs:42:21
[INFO] [stdout]    |
[INFO] [stdout] 42 |                     return Some(p);
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -                     return Some(p);
[INFO] [stdout] 42 +                     Some(p)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/problems/caveat_venditor.rs:57:21
[INFO] [stdout]    |
[INFO] [stdout] 57 |                     return Some(p);
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 57 -                     return Some(p);
[INFO] [stdout] 57 +                     Some(p)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/problems/coniunctis_viribus.rs:27:20
[INFO] [stdout]    |
[INFO] [stdout] 27 |                 if !end_ref.as_mut().is_some_and(|t| t.len() < trains_here.len()) {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `end_ref.as_mut().is_none_or(|t| t.len() >= trains_here.len())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/problems/quid_pro_quo.rs:5:27
[INFO] [stdout]   |
[INFO] [stdout] 5 | fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout]   |                           ^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout] 5 + fn get_surplus(resources: &[i32], goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/problems/quid_pro_quo.rs:5:45
[INFO] [stdout]   |
[INFO] [stdout] 5 | fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout]   |                                             ^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - fn get_surplus(resources: &Vec<i32>, goals: &Vec<i32>) -> Vec<i32> {
[INFO] [stdout] 5 + fn get_surplus(resources: &Vec<i32>, goals: &[i32]) -> Vec<i32> {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/problems/quid_pro_quo.rs:147:5
[INFO] [stdout]     |
[INFO] [stdout] 147 |     return false;
[INFO] [stdout]     |     ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 147 -     return false;
[INFO] [stdout] 147 +     false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `k` is used to index `character_surplus`
[INFO] [stdout]   --> src/problems/quid_pro_quo.rs:92:22
[INFO] [stdout]    |
[INFO] [stdout] 92 |             for k in 0..m {
[INFO] [stdout]    |                      ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 92 -             for k in 0..m {
[INFO] [stdout] 92 +             for (k, <item>) in character_surplus.iter().enumerate().take(m) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`)
[INFO] [stdout]    --> src/problems/quid_pro_quo.rs:197:58
[INFO] [stdout]     |
[INFO] [stdout] 197 |                 .map(|_| (0..n).map(|_| rng.gen_range(0..n as i32)).collect())
[INFO] [stdout]     |                                                          ^^^^^^^^ help: try: `n`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`)
[INFO] [stdout]    --> src/problems/quid_pro_quo.rs:200:58
[INFO] [stdout]     |
[INFO] [stdout] 200 |                 .map(|_| (0..n).map(|_| rng.gen_range(0..n as i32)).collect())
[INFO] [stdout]     |                                                          ^^^^^^^^ help: try: `n`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s
[INFO] running `Command { std: "docker" "inspect" "cfc7d59a248730e0714609e933bb3ea65ed8d16a3a278e7e0fe4d6f2fe9ee157", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "cfc7d59a248730e0714609e933bb3ea65ed8d16a3a278e7e0fe4d6f2fe9ee157", kill_on_drop: false }`
[INFO] [stdout] cfc7d59a248730e0714609e933bb3ea65ed8d16a3a278e7e0fe4d6f2fe9ee157