[INFO] cloning repository https://github.com/Ohanronnie/rust-moviedl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ohanronnie/rust-moviedl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOhanronnie%2Frust-moviedl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOhanronnie%2Frust-moviedl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8e38dd4c579fc05bd39c91f4792dfbf497788808 [INFO] linting Ohanronnie/rust-moviedl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOhanronnie%2Frust-moviedl" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Ohanronnie/rust-moviedl [INFO] finished tweaking git repo https://github.com/Ohanronnie/rust-moviedl [INFO] tweaked toml for git repo https://github.com/Ohanronnie/rust-moviedl written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Ohanronnie/rust-moviedl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Ohanronnie/rust-moviedl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded getopts v0.2.23 [INFO] [stderr] Downloaded ego-tree v0.6.3 [INFO] [stderr] Downloaded scraper v0.18.1 [INFO] [stderr] Downloaded hyper-util v0.1.15 [INFO] [stderr] Downloaded async-compression v0.4.25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 67703f2a3a4c8033d05f8a1ee20f00702344c709ed5794886abd68e0e54f32d5 [INFO] running `Command { std: "docker" "start" "-a" "67703f2a3a4c8033d05f8a1ee20f00702344c709ed5794886abd68e0e54f32d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "67703f2a3a4c8033d05f8a1ee20f00702344c709ed5794886abd68e0e54f32d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67703f2a3a4c8033d05f8a1ee20f00702344c709ed5794886abd68e0e54f32d5", kill_on_drop: false }` [INFO] [stdout] 67703f2a3a4c8033d05f8a1ee20f00702344c709ed5794886abd68e0e54f32d5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac7e1bea28fe9dcc8b53b78d7b26b59ea8b7e7f9ba8b5630a3ca354e90efb726 [INFO] running `Command { std: "docker" "start" "-a" "ac7e1bea28fe9dcc8b53b78d7b26b59ea8b7e7f9ba8b5630a3ca354e90efb726", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling getrandom v0.2.16 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling cookie v0.17.0 [INFO] [stderr] Checking dtoa v1.0.10 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking brotli v8.0.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking getopts v0.2.23 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking ego-tree v0.6.3 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking ctrlc v3.4.7 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking publicsuffix v2.3.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking async-compression v0.4.25 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking h2 v0.4.11 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking cookie_store v0.20.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking scraper v0.18.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-util v0.1.15 [INFO] [stderr] Checking mockito v1.7.0 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking rust-downloader v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/downloader.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if test && true { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `test` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/downloader.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | let filename = url.split('/').last().unwrap_or("file.bin"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 - let filename = url.split('/').last().unwrap_or("file.bin"); [INFO] [stdout] 15 + let filename = url.split('/').next_back().unwrap_or("file.bin"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/downloader.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | chunk_size: (size + chunks as u64 - 1) / chunks as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(chunks as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/downloader.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / if let Ok(resp) = client.head(url).send() { [INFO] [stdout] 94 | | if let Some(size) = resp.headers().get(header::CONTENT_LENGTH) { [INFO] [stdout] 95 | | if let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | | return size; [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 93 ~ if let Ok(resp) = client.head(url).send() [INFO] [stdout] 94 ~ && let Some(size) = resp.headers().get(header::CONTENT_LENGTH) { [INFO] [stdout] 95 | if let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | return size; [INFO] [stdout] 97 | } [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/downloader.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | / if let Some(size) = resp.headers().get(header::CONTENT_LENGTH) { [INFO] [stdout] 95 | | if let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | | return size; [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 94 ~ if let Some(size) = resp.headers().get(header::CONTENT_LENGTH) [INFO] [stdout] 95 ~ && let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | return size; [INFO] [stdout] 97 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/downloader.rs:105:1 [INFO] [stdout] | [INFO] [stdout] 105 | / fn download_chunk( [INFO] [stdout] 106 | | client: Client, [INFO] [stdout] 107 | | url: String, [INFO] [stdout] 108 | | start: u64, [INFO] [stdout] ... | [INFO] [stdout] 114 | | meta: Arc>, [INFO] [stdout] 115 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / if let Some(a_tag) = article.select(&link_selector).next() { [INFO] [stdout] 23 | | if let Some(href) = a_tag.value().attr("href") { [INFO] [stdout] 24 | | if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 22 ~ if let Some(a_tag) = article.select(&link_selector).next() [INFO] [stdout] 23 ~ && let Some(href) = a_tag.value().attr("href") { [INFO] [stdout] 24 | if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] ... [INFO] [stdout] 28 | } [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / if let Some(href) = a_tag.value().attr("href") { [INFO] [stdout] 24 | | if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ if let Some(href) = a_tag.value().attr("href") [INFO] [stdout] 24 ~ && let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] 27 | } [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some(img_tag) = a_tag.select(&img_selector).next() [INFO] [stdout] 25 ~ && let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Some(href) = a.value().attr("href") { [INFO] [stdout] 64 | | if href.contains("nkiserv.com") || href.contains("ds2.nkiserv.com") { [INFO] [stdout] 65 | | println!("⚡ Found direct download link: {}", href); [INFO] [stdout] 66 | | final_links.push(href.to_string()); [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ if let Some(href) = a.value().attr("href") [INFO] [stdout] 64 ~ && (href.contains("nkiserv.com") || href.contains("ds2.nkiserv.com")) { [INFO] [stdout] 65 | println!("⚡ Found direct download link: {}", href); [INFO] [stdout] 66 | final_links.push(href.to_string()); [INFO] [stdout] 67 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / for line in reader.lines() { [INFO] [stdout] 52 | | if let Ok(url) = line { [INFO] [stdout] 53 | | if !url.trim().is_empty() { [INFO] [stdout] 54 | | urls.push(url.trim().to_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / if let Ok(url) = line { [INFO] [stdout] 53 | | if !url.trim().is_empty() { [INFO] [stdout] 54 | | urls.push(url.trim().to_string()); [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ for url in reader.lines().flatten() { [INFO] [stdout] 52 + if !url.trim().is_empty() { [INFO] [stdout] 53 + urls.push(url.trim().to_string()); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / if let Ok(url) = line { [INFO] [stdout] 53 | | if !url.trim().is_empty() { [INFO] [stdout] 54 | | urls.push(url.trim().to_string()); [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Ok(url) = line [INFO] [stdout] 53 ~ && !url.trim().is_empty() { [INFO] [stdout] 54 | urls.push(url.trim().to_string()); [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/downloader.rs:158:21 [INFO] [stdout] | [INFO] [stdout] 158 | save_meta(&meta_path, &m); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 158 | let _ = save_meta(&meta_path, &m); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/downloader.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if test && true { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `test` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/downloader.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | let filename = url.split('/').last().unwrap_or("file.bin"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 - let filename = url.split('/').last().unwrap_or("file.bin"); [INFO] [stdout] 15 + let filename = url.split('/').next_back().unwrap_or("file.bin"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/downloader.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | chunk_size: (size + chunks as u64 - 1) / chunks as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(chunks as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/downloader.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / if let Ok(resp) = client.head(url).send() { [INFO] [stdout] 94 | | if let Some(size) = resp.headers().get(header::CONTENT_LENGTH) { [INFO] [stdout] 95 | | if let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | | return size; [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 93 ~ if let Ok(resp) = client.head(url).send() [INFO] [stdout] 94 ~ && let Some(size) = resp.headers().get(header::CONTENT_LENGTH) { [INFO] [stdout] 95 | if let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | return size; [INFO] [stdout] 97 | } [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/downloader.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | / if let Some(size) = resp.headers().get(header::CONTENT_LENGTH) { [INFO] [stdout] 95 | | if let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | | return size; [INFO] [stdout] 97 | | } [INFO] [stdout] 98 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 94 ~ if let Some(size) = resp.headers().get(header::CONTENT_LENGTH) [INFO] [stdout] 95 ~ && let Ok(size) = size.to_str().unwrap_or("0").parse::() { [INFO] [stdout] 96 | return size; [INFO] [stdout] 97 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/downloader.rs:105:1 [INFO] [stdout] | [INFO] [stdout] 105 | / fn download_chunk( [INFO] [stdout] 106 | | client: Client, [INFO] [stdout] 107 | | url: String, [INFO] [stdout] 108 | | start: u64, [INFO] [stdout] ... | [INFO] [stdout] 114 | | meta: Arc>, [INFO] [stdout] 115 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / if let Some(a_tag) = article.select(&link_selector).next() { [INFO] [stdout] 23 | | if let Some(href) = a_tag.value().attr("href") { [INFO] [stdout] 24 | | if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 22 ~ if let Some(a_tag) = article.select(&link_selector).next() [INFO] [stdout] 23 ~ && let Some(href) = a_tag.value().attr("href") { [INFO] [stdout] 24 | if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] ... [INFO] [stdout] 28 | } [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | / if let Some(href) = a_tag.value().attr("href") { [INFO] [stdout] 24 | | if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ if let Some(href) = a_tag.value().attr("href") [INFO] [stdout] 24 ~ && let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] 27 | } [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some(img_tag) = a_tag.select(&img_selector).next() { [INFO] [stdout] 25 | | if let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some(img_tag) = a_tag.select(&img_selector).next() [INFO] [stdout] 25 ~ && let Some(alt) = img_tag.value().attr("alt") { [INFO] [stdout] 26 | results.push((alt.to_string(), href.to_string())); [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nkiri.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Some(href) = a.value().attr("href") { [INFO] [stdout] 64 | | if href.contains("nkiserv.com") || href.contains("ds2.nkiserv.com") { [INFO] [stdout] 65 | | println!("⚡ Found direct download link: {}", href); [INFO] [stdout] 66 | | final_links.push(href.to_string()); [INFO] [stdout] 67 | | } [INFO] [stdout] 68 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ if let Some(href) = a.value().attr("href") [INFO] [stdout] 64 ~ && (href.contains("nkiserv.com") || href.contains("ds2.nkiserv.com")) { [INFO] [stdout] 65 | println!("⚡ Found direct download link: {}", href); [INFO] [stdout] 66 | final_links.push(href.to_string()); [INFO] [stdout] 67 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / for line in reader.lines() { [INFO] [stdout] 52 | | if let Ok(url) = line { [INFO] [stdout] 53 | | if !url.trim().is_empty() { [INFO] [stdout] 54 | | urls.push(url.trim().to_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / if let Ok(url) = line { [INFO] [stdout] 53 | | if !url.trim().is_empty() { [INFO] [stdout] 54 | | urls.push(url.trim().to_string()); [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ for url in reader.lines().flatten() { [INFO] [stdout] 52 + if !url.trim().is_empty() { [INFO] [stdout] 53 + urls.push(url.trim().to_string()); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / if let Ok(url) = line { [INFO] [stdout] 53 | | if !url.trim().is_empty() { [INFO] [stdout] 54 | | urls.push(url.trim().to_string()); [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Ok(url) = line [INFO] [stdout] 53 ~ && !url.trim().is_empty() { [INFO] [stdout] 54 | urls.push(url.trim().to_string()); [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/downloader.rs:158:21 [INFO] [stdout] | [INFO] [stdout] 158 | save_meta(&meta_path, &m); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 158 | let _ = save_meta(&meta_path, &m); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 48s [INFO] running `Command { std: "docker" "inspect" "ac7e1bea28fe9dcc8b53b78d7b26b59ea8b7e7f9ba8b5630a3ca354e90efb726", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac7e1bea28fe9dcc8b53b78d7b26b59ea8b7e7f9ba8b5630a3ca354e90efb726", kill_on_drop: false }` [INFO] [stdout] ac7e1bea28fe9dcc8b53b78d7b26b59ea8b7e7f9ba8b5630a3ca354e90efb726