[INFO] cloning repository https://github.com/OctavioGalland/rip8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/OctavioGalland/rip8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOctavioGalland%2Frip8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOctavioGalland%2Frip8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1a1a3becef1c2c5beb57a6ecb746e893f27c3119 [INFO] linting OctavioGalland/rip8 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOctavioGalland%2Frip8" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/OctavioGalland/rip8 [INFO] finished tweaking git repo https://github.com/OctavioGalland/rip8 [INFO] tweaked toml for git repo https://github.com/OctavioGalland/rip8 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/OctavioGalland/rip8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/OctavioGalland/rip8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e07d420856f75aa96ba257ae40863a0004e415403d17aefa5a5260f0a3d81e50 [INFO] running `Command { std: "docker" "start" "-a" "e07d420856f75aa96ba257ae40863a0004e415403d17aefa5a5260f0a3d81e50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e07d420856f75aa96ba257ae40863a0004e415403d17aefa5a5260f0a3d81e50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e07d420856f75aa96ba257ae40863a0004e415403d17aefa5a5260f0a3d81e50", kill_on_drop: false }` [INFO] [stdout] e07d420856f75aa96ba257ae40863a0004e415403d17aefa5a5260f0a3d81e50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 356c9609bcd370158956119d3b1761a7ea2946e8ec35b68aef8f9b81f9d54102 [INFO] running `Command { std: "docker" "start" "-a" "356c9609bcd370158956119d3b1761a7ea2946e8ec35b68aef8f9b81f9d54102", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling sdl2 v0.37.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling sdl2-sys v0.37.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking rip8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1161:50 [INFO] [stdout] | [INFO] [stdout] 1161 | assert_eq!(rip8.memory[rip8.i as usize - 01], 0x03); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] = note: `#[warn(clippy::zero_prefixed_literal)]` on by default [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1161 - assert_eq!(rip8.memory[rip8.i as usize - 01], 0x03); [INFO] [stdout] 1161 + assert_eq!(rip8.memory[rip8.i as usize - 1], 0x03); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1161 | assert_eq!(rip8.memory[rip8.i as usize - 0o1], 0x03); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1162:50 [INFO] [stdout] | [INFO] [stdout] 1162 | assert_eq!(rip8.memory[rip8.i as usize - 02], 0x00); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1162 - assert_eq!(rip8.memory[rip8.i as usize - 02], 0x00); [INFO] [stdout] 1162 + assert_eq!(rip8.memory[rip8.i as usize - 2], 0x00); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1162 | assert_eq!(rip8.memory[rip8.i as usize - 0o2], 0x00); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1163:50 [INFO] [stdout] | [INFO] [stdout] 1163 | assert_eq!(rip8.memory[rip8.i as usize - 03], 0x00); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1163 - assert_eq!(rip8.memory[rip8.i as usize - 03], 0x00); [INFO] [stdout] 1163 + assert_eq!(rip8.memory[rip8.i as usize - 3], 0x00); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1163 | assert_eq!(rip8.memory[rip8.i as usize - 0o3], 0x00); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1165:50 [INFO] [stdout] | [INFO] [stdout] 1165 | assert_eq!(rip8.memory[rip8.i as usize - 04], 0x04); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1165 - assert_eq!(rip8.memory[rip8.i as usize - 04], 0x04); [INFO] [stdout] 1165 + assert_eq!(rip8.memory[rip8.i as usize - 4], 0x04); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1165 | assert_eq!(rip8.memory[rip8.i as usize - 0o4], 0x04); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1166:50 [INFO] [stdout] | [INFO] [stdout] 1166 | assert_eq!(rip8.memory[rip8.i as usize - 05], 0x05); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1166 - assert_eq!(rip8.memory[rip8.i as usize - 05], 0x05); [INFO] [stdout] 1166 + assert_eq!(rip8.memory[rip8.i as usize - 5], 0x05); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1166 | assert_eq!(rip8.memory[rip8.i as usize - 0o5], 0x05); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1167:50 [INFO] [stdout] | [INFO] [stdout] 1167 | assert_eq!(rip8.memory[rip8.i as usize - 06], 0x02); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1167 - assert_eq!(rip8.memory[rip8.i as usize - 06], 0x02); [INFO] [stdout] 1167 + assert_eq!(rip8.memory[rip8.i as usize - 6], 0x02); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1167 | assert_eq!(rip8.memory[rip8.i as usize - 0o6], 0x02); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1169:50 [INFO] [stdout] | [INFO] [stdout] 1169 | assert_eq!(rip8.memory[rip8.i as usize - 07], 0x06); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1169 - assert_eq!(rip8.memory[rip8.i as usize - 07], 0x06); [INFO] [stdout] 1169 + assert_eq!(rip8.memory[rip8.i as usize - 7], 0x06); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1169 | assert_eq!(rip8.memory[rip8.i as usize - 0o7], 0x06); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1170:50 [INFO] [stdout] | [INFO] [stdout] 1170 | assert_eq!(rip8.memory[rip8.i as usize - 08], 0x07); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1170 - assert_eq!(rip8.memory[rip8.i as usize - 08], 0x07); [INFO] [stdout] 1170 + assert_eq!(rip8.memory[rip8.i as usize - 8], 0x07); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1171:50 [INFO] [stdout] | [INFO] [stdout] 1171 | assert_eq!(rip8.memory[rip8.i as usize - 09], 0x00); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1171 - assert_eq!(rip8.memory[rip8.i as usize - 09], 0x00); [INFO] [stdout] 1171 + assert_eq!(rip8.memory[rip8.i as usize - 9], 0x00); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1194:50 [INFO] [stdout] | [INFO] [stdout] 1194 | assert_eq!(rip8.memory[rip8.i as usize - 01], 0x00); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1194 - assert_eq!(rip8.memory[rip8.i as usize - 01], 0x00); [INFO] [stdout] 1194 + assert_eq!(rip8.memory[rip8.i as usize - 1], 0x00); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1194 | assert_eq!(rip8.memory[rip8.i as usize - 0o1], 0x00); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1195:50 [INFO] [stdout] | [INFO] [stdout] 1195 | assert_eq!(rip8.memory[rip8.i as usize - 02], 0x44); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1195 - assert_eq!(rip8.memory[rip8.i as usize - 02], 0x44); [INFO] [stdout] 1195 + assert_eq!(rip8.memory[rip8.i as usize - 2], 0x44); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1195 | assert_eq!(rip8.memory[rip8.i as usize - 0o2], 0x44); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1196:50 [INFO] [stdout] | [INFO] [stdout] 1196 | assert_eq!(rip8.memory[rip8.i as usize - 03], 0x88); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1196 - assert_eq!(rip8.memory[rip8.i as usize - 03], 0x88); [INFO] [stdout] 1196 + assert_eq!(rip8.memory[rip8.i as usize - 3], 0x88); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1196 | assert_eq!(rip8.memory[rip8.i as usize - 0o3], 0x88); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/rip8.rs:1197:50 [INFO] [stdout] | [INFO] [stdout] 1197 | assert_eq!(rip8.memory[rip8.i as usize - 04], 0xff); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 1197 - assert_eq!(rip8.memory[rip8.i as usize - 04], 0xff); [INFO] [stdout] 1197 + assert_eq!(rip8.memory[rip8.i as usize - 4], 0xff); [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 1197 | assert_eq!(rip8.memory[rip8.i as usize - 0o4], 0xff); [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rip8.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn from_image_at_start(image: &Vec, freq: u32, start_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ pub fn from_image_at_start(image: &[u8], freq: u32, start_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] 38 | assert!(image.len() == RIP8_MEMORY_SIZE); [INFO] [stdout] ... [INFO] [stdout] 41 | pc: start_address, [INFO] [stdout] 42 ~ memory: image.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rip8.rs:64:37 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn from_rom_at_address(rom: &Vec, freq: u32, loading_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn from_rom_at_address(rom: &Vec, freq: u32, loading_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] 64 + pub fn from_rom_at_address(rom: &[u8], freq: u32, loading_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `rom` [INFO] [stdout] --> src/rip8.rs:98:18 [INFO] [stdout] | [INFO] [stdout] 98 | for i in 0..rom.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 98 - for i in 0..rom.len() { [INFO] [stdout] 98 + for in &rom { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/rip8.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | memory.push(0xff); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0xff;SIZE]` [INFO] [stdout] = help: or `memory.extend(std::iter::repeat_n(0xff, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | x = x % RIP8_DISPLAY_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x %= RIP8_DISPLAY_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | y = y % RIP8_DISPLAY_HEIGHT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y %= RIP8_DISPLAY_HEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | x = x % RIP8_DISPLAY_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x %= RIP8_DISPLAY_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | y = y % RIP8_DISPLAY_HEIGHT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y %= RIP8_DISPLAY_HEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if ir & 0xffff == 0x00e0 { [INFO] [stdout] | ^^^^^^^^^^^ help: consider reducing it to: `ir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:185:19 [INFO] [stdout] | [INFO] [stdout] 185 | } else if ir & 0xffff == 0x00ee { [INFO] [stdout] | ^^^^^^^^^^^ help: consider reducing it to: `ir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:199:30 [INFO] [stdout] | [INFO] [stdout] 199 | self.stack.push(((self.pc >> 0) & 0xff) as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider reducing it to: `self.pc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | self.memory[self.i as usize + 0] = (self.v[x] / 100) % 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(self.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:292:48 [INFO] [stdout] | [INFO] [stdout] 292 | self.memory[self.i as usize + 2] = (self.v[x] / 1) % 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider reducing it to: `self.v[x]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `SCANCODE_MAPPING` [INFO] [stdout] --> src/main.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 120 | for k in 0..SCANCODE_MAPPING.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 120 - for k in 0..SCANCODE_MAPPING.len() { [INFO] [stdout] 120 + for (k, ) in SCANCODE_MAPPING.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rip8.rs:37:39 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn from_image_at_start(image: &Vec, freq: u32, start_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ pub fn from_image_at_start(image: &[u8], freq: u32, start_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] 38 | assert!(image.len() == RIP8_MEMORY_SIZE); [INFO] [stdout] ... [INFO] [stdout] 41 | pc: start_address, [INFO] [stdout] 42 ~ memory: image.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rip8.rs:64:37 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn from_rom_at_address(rom: &Vec, freq: u32, loading_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn from_rom_at_address(rom: &Vec, freq: u32, loading_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] 64 + pub fn from_rom_at_address(rom: &[u8], freq: u32, loading_address: u16, get_random: fn() -> u8) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `rom` [INFO] [stdout] --> src/rip8.rs:98:18 [INFO] [stdout] | [INFO] [stdout] 98 | for i in 0..rom.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 98 - for i in 0..rom.len() { [INFO] [stdout] 98 + for in &rom { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/rip8.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | memory.push(0xff); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0xff;SIZE]` [INFO] [stdout] = help: or `memory.extend(std::iter::repeat_n(0xff, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | x = x % RIP8_DISPLAY_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x %= RIP8_DISPLAY_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | y = y % RIP8_DISPLAY_HEIGHT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y %= RIP8_DISPLAY_HEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | x = x % RIP8_DISPLAY_WIDTH; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x %= RIP8_DISPLAY_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rip8.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | y = y % RIP8_DISPLAY_HEIGHT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y %= RIP8_DISPLAY_HEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if ir & 0xffff == 0x00e0 { [INFO] [stdout] | ^^^^^^^^^^^ help: consider reducing it to: `ir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:185:19 [INFO] [stdout] | [INFO] [stdout] 185 | } else if ir & 0xffff == 0x00ee { [INFO] [stdout] | ^^^^^^^^^^^ help: consider reducing it to: `ir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:199:30 [INFO] [stdout] | [INFO] [stdout] 199 | self.stack.push(((self.pc >> 0) & 0xff) as u8); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider reducing it to: `self.pc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:290:25 [INFO] [stdout] | [INFO] [stdout] 290 | self.memory[self.i as usize + 0] = (self.v[x] / 100) % 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(self.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:292:48 [INFO] [stdout] | [INFO] [stdout] 292 | self.memory[self.i as usize + 2] = (self.v[x] / 1) % 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider reducing it to: `self.v[x]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rip8.rs:791:20 [INFO] [stdout] | [INFO] [stdout] 791 | if (x == 0 && y == 0) || [INFO] [stdout] | ____________________^ [INFO] [stdout] 792 | | (y > 24 && x > 56) || [INFO] [stdout] 793 | | (y > 24 && x == 0) || [INFO] [stdout] 794 | | (y ==0 && x > 56) { [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 791 - if (x == 0 && y == 0) || [INFO] [stdout] 792 - (y > 24 && x > 56) || [INFO] [stdout] 793 - (y > 24 && x == 0) || [INFO] [stdout] 794 - (y ==0 && x > 56) { [INFO] [stdout] 791 + if !(y != 0 && y <= 24 || x != 0 && x <= 56) { [INFO] [stdout] | [INFO] [stdout] 791 - if (x == 0 && y == 0) || [INFO] [stdout] 792 - (y > 24 && x > 56) || [INFO] [stdout] 793 - (y > 24 && x == 0) || [INFO] [stdout] 794 - (y ==0 && x > 56) { [INFO] [stdout] 791 + if (x > 56 || x == 0) && (y > 24 || y == 0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:920:32 [INFO] [stdout] | [INFO] [stdout] 920 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:934:32 [INFO] [stdout] | [INFO] [stdout] 934 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0x20); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:948:32 [INFO] [stdout] | [INFO] [stdout] 948 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:962:32 [INFO] [stdout] | [INFO] [stdout] 962 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:976:32 [INFO] [stdout] | [INFO] [stdout] 976 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0x90); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:990:32 [INFO] [stdout] | [INFO] [stdout] 990 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1004:32 [INFO] [stdout] | [INFO] [stdout] 1004 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1018:32 [INFO] [stdout] | [INFO] [stdout] 1018 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1032:32 [INFO] [stdout] | [INFO] [stdout] 1032 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1046:32 [INFO] [stdout] | [INFO] [stdout] 1046 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1060:32 [INFO] [stdout] | [INFO] [stdout] 1060 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1074:32 [INFO] [stdout] | [INFO] [stdout] 1074 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xe0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1088:32 [INFO] [stdout] | [INFO] [stdout] 1088 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1102:32 [INFO] [stdout] | [INFO] [stdout] 1102 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xe0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1116:32 [INFO] [stdout] | [INFO] [stdout] 1116 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/rip8.rs:1130:32 [INFO] [stdout] | [INFO] [stdout] 1130 | assert_eq!(rip8.memory[rip8.i as usize + 0], 0xf0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `(rip8.i as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `SCANCODE_MAPPING` [INFO] [stdout] --> src/main.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 120 | for k in 0..SCANCODE_MAPPING.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 120 - for k in 0..SCANCODE_MAPPING.len() { [INFO] [stdout] 120 + for (k, ) in SCANCODE_MAPPING.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.22s [INFO] running `Command { std: "docker" "inspect" "356c9609bcd370158956119d3b1761a7ea2946e8ec35b68aef8f9b81f9d54102", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "356c9609bcd370158956119d3b1761a7ea2946e8ec35b68aef8f9b81f9d54102", kill_on_drop: false }` [INFO] [stdout] 356c9609bcd370158956119d3b1761a7ea2946e8ec35b68aef8f9b81f9d54102