[INFO] cloning repository https://github.com/Object905/rust_srt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Object905/rust_srt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FObject905%2Frust_srt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FObject905%2Frust_srt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 635366837df69939fb4a1ffc144d24ff9c0da13e [INFO] linting Object905/rust_srt against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FObject905%2Frust_srt" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Object905/rust_srt [INFO] finished tweaking git repo https://github.com/Object905/rust_srt [INFO] tweaked toml for git repo https://github.com/Object905/rust_srt written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Object905/rust_srt on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Object905/rust_srt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thread_local v0.2.6 [INFO] [stderr] Downloaded libc v0.2.15 [INFO] [stderr] Downloaded regex-syntax v0.3.4 [INFO] [stderr] Downloaded regex v0.1.73 [INFO] [stderr] Downloaded aho-corasick v0.5.2 [INFO] [stderr] Downloaded lazy_static v0.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eaab238b9713fe631b611972b93331d5d337c4ea67eae2fd60383398213a31cb [INFO] running `Command { std: "docker" "start" "-a" "eaab238b9713fe631b611972b93331d5d337c4ea67eae2fd60383398213a31cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eaab238b9713fe631b611972b93331d5d337c4ea67eae2fd60383398213a31cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaab238b9713fe631b611972b93331d5d337c4ea67eae2fd60383398213a31cb", kill_on_drop: false }` [INFO] [stdout] eaab238b9713fe631b611972b93331d5d337c4ea67eae2fd60383398213a31cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a99483ba03e2a3168f78669b5f48c87825ec7517781bc4e2639997072bc4a9cb [INFO] running `Command { std: "docker" "start" "-a" "a99483ba03e2a3168f78669b5f48c87825ec7517781bc4e2639997072bc4a9cb", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking libc v0.2.15 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking regex-syntax v0.3.4 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Checking lazy_static v0.2.1 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking aho-corasick v0.5.2 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.6 [INFO] [stderr] Checking regex v0.1.73 [INFO] [stderr] Checking srt v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | hours: hours, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | minutes: minutes, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | seconds: seconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | miliseconds: miliseconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | hours: hours, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | minutes: minutes, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | seconds: seconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | miliseconds: miliseconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/utils.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | try!(file.read_to_string(&mut content)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/utils.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | let mut file = try!(File::open(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | text: text, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:25:27 [INFO] [stdout] | [INFO] [stdout] 25 | let mut content = try!(utils::read_file(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | Ok(try!(Subtitles::from_str(&content))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | try!(write!(&mut file, "\r\n\r\n")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | let mut file = try!(File::create(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | try!(write!(&mut file, "{}", line)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 249 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:250:17 [INFO] [stdout] | [INFO] [stdout] 250 | text: text, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | try!(write!(f, "{}", line)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | hours: hours, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | minutes: minutes, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | seconds: seconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | miliseconds: miliseconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | hours: hours, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | minutes: minutes, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | seconds: seconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/timestamp.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | miliseconds: miliseconds, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `miliseconds` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/utils.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | try!(file.read_to_string(&mut content)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/utils.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | let mut file = try!(File::open(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | text: text, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subline.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:25:27 [INFO] [stdout] | [INFO] [stdout] 25 | let mut content = try!(utils::read_file(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | Ok(try!(Subtitles::from_str(&content))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | try!(write!(&mut file, "\r\n\r\n")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | let mut file = try!(File::create(&path)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | try!(write!(&mut file, "{}", line)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 249 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:250:17 [INFO] [stdout] | [INFO] [stdout] 250 | text: text, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:251:17 [INFO] [stdout] | [INFO] [stdout] 251 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/subtitles.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/subtitles.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | try!(write!(f, "{}", line)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/subtitles.rs:320:19 [INFO] [stdout] | [INFO] [stdout] 320 | static PATH: &'static str = "example.srt"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/utils.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / lazy_static! { [INFO] [stdout] 24 | | pub static ref SUBS: Regex = Regex::new(r"(?x) [INFO] [stdout] 25 | | (\d+) [INFO] [stdout] 26 | | \r\n [INFO] [stdout] ... | [INFO] [stdout] 35 | | static ref UNIFY_NEWLINE_STYLE: Regex = Regex::new(r"(?:\r\n|\n)").unwrap(); [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/subtitles.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / lazy_static! { [INFO] [stdout] 323 | | static ref SUBS: Subtitles = Subtitles::from_file(PATH).unwrap(); [INFO] [stdout] 324 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/subtitles.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / lazy_static! { [INFO] [stdout] 323 | | static ref SUBS: Subtitles = Subtitles::from_file(PATH).unwrap(); [INFO] [stdout] 324 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:15:43 [INFO] [stdout] | [INFO] [stdout] 15 | let result = EOF_EMPTY_LINES.replacen(&content, 1, "\r\n\r\n"); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | SUBS.is_match(&content) [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Subtitles` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/subtitles.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/subtitles.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 54 | | if elem.index != index as u32 { [INFO] [stdout] 55 | | panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 56 | | sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 53 - indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 54 - if elem.index != index as u32 { [INFO] [stdout] 55 - panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 56 - sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 57 - } [INFO] [stdout] 58 - }); [INFO] [stdout] 53 + if let Some(elem) = indexed_subline.as_ref() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/subtitles.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 72 | | if elem.index != index as u32 { [INFO] [stdout] 73 | | panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 74 | | sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 75 | | } [INFO] [stdout] 76 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 71 - indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 72 - if elem.index != index as u32 { [INFO] [stdout] 73 - panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 74 - sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 75 - } [INFO] [stdout] 76 - }); [INFO] [stdout] 71 + if let Some(elem) = indexed_subline.as_ref() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subtitles.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | return Some(&guess); [INFO] [stdout] | ^^^^^^ help: change this to: `guess` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subtitles.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 145 | return Some(&guess); [INFO] [stdout] | ^^^^^^ help: change this to: `guess` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subtitles.rs:230:46 [INFO] [stdout] | [INFO] [stdout] 230 | for cap in utils::SUBS.captures_iter(&content) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/subtitles.rs:398:35 [INFO] [stdout] | [INFO] [stdout] 398 | line.text = line.text.trim_right_matches(" lol").to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 398 - line.text = line.text.trim_right_matches(" lol").to_owned(); [INFO] [stdout] 398 + line.text = line.text.trim_end_matches(" lol").to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/subtitles.rs:307:14 [INFO] [stdout] | [INFO] [stdout] 307 | fn index<'a>(&'a self, index: usize) -> &'a Self::Output { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 307 - fn index<'a>(&'a self, index: usize) -> &'a Self::Output { [INFO] [stdout] 307 + fn index(&self, index: usize) -> &Self::Output { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:286:21 [INFO] [stdout] | [INFO] [stdout] 286 | assert!(!(t1 != t2)); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(t1 == t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:291:21 [INFO] [stdout] | [INFO] [stdout] 291 | assert!(!(t1 > t2)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(t1 <= t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:292:21 [INFO] [stdout] | [INFO] [stdout] 292 | assert!(!(t1 < t2)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(t1 >= t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | assert!(!(t1 == t2)); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(t1 != t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:301:21 [INFO] [stdout] | [INFO] [stdout] 301 | assert!(!(t1 <= t2)); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(t1 > t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | assert!(!(t1 < t2)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(t1 >= t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:309:21 [INFO] [stdout] | [INFO] [stdout] 309 | assert!(!(t1 == t2)); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(t1 != t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:312:21 [INFO] [stdout] | [INFO] [stdout] 312 | assert!(!(t1 >= t2)); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(t1 < t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/timestamp.rs:315:21 [INFO] [stdout] | [INFO] [stdout] 315 | assert!(!(t1 > t2)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(t1 <= t2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Timestamp` which implements the `Copy` trait [INFO] [stdout] --> src/timestamp.rs:282:18 [INFO] [stdout] | [INFO] [stdout] 282 | let t2 = t1.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `t1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Timestamp` which implements the `Copy` trait [INFO] [stdout] --> src/timestamp.rs:324:22 [INFO] [stdout] | [INFO] [stdout] 324 | let t2 = t1.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `t1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Timestamp` which implements the `Copy` trait [INFO] [stdout] --> src/timestamp.rs:332:22 [INFO] [stdout] | [INFO] [stdout] 332 | let t2 = t1.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `t1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Timestamp` which implements the `Copy` trait [INFO] [stdout] --> src/timestamp.rs:398:22 [INFO] [stdout] | [INFO] [stdout] 398 | let t3 = t2.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `t2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:15:43 [INFO] [stdout] | [INFO] [stdout] 15 | let result = EOF_EMPTY_LINES.replacen(&content, 1, "\r\n\r\n"); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | SUBS.is_match(&content) [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/utils.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/utils.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Subtitles` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/subtitles.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/subtitles.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 54 | | if elem.index != index as u32 { [INFO] [stdout] 55 | | panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 56 | | sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 53 - indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 54 - if elem.index != index as u32 { [INFO] [stdout] 55 - panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 56 - sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 57 - } [INFO] [stdout] 58 - }); [INFO] [stdout] 53 + if let Some(elem) = indexed_subline.as_ref() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/subtitles.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 72 | | if elem.index != index as u32 { [INFO] [stdout] 73 | | panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 74 | | sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 75 | | } [INFO] [stdout] 76 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 71 - indexed_subline.as_ref().map(|elem| { [INFO] [stdout] 72 - if elem.index != index as u32 { [INFO] [stdout] 73 - panic!("Subtitles's inner structure is broken, inner vector of Subtitles must always be \ [INFO] [stdout] 74 - sorted and also unterlying SubLine's indices must be correct"); [INFO] [stdout] 75 - } [INFO] [stdout] 76 - }); [INFO] [stdout] 71 + if let Some(elem) = indexed_subline.as_ref() { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subtitles.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | return Some(&guess); [INFO] [stdout] | ^^^^^^ help: change this to: `guess` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subtitles.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 145 | return Some(&guess); [INFO] [stdout] | ^^^^^^ help: change this to: `guess` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subtitles.rs:230:46 [INFO] [stdout] | [INFO] [stdout] 230 | for cap in utils::SUBS.captures_iter(&content) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/subtitles.rs:307:14 [INFO] [stdout] | [INFO] [stdout] 307 | fn index<'a>(&'a self, index: usize) -> &'a Self::Output { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 307 - fn index<'a>(&'a self, index: usize) -> &'a Self::Output { [INFO] [stdout] 307 + fn index(&self, index: usize) -> &Self::Output { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subtitles.rs:369:20 [INFO] [stdout] | [INFO] [stdout] 369 | sub_str += &"\r\n\r\n"; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `"\r\n\r\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.35s [INFO] running `Command { std: "docker" "inspect" "a99483ba03e2a3168f78669b5f48c87825ec7517781bc4e2639997072bc4a9cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a99483ba03e2a3168f78669b5f48c87825ec7517781bc4e2639997072bc4a9cb", kill_on_drop: false }` [INFO] [stdout] a99483ba03e2a3168f78669b5f48c87825ec7517781bc4e2639997072bc4a9cb