[INFO] cloning repository https://github.com/Nytogen/Rust_Shell [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nytogen/Rust_Shell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNytogen%2FRust_Shell", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNytogen%2FRust_Shell'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d044441203b0a3656d0201b923a2157a71be37d5 [INFO] linting Nytogen/Rust_Shell against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNytogen%2FRust_Shell" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Nytogen/Rust_Shell [INFO] finished tweaking git repo https://github.com/Nytogen/Rust_Shell [INFO] tweaked toml for git repo https://github.com/Nytogen/Rust_Shell written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Nytogen/Rust_Shell on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Nytogen/Rust_Shell already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded redox_users v0.5.0 [INFO] [stderr] Downloaded windows-targets v0.53.2 [INFO] [stderr] Downloaded syn v2.0.103 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebd547f4217e05bd4efebc775e6823704595acf7b16bf0126960463488dda832 [INFO] running `Command { std: "docker" "start" "-a" "ebd547f4217e05bd4efebc775e6823704595acf7b16bf0126960463488dda832", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebd547f4217e05bd4efebc775e6823704595acf7b16bf0126960463488dda832", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebd547f4217e05bd4efebc775e6823704595acf7b16bf0126960463488dda832", kill_on_drop: false }` [INFO] [stdout] ebd547f4217e05bd4efebc775e6823704595acf7b16bf0126960463488dda832 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec78fa79c4e98da7e88fb830fcfd18ef0d7de59b32177917aa168fbaa304361f [INFO] running `Command { std: "docker" "start" "-a" "ec78fa79c4e98da7e88fb830fcfd18ef0d7de59b32177917aa168fbaa304361f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.103 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking codecrafters-shell v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | handle_echo(&input[5..].trim()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `input[5..].trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | curr_path.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `curr_path.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_program` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:98:34 [INFO] [stdout] | [INFO] [stdout] 95 | if new_program.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = new_program` [INFO] [stdout] ... [INFO] [stdout] 98 | let new_program_stdout = new_program.unwrap().stdout; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 121 | if !env::set_current_dir(&home_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(&home_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | if !env::set_current_dir(&new_directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(&new_directory).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | let home_path; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `home_path` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 113 ~ [INFO] [stdout] 114 | [INFO] [stdout] 115 | //Assumes we always can retrieve the home path [INFO] [stdout] 116 ~ let home_path = match dirs::home_dir() { [INFO] [stdout] 117 ~ Some(path) if !path.as_os_str().is_empty() => path, [INFO] [stdout] 118 ~ _ => "".into(), [INFO] [stdout] 119 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:127:34 [INFO] [stdout] | [INFO] [stdout] 127 | if !env::set_current_dir(&new_directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `new_directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:28:25 [INFO] [stdout] | [INFO] [stdout] 28 | handle_echo(&input[5..].trim()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `input[5..].trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | curr_path.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `curr_path.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `new_program` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:98:34 [INFO] [stdout] | [INFO] [stdout] 95 | if new_program.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = new_program` [INFO] [stdout] ... [INFO] [stdout] 98 | let new_program_stdout = new_program.unwrap().stdout; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 121 | if !env::set_current_dir(&home_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(&home_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | if !env::set_current_dir(&new_directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::set_current_dir(&new_directory).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | let home_path; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `home_path` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 113 ~ [INFO] [stdout] 114 | [INFO] [stdout] 115 | //Assumes we always can retrieve the home path [INFO] [stdout] 116 ~ let home_path = match dirs::home_dir() { [INFO] [stdout] 117 ~ Some(path) if !path.as_os_str().is_empty() => path, [INFO] [stdout] 118 ~ _ => "".into(), [INFO] [stdout] 119 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:127:34 [INFO] [stdout] | [INFO] [stdout] 127 | if !env::set_current_dir(&new_directory).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `new_directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.33s [INFO] running `Command { std: "docker" "inspect" "ec78fa79c4e98da7e88fb830fcfd18ef0d7de59b32177917aa168fbaa304361f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec78fa79c4e98da7e88fb830fcfd18ef0d7de59b32177917aa168fbaa304361f", kill_on_drop: false }` [INFO] [stdout] ec78fa79c4e98da7e88fb830fcfd18ef0d7de59b32177917aa168fbaa304361f