[INFO] cloning repository https://github.com/NylikPT/AdventOfCode2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NylikPT/AdventOfCode2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNylikPT%2FAdventOfCode2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNylikPT%2FAdventOfCode2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1f24059599198eceee538acc339efcec61fca113 [INFO] linting NylikPT/AdventOfCode2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNylikPT%2FAdventOfCode2023" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NylikPT/AdventOfCode2023 [INFO] finished tweaking git repo https://github.com/NylikPT/AdventOfCode2023 [INFO] tweaked toml for git repo https://github.com/NylikPT/AdventOfCode2023 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NylikPT/AdventOfCode2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NylikPT/AdventOfCode2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 24a3588a182b4ce1dc1d4d7bef0d08981146c0e4d2cf1327a8a2fdfb15a0655a [INFO] running `Command { std: "docker" "start" "-a" "24a3588a182b4ce1dc1d4d7bef0d08981146c0e4d2cf1327a8a2fdfb15a0655a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "24a3588a182b4ce1dc1d4d7bef0d08981146c0e4d2cf1327a8a2fdfb15a0655a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24a3588a182b4ce1dc1d4d7bef0d08981146c0e4d2cf1327a8a2fdfb15a0655a", kill_on_drop: false }` [INFO] [stdout] 24a3588a182b4ce1dc1d4d7bef0d08981146c0e4d2cf1327a8a2fdfb15a0655a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 813ab148fa2ecfedd96f9ddfa332a050b81f908fd1abe71dd148116f26523866 [INFO] running `Command { std: "docker" "start" "-a" "813ab148fa2ecfedd96f9ddfa332a050b81f908fd1abe71dd148116f26523866", kill_on_drop: false }` [INFO] [stderr] Checking advent_of_code_2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day2.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | if !parse_num.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `parse_num.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_num` after checking its variant with `is_err` [INFO] [stdout] --> src/bin/day2.rs:25:27 [INFO] [stdout] | [INFO] [stdout] 23 | if !parse_num.is_err() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 24 | color = it.next().unwrap(); [INFO] [stdout] 25 | num = parse_num.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/bin/day2.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | for line in lines { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (i, line) in (1..).zip(lines.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day1.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if one.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!one.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/bin/day1.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 24 | digits.0.0 = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/bin/day1.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | digits.1.0 = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day2.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | if !parse_num.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `parse_num.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/bin/day1.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | digits.1.0 = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_num` after checking its variant with `is_err` [INFO] [stdout] --> src/bin/day2.rs:25:27 [INFO] [stdout] | [INFO] [stdout] 23 | if !parse_num.is_err() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 24 | color = it.next().unwrap(); [INFO] [stdout] 25 | num = parse_num.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/bin/day1.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | for line in lines { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (i, line) in (1..).zip(lines.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bin/day1.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | if one.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!one.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/bin/day1.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 24 | digits.0.0 = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/bin/day1.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | digits.1.0 = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/bin/day1.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | digits.1.0 = value.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/bin/day1.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | for line in lines { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (i, line) in (1..).zip(lines.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/bin/day2.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | for line in lines { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `for (i, line) in (1..).zip(lines.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "813ab148fa2ecfedd96f9ddfa332a050b81f908fd1abe71dd148116f26523866", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "813ab148fa2ecfedd96f9ddfa332a050b81f908fd1abe71dd148116f26523866", kill_on_drop: false }` [INFO] [stdout] 813ab148fa2ecfedd96f9ddfa332a050b81f908fd1abe71dd148116f26523866